[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

Added iounmap inorder to free memory mapped to pointer before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 26cb8c8..35af362

[RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 26cb8c8..35af362 100644

[PATCH v3] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- v3: reverted to v1 logic, on top of usb-next branch drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers

Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

On 4 December 2015 at 21:53, Greg KH wrote: > On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> v2: changed logic a bit, becaus

[PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- v2: changed logic a bit, because of recent patches pushed to usb-next drivers/usb/host/pci-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/pci

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

Hi Greg, I am little unclear. Now, shall I resend my patch on top of usb.git tree or linux.git tree. Regards, Saurabh On 2 December 2015 at 21:15, Greg KH wrote: > On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote: >> On 2 December 2015 at 04:05, Greg KH wrote: >>

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

On 2 December 2015 at 04:05, Greg KH wrote: > On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> drivers/usb/host/pci-quirks

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

pinging in case this patch is lost. On 6 November 2015 at 17:46, Saurabh Sengar wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar > --- > drivers/usb/host/pci-quirks.c | 4 ++-- > 1 file changed, 2 insertio

Re: [PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

any conclusion for this patch ? any feedback ? On Oct 28, 2015 2:46 PM, "Peter Chen" wrote: > > On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote: > > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc > > > > Signed-off-by: Sa

Re: [PATCH v4] usb: chipidea: removing of_find_property

On 18 November 2015 at 12:54, Peter Chen wrote: > I am clear now, I will queue it. Thank you -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] usb: chipidea: removing of_find_property

On 18 November 2015 at 11:35, Peter Chen wrote: > On Wed, Nov 18, 2015 at 09:40:12AM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >> of_property_read_u32() anyway calls to of_find_property() only. >> >> Si

[PATCH v4] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v4 : removed return type check for optional property 'itc-setting' drivers/usb/chipidea/c

Re: [PATCH v3] usb: chipidea: removing of_find_property

ot OK, I will send a another patch(v4) as you have suggested. Regards, Saurabh On 18 November 2015 at 09:08, Peter Chen wrote: > On Tue, Nov 17, 2015 at 05:22:26PM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >> of_

Re: [PATCH v2] usb: chipidea: removing of_find_property

Hi Julia, You have used v2 of patch, I have sent v3 of patch too. 1:30 hour before Please use version 3 as that is the latest. version 3 : https://lkml.org/lkml/2015/11/17/243 Sorry for trouble. Regards, Saurabh On 17 November 2015 at 18:28, Julia Lawall wrote: > Please check. The code, w

[PATCH v3] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2 : removed pval variable v3 : removed unnecessary if condition drivers/usb/chipidea/core.c | 59

[PATCH v2] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2: removed pval variable drivers/usb/chipidea/core.c | 61 +++-- 1 file changed, 26

[PATCH] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- drivers/usb/chipidea/core.c | 67 ++--- 1 file changed, 32 insertions(+), 35

[PATCH v2] usb: host: ohci-pxa27x: use of_property_read_bool()

for checking if a property is present or not, of_property_read_bool is more appropriate than of_get_property() Signed-off-by: Saurabh Sengar --- v2 : replaced then to than in description drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH] usb: host: ohci-pxa27x: use of_property_read_bool()

for checking if a property is present or not, of_property_read_bool is more appropriate then of_get_property() Signed-off-by: Saurabh Sengar --- drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/ohci-pxa27x.c b

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index f940056..332f687

[PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

replace dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Saurabh Sengar --- drivers/usb/chipidea/udc.c | 3 +-- drivers/usb/gadget/udc/gr_udc.c | 3 +-- drivers/usb/host/uhci-q.c | 3 +-- drivers/usb/host/whci/qset.c| 3 +-- drivers/usb/host/xhci

[PATCH] fixing the coding style changes

>From 999005638f8d3f95075fdfdc6bf8f7ff88810f5d Mon Sep 17 00:00:00 2001 From: Saurabh Sengar Date: Sun, 25 Oct 2015 08:58:42 +0530 Subject: [PATCH] fixing the coding style changes Attached a patch whic fixes the checkpatch.pl script error Here, couple of static variables were initialise t

[PATCH v2 4/9] usb: host: ehci-st: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index 7e4bd39

[PATCH v2 7/9] usb: host: xhci: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/xhci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 526ebc0..19076fa

[PATCH v2 8/9] usb: serial: mxuport: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/serial/mxuport.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index

[PATCH v2 9/9] usb: misc: ftdi-elan: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/misc/ftdi-elan.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c

[PATCH v2 6/9] usb: host: u132-hcd: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/u132-hcd.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb

[PATCH v2 5/9] usb: host: oxu210hp-hcd: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/oxu210hp-hcd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c

[PATCH v2 3/9] usb: musb: musb_dsps: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index

[PATCH v2 2/9] usb: phy: phy-keystone: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-keystone.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-keystone.c b/drivers/usb/phy/phy-keystone.c index

[PATCH v2 1/9] usb: phy: phy-mxs-usb: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-mxs-usb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index

[PATCH v2 0/9] usb: Simplify return statements

From: Saurabh Karajgaonkar This patch series is created using simple_return.cocci coccinelle script. It replaces the redundant instances where variable is first assigned return value from a function call and then used in return statement, by direct function call in the return statement. Changes

[PATCH 7/9] usb: host: xhci: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/xhci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 526ebc0..19076fa

[PATCH 3/9] usb: musb: musb_dsps: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index

[PATCH 5/9] usb: host: oxu210hp-hcd: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/oxu210hp-hcd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c

[PATCH 6/9] usb: host: u132-hcd: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/u132-hcd.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host

[PATCH 8/9] usb: serial: mxuport: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/serial/mxuport.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index

[PATCH 4/9] usb: host: ehci-st: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index 7e4bd39

[PATCH 2/9] usb: phy: phy-keystone: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-keystone.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-keystone.c b/drivers/usb/phy/phy-keystone.c index

[PATCH 1/9] usb: phy: phy-mxs-usb: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-mxs-usb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index

[PATCH 0/9] usb: Simplify return statements

From: Saurabh Karajgaonkar This patch series is created using simple_return.cocci coccinelle script. It replaces the redundant instances where variable is first assigned return value from a function call and then used in return statement, by direct function call in the return statement. Saurabh

[PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/misc/ftdi-elan.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index

Re: [PATCH] drivers/usb/: Simplify return statements

Sure, I'll do that. Just wanted to know whether I should split the patches and send them in this same mail thread (may be something like [PATCH 01/04 V2]) or should I start new threads and send them separately to the respective maintainers. Thanks and Regards, Saurabh Karajgaonkar On Thu

[PATCH] drivers/usb/: Simplify return statements

From: Saurabh Karajgaonkar This patch is created using simple_return.cocci coccinelle script. It replaces the redundant instances where variables are assigned return value from functions and then used in return statements. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c