Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-24 Thread Matthieu CASTET
perly, > but thanks to a script from Joe Perches, this was easily done. > > Reported-by: Joe Perches > Cc: Matthieu CASTET > Cc: Stanislaw Gruszka > Cc: Peter Chen > Cc: Alan Stern > Cc: Mathias Nyman > Cc: Bin Liu > Cc: Felipe Balbi > Signed-off-by: Gr

[PATCH v2] gadget event trace : add request pointer

2017-12-01 Thread Matthieu CASTET
zsI status -115 --> 0 ->transport-224 [000] d.h147.164887: usb_gadget_giveback_request: ep1in: req ffc07c0def10 length 24/24 sgs 0/0 stream 0 zsI status 0 --> 0 ->transport-224 [000] d..147.164907: usb_ep_queue: ep1in: req ffc07c0def10 length 0/122 sgs

Re: [PATCH] gadget event trace : add request pointer

2017-12-01 Thread Matthieu CASTET
Hi Felipe, Le Fri, 1 Dec 2017 12:49:07 +0200, Felipe Balbi a écrit : > Hi, > > > This is, indeed, really useful. However do you mind removing the [] and > adding a space so that output looks like: > > [00:59:36.784082] ->transport-222 [002] d..1 112.602331: > usb_ep_queue: ep1in: re

[PATCH] gadget event trace : add request pointer

2017-12-01 Thread Matthieu CASTET
[ffc07c234710] length 7/7 sgs 0/0 stream 0 zsI status 0 --> 0 [00:59:36.800117] ls-452 [000] d.h1 112.602721: usb_gadget_giveback_request: ep1out: req[ffc07cbab610] length 24/24 sgs 0/0 stream 0 zsI status 0 --> 0 Signed-off-by: Matthieu CASTET --- drivers/usb/g

Re: Errata for Freescale root-hub TT?

2015-06-30 Thread Matthieu CASTET
Hi Peter, Le Mon, 29 Jun 2015 16:40:52 +0800, Peter Chen a écrit : > I am not sure if you have noticed the patch[1], it is the solution for > this issue, in the RTL, the default reserved time for one packet is > 1023 bytes for siTD, so after 4 * 64 packets has transfered, the > reserved time is

Re: PD: [Bug 92341] xHCI USB driver, support for non-conformant HS USB devices with bulk endpoints of maxpacket size different than 512

2015-02-02 Thread Matthieu CASTET
Le Mon, 2 Feb 2015 15:39:47 +0200, Mathias Nyman a écrit : > So apparently there were some devices that started working after the 512byte > was forced? > I wasn't involved in this at the time so I don't know the details, perhaps > Alan remembers? > > As the patch says, USB2 specs say HS bulk en

Re: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-18 Thread Matthieu CASTET
Le Wed, 17 Dec 2014 20:40:29 +0800, Peter Chen a écrit : > On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote: > > On 12/17/2014 02:05 PM, Peter Chen wrote: > > > Hi all, > > > > > > At the first two patches, I add identification registers APIs, we can get > > > controller's revisio

Re: chipidea hangs on mx51 running linux-next

2014-12-09 Thread Matthieu CASTET
Le Tue, 9 Dec 2014 11:09:55 -0200, Fabio Estevam a écrit : > Hi, > > I am running linux-next 20141208 on a imx51-babbage board and the > following hang is observed: > > [1.243660] usbcore: registered new interface driver usb-storage > [1.261619] ci_hdrc ci_hdrc.1: doesn't support gadget

Re: Buffer I/O error after s2ram with usb storage

2014-08-29 Thread Matthieu CASTET
Le Wed, 27 Aug 2014 10:54:53 -0400, Alan Stern a écrit : > On Wed, 27 Aug 2014, Matthieu CASTET wrote: > > > Ping > > > > I have got also a problem with a usb sdcard reader (without power cut > > during suspend) > > > > > The usb storage driver

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Matthieu CASTET
8:0:0:0: [sdb] [ 1204.141510] Add. Sense: Not ready to ready change, medium may have changed [ 1204.141514] sd 8:0:0:0: [sdb] CDB: [ 1204.141516] Read(10): 28 00 00 0a 75 f8 00 00 08 00 [ 1204.141526] end_request: I/O error, dev sdb, sector 685560 Le Mon, 28 Apr 2014 15:01:39 +0200, Matthieu CAST

Re: Buffer I/O error after s2ram with usb storage persistance

2014-04-22 Thread Matthieu CASTET
Le Fri, 18 Apr 2014 14:29:46 -0400, Alan Stern a écrit : > On Fri, 18 Apr 2014, Matthieu CASTET wrote: > > > "echo mem > /sys/power/state; cat /dev/sdx > /dev/null" works. > > I guess this works because the initial open of /dev/sdx swallows the > media-c

Re: Buffer I/O error after s2ram with usb storage persistance

2014-04-18 Thread Matthieu CASTET
Hi Alan, thanks for your answers. Le Fri, 18 Apr 2014 10:42:14 -0400, Alan Stern a écrit : > On Fri, 18 Apr 2014, Matthieu CASTET wrote: > > > Hi, > > > > while playing with suspend to ram I found a strange behavior with usb > > persistence. > > >

Buffer I/O error after s2ram with usb storage persistance

2014-04-18 Thread Matthieu CASTET
Hi, while playing with suspend to ram I found a strange behavior with usb persistence. This can be easily reproduce by doing : - plug a usb key - start to read the usb key : "cat /dev/sdx > /dev/null" - go to suspend : "echo mem > /sys/power/state" - while in suspend, unplug and replug the usb ke

Re: [PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Matthieu CASTET
Le Mon, 24 Feb 2014 16:03:10 +0800, Neil Zhang a écrit : > This patch set is mainly for bug fix. > > Neil Zhang (6): > usb: gadget: mv_udc: remove redundant pull up in udc_start > usb: gadget: mv_udc: disable HW zlt for ep0 > usb: gadget: mv_udc: clear corresponding interrupt when flush fi

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-29 Thread Matthieu CASTET
Hi, Le Fri, 24 Jan 2014 11:07:01 -0500, Alan Stern a écrit : > Matthieu: > > Can you help with this problem? > > > You were right; that driver caused the problem. > > Matthieu Castet wrote the Cypress-ATACB driver, so maybe he can help. > > As shown above

Re: chipidea udc: ctrl traffic on endpoint 8

2014-01-20 Thread Matthieu CASTET
Le Sat, 18 Jan 2014 09:03:01 +0100, Michael Grzeschik a écrit : > On Fri, Jan 17, 2014 at 05:15:49PM +0100, Matthieu CASTET wrote: > > How many fifo have your controller (hw_ep_max) ? > > It's MX28. For this hw_ep_max is 16. > > > When you say fifo on positio

Re: chipidea udc: ctrl traffic on endpoint 8

2014-01-17 Thread Matthieu CASTET
Le Fri, 17 Jan 2014 16:54:07 +0100, Michael Grzeschik a écrit : > Hi Peter, > > we recently see a lot of warnings with the chipidea udc. > The driver is running as g_ether gadget. > > cat drivers/usb/chipidea/udc.c > ... > > if (i != 0) { > dev_warn(ci->dev, "ctrl traff

[PATCH] usb: chipidea: need to mask when writting endptflush and endptprime

2014-01-17 Thread Matthieu CASTET
in hw_write. Signed-off-by: Matthieu CASTET Tested-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 69d20fb..9e2e39b 100644 --- a/drivers/usb/chipidea/udc.c

[PATCH] usb: chipidea: need to mask when writting endptflush and endptprime

2014-01-14 Thread Matthieu CASTET
hw_write. Signed-off-by: Matthieu CASTET --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 69d20fb..9e2e39b 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c

chipidea : ENDPTFLUSH and ENDPTPRIME register access

2014-01-10 Thread Matthieu CASTET
Hi, ENDPTFLUSH and ENDPTPRIME are registers that are set by software and clear by hardware. The current code manipulate them with "hw_write(ci, register, BIT(n), BIT(n));" This do not look sane to me, because hw_write will read the register, apply the mask and write the value. What happen if t

Re: [PATCH] xhci: extra long delay for S4

2013-09-30 Thread Matthieu CASTET
Le Mon, 30 Sep 2013 14:50:12 +0100, Oliver Neukum a écrit : > On Mon, 2013-09-30 at 05:33 -0700, Greg KH wrote: > > On Mon, Sep 30, 2013 at 02:25:29PM +0200, oli...@neukum.org wrote: > > > From: Oliver Neukum > > > > > > Some controllers really do need much longer than the standard > > > allows

Re: [RFC 2/3] EHCI: convert the IRQ handler to a tasklet

2013-08-23 Thread Matthieu CASTET
Le Thu, 22 Aug 2013 21:39:17 +0100, Alan Stern a écrit : > This patch divides ehci-hcd's interrupt handler into a top half and a > bottom half, using a tasklet to execute the latter. > > The conversion is very straightforward. The only subtle point is that > we have to ignore interrupts that ar

Re: [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-01 Thread Matthieu CASTET
: http://marc.info/?l=linux-usb&m=133701342028213&w=2 They may apply to your commit. > > Inspired-by: Matthieu CASTET > Signed-off-by: Tuomas Tynkkynen > --- > drivers/usb/chipidea/host.c | 1 + > drivers/usb/host/ehci-hub.c | 14 +++--- > drivers/usb/host/eh

Re: Two remain problems at chipidea driver

2013-03-15 Thread Matthieu CASTET
Peter Chen a écrit : > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: Do you see any problems with this? >>> How to know vbus status if dr_mode == gadget, we need to indicate connection >>> and disconnection? >> We don't. Do we need to indicate vbus session valid for gadge

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Matthieu CASTET
Alexander Shishkin a écrit : > Peter Chen writes: > >> Hi David > > Hi, > >> I notice at your code for hw_usb_set_address, there is a comment for it >> /** >> * This function explicitly sets the address, without the "USBADRA" (advance) >> * feature, which is not supported by older versions of

Re: Testing for hardware bug in EHCI controllers

2013-03-05 Thread Matthieu CASTET
Bo Shen a écrit : > Hi Alan, > > On 3/4/2013 23:16, Alan Stern wrote: >> On Mon, 4 Mar 2013, Bo Shen wrote: >> >>> Hi Alan, >>> >>> On 02/26/2013 04:54 AM, Alan Stern wrote: Sarah (and anyone else who's interested): A while ago I wrote about a hardware bug in my Intel ICH5 and ICH8

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-31 Thread Matthieu CASTET
Sascha Hauer a écrit : > On Wed, Jan 30, 2013 at 05:54:54PM +0100, Matthieu CASTET wrote: >>> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c >>> index 57cae1f..dcb650f 100644 >>> --- a/drivers/usb/chipidea/core.c >>> +++ b/drivers

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Matthieu CASTET
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 57cae1f..dcb650f 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -67,6 +67,8 @@ > #include > #include > #include > +#include > +#include > > #include "ci.h" > #include "u

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-21 Thread Matthieu CASTET
Michael Grzeschik a écrit : > On Fri, Nov 16, 2012 at 05:39:42PM +0200, Alexander Shishkin wrote: >> Matthieu CASTET writes: >> >>> Alexander Shishkin a écrit : >>>> Michael Grzeschik writes: >>>> >>>>> On Fri, Nov 16, 2012 at 03:34

Re: [PATCH 7/9] usb: chipidea: udc: add force-full-speed option

2012-11-16 Thread Matthieu CASTET
Alexander Shishkin a écrit : > Michael Grzeschik writes: > >> This patch makes it possible to set the chipidea udc >> into full-speed only mode. It can be set by the oftree >> property "force-full-speed". >> >> Signed-off-by: Michael Grzeschik >> Signed-off-by: Marc Kleine-Budde >> --- >> driv

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Matthieu CASTET
Alexander Shishkin a écrit : > Michael Grzeschik writes: > >> On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote: >>> Michael Grzeschik writes: >>> On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> This patch ma

Re: usb audio race at disconnect time

2012-10-18 Thread Matthieu CASTET
Takashi Iwai a écrit : > At Tue, 16 Oct 2012 18:01:13 +0200, > Matthieu CASTET wrote: >> Takashi Iwai a écrit : >>> At Mon, 15 Oct 2012 19:41:40 +0200, >>> Matthieu CASTET wrote: >>>> Hi Takashi, >>>> >>>> But I believe I

Re: usb audio race at disconnect time

2012-10-16 Thread Matthieu CASTET
Takashi Iwai a écrit : > At Mon, 15 Oct 2012 19:41:40 +0200, > Matthieu CASTET wrote: >> Hi Takashi, >> >> But I believe I found other races in the alsa char device handling. With the >> attached patch, if you disconnect the usb audio device between "msleep o&quo

Re: usb audio race at disconnect time

2012-10-15 Thread Matthieu CASTET
Hi Takashi, Takashi Iwai a écrit : > At Fri, 12 Oct 2012 17:42:19 +0200, > Matthieu CASTET wrote: >> Hi, >> >> >> Takashi Iwai a écrit : >>> [Added Daniel and Clemens in the loop] >>> >>> >>> I don't think this is neede

Re: usb audio race at disconnect time

2012-10-12 Thread Matthieu CASTET
Hi, Takashi Iwai a écrit : > [Added Daniel and Clemens in the loop] > > > I don't think this is needed. > > So... the below is a quick hack I did without testing at all. > Hopefully this can give some advance. Thanks for the quick patch. The patch didn't apply cleany of linus tree, of which t

usb audio race at disconnect time

2012-10-11 Thread Matthieu CASTET
Hi, while doing some monkey tests on a product we found races in usb audio code when the device in unplugged from usb (on linus master tree). This can be reproduced with usb_audio_show_race.diff and CONFIG_DEBUG_SLAB. With this patch, start a stream : # arecord -D hw:0 -r 44100 -c 2 -f S16_LE >

Re: [PATCH] ueagle-atm: Declare MODULE_FIRMWARE usage

2012-07-28 Thread matthieu castet
Ack-by: matthieu castet Le Wed, 25 Jul 2012 14:32:50 -0600, Tim Gardner a écrit : > Cc: Matthieu CASTET > Cc: Stanislaw Gruszka > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/usb/at

[RFC] mass storage : emulation of sat scsi_pass_thru with ATACB

2008-02-25 Thread matthieu castet
Hi, I have got a cypress usb-ide bridge and I would like to tune or monitor my disk with tools like hdparm, hddtemp or smartctl. My controller support a way to send raw ATA command to the disk with something call atacb (see http://download.cypress.com.edgesuite.net/design_resources/datasheets/co