s to
check whether the device's descriptors have changed before resuscitating
an enabled port.
Signed-off-by: David Heinzelmann
Acked-by: Alan Stern
---
Changes in v5:
- added Acked-by
Changes in v4:
- changed commit description
Changes in v3:
- changed commit message and description
-
On Tue, Oct 08, 2019 at 02:55:46PM +0200, Greg KH wrote:
> What happened to Alan's ack?
>
I'm not sure I'm allowed to add someone else's acked-by tag?
If so I will sent v5.
David
s to
check whether the device's descriptors have changed before resuscitating
an enabled port.
Signed-off-by: David Heinzelmann
---
Changes in v4:
- changed commit description
Changes in v3:
- changed commit message and description
- fix code style
Changes in v2:
- fix logic error to han
Hi,
I hope it all fits now.
David
>From 8517ecfac0175aebba03bb0868dde652bc3c36e5 Mon Sep 17 00:00:00 2001
From: David Heinzelmann
Date: Fri, 4 Oct 2019 12:28:36 +0200
Subject: [PATCH v4] usb: hub: Check device descriptor before resusciation
If a device connected to an xHCI host control
Hi,
thank you for the feedback! I hope this time everything is in order.
However, the correct error description is somewhat difficult for me.
Here is the third version:
>From 58634d035508b621025da1d866179b59ed0ae37a Mon Sep 17 00:00:00 2001
From: David Heinzelmann
Date: Fri, 4 Oct 2019 12
On Wed, Sep 25, 2019 at 10:20:00AM -0400, Alan Stern wrote:
> On Tue, 24 Sep 2019, David Heinzelmann wrote:
>
> > > I really don't understand this.
> > >
> > > Your patch involves the case where there was a connect-change event but
> > > the p
.0
>> controller).
Or maybe your hardware is just getting some of the memory accesses wrong?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
On Mon, Sep 23, 2019 at 10:49:59AM -0400, Alan Stern wrote:
> On Fri, 20 Sep 2019, David Heinzelmann wrote:
>
> > On Fri, Sep 20, 2019 at 02:15:38PM +0200, Greg KH wrote:
> > > On Fri, Sep 20, 2019 at 03:17:26PM +0200, David Heinzelmann wrote:
> > > > Hi,
>
On Fri, Sep 20, 2019 at 02:15:38PM +0200, Greg KH wrote:
> On Fri, Sep 20, 2019 at 03:17:26PM +0200, David Heinzelmann wrote:
> > Hi,
> >
> > sorry for the wrong patch format.
>
> No problem, that's normal. But please do not top-post on linux mailing
> li
citate the exisiting device.
On Fri, Sep 20, 2019 at 10:55:56AM +0200, Greg KH wrote:
> On Fri, Sep 20, 2019 at 12:36:28PM +0200, David Heinzelmann wrote:
> > When a port connection-change occurs the hub driver tries to resuscitate an
> > existing device.
> > Activated from a firm
and the connection-change event is ignored.
Signed-off-by: David Heinzelmann
---
drivers/usb/core/hub.c | 181 ++---
1 file changed, 96 insertions(+), 85 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 236313f41f4a
From: Bjørn Mork
Date: Thu, 12 Sep 2019 10:42:00 +0200
> A Mediatek based smartphone owner reports problems with USB
> tethering in Linux. The verbose USB listing shows a rndis_host
> interface pair (e0/01/03 + 10/00/00), but the driver fails to
> bind with
>
> [ 355.960428] usb 1-4: bad CDC d
he USB device name as an
unterminated string. This may be truncated - it is currently
limited to a maximum 63 chars.
Note that it is permissible for event records to be of variable length -
or, at least, the length may be dependent on the subtype.
Signed-off-by: David How
in dmesg.
Signed-off-by: David Howells
---
samples/Kconfig |6 +
samples/Makefile |1
samples/watch_queue/Makefile |8 +
samples/watch_queue/watch_test.c | 231 ++
4 files changed, 246 insertions(+)
create m
From: Markus Elfring
Date: Wed, 21 Aug 2019 22:24:16 +0200
> From: Markus Elfring
> Date: Wed, 21 Aug 2019 22:16:02 +0200
>
> The dev_kfree_skb() function performs also input parameter validation.
> Thus the test around the shown calls is not needed.
>
> This issue was detected by using the Co
From: Wenwen Wang
Date: Wed, 14 Aug 2019 13:56:43 -0500
> In kalmia_init_and_get_ethernet_addr(), 'usb_buf' is allocated through
> kmalloc(). In the following execution, if the 'status' returned by
> kalmia_send_init_packet() is not 0, 'usb_buf' is not deallocated, leading
> to memory leaks. To f
From: Wenwen Wang
Date: Wed, 14 Aug 2019 13:03:38 -0500
> In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
> Then, the execution waits for the firmware to become ready. If the firmware
> is not ready in time, the execution is terminated. However, the allocated
> 'dev->partia
From: Wenwen Wang
Date: Wed, 14 Aug 2019 11:23:13 -0500
> In lan78xx_probe(), a new urb is allocated through usb_alloc_urb() and
> saved to 'dev->urb_intr'. However, in the following execution, if an error
> occurs, 'dev->urb_intr' is not deallocated, leading to memory leaks. To fix
> this issue,
I am new to this mailing list, so please go easy on me if I'm breaking
etiquete.
Upgraded my Fedora 30 install from linux kernel 5.2.6 to 5.2.7 (and
5.2.8) and my apple usb superdrive stopped working. Booting up in 5.2.6
and it works again as expected, so it appears to be due to changes in
5.2.7.
From: Hayes Wang
Date: Fri, 9 Aug 2019 03:38:53 +
> Jakub Kicinski [jakub.kicin...@netronome.com]
> [..]> The kernel could support it. And I has finished it.
>> > However, when I want to test it by ethtool, I couldn't find suitable
>> > command.
>> > I couldn't find relative feature in the s
From: Johan Hovold
Date: Mon, 5 Aug 2019 12:00:55 +0200
> Fix two reset-gpio sanity checks which were never converted to use
> gpio_is_valid(), and make sure to use -EINVAL to indicate a missing
> reset line also for the UART-driver module parameter and for the USB
> driver.
>
> This specifical
same value.
(It might be different for different devices.)
ISTR that dma_alloc_coherent() returns this value to the caller.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
ked-by: Greg Kroah-Hartman
> Acked-by: Michael S. Tsirkin
> Reviewed-by: Jarkko Sakkinen
> Reviewed-by: Jason Gunthorpe
> Reviewed-by: Jiri Kosina
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Arnd Bergmann
I assume this has to go via your series, thus:
Acked-by: David S. Miller
From: "Angus Ainslie (Purism)"
Date: Wed, 24 Jul 2019 07:52:27 -0700
> From: Bob Ham
>
> The BroadMobi BM818 M.2 card uses the QMI protocol
>
> Signed-off-by: Bob Ham
> Signed-off-by: Angus Ainslie (Purism)
Applied, thanks.
From: Chuhong Yuan
Date: Tue, 23 Jul 2019 10:16:27 +0800
> David Miller 于2019年7月23日周二 上午9:22写道：
>>
>> From: Chuhong Yuan
>> Date: Mon, 22 Jul 2019 15:41:34 +0800
>>
>> > Merge the combo uses of cpu_to_le32s and memcpy.
>> > Use put_unaligne
From: Chuhong Yuan
Date: Mon, 22 Jul 2019 15:41:34 +0800
> Merge the combo uses of cpu_to_le32s and memcpy.
> Use put_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Isn't the skb->data aligned to 4 bytes in these situations?
If so, we should use the aligne
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 15:36:15 +0800
> Merge the combo use of memcpy and lexx_to_cpus.
> Use get_unaligned_lexx instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 16:27:31 +0800
> Merge the combo use of memcpy and le32_to_cpus.
> Use get_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
From: Chuhong Yuan
Date: Fri, 19 Jul 2019 17:07:15 +0800
> Merge the combo use of memcpy and le32_to_cpus.
> Use get_unaligned_le32 instead.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
From: Rogan Dawes
Date: Wed, 17 Jul 2019 11:14:33 +0200
> Signed-off-by: Rogan Dawes
Applied.
From: Phong Tran
Date: Mon, 15 Jul 2019 22:08:14 +0700
> The syzbot test with random endpoint address which made the idx is
> overflow in the table of endpoint configuations.
>
> this adds the checking for fixing the error report from
> syzbot
>
> KASAN: stack-out-of-bounds Read in hfcsusb_prob
From: Bjørn Mork
Date: Mon, 24 Jun 2019 18:45:11 +0200
> The syzbot reported
>
> Call Trace:
> __dump_stack lib/dump_stack.c:77 [inline]
> dump_stack+0xca/0x13e lib/dump_stack.c:113
> print_address_description+0x67/0x231 mm/kasan/report.c:188
> __kasan_report.cold+0x1a/0x32 mm/kasan/rep
ent looks broken!
Were buf[] too small the length returned would include a '\0'.
Now it is quite likely that the overflow is actually impossible
(provided buf[] has room for the '\n').
OTOH the 'correct' fix is to replace the snprintf() with scnprintf()
and remov
From: Kloetzke Jan
Date: Tue, 21 May 2019 13:18:40 +
> When disconnecting cdc_ncm the kernel sporadically crashes shortly
> after the disconnect:
...
> The crash happens roughly 125..130ms after the disconnect. This
> correlates with the 'delay' timer that is started on certain USB tx/rx
> e
From: Kloetzke Jan
Date: Thu, 16 May 2019 07:10:30 +
> Am Montag, den 06.05.2019, 10:17 +0200 schrieb Oliver Neukum:
>> On So, 2019-05-05 at 00:45 -0700, David Miller wrote:
>> > From: Kloetzke Jan
>> > Date: Tue, 30 Apr 2019 14:15:07 +
>> >
>&
From: Alan Stern
> Sent: 29 April 2019 18:55
> On Mon, 29 Apr 2019, Oliver Neukum wrote:
>
> > On Mo, 2019-04-29 at 12:08 -0400, Alan Stern wrote:
> > > On Mon, 29 Apr 2019, Oliver Neukum wrote:
> > >
> > > > On Mo, 2019-04-29 at 15:06 +, David
From: Oliver Neukum
> On Mo, 2019-04-29 at 14:19 +0000, David Laight wrote:
> > From: Oliver Neukum
> > > Sent: 29 April 2019 14:38
> > > On Mo, 2019-04-29 at 13:31 +, David Laight wrote:
> > > > From: Oliver Neukum
> > > > >
> > >
From: Oliver Neukum
> Sent: 29 April 2019 14:38
> On Mo, 2019-04-29 at 13:31 +, David Laight wrote:
> > From: Oliver Neukum
> > >
> > > + * USB has unusual scatter-gather requirements: the length of each
> > > + * scatterlist element except the last m
st be divisible by the
> + * Bulk maxpacket value. Fortunately this value is always a
> + * power of 2. Inform the block layer about this requirement.
> + */
That isn't the correct restriction for XHCI.
It has its own perverse restrictions.
I think they are all handle
eous, but that, perhaps, it's the best that can be
done.
Thoughts?
--david
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 2e2f736384ab..aca2613225f3 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -65,6 +65,8 @@ struct ftdi_
so that the tool will work
with the vhci-hcd driver from kernel version 3.18 onward.
Signed-off-by: David Valleau
---
tools/usb/usbip/libsrc/vhci_driver.c | 246 ---
tools/usb/usbip/libsrc/vhci_driver.h | 7 +
2 files changed, 228 insertions(+), 25 deletions(-)
diff
From: David Chen
Date: Wed, 20 Feb 2019 13:47:19 +0800
> From: David Chen
>
> RTL8153-BD is used in Dell DA300 type-C dongle.
> Added RTL8153-BD support to activate MAC address pass through on DA300.
> Apply correction on previously submitted patch in net.git tree.
>
>
Hi Jiri,
Thanks for your comments. BND_MASK and BD_MASK are defined separately, and I
have tested RTL8153-BD and RTL8153-BND devices, both work as expected.
Thanks and Regards,
-David
> Jiri Slaby 於 2019年2月18日 下午10:22 寫道：
>
>> On 18. 02. 19, 15:00, David Chen wrote:
>>
From: David Chen
RTL8153-BD is used in Dell DA300 type-C dongle.
Added RTL8153-BD support to activate MAC address pass through on DA300.
Apply correction on previously submitted patch in net.git tree.
Signed-off-by: David Chen
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1 insertion
From: David Chen
Date: Sat, 16 Feb 2019 17:16:42 +0800
> From: David Chen
>
> RTL8153-BD is used in Dell DA300 type-C dongle.
> It should be added to the whitelist of devices to activate MAC address
> pass through.
>
> Per confirming with Realtek all devices contain
Where is patch #1?
From: David Chen
RTL8153-BD is used in Dell DA300 type-C dongle.
It should be added to the whitelist of devices to activate MAC address
pass through.
Per confirming with Realtek all devices containing RTL8153-BD should
activate MAC pass through and there won't use pass through bit on efuse
Hi Oliver,
Thanks for reviewing. I have made some mistake, will correct it and resend.
Thanks and Regards,
-David
> Oliver Neukum 於 2019年2月18日 下午4:04 寫道：
>
>> On Mo, 2019-02-18 at 11:48 +0800, David Chen wrote:
>> From: David Chen
>>
>> Per confirming with
From: David Chen
Per confirming with Realtek all devices containing RTL8153-BD should
activate MAC pass through and there won't use pass through bit on efuse
like in RTL8153-AD.
Signed-off-by: David Chen
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Beniamino Galvani
Date: Fri, 15 Feb 2019 13:20:42 +0100
> The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR
> quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as
> already done for other IDs shared between different devices.
>
> Signed-off-by: Beniamino Ga
From: David Chen
RTL8153-BD is used in Dell DA300 type-C dongle.
It should be added to the whitelist of devices to activate MAC address
pass through.
Per confirming with Realtek all devices containing RTL8153-BD should
activate MAC pass through and there won't use pass through bit on efuse
From: "Gustavo A. R. Silva"
Date: Thu, 7 Feb 2019 21:13:13 -0600
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo
From: "Gustavo A. R. Silva"
Date: Fri, 8 Feb 2019 13:09:06 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -W
From: "Gustavo A. R. Silva"
Date: Fri, 8 Feb 2019 13:07:29 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -W
From: Zhang Run
Date: Thu, 24 Jan 2019 13:48:49 +0800
> The ax88772_bind() should return error code immediately when the PHY
> was not reset properly through ax88772a_hw_reset().
> Otherwise, The asix_get_phyid() will block when get the PHY
> Identifier from the PHYSID1 MII registers through asi
From: YueHaibing
Date: Fri, 18 Jan 2019 02:06:49 +
> From: Yue Haibing
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
> variable 'rx_stat' set but not used [-Wunused-but-set-va
nts.
>
> Exceptions are pcpu_populate_pte() and kernel_map_range() that were
> slightly refactored to accommodate the change.
>
> Signed-off-by: Mike Rapoport
Acked-by: David S. Miller
This website hasn't worked for quite some time.
Signed-off-by: David Brown
Cc: Matt Dharm
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 82ad0eabce4f..0dbba14128e4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14142,7 +14142,6 @@ M:
From: Bjørn Mork
Date: Sat, 5 Jan 2019 14:32:39 +0100
> This function is unreadable enough without indenting mismatches
> and unnecessary line breaks.
>
> Signed-off-by: Bjørn Mork
Applied, thanks.
From: Mario Limonciello
Date: Tue, 11 Dec 2018 08:16:14 -0600
> All previous docks and dongles that have supported this feature use
> the RTL8153-AD chip.
>
> RTL8153-BND is a new chip that will be used in upcoming Dell type-C docks.
> It should be added to the whitelist of devices to activate M
From: Igor Russkikh
Date: Wed, 12 Dec 2018 13:50:06 +
> This patches introduce the thermal throttling feature to prevent possible
> heat damage to the hardware.
I see what seems to be a bit of a conflict here, maybe you can explain
the situation better to me.
Andrew suggested that the firmw
From: Greg KH
Date: Wed, 12 Dec 2018 12:42:24 +0100
> From: Hui Peng
>
> The function hso_probe reads if_num from the USB device (as an u8) and uses
> it without a length check to index an array, resulting in an OOB memory read
> in hso_probe or hso_get_config_data.
>
> Add a length check for
From: Mathias Payer
Date: Sun, 9 Dec 2018 21:17:58 +0100
> I've attached the updated patch. (Greg, please add your Signed-off-by).
Patches should be posted inline, not as attachments as per
process/submitting-patches.rst
From: Mathias Payer
Date: Sun, 9 Dec 2018 21:02:25 +0100
> Passing an int to the macro results in a compiler warning. One option would be
> to test for the individual errors (instead of using the macro) with the
> drawback
> that future extensions that return different errors may be missed. Anot
From: Greg KH
Date: Sun, 9 Dec 2018 17:32:45 +0100
> + } else {
> port_spec = hso_get_config_data(interface);
> + if (IS_ERR_VALUE((long)port_spec))
> + goto exit;
'port_spec' is an 'int', it makes no sense to cast it 3 times all the
way back to
From: Igor Russkikh
Date: Mon, 26 Nov 2018 09:32:56 +
> This patchset introduces support for new multigig ethernet to USB dongle,
> developed jointly by Aquantia (Phy) and ASIX (USB MAC).
Series applied, thanks.
From: Bernd Eckstein <3erndeckst...@gmail.com>
Date: Fri, 23 Nov 2018 13:51:26 +0100
> The bug is not easily reproducable, as it may occur very infrequently
> (we had machines with 20minutes heavy downloading before it occurred)
> However, on a virual machine (VMWare on Windows 10 host) it occurre
Signed-off-by: "David R. Piegdon"
systemd allows use of predictable netdev names. these currently do
not work for netdevs connected to USB platform busses, as the id
of the platform bus is not necessarily consistent across kernel
versions. this patch allows setting a suggested
been defined!
In the current master there are a few platforms that contain such
aliases, e.g. am33xx, dm814x or imx6qdl
Yours,
David
David R. Piegdon (2):
usb core: dts: allow suggesting usb bus number for platform busses
dt-bindings: allow suggesting usb bus number for usb platform b
Signed-off-by: "David R. Piegdon"
systemd allows use of predictable netdev names. these currently do
not work for netdevs connected to USB platform busses, as the id
of the platform bus is not necessarily consistent across kernel
versions. this patch allows setting a suggested
From: Igor Russkikh
Date: Wed, 21 Nov 2018 10:13:48 +
> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet
> *dev, struct sk_buff *skb,
> /*Length of actual data*/
> tx_desc |= skb->len & AQ_TX_DESC_LEN_MASK;
>
> + /* TSO MSS */
> + tx_desc |= ((u
From: Igor Russkikh
Date: Wed, 21 Nov 2018 10:13:42 +
> +static void aqc111_rx_checksum(struct sk_buff *skb, u64 *pkt_desc)
> +{
...
> + /* checksum error bit is set */
> + if (*pkt_desc & AQ_RX_PD_L4_ERR || *pkt_desc & AQ_RX_PD_L3_ERR)
> + return;
...
> @@ -661,6 +698,7
From: Igor Russkikh
Date: Wed, 21 Nov 2018 10:13:39 +
> + desc_hdr = *(u64 *)skb_tail_pointer(skb);
> + le64_to_cpus(&desc_hdr);
This is:
desc_hdr = le64_to_cpup(skb_tail_pointer(skb));
> + /* Get the first RX packet descriptor */
> + pkt_desc = (u64 *)(skb->data +
From: Igor Russkikh
Date: Wed, 21 Nov 2018 10:13:37 +
> + if (padding_size != 0)
> + skb_put(skb, padding_size);
I think you want to use skb_put_zero() here rather than leaving it
uninitialized. I know it's padding, but if for some reason this leaks
onto the wire or elsewher
From: Ben Dooks
Date: Wed, 14 Nov 2018 11:50:18 +
> This is a series of a few driver cleanups and some fixups of the code
> for the SMSC95XX driver. There have been a few reviews, and the issues
> have been fixed so this should be ready for merging.
>
> I will work on the tx-alignment and th
From: Stefan Wahren
Date: Thu, 8 Nov 2018 20:38:26 +0100
> The commit f77f0aee4da4 ("net: use core MTU range checking in USB NIC
> drivers") introduce a common MTU handling for usbnet. But it's missing
> the necessary changes for smsc95xx. So set the MTU range accordingly.
>
> This patch has be
From: Andrew Jeffery
> Sent: 08 November 2018 01:55
> > - EPDBG(ep,"Enqueing request on wrong or disabled EP\n");
> > + EPDBG(ep, "Enqueuing request on wrong or disabled EP\n");
Shouldn't it be Enqueueing ?
David
-
Register
From: Frieder Schrempf
Date: Wed, 31 Oct 2018 22:52:19 +0100
> We need to make sure, that the carrier check polling is disabled
> while suspending. Otherwise we can end up with usbnet_read_cmd()
> being issued when only usbnet_read_cmd_nopm() is allowed. If this
> happens, read operations lock up
ronise the counter
to the host bus clock and generates garbage during an increment.
Such errors can be a complete mix of the old and new values, not just
a 'carry chain' error.
If the two reads give different values a third one should be correct
(even if it differs from the second one).
From: YueHaibing
Date: Fri, 12 Oct 2018 01:49:13 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status':
> drivers/net/usb/cdc_ncm.c:1603:22: warning:
> variable 'ctx' set but not used [-Wunused-but-set-variable]
> struct cdc_ncm_ctx
From: Ben Dooks
Date: Thu, 11 Oct 2018 14:03:32 +0100
> The tasklet initialisation would be better done by tasklet_init()
> instead of assuming all the fields are in an ok state by default.
>
> This does not fix any actual know bug.
>
> Signed-off-by: Ben Dooks
Applied to net-next.
From: David Miller
> Sent: 05 October 2018 22:24
>
> From: Ben Dooks
> Date: Tue, 2 Oct 2018 17:56:02 +0100
>
> > - memcpy(skb->data, &tx_cmd_a, 4);
> > + ptr = skb_push(skb, 8);
> > + tx_cmd_a = cpu_to_le32(tx_cmd_a);
> > + tx_cmd
From: Ben Dooks
Date: Sat, 06 Oct 2018 12:27:27 +0100
> Thanks, got a new version of the series just being tested with this.
> Should it go into the original, or as a separate change?
Into the original.
From: Ben Dooks
Date: Tue, 2 Oct 2018 17:56:02 +0100
> - memcpy(skb->data, &tx_cmd_a, 4);
> + ptr = skb_push(skb, 8);
> + tx_cmd_a = cpu_to_le32(tx_cmd_a);
> + tx_cmd_b = cpu_to_le32(tx_cmd_b);
> + memcpy(ptr, &tx_cmd_a, 4);
> + memcpy(ptr+4, &tx_cmd_b, 4);
Even a memcpy
From: Igor Russkikh
Date: Fri, 5 Oct 2018 10:24:55 +
> + switch (aqc111_data->link_speed) {
> + case AQ_INT_SPEED_5G:
> + {
> + link_speed = 5000;
> + reg8 = 0x05;
> + reg16 = 0x001F;
> + break;
> + }
Please do not put curly bra
From: Igor Russkikh
Date: Fri, 5 Oct 2018 10:24:44 +
> +static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value,
> + u16 index, u16 size, void *data, int nopm)
> +{
> + int ret;
> + int (*fn)(struct usbnet *dev, u8 cmd, u8 reqtype, u16 value,
> +
From: Igor Russkikh
Date: Fri, 5 Oct 2018 10:24:42 +
> +static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf)
> +{
> + int ret;
> + struct usb_device *udev = interface_to_usbdev(intf);
Please always order local variable declarations from longest to shortest
line (rev
From: Yu Zhao
Date: Fri, 28 Sep 2018 17:04:30 -0600
> Cancel pending work before freeing smsc75xx private data structure
> during binding. This fixes the following crash in the driver:
>
> BUG: unable to handle kernel NULL pointer dereference at 0050
> IP: mutex_lock+0x2b/0x3f
>
> W
/* workaround - hardware tx checksum does not work
> @@ -2035,21 +2039,18 @@ static struct sk_buff *smsc95xx_tx_fixup(struct
> usbnet *dev,
> skb_push(skb, 4);
> cpu_to_le32s(&csum_preamble);
Not related, but csum_preamble =
From: Ben Dooks
Date: Mon, 1 Oct 2018 17:02:43 +0100
> From: Ben Dooks
>
> The driver_info field that is used for describing each of the usb-net
> drivers using the usbnet.c core all declare their information as const
> and the usbnet.c itself does not try and modify the struct.
>
> It is the
skb_push(skb, 4 - align);
> +
> skb_push(skb, 4);
You don't want to call skb_push() twice.
IIRC really horrid things happen if the data has to be copied.
(Actually what happens to the alignment in that case??)
And there is another skb_push() below
> - tx_cmd_b
From: Florian Fainelli
Date: Fri, 28 Sep 2018 16:18:49 -0700
> Most of our USB Ethernet drivers don't seem to be checking properly
> whether the user is supplying a correct Wake-on-LAN mode to enter, so
> the experience as an user could be confusing, since it would generally
> lead to either no w
From: Florian Fainelli
Date: Mon, 24 Sep 2018 13:54:13 -0700
> Most of our USB Ethernet drivers don't seem to be checking properly
> whether the user is supplying a correct Wake-on-LAN mode to enter, so
> the experience as an user could be confusing, since it would generally
> lead to either no w
From: YueHaibing
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_t
From: Bjørn Mork
Date: Mon, 17 Sep 2018 22:00:24 +0200
> Recent firmware revisions have added the ability to force
> these modems to USB2 mode, hiding their SuperSpeed
> capabilities from the host. The driver has been using the
> SuperSpeed capability, as shown by the bcdUSB field of the
> devic
From: zhong jiang
Date: Sun, 16 Sep 2018 21:20:17 +0800
> of_node_put has taken the null pointer check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang
Applied.
double-checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
>
> Signed-off-by: Arnd Bergmann
> ---
> fs/btrfs/super.c| 2 +-
Acked-by: David Sterba
From: Stefan Wahren
Date: Tue, 4 Sep 2018 19:29:08 +0200
> This patch series contains some minor improvements for the lan78xx
> driver.
>
> Changes in V2:
> - Keep Copyright comment as multi-line
> - Add Raghuram's Reviewed-by
Series applied, thanks.
From: "Gustavo A. R. Silva"
Date: Mon, 3 Sep 2018 13:48:45 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1077614 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva
Applied, thank y
From: Florian Fainelli
Date: Tue, 15 May 2018 16:56:17 -0700
> This patch series updates of_mdiobus_register() such that when the device_node
> argument is NULL, it calls mdiobus_register() directly. This is consistent
> with
> the behavior of of_mdiobus_register() when CONFIG_OF=n.
>
> I only
1 - 100 of 2187 matches
Mail list logo
