Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through

2019-08-16 Thread Cristian.Birsan
On 8/5/19 9:48 PM, Gustavo A. R. Silva wrote: > External E-Mail > > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: at91_dt_defconfig arm): > > drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may > fal

[PATCH v4 2/2] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

2017-04-07 Thread cristian.birsan
From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drive

[PATCH v4 1/2] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error

2017-04-07 Thread cristian.birsan
From: Cristian Birsan Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/

[PATCH v4 0/2] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-04-07 Thread cristian.birsan
From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP configuration error - Kconfig comme

[PATCH linux-next v3 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

2017-04-03 Thread cristian.birsan
From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drive

[PATCH linux-next v3 3/4] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error

2017-04-03 Thread cristian.birsan
From: Cristian Birsan Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/

[PATCH linux-next v3 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-04-03 Thread cristian.birsan
From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP configuration error - Kconfig comme

[PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup

2017-04-03 Thread cristian.birsan
From: Cristian Birsan Minor code cleanup based on feedback received on mailinglist. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/udc/

[PATCH linux-next v3 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree

2017-04-03 Thread cristian.birsan
From: Cristian Birsan Check fifo configuration values against device tree values for endpoint fifo in auto configuration mode (fifo_mode=0). Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 24 ++-- 1 file changed, 22 ins

[PATCH linux-next v2 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig

[PATCH linux-next v2 2/4] usb: gadget: udc: atmel: Minor code cleanup

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Minor code cleanup based on feedback received on mailinglist. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drive

[PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Use dev_warn() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/driver

[PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-03-28 Thread cristian.birsan
From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP configuration error - Kconfig comme

[PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Check fifo configuration values against device tree values for endpoint fifo in auto configuration mode (fifo_mode=0). Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-

[PATCH 3/4 linux-next] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

2017-02-14 Thread cristian.birsan
From: Cristian Birsan Use dev_warn() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/driver

[PATCH 4/4 linux-next] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

2017-02-14 Thread cristian.birsan
From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig

[PATCH 2/4 linux-next] usb: gadget: udc: atmel: Minor code cleanup

2017-02-14 Thread cristian.birsan
From: Cristian Birsan Minor code cleanup based on feedback received on mailinglist. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/

[PATCH 1/4 linux-next] usb: gadget: udc: atmel: Check fifo configuration values against device tree

2017-02-14 Thread cristian.birsan
From: Cristian Birsan Check fifo configuration values against device tree values for endpoint fifo in auto configuration mode (fifo_mode=0). Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions

[PATCH 0/4 linux-next] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-02-14 Thread cristian.birsan
From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP configuration error - Kconfig comme

[PATCH] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-02-10 Thread cristian.birsan
From: Cristian Birsan This patch provides fixes for the following: - fifo table parameters validation against device tree values - coding style - error message display - Kconfig comments Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig

[PATCH linux-next] fixup! usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-02-06 Thread cristian.birsan
From: Cristian Birsan Signed-off-by: Cristian Birsan --- Fixes since previous patch: - Fix coding style - Validate parameters againsta device tree values - Update error message display - Update Kconfig comments drivers/usb/gadget/udc/Kconfig | 5 ++--

[PATCH linux-next v2 0/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-01-23 Thread cristian.birsan
From: Cristian Birsan Hi, This patch updates the usb endpoint allocation scheme for atmel usba driver to make sure all endpoints are allocated in order. This requirement comes from the datasheet of the controller. The allocation scheme is decided by fifo_mode parameter. For fifo_mode = 0 the dr

[PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-01-23 Thread cristian.birsan
From: Cristian Birsan Update atmel udc driver with a new enpoint allocation scheme. The data sheet requires that all endpoints are allocated in order. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 14 ++ drivers/usb/gadget/udc/atmel_usba_udc.c | 236

[PATCH linux-next 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-01-20 Thread cristian.birsan
From: Cristian Birsan Update atmel udc driver with a new enpoint allocation scheme. The data sheet requires that all endpoints are allocated in order. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 14 ++ drivers/usb/gadget/udc/atmel_usba_udc.c | 236

[PATCH linux-next 0/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-01-20 Thread cristian.birsan
From: Cristian Birsan Hi, This patch updates the usb endpoint allocation scheme for atmel usba driver to make sure all endpoints are allocated in order. This requirement comes from the datasheet of the controller. The allocation scheme is decided by fifo_mode parameter. For fifo_mode = 0 the dr