> From: Chuhong Yuan
> Sent: Friday, July 19, 2019 3:36 AM
> Cc: Woojung Huh - C21699 ; UNGLinuxDriver
> ; David S . Miller ;
> net...@vger.kernel.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org; Chuhong Yuan
>
> Subject: [PATCH] net: lan78xx: Merge memcpy + lexx_to_cpus to
> get
Hi Lukas & Minas,
> On Tue, Apr 09, 2019 at 09:28:16AM +, Minas Harutyunyan wrote:
> > Am 09.04.19 um 08:54 schrieb Jisheng Zhang:
> > > The second one: 8000 usb interrupts per second when idle.
> > > This is abnormal. any idea? Is it due to the lan78xx?
> >
> > dwc2 in host mode enable SOF in
Hi Ben,
> -Original Message-
> From: netdev-ow...@vger.kernel.org On Behalf
> Of Ben Dooks
> Sent: Wednesday, November 14, 2018 6:50 AM
> To: net...@vger.kernel.org
> Cc: oneu...@suse.com; da...@davemloft.net; linux-usb@vger.kernel.org; linux-
> ker...@vger.kernel.org; steve.glendinn...@
> The driver supports a fair amount of Wake-on-LAN modes, but is not
> checking that the user specified one that is supported.
>
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
> Ethernet device driver")
> Signed-off-by: Florian Fainelli
Reviewed-by: Woojung Huh
Than
Hi Florian,
> @@ -1401,19 +1401,10 @@ static int lan78xx_set_wol(struct net_device
...
> + if (pdata->wol & ~WAKE_ALL)
> + return -EINVAL;
If I understand correctly, it needs to check againt "wol->wolopts" than
pdata->wol.
> +
> + pdata->wol = wol->wolopts;
Thanks.
Woo
Hi Florian,
> >> + if (pdata->wol == 0)
> >> + return -EINVAL;
> >> +
> > It will make function return when disabling WOL.
>
> Huh, yes, good point.
>
> > Is there other place handling this scenario?
>
> How do you mean?
>
I meant there is another path I might miss when disabling WOL
Hi Florian,
> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev,
> if (wol->wolopts & WAKE_ARP)
> pdata->wol |= WAKE_ARP;
>
> + if (pdata->wol == 0)
> + return -EINVAL;
> +
It will make function return when disabling WOL.
Is there other
Hi Stefan,
Thanks for report. We will try to repro issue and contact you if need more
details.
Regards,
Woojung
> -Original Message-
> From: Stefan Wahren [mailto:stefan.wah...@i2se.com]
> Sent: Saturday, April 28, 2018 3:59 AM
> To: Nisar Sayed - I17970 ; Woojung Huh - C21699
>
> Cc:
> > @@ -2097,6 +2098,25 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
> > (void)lan78xx_set_eee(dev->net, &edata);
> > }
> >
> > + if (!of_property_read_u32_array(dev->udev->dev.of_node,
> > + "microchip,led-modes",
> > +
Hi Alexander,
Thanks for patch. We will look into it if there is any corner case
Such as plug in/out while operations.
Woojung
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Wednesday, March 14, 2018 10:55 AM
> To: Woojung Huh - C21699
> Cc: UNGLinuxDriver ;
> From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net]
> Sent: Saturday, October 28, 2017 4:57 PM
> To: net...@vger.kernel.org; linux-usb@vger.kernel.org; UNGLinuxDriver;
> Woojung Huh - C21699
> Cc: LKML; kernel-janit...@vger.kernel.org
> Subject: [PATCH] lan78xx: Use common error handli
> -Original Message-
> From: Petr Kulhavy [mailto:br...@jikos.cz]
> Sent: Thursday, July 13, 2017 1:41 PM
> To: steve.glendinn...@shawell.net; UNGLinuxDriver
> Cc: net...@vger.kernel.org; linux-usb@vger.kernel.org; Petr Kulhavy
> Subject: [PATCH] smsc95xx: use ethtool_op_get_ts_info()
>
>
> This chip is used by a lot of embedded devices and also by the Raspberry
> Pi 1, 2 & 3 which were created to promote the study of computer
> sciences. Students wanting to learn kernel / network device driver
> programming through those devices can only rely on the Linux kernel
> driver source to
> I based my comments on the datasheet. For the LED_GPIO_CFG register, the
> datasheet says:
> > This register configures the external GPIO[2:0] pins.
>
> QFN package description also indicates GPIOs 0, 1 & 2.
> As an example for the LAN9514, pin 22 of the QFN indicates:
> > nSPD_LED/GPIO2
>
> In
> +/* LED General Purpose IO Configuration Register */
> +#define LED_GPIO_CFG (0x24)
> +#define LED_GPIO_CFG_SPD_LED (0x0100)/* GPIO2 as SPD LED
> */
> +#define LED_GPIO_CFG_LNK_LED (0x0010)/* GPIO1 as LNK LED
> */
> +#define LED_GPIO_CFG_FDX_LED (0x0001)/* GPIO0 as
> lan78xx appears to use phylib in a rather weird way, accessing the PHY
> partly through phylib, and partly by makign direct accesses to it,
> including to the Clause 45 registers. As the indirect MMD accessors are
> going away, update this driver to use the plain phy_(read|write)_mmd()
> access
> Signed-off-by: Pan Bian
> ---
> drivers/net/usb/lan78xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index db558b8..f33460c 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -3395,6 +3395,7 @@ s
> Signed-off-by: Florian Fainelli
> ---
> drivers/net/usb/lan78xx.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index bcd9010c1f27..cf2857fa938f 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net
> Joe Perches (2):
> lan78xx: Remove locally defined trailing underscores from defines and uses
> microchipphy.h and uses: Remove trailing underscores from defines and
> uses
>
> drivers/net/phy/microchip.c |4 +-
> drivers/net/usb/lan78xx.c| 368 +++
> drivers/net/usb/l
> -Original Message-
> From: Wolfram Sang [mailto:wsa-...@sang-engineering.com]
> Sent: Thursday, August 11, 2016 5:05 PM
> To: linux-usb@vger.kernel.org
> Cc: Wolfram Sang; Woojung Huh - C21699; UNGLinuxDriver;
> net...@vger.kernel.org
> Subject: [PATCH 08/16] net: usb: lan78xx: don't prin
> > > But this leaves open the issue that querying the device too often will
> > > prevent it from going into autosuspend. It seems to me that the best
> > > way to deal with this is to make sure that the autosuspend timeout is
> > > shorter than the interal between queries, not to make the queryi
> But this leaves open the issue that querying the device too often will
> prevent it from going into autosuspend. It seems to me that the best
> way to deal with this is to make sure that the autosuspend timeout is
> shorter than the interal between queries, not to make the querying
> conditional
> -Original Message-
> From: Guenter Roeck [mailto:li...@roeck-us.net]
> Sent: Sunday, March 20, 2016 6:59 PM
> To: Geert Uytterhoeven; Woojung Huh - C21699; UNGLinuxDriver; David S.
> Miller
> Cc: Rafael J. Wysocki; net...@vger.kernel.org; linux-usb@vger.kernel.org;
> linux...@vger.kernel.
> -Original Message-
> From: Oliver Neukum [mailto:oneu...@suse.com]
> Sent: Monday, March 21, 2016 4:36 AM
> To: Geert Uytterhoeven
> Cc: Woojung Huh - C21699; UNGLinuxDriver; David S. Miller; Guenter Roeck;
> Rafael J. Wysocki; net...@vger.kernel.org; linux-usb@vger.kernel.org;
> linux...
24 matches
Mail list logo
