n PTR_ERR(udc->udp_baseaddr);
> }
>
> /* Get USB device clock */
thank you for the change, it is a correct fix.
I do suppose that dev_err() in the context can be evenly removed, but
likely it should be another change.
Acked-by: Vladimir Zapolskiy
--
Best wishes,
Vladimir
option are left aside deliberately.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/storage/Kconfig | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index ec84758..8d7d764 100644
--- a/drivers/usb
-off-by: Vladimir Zapolskiy
---
drivers/usb/storage/Kconfig | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index 8d7d764..6fd4272 100644
--- a/drivers/usb/storage/Kconfig
+++ b/drivers/usb/storage/Kconfig
@@ -176,15 +176,10
Hi Alan,
thank you for review.
On 08/09/2018 05:01 PM, Alan Stern wrote:
> On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote:
>
>> Instead of explicit setting of USB_STORAGE dependency for every
>> underlying build entries, exploit if USB_STORAGE / endif block.
>>
&g
Hi Oliver,
On 08/09/2018 10:38 AM, Oliver Neukum wrote:
> On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
>> Because USB_STORAGE build symbol strictly depends on SCSI build
>> symbol, there is no need to specify it again for USB_UAS and
>> USB_STORAGE_ENE
description,
hence the change removes this duplication.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/storage/Kconfig | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index 0aef832d3be6..7db5b28fbf0c 100644
--- a/drivers/usb/storage
Instead of explicit setting of USB_STORAGE dependency for every
underlying build entries, exploit if USB_STORAGE / endif block.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/storage/Kconfig | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb
On 12/08/2016 12:34 AM, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() extern declaration as it is already declared
> as extern in include/linux/usb.h.
>
> Signed-off-by: Manjunath Goudar
> Cc: Vladimir Zapolskiy
> Cc: Sylvain Lemieux
-by: Manjunath Goudar
> Cc: Vladimir Zapolskiy
> Cc: Sylvain Lemieux
> Cc: Alan Stern
> Cc: Greg Kroah-Hartman
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
Looks good, thank you for the change.
Acked
Hi Bin,
On 09.03.2016 02:57, Vladimir Zapolskiy wrote:
> The usb_get_phy() function returns either a valid pointer to phy or
> ERR_PTR() error, check for NULL always fails and may lead to oops on
> error path, fix this issue.
>
> Signed-off-by: Vladimir Zapolskiy
> ---
&
; in qset_free_std() as suggested by Vladimir Zapolskiy.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov
Reviewed-by: Vladimir Zapolskiy
> ---
> drivers/usb/host/whci/qset.c | 8 ++--
> 1 file changed, 6 insert
On 26.03.2016 00:56, Alexey Khoroshilov wrote:
> On 26.03.2016 01:03, Vladimir Zapolskiy wrote:
>> On 25.03.2016 22:23, Alexey Khoroshilov wrote:
>>> Fixing checks for dma mapping error in qset_fill_page_list(),
>>> I have missed two similar problems in q
On 25.03.2016 22:23, Alexey Khoroshilov wrote:
> Fixing checks for dma mapping error in qset_fill_page_list(),
> I have missed two similar problems in qset_add_urb_sg() and
> in qset_add_urb_sg_linearize().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alex
Hi Felipe,
On 09.03.2016 02:57, Vladimir Zapolskiy wrote:
> The usb_get_phy() function returns either a valid pointer to phy or
> ERR_PTR() error, check for NULL always fails and may lead to oops on
> error path, fix this issue.
>
> Signed-off-by: Vladimir Zapolskiy
> ---
&
The usb_get_phy() function returns either a valid pointer to phy or
ERR_PTR() error, check for NULL always fails and may lead to oops on
error path, fix this issue.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/musb/jz4740.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Direct access to clock control registers can be safely removed, the
task of clock management is done by platform clock driver based on
common clock framework.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 29 -
1 file changed, 29
LPC32xx common clock framework driver correctly manages parent clocks
of USB device clock, so there is no need to manually enable and
disable them from the driver, which now depends only on a single USB
device clock.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/gadget/udc/lpc32xx_udc.c
.
The change is wanted for v4.6, because in this release LPC32xx will
be finally switched to the CCF.
I'm adding Roland to Cc, however in fact the platform is unmaintained.
Vladimir Zapolskiy (3):
usb: udc: lpc32xx: switch to clock prepare/unprepare model
usb: udc: lpc32xx: remove direct a
nit) from [<>] (do_one_initcall+0x11c/0x1dc)
[<>] (do_one_initcall) from [<>] (kernel_init_freeable+0x10c/0x1d4)
[<>] (kernel_init_freeable) from [<>] (kernel_init+0x10/0xec)
[<>] (kernel_init) from [<>] (ret_from_fork+0x14/0x24)
Signed-off-by: V
re USB PLL
usb-ohci: probe of 3102.ohci failed with error -2
I'm adding Roland to Cc, however in fact the platform is unmaintained.
Vladimir Zapolskiy (2):
usb: ohci: nxp: remove direct access to clock controller registers
usb: ohci: nxp: remove USB PLL and USB OTG clock management
d
Direct access to clock control registers can be safely removed, the
task of clock management is done by platform clock driver based on
common clock framework.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/ohci-nxp.c | 18 --
1 file changed, 18 deletions(-)
diff --git a
LPC32xx common clock framework driver correctly manages parent clocks
of USB OHCI clock, so there is no need to manually enable and
disable them from the driver, which now depends only on a single USB
host clock.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/ohci-nxp.c | 62
Hi Felipe, Greg,
On 02.12.2015 08:17, Vladimir Zapolskiy wrote:
> Hi Felipe,
>
> On 17.10.2015 22:24, Vladimir Zapolskiy wrote:
>> If common clock framework is configured, the driver generates warnings,
>> which is fixed by this change:
>>
>> WARNING: CPU:
On 08.12.2015 17:30, Alan Stern wrote:
> On Tue, 8 Dec 2015, Vladimir Zapolskiy wrote:
>
>> Remove mach/irq.h from the list of included headers, there is no
>> compilation dependency on this include file, the change is needed
>> to prevent a compilation failure, wh
Remove mach/irq.h from the list of included headers, there is no
compilation dependency on this include file, the change is needed
to prevent a compilation failure, when mach/irq.h is removed.
Additionally remove other unneeded includes.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host
Remove mach/irq.h from the list of included headers, there is no
compilation dependency on this include file, and the change is needed
to prevent a compilation failure, when mach/irq.h is removed.
Additionally remove other unneeded includes and sort out their order.
Signed-off-by: Vladimir
Hi Felipe,
On 17.10.2015 22:24, Vladimir Zapolskiy wrote:
> If common clock framework is configured, the driver generates warnings,
> which is fixed by this change:
>
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:728
> clk_core_enable+0x2c/0xf0()
> Modules linked in:
&
On 20.10.2015 09:05, Peter Chen wrote:
> On Mon, Oct 19, 2015 at 07:00:26PM +0300, Vladimir Zapolskiy wrote:
>> This change allows to get a driver instance of usb controller, which
>> registers an irq, now the interrupt names are unique:
>>
>> # cat /proc/inter
-off-by: Vladimir Zapolskiy
---
drivers/usb/chipidea/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 3feebf7..f2d2e5c 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -917,7 +917,7
The change adds missing clk_disable_unprepare(usb_otg_clk) call, also
the disabled clocks are sorted in order opposite to enabled clocks.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/ohci-nxp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci
one_initcall) from [<>] (do_init_module+0x60/0x368)
[<>] (do_init_module) from [<>] (load_module+0x16d0/0x1b7c)
[<>] (load_module) from [<>] (SyS_finit_module+0x90/0xa4)
[<>] (SyS_finit_module) from [<>] (ret_fast_syscall+0x0/0x38)
Signed-off-by: Vladimir Zapo
There is no need to unregister the I2C device, which serves as a phy
from host code, this should be done in the correspondent phy driver.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/ohci-nxp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers
The changeset contains a couple of fixes in the LPC32xx OHCI driver
related to clock enable/disable usage and one more fix of improper
phy device release on driver removal.
Vladimir Zapolskiy (3):
usb: host: lpc32xx: fix warnings caused by enabling unprepared clock
usb: host: lpc32xx: balance
ter+0x50/0x64)
[<>] (__platform_driver_register) from [<>]
(__platform_driver_probe+0x54/0x100)
[<>] (__platform_driver_probe) from [<>] (lpc32xx_udc_driver_init+0x1c/0x28)
[<>] (lpc32xx_udc_driver_init) from [<>] (do_one_initcall+0x11c/0x1dc)
[
On 30.03.2015 05:38, Sören Brinkmann wrote:
> On Sun, 2015-03-29 at 05:43AM +0300, Vladimir Zapolskiy wrote:
>> devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never
>> returns NULL, fix the check to prevent access to invalid
>> virtual address.
>>
>>
devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never
returns NULL, fix the check to prevent access to invalid
virtual address.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/gadget/udc/udc-xilinx.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb
Hi Fabio,
On 15.12.2014 17:05, Fabio Estevam wrote:
> On Tue, Dec 9, 2014 at 11:48 AM, Matthieu CASTET
> wrote:
>
>> Is your usb phy ok ?
>>
>> I saw freeze like that when there was no ulpi communication with the
>> usb phy.
>
> Thanks. I fixed it by passing 'regulator-boot-on' to the USB regul
On 07.11.2014 02:16, Peter Chen wrote:
>
>> Hi Peter,
>>
>> On 06.11.2014 09:15, Peter Chen wrote:
>>> On Wed, Nov 05, 2014 at 08:52:25PM +0200, Vladimir Zapolskiy wrote:
>>>> On some boards powered by iMX6Q rev1.0 I get non-working USB Host 1
>
Hi Peter,
On 06.11.2014 09:15, Peter Chen wrote:
> On Wed, Nov 05, 2014 at 08:52:25PM +0200, Vladimir Zapolskiy wrote:
>> On some boards powered by iMX6Q rev1.0 I get non-working USB Host 1
>> (connected to a hub, no other devices are connected to this hub) and
>> repe
Hi Felipe,On 05.11.2014 21:00, Felipe Balbi wrote:
> On Wed, Nov 05, 2014 at 08:52:25PM +0200, Vladimir Zapolskiy wrote:
>> On some boards powered by iMX6Q rev1.0 I get non-working USB Host 1
>> (connected to a hub, no other devices are connected to this hub) and
>> repe
: Vladimir Zapolskiy
Cc: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 0e0c415..fbd079f 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy
uhci_start() is executed one time during usb_add_hcd() call and by
default UHCI frame list is allocated from atomic DMA pool.
Do non-atomic allocation of uhci->frame and free some space in
coherent atomic DMA pool.
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Signed-off-by: Vladimir Zapols
OHCI HCCA memory region is allocated from atomic DMA pool one time
during usb_add_hcd() and deallocated by usb_remove_hcd().
Do non-atomic allocation of OHCI HCCA and free some space in
coherent atomic DMA pool.
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Signed-off-by: Vladimir Zapolskiy
This change makes two more one-time per HCD allocations to be done
from non-atomic DMA pool, the main purpose of the change is to save
some bits of space in coherent atomic DMA pool, which is 256KB by
default on ARM platform.
Vladimir Zapolskiy (2):
USB: OHCI: don't allocate HCCA atomi
On 03.07.2014 19:38, Alan Stern wrote:
On Thu, 3 Jul 2014, Vladimir Zapolskiy wrote:
ehci_mem_init() is executed one time during ehci_init() and by default
all memory allocations but ehci->periodic are done not atomically,
GFP_KERNEL is passed as flags parameter.
Do similar allocation
Stern
Cc: Greg Kroah-Hartman
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/ehci-mem.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
index c0fb6a8..b6205fa 100644
--- a/drivers/usb/host/ehci-mem.c
+++ b/d
Hi Peter,
On 05/07/13 04:39, Peter Chen wrote:
On Fri, May 3, 2013 at 6:13 AM, Vladimir Zapolskiy
wrote:
This change removes calls of uvc_function_connect()/uvc_function_disconnect()
functions from open()/close() syscalls.
This is a bugfix in g_webcam module, in some test scenarios (e.g
Hi,
On 05/04/13 21:22, Bhupesh SHARMA wrote:
Hi,
On 5/3/2013 6:00 PM, Vladimir Zapolskiy wrote:
Hi Laurent,
thank you for the comment.
On 05/03/13 02:05, Laurent Pinchart wrote:
Hi Vladimir,
On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote:
On 05/03/13 01:18, Laurent Pinchart
Hi Laurent,
thank you for the comment.
On 05/03/13 02:05, Laurent Pinchart wrote:
Hi Vladimir,
On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote:
On 05/03/13 01:18, Laurent Pinchart wrote:
On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote:
This change removes redundant calls to
Hi Laurent,
On 05/03/13 01:18, Laurent Pinchart wrote:
Hi Vladimir,
Thank you for the patch.
On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote:
This change removes redundant calls to uvc_function_connect() and
uvc_function_disconnect() on V4L2 device node open and release.
These two
The uvc_function_connect() and uvc_function_disconnect() functions are to be
removed, because there is no users of them.
Signed-off-by: Vladimir Zapolskiy
Cc: Laurent Pinchart
---
drivers/usb/gadget/f_uvc.c | 24
drivers/usb/gadget/uvc.h |3 ---
2 files changed
information about current mode of the controller.
The UDC may be in suspended state, or an OTG controller may be in host mode,
therefore it seems better not to try to forcibly pull-up D+ line on open()
syscall.
Signed-off-by: Vladimir Zapolskiy
Cc: Laurent Pinchart
---
drivers/usb/gadget/uvc_v4l2.c
C driver's .pullup
functions, however presence of pullup controls from uvcvideo seems to
be redundant.
[1] http://kerneltrap.org/mailarchive/linux-usb/2010/12/29/6268355/thread
Vladimir Zapolskiy (2):
usb: gadget/uvc: remove connect/disconnect calls on open/release
usb: gadget/uvc: re
53 matches
Mail list logo
