Re: [PATCH 1/3] usb: phy: introduce usb_phy_set_event interface

2014-11-19 Thread Todd Poynor
On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > usb: phy: introduce usb_phy_set_event interface Hi Kiran, this is new stuff that is all your own work and you deserve the credit. Thanks for working to get this feature in shape for mainline! T

Re: [RFC v2 2/2] usb: phy: Temporarily hold wakeupsource on charger connect and disconnect events

2014-09-05 Thread Todd Poynor
On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote: ... >> diff --git a/drivers/usb/phy/otg-wakeupsource.c >> b/drivers/usb/phy/otg-wakeupsource.c >> index fca2010..70fa05e 100644 >> --- a/drivers/usb/phy/otg-wakeupso

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-09-02 Thread Todd Poynor
On Fri, Aug 29, 2014 at 1:50 PM, Felipe Balbi wrote: > Hi, > > On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote: >> On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: >> ... >> > you never explain why this is needed and you have also added some >&g

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-27 Thread Todd Poynor
On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: ... > you never explain why this is needed and you have also added some > information to commit log which shouldn't be here. Android uses this to prevent suspend from interfering with USB peripheral traffic, notably adb. The wakeup source is