Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Timur Tabi
On 5/22/18 1:55 PM, Adam Wallis wrote: + struct device *dev = xhci_to_hcd(xhci)->self.sysdev; Since you only use 'dev' to get the NUMA node, you might want to consider this instead: int node = dev_to_node(xhci_to_hcd(xhci)->self.sysdev); -- Qualcomm Datacenter Technologies, In

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/04/2017 09:48 AM, Adam Wallis wrote: As noted in the patch description, xhci-plat devices will use a default of 40,000, while MTK devices will use a default of 5,000. This is also documented in the probe for each relevant driver. This is further confirmed in the description for each driver'

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/4/17 8:27 AM, Adam Wallis wrote: If no interval is specified, the default of 40,000ns (IMOD=160) will be used. ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... + xhci->i

Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Timur Tabi
On 01/31/2017 01:19 PM, Russell King wrote: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + The v

Re: [PATCH 4/6] usb: make xhci platform driver use 64 bit or 32 bit DMA

2016-04-14 Thread Timur Tabi
On Tue, Mar 8, 2016 at 8:59 AM, Timur Tabi wrote: >> + /* Try setting the coherent_dma_mask to 64 bits, then try 32 bits >> */ >> + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); >> + if (ret) { >> + ret =

Re: [PATCH 4/6] usb: make xhci platform driver use 64 bit or 32 bit DMA

2016-03-08 Thread Timur Tabi
Mathias Nyman wrote: Evolution of the patch can be found in this thread: http://www.spinics.net/lists/linux-usb/msg128495.html I think version 8 was the final one. I couldn't find any answers to my questions in that thread. The key change to the patch was made between v1 and v2: +

Re: [PATCH 4/6] usb: make xhci platform driver use 64 bit or 32 bit DMA

2016-03-04 Thread Timur Tabi
On Fri, Oct 9, 2015 at 5:30 AM, Mathias Nyman wrote: > The xhci platform driver needs to work on systems that > either only support 64-bit DMA or only support 32-bit DMA. > Attempt to set a coherent dma mask for 64-bit DMA, and > attempt again with 32-bit DMA if that fails. I know this patch is a

Re: [PATCH 1/5] [v2] usb: host: ehci-msm: Allow LS devices to work

2016-01-06 Thread Timur Tabi
Timur Tabi wrote: From: Jack Pham Disable the silicon quirk which is normally enabled for HSIC host mode. This would otherwise prevent low speed devices from enumerating properly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi Felipe, any change that these five patches can make it

[PATCH 2/5] [v2] usb: host: ehci-msm: Remove dependency on OTG PHY

2015-12-10 Thread Timur Tabi
being present and call usb_add_hcd() directly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 53 ++--- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci

[PATCH 3/5] [v2] usb: host: ehci-msm: Add support for ACPI probing

2015-12-10 Thread Timur Tabi
From: Jack Pham Allow the EHCI MSM driver to probe against an ACPI enumerated device with ID QCOM8040. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host

[PATCH 1/5] [v2] usb: host: ehci-msm: Allow LS devices to work

2015-12-10 Thread Timur Tabi
From: Jack Pham Disable the silicon quirk which is normally enabled for HSIC host mode. This would otherwise prevent low speed devices from enumerating properly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 2 ++ include/linux/usb/msm_hsusb_hw.h

[PATCH 4/5] [v2] usb: host: ehci-msm: Fix register initialization

2015-12-10 Thread Timur Tabi
support. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 102837e..b71947d 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehc

[PATCH 5/5] [v2] usb: host: ehci-msm: Register usb shutdown function

2015-12-10 Thread Timur Tabi
From: Azriel Samson Registering usb_hcd_platform_shutdown to be called during shutdown. This is a generic function that performs the generic host stack's shutdown. It ensures that USB operations do not continue while kexec boots a new kernel. Signed-off-by: Azriel Samson Signed-off-by:

Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB

2015-12-10 Thread Timur Tabi
On Fri, Nov 6, 2015 at 12:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross I know it's a little late, but ... Acked-by: Timur Tabi -- Qualcomm Innovation Center,

Re: [PATCH 4/5] usb: ehci-msm: Fix register initialization

2015-12-09 Thread Timur Tabi
Jack Pham wrote: Andy already sent a patch for just this register change. http://marc.info/?l=linux-usb&m=144678991912202&w=2 I see it's already been queued on Greg's usb-next. I think it would be good to rebase. Ok, I will do that in my next patch version. -- Sent by an employee of the Qualc

[PATCH 4/5] usb: ehci-msm: Fix register initialization

2015-12-09 Thread Timur Tabi
e support. Also, update to use the correct value of AHBMODE to allow data transfers to be posted AHB transactions. This aligns with the value used in the downstream MSM kernel. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 4 +++- 1 file changed, 3 insertion

[PATCH 5/5] usb: ehci-msm: Register usb shutdown function

2015-12-09 Thread Timur Tabi
From: Azriel Samson Registering usb_hcd_platform_shutdown to be called during shutdown. This is a generic function that performs the generic host stack's shutdown. It ensures that USB operations do not continue while kexec boots a new kernel. Signed-off-by: Azriel Samson Signed-off-by:

[PATCH 3/5] usb: ehci-msm: Add support for ACPI probing

2015-12-09 Thread Timur Tabi
From: Jack Pham Allow the EHCI MSM driver to probe against an ACPI enumerated device with ID QCOM8040. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host

[PATCH 1/5] usb: ehci-msm: Allow LS devices to work

2015-12-09 Thread Timur Tabi
From: Jack Pham Disable the silicon quirk which is normally enabled for HSIC host mode. This would otherwise prevent low speed devices from enumerating properly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 2 ++ include/linux/usb/msm_hsusb_hw.h

[PATCH 2/5] usb: ehci-msm: Remove dependency on OTG PHY

2015-12-09 Thread Timur Tabi
being present and call usb_add_hcd() directly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi --- drivers/usb/host/ehci-msm.c | 53 ++--- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci