Re: [PATCH v4 3/3] usb: chipidea: register driver as a peripheral with the phy

2015-11-23 Thread Tim Bird
On 11/23/2015 12:29 AM, Peter Chen wrote: > On Fri, Nov 20, 2015 at 03:47:20PM -0800, Tim Bird wrote: >> Register the chipidea driver with the phy, so that the phy >> driver can kick the gadget driver when it resumes from low power. >> The phy-msm-usb (Qualcomm) driver requ

[PATCH v4 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Tim Bird
Add support for async_irq to wake up driver from low power mode. Without this, the power management code never calls resume. Remove a spurious interrupt enable in the driver resume function. Signed-off-by: Tim Bird --- drivers/usb/phy/phy-msm-usb.c | 17 - include/linux/usb

[PATCH v4 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
Add optional async_irq to msm_hsusb binding doc. Signed-off-by: Tim Bird --- Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree

[PATCH v4 3/3] usb: chipidea: register driver as a peripheral with the phy

2015-11-20 Thread Tim Bird
Register the chipidea driver with the phy, so that the phy driver can kick the gadget driver when it resumes from low power. The phy-msm-usb (Qualcomm) driver requires this in order to recover gadget operation after you disconnect the USB cable and reconnect it. Signed-off-by: Tim Bird

Re: [PATCH v3 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
On 11/20/2015 03:22 PM, Arnd Bergmann wrote: > On Friday 20 November 2015 15:20:39 Tim Bird wrote: >> +- interrupt-names: Should contain the following: >> + "core"USB core interrupt >> + "async" Asynchronous interrupt to wake up from low

Re: [PATCH v3 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
On 11/20/2015 03:20 PM, Tim Bird wrote: > Add optional async_irq to msm_hsusb binding doc. > > Signed-off-by: Tim Bird > Acked-by: Rob Herring I probably should have taken this Acked-by by Rob off. Sorry about that. -- Tim > --- > Documentation/devicetree/bindings/usb/

[PATCH v3 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Tim Bird
Add support for async_irq to wake up driver from low power mode. Without this, the power management code never calls resume. Remove a spurious interrupt enable in the driver resume function. Signed-off-by: Tim Bird --- drivers/usb/phy/phy-msm-usb.c | 17 - include/linux/usb

[PATCH v3 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
Add optional async_irq to msm_hsusb binding doc. Signed-off-by: Tim Bird Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b

[PATCH v3 3/3] usb: chipidea: register driver as a peripheral with the phy

2015-11-20 Thread Tim Bird
Register the chipidea driver with the phy, so that the phy driver can kick the gadget driver when it resumes from low power. The phy-msm-usb (Qualcomm) driver requires this in order to recover gadget operation after you disconnect the USB cable and reconnect it. Signed-off-by: Tim Bird

Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
On 11/20/2015 02:44 PM, Arnd Bergmann wrote: > On Friday 20 November 2015 14:37:16 Tim Bird wrote: >> +- interrupt-names: Should contain the following: >> + "core_irq"USB core interrupt >> + "async_irq" Asynchronous interrupt to wake up from low

[PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-20 Thread Tim Bird
Add optional async_irq to msm_hsusb binding doc. Signed-off-by: Tim Bird Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b

[PATCH v2 3/3] usb: chipidea: register driver as a peripheral with the phy

2015-11-20 Thread Tim Bird
Register the chipidea driver with the phy, so that the phy driver can kick the gadget driver when it resumes from low power. The phy-msm-usb (Qualcomm) driver requires this in order to recover gadget operation after you disconnect the USB cable and reconnect it. Signed-off-by: Tim Bird

[PATCH v2 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Tim Bird
Add support for async_irq to wake up driver from low power mode. Without this, the power management code never calls resume. Remove a spurious interrupt enable in the driver resume function. Signed-off-by: Tim Bird --- drivers/usb/phy/phy-msm-usb.c | 17 - include/linux/usb

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Tim Bird
On 11/16/2015 09:21 AM, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: >> On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: >>> >>> >>> On 11/10/2015 07:14 PM, Peter Chen wrote: >>>> On Tue, Nov 10, 2015 at 04:46:51PM -

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-11 Thread Tim Bird
On 11/10/2015 07:14 PM, Peter Chen wrote: > On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote: >> This fixes a bug where if you disconnect and re-connect the USB cable, >> the gadget driver stops working. >> >> Add support for async_irq to wake up driver from

[PATCH 1/2] Documentation: dt-bindings: add async_irq to msm_hsusb

2015-11-10 Thread Tim Bird
Add optional async_irq to msm_hsusb binding doc. Signed-off-by: Tim Bird --- Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree

[PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-10 Thread Tim Bird
having the chipidea driver register with it, for vbus connect notifications. Signed-off-by: Tim Bird --- drivers/usb/chipidea/udc.c| 6 ++ drivers/usb/phy/phy-msm-usb.c | 16 include/linux/usb/msm_hsusb.h | 1 + 3 files changed, 23 insertions(+) diff --git a/drivers/usb

Re: [GIT PULL] On-demand device probing

2015-10-23 Thread Tim Bird
On 10/22/2015 11:53 AM, Frank Rowand wrote: > On 10/22/2015 7:44 AM, Greg Kroah-Hartman wrote: >> >> >> On Thu, Oct 22, 2015 at 11:05:11AM +0200, Tomeu Vizoso wrote: >>> But that's moot currently because Greg believes that the time spent >>> probing devices at boot time could be reduced enough so

Re: [PATCH v2] usb: phy: msm: Unregister VBUS and ID events notifiers

2015-09-08 Thread Tim Bird
; Fixes: 591fc116f330 ("usb: phy: msm: Use extcon framework for VBUS and ID > detection") > > Reported-by: Tim Bird > Signed-off-by: Ivan T. Ivanov > --- > > Patch reworked to use new extcon API. > > drivers/usb/phy/phy-msm-usb.c | 25

Re: [PATCH] usb: phy: msm: Unregister driver interest for VBUS and ID events

2015-08-24 Thread Tim Bird
e fail. > > Fixes: 591fc116f330 ("usb: phy: msm: Use extcon framework for VBUS and ID > detection") > > Reported-by: Tim Bird > Signed-off-by: Ivan T. Ivanov > --- > drivers/usb/phy/phy-msm-usb.c | 26 +- > 1 file changed, 17 insertions(+

repeat... Re: BUG: usb: phy: msm: problem with EPROBE defer and extcon cleanup

2015-08-17 Thread Tim Bird
Sorry - I mistyped Ivan's e-mail the first time. On 08/17/2015 04:43 PM, Tim Bird wrote: > Ivan, > > I'm seeing a bug in the phy-msm-usb.c code, when I get an EPROBE defer during > probing the driver. > The code is statically linked in the kernel, and the dts for my

BUG: usb: phy: msm: problem with EPROBE defer and extcon cleanup

2015-08-17 Thread Tim Bird
Ivan, I'm seeing a bug in the phy-msm-usb.c code, when I get an EPROBE defer during probing the driver. The code is statically linked in the kernel, and the dts for my board is specifying an extcon phandle for the ID pin. Below is a fragment of the kernel output for a boot of this code. Messa

Re: [Device-mainlining] [PATCH v2 2/3] gadget: Introduce the usb charger framework

2015-08-17 Thread Tim Bird
On 08/16/2015 08:03 PM, Baolin Wang via device-mainlining wrote: > On 14 August 2015 at 23:27, Greg KH wrote: >> On Fri, Aug 14, 2015 at 05:47:45PM +0800, Baolin Wang wrote: >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU

Re: [ANNOUNCE] tree closed for v4.3 merge window

2015-08-10 Thread Tim Bird
On Mon, Aug 10, 2015 at 7:34 AM, Felipe Balbi wrote: > On Fri, Aug 07, 2015 at 02:30:45PM -0700, Tim Bird wrote: >> On Thu, Aug 6, 2015 at 9:40 AM, Felipe Balbi wrote: >> > Hi folks, >> > >> > if your patches aren't in my tree yet, it's too late, sor

Re: [ANNOUNCE] tree closed for v4.3 merge window

2015-08-07 Thread Tim Bird
hes until v4.3-rc1 is tagged as that goes a > long way towards keeping my sanity ;-) I'm not sure I understand. What about discussion of USB patches for the next release? Can we send RFC patches amongst ourselves to the linux-usb list? -- Tim Bird Senior Software Engineer, Sony Mobile Ar

Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-07-29 Thread Tim Bird
On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov wrote: > On recent Qualcomm platforms VBUS and ID lines are not routed to > USB PHY LINK controller. Use extcon framework to receive connect > and disconnect ID and VBUS notification. > > Signed-off-by: Ivan T. Ivanov > --- > Changes sice v2 [1]. > >

Re: Bug: shared usb dt document is incorrect

2015-07-29 Thread Tim Bird
On 07/28/2015 07:54 PM, Rob Herring wrote: > On Tue, Jul 28, 2015 at 8:06 PM, Tim Bird wrote: >> Antoine and Rob, >> >> I was just doing some testing with USB on a Qualcomm SoC. >> >> I followed the instructions in the binding document: >> Documentation/d

Bug: shared usb dt document is incorrect

2015-07-28 Thread Tim Bird
Antoine and Rob, I was just doing some testing with USB on a Qualcomm SoC. I followed the instructions in the binding document: Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt which has a compatible for "qcom,ci-hdrc", and is, in general, for chipidea-based USB controllers. It says in th

Re: Fwd: Status of chipidea msm USB reset patch

2014-09-04 Thread Tim Bird
On Fri, Aug 15, 2014 at 12:08 AM, Ivan T. Ivanov wrote: > On Fri, 2014-08-15 at 08:23 +0800, Peter Chen wrote: >> On Thu, Aug 14, 2014 at 11:54:02AM -0500, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Aug 14, 2014 at 09:53:10AM -0700, Tim Bird wrote: >

Fwd: Status of chipidea msm USB reset patch

2014-08-14 Thread Tim Bird
Ping. Anybody know the status of this patch? Is it queued in someone's tree? Without it the USB driver for the Qualcomm 8974 (hsusb phy) doesn't work (at least for me). It looks like it got dropped from Ivan's original patch series, back in May. -- Forwarded message -----

Re: To otg-fsm or not to otg-fsm? That is the question.

2014-08-12 Thread Tim Bird
idea of how the state machines map, try adding the charger stuff. If I feel like I need to modify the generic state machine, I'll ask on list. I'm a newbie at USB stuff and I don't want to break anything. Thanks. -- Tim Bird Senior Software Engineer, Sony Mobile Architecture Gr

To otg-fsm or not to otg-fsm? That is the question.

2014-08-11 Thread Tim Bird
e machine, or just try to mainline the state machine from the out-of-tree driver? I'm suspecting the former will be more work, but I want to do the right thing. Really I'm just checking that using the generic state machine is the preferred method of supporting USB OTG drivers going for

Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR

2014-04-21 Thread Tim Bird
On Mon, Apr 21, 2014 at 9:14 AM, Felipe Balbi wrote: > Hi, > > On Fri, Apr 04, 2014 at 03:18:11PM -0700, Tim Bird wrote: >> Select the secondary PHY using the TCSR register, if phy-num=1 >> in the DTS (or phy_number is set in the platform data). The >> SOC has 2 PHYs

[PATCH] usb: phy: msm: Select secondary PHY via TCSR

2014-04-04 Thread Tim Bird
t the USB driver working at all on a dragonboard, from cold boot. This patch depends on patch 5/14 from Ivan's msm USB patch set. It does not use DT for the register address, as there's no evidence that this address changes between SoC versions. Signed-off-by: Tim Bird --- drivers/

Re: [PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-19 Thread Tim Bird
Thanks very much. I will try out the things you mention and let you know if I make progress. -- Tim On Wed, Feb 19, 2014 at 6:58 AM, Ivan T. Ivanov wrote: > > Hi Tim, > > On Tue, 2014-02-18 at 22:21 -0800, Tim Bird wrote: >> Ivan, >> >> I'm having tremend

Re: [PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-18 Thread Tim Bird
msm: Add device tree support > usb: chipidea: msm: Initialize offset of the capability registers > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 ++ > drivers/usb/chipidea/ci_hdrc_msm.c | 24 > +++- > 2 files changed

Re: [Celinux-dev] PDF documentation

2012-10-17 Thread Tim Bird
document says it is "public", I'm not sure it's legal to post verbatim contents to a web site. So - useful or not, I'm worried it's not legal. -- Tim = Tim Bird Architecture Group Chair, CE Workgroup of the Linux Foundation Senior Staff E

Re: [Celinux-dev] PDF documentation

2012-10-16 Thread Tim Bird
s very good for collecting the information, and having a way to snapshot and publish the items solves some of the problems wikis have (uneven editing across multiple pages over time can lead to inconsistent pages). It sounds like the tools have improved since we did this, and maybe we should look a