Re: Lockdep is less useful than it was

2017-12-08 Thread Theodore Ts'o
On Thu, Dec 07, 2017 at 02:38:03PM -0800, Matthew Wilcox wrote: > I think it was a mistake to force these on for everybody; they have a > much higher false-positive rate than the rest of lockdep, so as you say > forcing them on leads to fewer people using *any* of lockdep. > > The bug you're hitti

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Theodore Ts'o
On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > > Unfortunately for you, I don't find arguments along the lines of > > "lockdep will save us" at all convincing. lockdep already throws > > too many false positives to be useful as a tool that reliably and > > accurately points out

Re: First kernel patch (optimization)

2015-09-19 Thread Theodore Ts'o
On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: > No. I don't want to lower the standards. Maybe in regard to silly style > stuff, but not in regard to code quality (and I mean real bugs like races, > deadlocks or such, and not if a line has more than 80 characters). I would > hav

Re: First kernel patch (optimization)

2015-09-19 Thread Theodore Ts'o
On Sat, Sep 19, 2015 at 02:52:06PM +0200, Alexander Holler wrote: > > I've recently posted a proof of concept for wiping files, or in other words > to really delete files, And it was a disaster because if someone posts > imperfect pathhes on this list, people have fun trying to eat you (because >

Re: First kernel patch (optimization)

2015-09-19 Thread Theodore Ts'o
On Fri, Sep 18, 2015 at 10:18:27PM -0700, Greg KH wrote: > And again, don't knock the basic whitespace patch. It is non-trivial, > see the tutorials for proof of that. > > And please, NEVER chide someone for contributing whitespace patches, > it's a sure way to ensure that this person never contr

Re: First kernel patch (optimization)

2015-09-18 Thread Theodore Ts'o
On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > So don't take cleanup patches for your code, that's fine, and I totally > understand why _you_ don't want to do that. But to blow off the effort > as being somehow trivial and not worthy of us, that's totally missing > the point, and makin

Re: First kernel patch (optimization)

2015-09-17 Thread Theodore Ts'o
On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > That isn't true. It helps the submitter understand the workflow and > expectations. What you meant to say is that it doesn't help you. The problem is that workflow isn't the hard part. It's the part that can be taught most easily

Re: First kernel patch (optimization)

2015-09-16 Thread Theodore Ts'o
On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch in

Re: Large disk drives

2014-11-05 Thread Theodore Ts'o
On Wed, Nov 05, 2014 at 05:07:48PM +0100, James Bottomley wrote: > > OK, but I still don't understand how windows gets the partition table on > there in the first place ... that must surely be some sort of guess the > disk size hack. 99% of the time the partition table was provided by the drive m

Re: SPDX-License-Identifier

2014-02-24 Thread Theodore Ts'o
On Mon, Feb 24, 2014 at 11:12:53AM +0100, Michal Simek wrote: > > But of course, I'm not a lawyer, and if your company has is paying for > > the development of the driver, the Golden Rule applies (he who has the > > Gold, makes the Rules), and each of our respective corporate lawyers > > may have d

Re: SPDX-License-Identifier

2014-02-21 Thread Theodore Ts'o
On Fri, Feb 21, 2014 at 09:57:20AM -0800, Greg Kroah-Hartman wrote: > > But shouldn't we at least write somewhere > > that it has connection to spdx.org where you can find out that licenses. > > Why? Are these licenses so unknown that no one knows what they are? > And, as part of the kernel-as-a-