Re: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440

2018-04-25 Thread Sylwester Nawrocki
On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski Reviewe

Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440

2018-04-25 Thread Sylwester Nawrocki
27;s good you didn't remove S3C64XX_SPI_QUIRK_POLL entirely as it will be needed for Exynos5433 ISP SPI controllers. Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majord

Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440

2018-04-25 Thread Sylwester Nawrocki
Cc: Jingoo Han On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski Thanks Krz

Re: [PATCHv3 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2017-10-05 Thread Sylwester Nawrocki
On 10/05/2017 02:11 PM, Andrzej Pietrasiewicz wrote: > +static int crport_handshake(struct exynos5_usbdrd_phy *phy_drd, > + u32 val, u32 cmd) > +{ > + u32 usec = 100; > + unsigned int result; > + > + writel(val | cmd, phy_drd->reg_phy + EXYNOS

Re: USB 3.0 is broken on Odroid Xu4 on latest kernel

2017-07-21 Thread Sylwester Nawrocki
Hi, On 07/21/2017 10:10 AM, Felipe Balbi wrote: Jochen Sprickerhof writes: I've send a patch for this some time ago here: http://marc.info/?l=linux-usb&m=149945465112440&w=2 This goes along with the patch in this thread: http://marc.info/?l=linux-usb&m=149983203023058&w=2 Would be great if

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Sylwester Nawrocki
cyclic >> dependency, so it is left as "select". >> >> Signed-off-by: Arun Ramamurthy > > Need your ACK for this patch. For drivers/media/platform/exynos4-is/Kconfig drivers/video/fbdev/exynos/Kconfig Acked-by: Sylwester Nawrocki -- Thanks, Syl

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-12-22 Thread Sylwester Nawrocki
Hi Vivek, On 25/11/14 12:48, Vivek Gautam wrote: > On Sat, Nov 22, 2014 at 8:42 PM, Kukjin Kim wrote: >> > On 11/22/14 17:40, Kishon Vijay Abraham I wrote: >>> >> On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: ... >>> I took dwc3 driver patches. >>> >> >>> >> I took the phy patches

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-05 Thread Sylwester Nawrocki
On 04/11/14 20:52, Paul Bolle wrote: > On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote: >> > As it's something that no one seemed to ever need before (i.e. it's not >> > a regression fix), but it would be a "new feature", I don't think it's >> > really a stable fix. >> > >> > But feel free to con

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-04 Thread Sylwester Nawrocki
On 04/11/14 00:24, Greg KH wrote: > On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote: >> > The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 >> > ("ARM: SAMSUNG: Remove remaining legacy code"). There are still >> > some ref

[PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-07 Thread Sylwester Nawrocki
Paul Bolle Acked-by: Jingoo Han Cc: [3.17+] Signed-off-by: Sylwester Nawrocki --- Changes since v2: - updated the commit description. drivers/usb/host/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig in

[PATCH] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code"). There are still some references left, fix that by replacing them with ARCH_S5PV210. Reported-by: Paul Bolle Signed-off-by: Sylwester Nawrocki --- drivers/usb/host/Kcon

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Sylwester Nawrocki
the driver. >> > >> > Ok, it makes more sense. >> > Just out of curiosity, what difference would this make ? > > Moreover, in case of Exynos5420 (and may be in future SoCs), where we > have 2 USB DRD PHY controllers, > we will need to have a way around to d

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-06 Thread Sylwester Nawrocki
On 28/04/14 08:17, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver and related code > use

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 08/04/14 16:36, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt > b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 28f9edb..6d99ba9 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindi

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 14/04/14 15:49, Vivek Gautam wrote: > True, we don't have a scope of instantiating this driver using old > platform device and > old legacy board files. > So we don't need this check then, right ? I think it can be dropped. At least IMHO there is no point to increase size of the module with an

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
On 09/04/14 14:24, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki > wrote: >> > On 09/04/14 13:54, Vivek Gautam wrote: >>> >> Adding support to enable/disable VBUS hooked to a gpio >>> >> to enable vbus supply on the port. &g

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
Hi Vivek, On 09/04/14 13:54, Vivek Gautam wrote: > Adding support to enable/disable VBUS hooked to a gpio > to enable vbus supply on the port. Does the GPIO control a fixed voltage regulator ? If so, shouldn't it be modelled by the regulator API instead ? > Signed-off-by: Vivek Gautam [...] > +

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Sylwester Nawrocki
W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote: On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote: On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abrah

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-07 Thread Sylwester Nawrocki
On 08/07/2013 07:06 PM, Julius Werner wrote: >> This breaks compatibility, both for an old kernel and a new dt and a new >> kernel with an old dt. Is anyone using these bindings? > > They only affect Samsung SoCs and have only been upstream for half a > year, so I doubt it's heavily used. It prob

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-07-29 Thread Sylwester Nawrocki
e documentation for dt binding can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Cc: Tomasz Figa > Cc: Greg Kroah-Hartman > Signed-off-by: Kishon Vijay Abraham I > Acked-by: Felipe Balbi > Tested-by: Sylwester Nawrocki > --- >

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Sylwester Nawrocki
On 07/24/2013 08:32 PM, Arnd Bergmann wrote: > On Tuesday 23 July 2013, Tomasz Figa wrote: >> On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: >>> On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those phy_address arrays stored? There are no board files when booti

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sylwester Nawrocki
On 07/21/2013 05:48 PM, Greg KH wrote: On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform d

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-24 Thread Sylwester Nawrocki
Hi, On 06/18/2013 11:49 AM, Felipe Balbi wrote: > On Mon, Jun 17, 2013 at 12:16:35PM +0200, Sylwester Nawrocki wrote: >> I have already used this API for our MIPI CSI-2/DSIM DPHYs driver, >> the RFC patch series can be found at [1]. >> >> Thanks, >> Sylwester

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-19 Thread Sylwester Nawrocki
Hi, On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: > +/** > + * phy_create() - create a new phy > + * @dev: device that is creating the new phy > + * @id: id of the phy > + * @ops: function pointers for performing phy operations > + * @label: label given to the phy > + * @priv: private data

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-18 Thread Sylwester Nawrocki
Hi Kishon, I've noticed there is a little inconsistency between the code and documentation. On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +3. Creating the PHY + +The PHY driver should create the PHY in order for other peripheral controllers +to make use of it. The PHY framework provid

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-17 Thread Sylwester Nawrocki
rected few typos in Documentation > * Changed PHY Subsystem to *bool* in Kconfig (to avoid compilation errors when > PHY Subsystem is kept as module and the dependent modules are built-in) > * Added if pm_runtime_enabled check before runtime pm calls. Looks good, feel free to add:

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
Hi, On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote: >>> +static inline int phy_init(struct phy *phy) >>> +{ >>> + pm_runtime_get_sync(&phy->dev); >> >> Hmm, no need to check return value here ? Also it looks a bit unexpected to > > I purposely dint check the return values in order to supp

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. For dt-boot, the PHY drivers should > also register *PHY provid

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
Hi, On 05/29/2013 07:38 AM, Kishon Vijay Abraham I wrote: > On Wednesday 29 May 2013 04:07 AM, Sylwester Nawrocki wrote: >> > On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: >>> >> The PHY framework provides a set of APIs for the PHY drivers to >>> >

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-05-28 Thread Sylwester Nawrocki
Hi Kishon, On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY

Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-15 Thread Sylwester Nawrocki
On 04/15/2013 12:36 PM, Kishon Vijay Abraham I wrote: > On Monday 15 April 2013 03:50 PM, Grant Likely wrote: >> On Wed, 20 Mar 2013 14:41:59 +0530, Kishon Vijay Abraham I >> wrote: >>> Added a generic PHY framework that provides a set of APIs for the PHY >>> drivers >>> to create/destroy a PHY a

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-04 Thread Sylwester Nawrocki
Hi, On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote: > On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote: >> On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote: >>> +4. Getting a reference to the PHY >>> + >>> +Before the controller can

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Sylwester Nawrocki
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-bindings.txt @@ -0,0 +1,67 @@ +This document explains only the dt data binding. For general information about s/dt data/device tree ? +PHY subsystem refer Documentation/phy.txt

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Sylwester Nawrocki
On 04/02/2013 12:38 AM, Stephen Warren wrote: On 04/01/2013 04:27 PM, Sylwester Nawrocki wrote: On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: diff --git a/Documentation/devicetree/bindings/phy/phy-bindings.txt +example2: +phys: phy { +compatible = "xxx"

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-01 Thread Sylwester Nawrocki
On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: diff --git a/Documentation/devicetree/bindings/phy/phy-bindings.txt b/Documentation/devicetree/bindings/phy/phy-bindings.txt new file mode 100644 index 000..35696b2 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-bindings.txt

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-01 Thread Sylwester Nawrocki
Just couple minor comments... On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY wit

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-03-20 Thread Sylwester Nawrocki
Hi Kishon, On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without using phandle,

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Sylwester Nawrocki
Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: > - { .compatible = "samsung,exynos-dwc3" }, > + { .compatible = "samsung,synopsis-dwc3" } You're both missing a point here. The synopsys IP driver is called dwc3.ko and that's compatible with synopsys,dwc3. Your glue l

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Sylwester Nawrocki
On 01/22/2013 06:35 AM, Kukjin Kim wrote: > - { .compatible = "samsung,exynos-dwc3" }, > + { .compatible = "samsung,synopsis-dwc3" }, > > Or if any version or something, how about following? > > + { .compatible = "samsung,dwc-v3" }, > >>> Well, yes the newer

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-11 Thread Sylwester Nawrocki
On 01/11/2013 09:08 AM, Vivek Gautam wrote: > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam Thanks for addressing my all comments, Reviewed-by: Sylwester Nawrocki -- To unsubscri

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-09 Thread Sylwester Nawrocki
Hi, On 12/28/2012 10:13 AM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam ... --- a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt +++ b/Documentation/devicetree/bindings

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Sylwester Nawrocki
Hi, On 12/26/2012 02:56 PM, Vivek Gautam wrote: On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- Hope these changes align with what architectura

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-26 Thread Sylwester Nawrocki
On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug Anderson Well, I have another idea. Yes, I know, specific chip name should be used. But you know the specific chip name in compatible can cause another confusion on other SoC w

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Sylwester Nawrocki
On 12/26/2012 01:28 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 31 drivers/usb/phy/samsung-usbphy.c

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-19 Thread Sylwester Nawrocki
Hi, On 12/19/2012 02:44 PM, Vivek Gautam wrote: --- a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt +++ b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt @@ -9,3 +9,15 @@ Required properties: - compatible : should be "samsung,exynos4210-usbphy" - reg : base physical add

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

2012-12-18 Thread Sylwester Nawrocki
On 12/18/2012 04:39 PM, Vivek Gautam wrote: Adding base address information required for enabling USB 3.0 DRD phy on exynos5250 SOC. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/e

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-18 Thread Sylwester Nawrocki
Hi Vivek, On 12/18/2012 02:56 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- Changes from v1: - Changed the name of property for phy handler from'samsung,usb-phyctrl' t

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Sylwester Nawrocki
On 11/07/2012 02:35 PM, Vivek Gautam wrote: @@ -180,10 +273,12 @@ enum samsung_cpu_type { /* * struct samsung_usbphy - transceiver driver state * @phy: transceiver structure + * @phy3: transceiver structure for USB 3.0 * @plat: platform data * @dev: The parent device supplied t

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

2012-11-07 Thread Sylwester Nawrocki
Hi Vivek, On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding base address information and required platform data support for enabling USB DRD phy on exynos5250 SOC. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi|3 ++- arch/arm/mach-exynos/include/mach/regs

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Sylwester Nawrocki
Hi, I have a few comments. Please see below... On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. exynso -> exynos Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usbphy.c| 337 +++