Re: implement put_char() in cdc-acm

2015-11-03 Thread Sven Brauch
On 03/11/15 09:58, Oliver Neukum wrote: > Basically > your device is special by doing implied flow control > when the host stops requesting data. Hmm, ok, interesting. But isn't that what always happens for USB bulk transfers, which is always the transport layer for the driver in question? Regards

Re: implement put_char() in cdc-acm

2015-11-02 Thread Sven Brauch
On 02/11/15 12:32, Oliver Neukum wrote: > given this test I will submit the patch. Mind you, I don't know if the improvement is due to your patch or other things. I didn't test the new kernel without your patch; should I? > Sven, can you ramp up the buffers in the manner Peter suggested > and rete

Re: implement put_char() in cdc-acm

2015-11-01 Thread Sven Brauch
On 01/11/15 20:59, Peter Hurley wrote: > Just the kernel .config of the host please. > > Regards, > Peter Hurley See attached. config.gz Description: application/gzip signature.asc Description: OpenPGP digital signature

Re: implement put_char() in cdc-acm

2015-11-01 Thread Sven Brauch
Hey, On 28/10/15 13:33, Oliver Neukum wrote: >> Sven, please test Oliver's patch on that tree. > It can be found at > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/tty/ I finally got around to test this; sorry for the delay. I cloned that tree (git describe said v4.3-rc5), and

Re: implement put_char() in cdc-acm

2015-10-28 Thread Sven Brauch
Hey, On 28/10/15 13:23, Peter Hurley wrote: > Sven, please test Oliver's patch on that tree. I will do as soon as I get around to it, I hope on the weekend. > Lastly, please confirm your test method/termios settings (iow, are > you using a reproducer or just 'cat big_file > /dev/ttyACM1') Sorry,

Re: implement put_char() in cdc-acm

2015-10-27 Thread Sven Brauch
Hey Oliver, On 27/10/15 16:07, Oliver Neukum wrote: > the theory that the lack of support for put_char() is a > major contributor to character loss in cdc-acm can be tested. > Sven, could you test the attached patch? It implements > the support. Thanks a lot for caring about this. I applied the pa

Re: [PATCH] Fix data loss in cdc-acm

2015-07-22 Thread Sven Brauch
Hi, On 23/07/15 00:12, Peter Hurley wrote: > The premature unthrottle actually leads to the data loss but the throttling > with a mere 2K left is _way too late_. Ok, yes, I think so too. > 10ms is a _really_ long time for a cpu not to attend to a kworker. > Which raises 2 questions: > 1. What are

Re: [PATCH] Fix data loss in cdc-acm

2015-07-21 Thread Sven Brauch
Hey, On 22/07/15 01:34, Peter Hurley wrote: > I'd like to see that data, if you can, which will help me understand > at least the timing. Sure, please see below for the code which produced the output and the actual output. Let me know if you need anything else. This was run with the unmodified ver

Re: [PATCH] Fix data loss in cdc-acm

2015-07-21 Thread Sven Brauch
Hi, Thank you for your comments. On 21/07/15 15:43, Oliver Neukum wrote: > But others won't and we'd preserve stale data in preference over fresh > data. If that is important for your device, you should be using an isochronous endpoint, not bulk, no? Also note that the driver currently does this

Re: [PATCH] Fix data loss in cdc-acm

2015-07-20 Thread Sven Brauch
On 20/07/15 19:25, Johan Hovold wrote: > What kernel version are you using? I'm using linux 4.1.2. > The idea of adding another layer of buffering in the cdc-acm driver has > been suggested in the past but was rejected (or at least questioned). > See for example this thread: > > https://lkm