Adding Mathias Nyman (new USB 3.0 maintainer) and the USB mailing list.
On Tue, Jul 21, 2015 at 11:21:18PM +0200, Martin MOKREJŠ wrote:
> Hi Sarah and Alan,
> I bought a new toy: 13port USB 3.0 HUB based on VIAlabs 812 chipset with
> two power-only charging ports: 1x1.5A and 1x2.4A (AUKEY CB-H1
the new maintainer, Mathias Nyman.
Sarah Sharp
> [1.] One line summary of the problem:
>
> Excessive CPU load when USB 3.0 hub with VIA VL812-B2 chipset is
> plugged into port served by internal (root) USB 3.0 hub
>
>
> [2.] Full description of the problem/report:
>
>
I'm no longer the USB 3.0 driver maintainer. Please work with Mathias
Nyman to fix this issue.
Sarah Sharp
On Fri, Oct 31, 2014 at 06:01:24PM +0300, parafin wrote:
> Hi,
>
> it was suggested to me that since you are the author of offending
> commit I should forward this email
l or it wouldn't resume from
> RAM but that was a black and white issue, the only real annoyance was
> the occasional xhci hang that requires rmmod xhci_hcd to recover from.
What do you mean by hang? Do other USB devices work under xhci (e.g.
mouse and keyboard) but the ethernet s
7;re on your own.
> Gary Cordelli
> Embedded Computer Engineer
> Mentor Computer Consulting LLC
> the embedded computer company
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrea,
I'm no longer the xHCI driver maintainer. Please work with Mathias, and
Cc the linux-usb mailing list.
Sarah Sharp
On Wed, Aug 20, 2014 at 04:12:49PM +0200, Andrea Arcangeli wrote:
> Hi Sarah,
>
> just a short followup on this. I still had 1gbps hangs with the
&g
d/blacklist-whatever.conf
That will at least stop the module from being loaded, but won't stop it
from being enumerated. I think there's a way for userspace to claim a
particular port so that the kernel doesn't even do enumeration, but I
can't remember the interface. Maybe Math
Adding Mathias Nyman. He is now the USB 3.0 maintainer.
Sarah Sharp
On Thu, Aug 14, 2014 at 11:46:33AM +0200, Hans de Goede wrote:
> Hi,
>
> On 08/14/2014 10:39 AM, Claudio Bizzarri wrote:
> > Ciao,
> >
> > thank you very much for replay, you are right: it'
mation. I known
> where the file is I will
> add the information then.
You may be looking at an older version of MAINTAINERS. Mathias has only
been marked as the maintainer since 3.15. Which kernel version are you
working on?
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e in from mainline, if no that's OK too.
I don't understand what the above sentence means. What commit message
are you referencing? What do you mean by "remove in from mainline"?
Try again?
Sarah Sharp
--
To unsubscribe from this list: send the line "unsub
ase direct people with xHCI issues to
Mathias Nyman, so that he's aware of any problems with the xHCI driver?
Thanks,
Sarah Sharp
On Tue, Jul 22, 2014 at 04:08:01PM +0200, Marek Uher wrote:
>
>
> Hi David,
>
> that's not good news. I have three same computers with ASMedia
I'm no longer the USB 3.0 maintainer. Please contact Mathias Nyman and
the Linux USB mailing list for help. They are on Cc.
Thanks,
Sarah Sharp
On Tue, Jun 24, 2014 at 11:14:50AM +0200, Carsten Koepp wrote:
> Hi Sarah,
>
> from what I've found on the internet your are th
Script is attached now.
Sarah
On Wed, Apr 30, 2014 at 04:04:24PM -0700, Sarah Sharp wrote:
> Hi Mathias,
>
> I tested both this patch and your global command queue patches on top of
> your for-usb-linus branch. After reverting commit 400362f1d8dc "ALSA:
> usb-audio:
s expected.
In short, I think it's fine to merge Julius' patch to usb-linus and your
command queue patches to usb-next.
Sarah Sharp
[1] https://lkml.org/lkml/2014/4/19/117
On Tue, Apr 29, 2014 at 10:38:17AM -0700, Julius Werner wrote:
> The current XHCI driver recalculates the Conte
to the longer version. (I've
deliberately misspelled it here, so it doesn't get expanded.) Sometimes
it takes a couple of round of `git blame` to figure out when the bug was
introduced.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 23, 2014 at 08:16:49AM +0800, Gavin Guo wrote:
> Hi Sarah,
>
>
> On Wed, Apr 23, 2014 at 7:57 AM, Sarah Sharp
> wrote:
> >
> > [Adding Mathias, who is the xHCI driver maintainer as of 3.15.]
> >
> > On Wed, Apr 23, 2014 at 07:23:43AM
s a new
slot ID, but it calls the function I added debugging to. A device may
also not get enumerated if it fails to respond to a Set Address control
transfer, but that code path already has some nicer printks already.
Sarah Sharp
p.s. You might want to try to remove your footer when communi
not be relevant to kernel development at this point,
> so I’ll take my ranting elsewhere.
I completely understand your frustration, and it actually is relevant to
kernel development. :) Perhaps the attached patch would have at lea
not be relevant to kernel development at this point,
> so I’ll take my ranting elsewhere.
I completely understand your frustration, and it actually is relevant to
kernel development. :) Perhaps the attached patch would have at lea
all the
internal resources to support that.
Can you unload and reload the module with dynamic debugging enabled, and
look for output in dmesg like:
// xHC can handle at most %d device slots.
There's an xHCI capabilities register that gets printed which contains
the maximum number of device
ently set in add_flags throughout
> the lifetime of a device. This means that when all endpoints are
> dropped, the Context Entries field can be set to 0 (which is invalid and
> may cause a Parameter Error) or -1 (which is interpreted as 31 and
> causes the driver to keep using the
g and replug in the device.
Mathias (xHCI maintainer) has plans to implement a fix for this,
but it will probably not land until 3.16 or later.
I suggest you remove any unconditional ClearHalt requests from your
userspace program in the mean time.
Sarah Sharp
> I have tested in following kerne
Cc'ing Mathias Nyman, who is taking over as xHCI driver maintainer.
On Sun, Mar 23, 2014 at 07:16:03PM +0100, baum...@hotmail.com wrote:
> Hello,
>
> I have problems with my USB 3.0 devices; external HDDs (HGST Touro Mobile Pro
> (Simpletech-Chip), Fantec case with WDC, Asmedia Chip) and a Sandi
nk PM at all.
Can you blacklist the usb-storage driver, and then send the output of
`sudo lsusb -v` with the USB 3.0 device plugged in?
Sarah Sharp
>
> Regards,
> Abhay Kumar
>
>
>
> On Sun, Mar 23, 2014 at 9:48 AM, Sarah Sharp
> wrote:
>
> > Cc-ing Mathias N
Cc-ing Mathias Nyman, who is taking over as xHCI maintainer.
On Sat, Mar 22, 2014 at 01:46:00AM +, Abhay Kumar wrote:
>
> Hi,
>
> In my linux kernel USB 3.0 pendrive is not getting detected some time.For
> the same usb port usb2.0 works perfectly.
>
> Here is the error message i am gettin
Cc-ing Mathias Nyman, who is taking over as xHCI maintainer.
On Fri, Mar 21, 2014 at 11:22:07AM +0800, Rick Chen wrote:
> Hi Sarah,
>
> I use linux 3.13.6 to test Logitech C310 web cam but encounter the
> following message and usb controller is disabled and all usb device freeze.
>
> [51237.0450
ices simply NAK the request to go into U1 or U2. You
have to use a bus analyzer and be sure you're actually going into low
power states when you're testing the dw3 code. There are a few devices
out there that support USB 3.0 LPM (Western Digital My Passport, for
example).
Sarah Sharp
--
ll the fishes!
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=eb44da0b3aa0105cb38d81c5747a8feae64834be
Sarah Sharp (1):
xhci: Transition maintainership to Mathias Nyman.
MAINTAINERS |2 +-
1 files changed, 1 insertions(+),
change with some software
engineering to communicate the speed increase to the device drivers, add
new device descriptor parsing to lsusb, but definitely nothing as big as
USB 3.0 was.
Signed-off-by: Sarah Sharp
Signed-off-by: Mathias Nyman
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1
On Thu, Mar 20, 2014 at 02:52:25PM -0700, Greg KH wrote:
> On Thu, Mar 20, 2014 at 02:33:33PM -0700, Sarah Sharp wrote:
> > Ok, so it looks like Alan finally acked all the port power off patches.
> >
> > Greg, how are you feeling about taking these for 3.15? I hear that
you. Either way, I'll compile a kernel with these patches
for my non-Intel host machine (NEC 0.96 host) and make sure they don't
break anything.
Sarah Sharp
On Thu, Mar 20, 2014 at 09:21:56AM -0700, Dan Williams wrote:
> On Thu, 2014-03-20 at 11:58 -0400, Alan Stern wrote:
vice. Exposing a file to play
with those settings may be interesting.
I'll let you handle triaging the xHCI bug reports, but please let me
know if you get stuck.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
n this fix, but wanted to address some issues in
the global command queue patches before starting on this task. Mathias
is taking over as xHCI maintainer after 3.15, so he can better provide a
timeline for when it will get fixed.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsub
; I don't know if this is the right list to ask , if so, hope this help you
> to find a fix.
This is a known issue. We have it tracked in our bug tracker, and
Mathias is working on a fix on top of the global command queue patches
to address this issue. Mathias will contact you when he gets a
hose words. Same with Acked-by lines.
Sarah Sharp
On Wed, Mar 12, 2014 at 11:16:24AM +0400, Igor Gnatenko wrote:
> After suspend another Renesas PCI-X USB 3.0 card doesn't work.
> [root@fedora-20 ~]# lspci -vmnnd 1912:
> Device: 03:00.0
> Class:USB controller [0c
n a USB hard drive device, suspend the laptop,
resume it, and the movie will continue playing. With this quirk, the
storage device will re-enumerated as a new block device, and the movie
will stop playing on resume.
So, I would like to limit the impact of this quirk as much as possible.
I wish I h
On Tue, Feb 11, 2014 at 06:11:09PM +0100, Andreas Cadhalpun wrote:
> Hi,
>
> thanks for looking into the issue.
>
> On 11.02.2014 17:40, Sarah Sharp wrote:
> >On Sat, Feb 08, 2014 at 03:56:31AM +, Ben Hutchings wrote:
> >>For the benefit of other developers, tha
Nec XHCI controller, it seems the Nec
writes the ptr to both the ep and stream contexts when streams are used.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 22 +++---
drivers/usb/host/xhci.h | 1 +
2 files changed, 16 insertions(+
ls around the radix tree insert, since we
can now insert entries in interrupt context. There are now two helper
functions to make the code cleaner, and those functions are moved to
make them static.]
Signed-off-by: Gerd Hoffmann
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
dri
right, but we
cannot trust userspace to get this right, so enforce it by killing any
urbs still pending on the interface.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/devio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/devio.c b
From: Hans de Goede
So that it can be used in other places too.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/config.c | 1 -
include/linux/usb.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index d966b59f7d7b..fc08ee919439 100644
--- a
From: Hans de Goede
This is a preparation patch for adding support for bulk streams to usbfs.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/hcd.c | 34 ++
include/linux/usb.h| 2 ++
2 files changed, 28 insertions(+), 8
: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-mem.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 39f9a99a503b..be7b7b6b5517 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index
From: Hans de Goede
This is a preparation patch for adding support for bulk streams.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/devio.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb
he first device that
doesn't support LPM, to avoid log spam. Further, cleanup some
unnecessary line breaks to help people to grep for the error messages.
Signed-off-by: Sarah Sharp
Cc: Alan Stern
---
drivers/usb/core/hub.c | 24
drivers/usb/host/xhci-hub.c |
old apps which may have
garbage in there (as it was unused until now in the bulk case), will not
break
2) This patch does not add support for allocating / freeing bulk-streams, that
is done in a follow up patch
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core
From: Hans de Goede
- Rename labels to properly reflect this
- Don't skip free-ing the streams when scsi_init_shared_tag_map fails
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 18 +-
1 file changed, 9 insertions(+), 9 dele
From: Hans de Goede
The loop uses up to 3 bytes of the endpoint extra data.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index
From: Gerd Hoffmann
xhci streams support is fixed, unblock usb attached scsi.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/Kconfig
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 3ec1d8fe06fa..51c5109bbefc 100644
From: Hans de Goede
The iu struct definitions are usb packet definitions, so no alignment should
happen. Notice that assuming 32 bit alignment this does not make any
difference at all.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
include/linux/usb/uas.h | 10 +-
1 file
not necessary.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 046eedfc3828..059ce62de4b0 100644
--- a
From: Hans de Goede
For USB-2 connections the stream-id must always be 0.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index
From: Hans de Goede
If we get ie 16 streams we can use stream-id 1-16, not 1-15.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage
app is done using streams it should call USBDEVFS_FREE_STREAMS
Note applications are advised to use libusb rather then using the
usbdevfs api directly. The latest version of libusb has support for streams.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/devio.c
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index fceffccc1be1..6ec48c2daf45 100644
From: Hans de Goede
Fix the uas_eh_bus_reset_handler not properly taking the usbdev lock
before calling usb_device_reset, the usb-core expects this lock to be
taken when usb_device_reset is called.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 9
ted with a non-zero stream_id would never get killed. Fix this.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 58cbc06ec
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 754468bbbfdc..d758faef8664 100644
From: Hans de Goede
Copy the sg alignment trick from the usb-storage driver, without this I'm
seeing intermittent errors when using uas devices with an ehci controller.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 18 ++
1
te this error in the response iu struct
definition because the additional response info field is normally filled
with zeros, and 0 is the response code value for success.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
include/linux/usb/uas.h | 2 +-
1 file changed, 1 insertion(+), 1 dele
From: Hans de Goede
Falling back from uas to usb-storage requires coordination between uas and
usb-storage, so use usb-storage's quirks module parameter, rather then
requiring the user to pass a param to 2 different modules.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
dr
From: Hans de Goede
uas_alloc_data_urb always gets called with a stream_id value of 0 when not
using streams. Removing the check makes it consistent with uas_alloc_sense_urb.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 3 +--
1 file changed, 1
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/hcd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 2518c3250750..9b445f43f825 100644
--- a/drivers/usb/core/hcd.c
From: Hans de Goede
The ss_ep_comp bmAttributes filed can contain more info then just the
streams, use usb_ss_max_streams to properly get max streams.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
ehci code this causes usb_submit_urb failure.
With this fixed the uas code works nicely with an uas device plugged into
an ehci port.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dr
USB 3.0 root
hub would get marked as being able to support streams.]
Signed-off-by: Oliver Neukum
Signed-off-by: Sarah Sharp
Acked-by: Hans de Goede
---
drivers/usb/host/xhci-pci.c | 3 +++
drivers/usb/host/xhci-plat.c | 3 +++
drivers/usb/storage/uas-detect.h | 4
include/linux
From: Hans de Goede
This is a preparation patch for teaching usb-storage to not bind to
uas devices.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas-detect.h | 40
drivers/usb/storage/uas.c| 40
-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 8c685801e267..d81d041842f4 100644
--- a/drivers/usb/storage
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas-detect.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
index 8de030a0a4a4
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/devio.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index d7571a63181d..502974b4deb5 100644
--- a
igned-off-by: Mathias Nyman
Acked-by: Dan Williams
Acked-by: Alan Stern
Signed-off-by: Sarah Sharp
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-pci.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
cond list.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 106 +++---
1 file changed, 44 insertions(+), 62 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage
sable streams for endpoint
0x81
, streams are already disabled!
[ 96.982400] xhci_hcd :01:00.0: WARN xhci_free_streams() called with
non-streams endpoint
But it is better to also warn about the actual cause of this later warnings.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah
-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 7a16ed8e8aac..019f2030ea0c 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
From: Hans de Goede
Since we use a fixed tag / stream for tasks we cannot allow more then one
to run at the same time. This could happen before this time if a task timed
out.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 39
at it.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 70
1 file changed, 39 insertions(+), 31 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index b3d27e6467ea..58cbc06ecdf9 100644
--- a/drivers/usb/host
error handling cmd
completes, corrupting the kernel heap.
Clearing cmdinfo on command queue-ing fixes this, and seems like a good idea
in general.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
ch is something to avoid if possible
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 08e9710f193d..a7ac97cc5949 100644
--- a/drivers/usb/stor
xhci_mem_cleanup if the controller resume fails.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index edfb31ad5949..60fc6720007f 100644
check in usb_alloc_streams().
Note normally streams still being allocated at reset / set-intf would be a
driver bug, but this can happen without it being a driver bug on reset-resume.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/core/hub.c | 5 -
drivers/usb/core/m
From: Hans de Goede
Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when
this happens, disable cmd queuing during the reset, and wait for existing
requests to finish in pre_reset.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 2 +-
include/linux/usb/uas.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 0ee5a05c0a7b
From: Hans de Goede
cmds are either on the inflight list or on the dead list, never both, so
we only need one list head.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 6cb9c2235a0b..1db3c2794a49 100644
--- a/drivers/usb/host/xhci.c
+++ b
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 60 ---
1 file changed, 46 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index
:104 IR-IO-APIC-fasteoi ehci_hcd:usb1, ehci_hcd:usb2
19:473 IR-IO-APIC-fasteoi xhci_hcd:usb3
Tested on v3.14-rc4.
Signed-off-by: Adrian Huang
Reviewed-by: Nagananda Chumbalkar
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c | 4
1 file changed, 4
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index cfe0102fcbae..8c685801e267 100644
--- a
From: Hans de Goede
At the kernel-summit Sarah Sharp asked me if I was willing to become the
uas maintainer. I said yes, and here is a patch to make this official.
Also remove Matthew Wilcox and Sarah Sharp as maintainers at their request.
I've also added myself to the module's auth
From: Hans de Goede
This is a preparation patch for adding better descriptor validation.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index f09205b162e4..62086829af14 100644
--- a/drivers/usb/storage
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 1a188399e090
et or disconnect.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 41 +
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index e06505c8f6f0..1a18839
gs in xhci_ring_expansion when
the ring is a stream ring.
Signed-off-by: Sarah Sharp
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-mem.c | 107 +---
1 file changed, 81 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/host
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 42 ++
1 file changed, 42 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 8023944f2501..7a16ed8e8aac
From: Hans de Goede
No changes, just the move.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas-detect.h | 27 +++
drivers/usb/storage/uas.c| 27 ---
2 files changed, 27 insertions(+), 27 deletions
).
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas-detect.h | 11 +
drivers/usb/storage/uas.c | 17 ++---
drivers/usb/storage/unusual_uas.h | 52 +++
include/linux/usb_usual.h | 6 +++--
4 files
From: Hans de Goede
The fixed endpoint config code was only necessary to deal with an early
uas prototype which has never been released, so lets drop it and enforce
proper uas endpoint descriptors.
Signed-off-by: Hans de Goede
Signed-off-by: Sarah Sharp
---
drivers/usb/storage/uas.c | 36
1 - 100 of 1456 matches
Mail list logo