Re: [PATCH v2] xhci: workaround CSS timeout on AMD SNPS 3.0 xHC

2018-11-23 Thread Sandeep Singh
Hi Kai-heng, On 11/23/2018 2:59 PM, Kai Heng Feng wrote: > Hi Sandeep, > >> On Nov 22, 2018, at 12:23 PM, Singh, Sandeep wrote: >> >> From: Sandeep Singh >> >> Occasionally AMD SNPS 3.0 xHC does not respond to >> CSS when set, also it does not fl

Re: [PATCH] xhci: workaround CSS timeout on AMD SNPS 3.0 xHC.

2018-11-20 Thread Sandeep Singh
Hi Kai-heng, On 11/16/2018 2:05 PM, Kai Heng Feng wrote: > Hi Sandeep, > >> On Nov 16, 2018, at 16:21, Singh, Sandeep wrote: >> >> From: Sandeep Singh >> >> Occasionally AMD SNPS 3.0 xHC does not respond to >> CSS when set, also it does not flag anythi

Re: [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.

2018-09-25 Thread Sandeep Singh
On 9/24/2018 6:39 PM, Mathias Nyman wrote: > On 21.09.2018 16:22, Sandeep Singh wrote: >> From: Sandeep Singh >> >> Observed "TRB completion code (27)" error which corresponds to Stopped - >> Length Invalid error(xhci spec section 4.17.4) while connecti

[PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.

2018-09-21 Thread Sandeep Singh
From: Sandeep Singh Observed "TRB completion code (27)" error which corresponds to Stopped - Length Invalid error(xhci spec section 4.17.4) while connecting USB to SATA bridge. Looks like this case was not considered when the following patch[1] was committed. Hence adding this new c

[PATCH] usb:xhci:Fix regression when ATI chipsets detected

2017-08-23 Thread Sandeep Singh
From: Sandeep Singh The following commit cause a regression on ATI chipsets. 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume")' This causes pinfo->smbus_dev to be wrongly set to NULL on systems with the ATI chipset that t

[PATCH] usb:xhci:Fix regression when ATI chipsets detected

2017-08-23 Thread Sandeep Singh
From: Sandeep Singh The following commit cause a regression on ATI chipsets. 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume")' This causes pinfo->smbus_dev to be wrongly set to NULL on systems with the ATI chipset that t

Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-09 Thread Sandeep Singh
On 8/4/2017 4:44 PM, Felipe Balbi wrote: > > Hi, > > Sandeep Singh writes: >> From: Sandeep Singh >> >> Certain HP keyboards would keep inputting a character automatically which >> is the wake-up key after S3 resume >> >> On some AMD platform

[PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-04 Thread Sandeep Singh
From: Sandeep Singh Certain HP keyboards would keep inputting a character automatically which is the wake-up key after S3 resume On some AMD platforms USB host fails to respond (by holding resume-K) to USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures that resume is

Re: [PATCH v2] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-04 Thread Sandeep Singh
On 8/4/2017 1:21 PM, Felipe Balbi wrote: > > Hi, > > Sandeep Singh writes: >>>>> Sandeep Singh writes: >>>>>> @@ -260,11 +266,12 @@ int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev >>>>>> *pdev) >>>>>&

Re: [PATCH v2] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-03 Thread Sandeep Singh
>>> Sandeep Singh writes: >>>> @@ -260,11 +266,12 @@ int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev >>>> *pdev) >>>> { >>>>/* Make sure amd chipset type has already been initialized */ >>>>usb_amd_find_chips

Re: [PATCH v2] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-03 Thread Sandeep Singh
On 8/3/2017 1:28 PM, Felipe Balbi wrote: > > Hi, > > Sandeep Singh writes: >> @@ -260,11 +266,12 @@ int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev >> *pdev) >> { >> /* Make sure amd chipset type has already been initialized */ >>

Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-08-02 Thread Sandeep Singh
r my reply? > > > http://daringfireball.net/2007/07/on_top > > > On Mon, Jul 31, 2017 at 12:10:08PM +0530, Sandeep Singh wrote: >> Hi Greg, >> >> Thanks for review. Apart from pci_ids.h, I see only 3 options, add this id >> as macro in pci_quirks.c >

[PATCH v2] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-02 Thread Sandeep Singh
From: Sandeep Singh Certain HP keyboards would keep inputting a character automatically which is the wake-up key after S3 resume On some AMD platforms USB host fails to respond (by holding resume-K) to USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures that resume is

Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-30 Thread Sandeep Singh
9PM +0530, Sandeep Singh wrote: >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index c71e532..d3f2296 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -583,6 +583,7 @@ >> #define PCI_DEVICE_ID_AMD_HUDSO

[PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-27 Thread Sandeep Singh
From: Sandeep Singh Certain HP keyboards would keep inputting a character automatically which is the wake-up key after S3 resume On some AMD platforms USB host fails to respond (by holding resume-K) to USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures that resume is