Re: [PATCH] usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

2017-06-27 Thread Sören Brinkmann
ustavo A. R. Silva Reviewed-by: Sören Brinkmann Sören -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: gadget: udc-xilinx: clean up a variable name

2017-04-27 Thread Sören Brinkmann
On Thu, 2017-04-27 at 12:11:18 +0300, Dan Carpenter wrote: > "ep->udc->lock" and "udc->lock" are the same thing. It confuses Smatch > if we don't use the same name consistently. > > Signed-off-by: Dan Carpenter Reviewed-by: Sören Brinkmann

Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing.

2016-09-01 Thread Sören Brinkmann
On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for v4: > -Used boolen pro

Re: [PATCH] usb: gadget: xilinx: fix devm_ioremap_resource() check

2015-03-29 Thread Sören Brinkmann
On Sun, 2015-03-29 at 05:43AM +0300, Vladimir Zapolskiy wrote: > devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never > returns NULL, fix the check to prevent access to invalid > virtual address. > > Signed-off-by: Vladimir Zapolskiy Reviewed-by: Sören Brinkmann

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Sören Brinkmann
On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: > All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional > and not prevent the driver from working. Fix the regression in the > behavior introduced by commit "usb: phy: generic: migrate to gpio_desc". > > At the same time,

Re: [PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-27 Thread Sören Brinkmann
On Fri, 2015-01-16 at 12:14PM +0100, Robert Jarzmik wrote: > Paul Zimmerman writes: > > > From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 > > From: Paul Zimmerman > > Date: Wed, 14 Jan 2015 18:15:58 -0800 > > Subject: [PATCH] usb: phy: make GPIOs optional for the generic p

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Sören Brinkmann
On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote: > On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: > > A reset through a GPIO is optional. Don't fail probing when it is > > missing. > > > > Reported-by: Andreas Färber > > Signed-off-by: Soren Brinkmann > > --- > > Hi And

Re: [PATCH v3] ARM: zynq: DT: Add USB to device tree

2015-01-26 Thread Sören Brinkmann
On Tue, 2015-01-27 at 02:14AM +0100, Andreas Färber wrote: > + linux-gpio, linux-usb, Felipe Balbi > > Am 26.01.2015 um 19:44 schrieb Sören Brinkmann: > > On Mon, 2015-01-26 at 08:23AM -0800, Sören Brinkmann wrote: > >> On Mon, 2015-01-26 at 05:21PM +0100, Andrea

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Sören Brinkmann
On Tue, 2014-09-23 at 12:28PM +0200, Antoine Tenart wrote: > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > and DMA mask, to support USB2 ChipIdea controllers that don't need > specific functions. > > Tested on the Marvell Berlin SoCs USB controllers. > > Signed-off-by: Antoin