Re: usb zero copy dma handling

On Thu, Aug 08, 2019 at 09:10:15AM -0700, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 10:46:36AM +0200, yvahkhfo.1df7f...@hashmail.org > wrote: > > --- a/drivers/usb/core/devio.c > > +++ b/drivers/usb/core/devio.c > > @@ -238,9 +238,14 @@ static int usbdev_mmap(struct file *file, struct >

Re: usb zero copy dma handling

On Thu, Aug 08, 2019 at 10:58:11AM +0200, Greg KH wrote: > But the main issue here is what exactly is this "fixing"? What is wrong > with the existing code that non-x86 systems have such a problem with? > Shouldn't all of these dma issues be handled by the platform with the > remap_pfn_range() cal

Re: [PATCH 00/14] ARM: move lpc32xx and dove to multiplatform

On Wed, Jul 31, 2019 at 09:56:42PM +0200, Arnd Bergmann wrote: > For dove, the patches are basically what I had proposed back in > 2015 when all other ARMv6/ARMv7 machines became part of a single > kernel build. I don't know what the state is mach-dove support is, > compared to the DT based support

Re: [PATCH] usb: ohci-sa1111: convert shutdown method to native device_driver

On Tue, Sep 26, 2017 at 11:35:32AM -0400, Alan Stern wrote: > On Tue, 26 Sep 2017, Russell King - ARM Linux wrote: > > > On Tue, Sep 26, 2017 at 10:35:23AM -0400, Alan Stern wrote: > > > On Tue, 26 Sep 2017, Russell King wrote: > > > > Convert the shutdown method

Re: [PATCH] usb: ohci-sa1111: convert shutdown method to native device_driver

On Tue, Sep 26, 2017 at 10:35:23AM -0400, Alan Stern wrote: > On Tue, 26 Sep 2017, Russell King wrote: > > Convert the shutdown method to use the device_driver shutdown function > > pointer rather than a private bus-type shutdown. This is the only user > > for SA bus

[PATCH] usb: ohci-sa1111: remove special sa1111 mmio accessors

Remove the special SA MMIO accessors from the ohci-sa driver as their definition will be removed shortly. The SA accessors are barrierless, so use the _relaxed variants. Signed-off-by: Russell King --- drivers/usb/host/ohci-sa.c | 10 +- 1 file changed, 5 insertions

[PATCH] usb: ohci-sa1111: convert shutdown method to native device_driver

Convert the shutdown method to use the device_driver shutdown function pointer rather than a private bus-type shutdown. This is the only user for SA bus types, so having the support code in the bus doesn't make any sense. Signed-off-by: Russell King --- drivers/usb/host/ohci-sa.

[PATCH] usb: ohci-sa1111: use sa1111_get_irq() to obtain IRQ resources

Use the provided sa_get_irq() to fetch the IRQ resources for the SA OHCI driver. Signed-off-by: Russell King --- drivers/usb/host/ohci-sa.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-sa.c b/drivers/usb/host/ohci-sa.c

[PATCH net-next 7/7] net: phy: clean up mmd_phy_indirect()

get rid of unnecessary parens. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index 80

[PATCH net-next 6/7] net: phy: remove the indirect MMD read/write methods

Remove the indirect MMD read/write methods which are now no longer necessary. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 119 + include/linux/phy.h| 42

[PATCH net-next 4/7] net: phy: switch remaining users to phy_(read|write)_mmd()

Switch everyone over to using phy_read_mmd() and phy_write_mmd() now that they are able to handle both Clause 22 indirect addressing and Clause 45 direct addressing methods to the MMD registers. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net

[PATCH net-next 1/7] net: phy: move phy MMD accessors to phy-core.c

ndrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/Makefile | 2 +- drivers/net/phy/phy-core.c | 135 + drivers/net/phy/phy.c | 85 include/linux/phy.h| 20 +-- 4

[PATCH net-next 3/7] net: lan78xx: update for phy_(read|write)_mmd_indirect() removal

instead. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Acked-by: Woojung Huh Signed-off-by: Russell King --- drivers/net/usb/lan78xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 9889a70ff4f6

[PATCH net-next 5/7] net: phy: convert micrel to new read_mmd/write_mmd driver methods

Convert micrel to the new read_mmd/write_mmd driver methods. This Clause 22 PHY does not support any MMD access method. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/micrel.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[PATCH net-next 0/7] Clean up PHY MMD accessors

This series cleans up phylib's MMD accessors, so that we have a common way of accessing the Clause 45 register set. The current situation is far from ideal - we have phy_(read|write)_mmd() which accesses Clause 45 registers over Clause 45 accesses, and we have phy_(read|write)_mmd_indirect(), whic

[PATCH net-next 2/7] net: phy: make phy_(read|write)_mmd() generic MMD accessors

Lunn Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 33 + include/linux/phy.h| 24 2 files changed, 49 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers

Re: [PATCH RFC 0/7] phylib MMD accessor cleanups

On Sun, Mar 19, 2017 at 03:30:38PM -0700, Florian Fainelli wrote: > Le 03/19/17 à 03:59, Russell King - ARM Linux a écrit : > > This series of patches does exactly that - we merge the functionality > > of the indirect accesses into the clause 45 accessors, and use these > >

[PATCH RFC 3/7] net: lan78xx: update for phy_(read|write)_mmd_indirect() removal

instead. Signed-off-by: Russell King --- drivers/net/usb/lan78xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 9889a70ff4f6..d885e0325422 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c

[PATCH RFC 0/7] phylib MMD accessor cleanups

Hi, This series cleans up the phylib MMD accessors. We have two accessors at present, phy_(read|write)_mmd() and phy_(read|write)_mmd_indirect() The _indirect methods access the MMD registers via a clause 22 phy, whereas the non-_indirect methods acess via clause 45 accesses. Current PHY-indepe

[PATCH 4.10-rc3 02/13] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King --- net/core/netprio_cgroup.c | 1 + 1 file

[PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function) drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaratio

[PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

nterface_t phy_interface; ^~~ Add linux/phy.h to macb.h Signed-off-by: Russell King --- drivers/net/ethernet/cadence/macb.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index d67adad67be1..383da8cf5f6d 10

[PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

27; has initializer but incomplete type drivers/net/ethernet/marvell/mvneta.c:2709:2: error: implicit declaration of function 'fixed_phy_update_state' [-Werror=implicit-function-declaration] Add linux/phy_fixed.h to mvneta.c Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mv

[PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

.h to svc_rdma_backchannel.c Signed-off-by: Russell King --- net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c index 288e35c2d8f4..cb1e48e54eb1 100644 --- a/ne

[PATCH 4.10-rc3 04/13] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

declaration drivers/net/usb/lan78xx.c:403:1: sparse: got } Add linux/phy.h to lan78xx.c Signed-off-by: Russell King --- drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 08f8703e4d54..9889a70ff4f6 100644 --- a

[PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King --- drivers/target/iscsi/iscsi_target_login.c | 1 + 1 file

[PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*()

odule build, become aliases to init_module(). Having more than one alias will cause a build error. Hence, rather than adding a linux/module.h include, remove the redundant MODULE_*() from this file. Acked-by: David Daney Signed-off-by: Russell King --- arch/mips/cavium-octeon/o

[PATCH 4.10-rc3 06/13] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 + 1 file changed, 1 insertio

[PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

as no type or storage class drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: error: type defaults to 'int' in declaration of 'module_init' drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: parameter names (without types) in function declaration drivers/net

[PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes

cable. Tested-by: Vivien Didelot Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 + include/net/dsa.h | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/driver

[PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

but not used [-Wunused-function] module_platform_driver(ath_ahb_driver); ^ include/linux/device.h:1459:19: note: in definition of macro 'module_driver' static int __init __driver##_init(void) \ ^~~~ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note

[PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSI

Re: [PATCH RFC 0/7] Clean up PHY MMD accessors

On Thu, Jan 19, 2017 at 11:42:47AM -0800, Florian Fainelli wrote: > On 01/13/2017 07:20 AM, Russell King - ARM Linux wrote: > > This series cleans up phylib's MMD accessors, so that we have a common > > way of accessing the Clause 45 register set. > > > > The cur

[PATCH RFC 0/7] Clean up PHY MMD accessors

This series cleans up phylib's MMD accessors, so that we have a common way of accessing the Clause 45 register set. The current situation is far from ideal - we have phy_(read|write)_mmd() which accesses Clause 45 registers over Clause 45 accesses, and we have phy_(read|write)_mmd_indirect(), whic

[PATCH RFC 5/7] net: phy: convert micrel to new read_mmd/write_mmd driver methods

Convert micrel to the new read_mmd/write_mmd driver methods. This Clause 22 PHY does not support any MMD access method. Signed-off-by: Russell King --- drivers/net/phy/micrel.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers

[PATCH RFC 6/7] net: phy: remove the indirect MMD read/write methods

Remove the indirect MMD read/write methods which are now no longer necessary. Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 119 + include/linux/phy.h| 18 --- 2 files changed, 35 insertions(+), 102 deletions(-) diff --git

[PATCH RFC 7/7] net: phy: clean up mmd_phy_indirect()

get rid of unnecessary parens. Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index 80795ccd3fab..357a4d0d7641 100644 --- a/drivers/net/phy/phy-co

[PATCH RFC 4/7] net: phy: switch remaining users to phy_(read|write)_mmd()

Switch everyone over to using phy_read_mmd() and phy_write_mmd() now that they are able to handle both Clause 22 indirect addressing and Clause 45 direct addressing methods to the MMD registers. Signed-off-by: Russell King --- drivers/net/phy/bcm-phy-lib.c | 12 drivers/net/phy

[PATCH RFC 1/7] net: phy: move phy MMD accessors to phy-core.c

Move the phy_(read|write)__mmd() helpers out of line, they will become our main MMD accessor functions, and so will be a little more complex. This complexity doesn't belong in an inline function. Also move the _indirect variants as well to keep like functionality together. Signed-off-by: Ru

[PATCH RFC 3/7] net: lan78xx: update for phy_(read|write)_mmd_indirect() removal

instead. Signed-off-by: Russell King --- drivers/net/usb/lan78xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 08f8703e4d54..5e222d47f212 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c

[PATCH RFC 2/7] net: phy: make phy_(read|write)_mmd() generic MMD accessors

: Russell King --- drivers/net/phy/phy-core.c | 31 +++ include/linux/phy.h| 24 2 files changed, 47 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index b8d8276a3099..b50b3a64cf6a 100644

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

On Wed, Sep 28, 2016 at 10:53:49AM +0300, Roger Quadros wrote: > Hi, > > On 12/09/16 14:38, Roger Quadros wrote: > > Hi Santosh & Russell, > > > > On 19/08/16 19:38, Santosh Shilimkar wrote: > >> > >> On 8/19/2016 12:30 AM, Roger Quadros wrote: > >>> Hi Santosh, > >>> > >> > > So I'm 99.9% co

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Wed, Sep 07, 2016 at 05:29:01PM +0800, Peter Chen wrote: > On Wed, Sep 07, 2016 at 10:52:46AM +0200, Arnd Bergmann wrote: > > On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote: > > > > > > The pre-condition of DT function at USB HCD core works is the host > > > controller device

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Fri, Sep 02, 2016 at 12:43:39PM +0200, Arnd Bergmann wrote: > On Thursday, September 1, 2016 5:14:28 PM CEST Leo Li wrote: > > > > Hi Felipe and Arnd, > > > > It has been a while since the last response to this discussion, but we > > haven't reached an agreement yet! Can we get to a conclusio

Re: [PATCH 1/2] usb: ohci-sa1111: remove machine_has_neponset()

On Fri, Aug 26, 2016 at 02:20:50PM -0400, Alan Stern wrote: > On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > > > On Fri, Aug 26, 2016 at 01:18:25PM -0400, Alan Stern wrote: > > > On Fri, 26 Aug 2016, Russell King wrote: > > > > > > > The ne

Re: [PATCH 1/2] usb: ohci-sa1111: remove machine_has_neponset()

On Fri, Aug 26, 2016 at 01:18:25PM -0400, Alan Stern wrote: > On Fri, 26 Aug 2016, Russell King wrote: > > > The neponset is a daughter board for the Assabet platform, which has a > > SA chip on it. If we're initialising the SA OHCI, and we're > > par

Re: [PATCH] USB: ohci-omap - avoid including mach/irqs.h

On Fri, Aug 26, 2016 at 01:20:53PM -0400, Alan Stern wrote: > On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > > > On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > > > On Fri, 19 Aug 2016, Russell King wrote: > > > > > > > ohc

Re: [PATCH] USB: ohci-omap - avoid including mach/irqs.h

On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > On Fri, 19 Aug 2016, Russell King wrote: > > > ohci-omap doesn't need to include mach/irqs.h - nothing within this > > driver needs anything from this header file. Remove this include. > > &g

[PATCH 2/2] usb: ohci-sa1111: remove mach/hardware.h include

The mach/hardware.h include doesn't seem to be necessary to build ohci-sa, so let's remove it to kill off an unnecessary platform specific include. Signed-off-by: Russell King --- drivers/usb/host/ohci-sa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/o

[PATCH 1/2] usb: ohci-sa1111: remove machine_has_neponset()

stead with machine_is_assabet(), and killing the mach/assabet.h include. Signed-off-by: Russell King --- drivers/usb/host/ohci-sa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-sa.c b/drivers/usb/host/ohci-sa.c index 2ac266d692a2..6dc5eaed8

[PATCH] USB: ohci-omap - avoid including mach/irqs.h

ohci-omap doesn't need to include mach/irqs.h - nothing within this driver needs anything from this header file. Remove this include. Signed-off-by: Russell King --- drivers/usb/host/ohci-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

On Thu, Aug 18, 2016 at 09:55:55AM -0700, Santosh Shilimkar wrote: > Hi Russell, > > On 8/18/2016 7:24 AM, Russell King - ARM Linux wrote: > >On Wed, Aug 17, 2016 at 03:05:17PM +0300, Roger Quadros wrote: > >>Since commit 6ce0d2001692 ("ARM: dma: Use d

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

nal change. The original commit doesn't mention which platform it was intended for or what the problem was, which would've been helpful. > > Fixes: 6ce0d2001692 ("ARM: dma: Use dma_pfn_offset for dma address > translation") > Cc: sta...@vger.kernel.org > Cc:

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Thu, Jul 21, 2016 at 05:20:12PM +0800, Peter Chen wrote: > On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote: > > On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote: > > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c &

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote: > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 69426e6..0d05812 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -914,6 +914,16 @@ static int ci_hdrc_probe(struct platfor

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: > >pointer and pass that in platform_data. This is really easy, it's > > Sorry but passing a struct device pointer in platform_data is > ridiculous. Not to mention that, as I said before, we can'

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

On Fri, Mar 18, 2016 at 09:54:14AM +0800, Peter Chen wrote: > Although I don't know what kinds of bugs it may have, it may be > met before, otherwise, why most of platform drivers need to call > dma_set_coherent_mask or dma_coerce_mask_and_coherent explicitly See Documentation/DMA-API.txt, specifi

Re: [GIT PULL] On-demand device probing

On Thu, Oct 22, 2015 at 07:44:05AM -0700, Greg Kroah-Hartman wrote: > > > On Thu, Oct 22, 2015 at 11:05:11AM +0200, Tomeu Vizoso wrote: > > Given that downstreams are already carrying as many hacks as they > > could think of to speed total boot up, I think this is effectively > > telling them to

Re: Alternative approach to solve the deferred probe

On Wed, Oct 21, 2015 at 08:36:23AM -0700, Frank Rowand wrote: > On 10/21/2015 1:18 AM, Russell King - ARM Linux wrote: > > On Tue, Oct 20, 2015 at 08:58:19PM -0700, Frank Rowand wrote: > >> On 10/20/2015 8:46 AM, Russell King - ARM Linux wrote: > > < snip >

Re: Alternative approach to solve the deferred probe

On Wed, Oct 21, 2015 at 09:13:48PM +0300, Grygorii Strashko wrote: > But I worry a bit (and that my main point) about these few additional > rounds of deferred device probing which I have right now and which allows > some of drivers to finish, finally, their probes successfully. > With proposed cha

Re: Alternative approach to solve the deferred probe

On Wed, Oct 21, 2015 at 07:55:29PM +0300, Grygorii Strashko wrote: > On 10/21/2015 06:36 PM, Frank Rowand wrote: > > The above is currently the last point for probe to succeed or defer > > (until possibly, as you mentioned, module loading resolves the defer). > > If a probe defers above, it will de

Re: Alternative approach to solve the deferred probe

On Tue, Oct 20, 2015 at 08:58:19PM -0700, Frank Rowand wrote: > On 10/20/2015 8:46 AM, Russell King - ARM Linux wrote: > > On Mon, Oct 19, 2015 at 06:21:40PM +0200, Geert Uytterhoeven wrote: > >> Hi Russell, > >> > >> On Mon, Oct 19, 2015 at 5:35 PM,

Re: Alternative approach to solve the deferred probe (was: [GIT PULL] On-demand device probing)

On Mon, Oct 19, 2015 at 06:21:40PM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Mon, Oct 19, 2015 at 5:35 PM, Russell King - ARM Linux > wrote: > >> > What you can do is print those devices which have failed to probe at > >> > late_initcall() time - p

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 08:27:44PM +0200, Uwe Kleine-König wrote: > Hello, > > On Mon, Oct 19, 2015 at 04:43:24PM +0100, Russell King - ARM Linux wrote: > > It's a bit ironic that you've chosen GPIO as an example there. The > > "new" GPIO API (the gpiod_

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 06:21:40PM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Mon, Oct 19, 2015 at 5:35 PM, Russell King - ARM Linux > wrote: > >> > What you can do is print those devices which have failed to probe at > >> > late_initcall() time - p

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 04:29:40PM +0100, David Woodhouse wrote: > I don't know that there *is* a coherent plan here to address it all. > > Certainly, we *will* need subsystems to have firmware-specific > knowledge in some cases. Take GPIO as an example; ACPI *has* a way to > describe GPIO, and pr

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 05:00:54PM +0200, Tomeu Vizoso wrote: > On 19 October 2015 at 16:30, Russell King - ARM Linux > wrote: > > I typically see one or two, maybe five maximum on the platforms I have > > here, but normally zero. > > Hmm, I have given a look at our l

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 04:10:56PM +0200, Tomeu Vizoso wrote: > On 19 October 2015 at 15:18, Russell King - ARM Linux > wrote: > > On Mon, Oct 19, 2015 at 02:34:22PM +0200, Tomeu Vizoso wrote: > >> ... If a device is available and has > >> a compatible driver, but

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 02:34:22PM +0200, Tomeu Vizoso wrote: > ... If a device is available and has > a compatible driver, but it cannot be probed because a dependency > isn't going to be available, that's an error and is going to cause > real-world problems unless the device is redundant. Current

Re: [GIT PULL] On-demand device probing

On Mon, Oct 19, 2015 at 10:44:41AM +0100, David Woodhouse wrote: > On Sun, 2015-10-18 at 20:53 +0100, Mark Brown wrote: > > On Sun, Oct 18, 2015 at 12:37:57PM -0700, Greg Kroah-Hartman wrote: > > > On Sun, Oct 18, 2015 at 08:29:31PM +0100, Mark Brown wrote: > > > > On Fri, Oct 16, 2015 at 11:57:50P

Re: Regression: USB OTG port breaks after a few hours in host mode on iMX6

On Thu, Oct 08, 2015 at 09:52:52AM +, Peter Chen wrote: > I can't reproduce it for 5 hours, and will change pinmux (do the same > thing with your platform), and do the overnight test. There's definitely something weird going on. Over night last night, I left the Logitech universal receiver in

Regression: USB OTG port breaks after a few hours in host mode on iMX6

This bug is soo obscure, I'm not even sure how to start debugging it. This never used to be a problem, but I'm not sure when it started as USB (in general) is not something I use regularly. In this setup, the USB OTG port is wired in host mode via pinmix configuration of the USB OTG ID pin:

Re: [PATCH v7 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA

On Tue, Sep 01, 2015 at 02:54:17PM +0300, Mathias Nyman wrote: > On 31.08.2015 21:58, Duc Dang wrote: > >On Thu, Aug 20, 2015 at 12:38 PM, Duc Dang wrote: > >>The xhci platform driver needs to work on systems that > >>either only support 64-bit DMA or only support 32-bit DMA. > >>Attempt to set a

Re: [PATCH v5 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA

On Fri, Aug 07, 2015 at 08:18:48PM -0700, Duc Dang wrote: > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index 890ad9d..5d03f8b 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -93,14 +93,14 @@ static int xhci_plat_probe(struct plat

Re: [Linux-am33-list] [PATCH v2 0/7] fix build failure of mn10300

On Thu, Jun 18, 2015 at 10:31:07AM -0500, Jay C. Polmar wrote: > I am on this list by mistake and 5/15/2011 we requested to be removed, > can someone remove me from this list? There are six mailing lists in the Cc line. For all of the lists present there, I can't help you, but you should be able

Re: [PATCH v2 0/7] fix build failure of mn10300

On Thu, Jun 18, 2015 at 05:47:46PM +0530, Sudip Mukherjee wrote: > This is an attempt to fix the build failures when building mn10300 with > allmodconfig. As I have never worked with arch files so I hope you will > point me to right direction to correct my mistakes in this attempt. Why has the lin

Re: [PATCH] usb: renesas: fix extcon dependency

On Wed, Jan 28, 2015 at 10:47:18PM +0100, Arnd Bergmann wrote: > The renesas usbhs driver calls extcon_get_edev_by_phandle(), which > is defined in drivers/extcon/extcon-class.c, and that can be a > loadable module. If the extcon-class support is disabled, usbhs > will work correctly for all device

Re: Lockdep problem: v3.18+ (with yesterday's Linus tip - 6f51ee709e4c)

On Wed, Jan 07, 2015 at 10:42:14AM -0500, Alan Stern wrote: > On Thu, 18 Dec 2014, Greg Kroah-Hartman wrote: > > That seems reasonable to me, unbinding when a reset is happening is > > going to be a rare condition, but if we get rid of it, and we try to > > queue a reset for a device that is gone,

Re: 3.18 / 3.19-rc1: ehci scheduling bug?

On Wed, Dec 24, 2014 at 12:00:00PM +0100, Frank Schäfer wrote: > See > https://bugzilla.kernel.org/show_bug.cgi?id=72891 > > Solved by > http://www.spinics.net/lists/linux-usb/msg118366.html Thanks, that seems to solve it. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up

3.18 / 3.19-rc1: ehci scheduling bug?

While testing an EM28xx based USB DVB stick which I've recently acquired, I find that occasionally the driver stops responding after it returns -EFBIG from one of its ioctls. I've no idea whether there's a previous kernel version which works. Finding the EFBIG return in ehci-sched.c, I decided to

Lockdep problem: v3.18+ (with yesterday's Linus tip - 6f51ee709e4c)

While unplugging a Logitek Keyboard/mouse micro-receiver, I got the lockdep splat below. However, I don't fully understand this splat - I see nothing in flush_work() nor process_one_work() making use of "intf->reset_ws" - which seems to be a USB thing. I guess lockdep is being re-used to validate

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

On Tue, Nov 18, 2014 at 12:05:45AM +0400, Dmitry Eremin-Solenikov wrote: > Hello, > > 2014-11-17 21:44 GMT+03:00 Robert Jarzmik : > > Dmitry Eremin-Solenikov writes: > > > >> Change clk_enable/disable() calls to clk_prepare_enable() and > >> clk_disable_unprepare(). > >> > >> Signed-off-by: Dmitr

Re: [PATCH V2 1/5] serial: pxa: prepare/unprepare clocks

On Mon, Nov 17, 2014 at 06:07:39PM +0300, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). NAK. Console writes can be called from IRQs-off regions. clk_prepare() can sleep. Sleeping is not permitted with IRQs off. -- FTT

Re: [PATCH V2 2/5] i2c: pxa: prepare/unprepare clocks

On Mon, Nov 17, 2014 at 06:07:40PM +0300, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > drivers/i2c/busses/i2c-pxa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 delet

Re: RCU bug with v3.17-rc3 ?

On Wed, Oct 15, 2014 at 10:25:13PM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 15, 2014 at 10:23:10PM +0100, Russell King - ARM Linux wrote: > > As I said, I have a patch in progress, but it seems that there needed > > to be some discussion about exactly which compil

Re: RCU bug with v3.17-rc3 ?

On Wed, Oct 15, 2014 at 10:23:10PM +0100, Russell King - ARM Linux wrote: > As I said, I have a patch in progress, but it seems that there needed > to be some discussion about exactly which compiler versions are affected. > It seems that it's not as trivial as looking at the

Re: RCU bug with v3.17-rc3 ?

On Tue, Oct 14, 2014 at 04:06:40AM +0200, Greg KH wrote: > On Mon, Oct 13, 2014 at 12:43:07PM +0100, Russell King - ARM Linux wrote: > > I think the only viable solution here is that: > > > > 1. We blacklist the bad compiler versions outright in the kernel. > > Yes, p

Re: RCU bug with v3.17-rc3 ?

On Mon, Oct 13, 2014 at 09:11:34AM +, David Laight wrote: > From: Nathan Lynch > > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: > > > > > > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and > > > it seems that thi

Re: RCU bug with v3.17-rc3 ?

On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote: > On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: > > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: > > > > > > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and &

Re: RCU bug with v3.17-rc3 ?

On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: > > We can blacklist these GCC versions quite easily. We already have GCC > > 3.3 blacklisted, and it's trivial to add others. I would want to include >

Re: RCU bug with v3.17-rc3 ?

On Fri, Oct 10, 2014 at 08:57:43AM -0500, Felipe Balbi wrote: > On Thu, Oct 09, 2014 at 04:07:15PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 09, 2014 at 03:46:37PM -0500, Felipe Balbi wrote: > > > On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: > > > > On Thu, Oct 09, 2

Re: RCU bug with v3.17-rc3 ?

On Fri, Oct 10, 2014 at 12:47:06AM +0300, Aaro Koskinen wrote: > Hi, > > On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: > > What GCC version are you using? > > > > 4.8.1 and 4.8.2 are known to miscompile the ARM kernel and these > > find_get_entry() crashes with 0x

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

On Thu, Jul 17, 2014 at 07:19:15PM +0800, Peter Chen wrote: > Currently, we are designing a generic driver, we don't know what's the > hardware architecture, we are trying to find a solution how to set > dma mask for all possible devices which will use this driver, Antoine's > this patch is trying

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

On Fri, Apr 25, 2014 at 04:07:00PM +0200, Gregory CLEMENT wrote: > +#if defined(CONFIG_HAVE_CLK) > +static int try_enable_clk(struct platform_device *pdev) > +{ > + struct clk *clk = devm_clk_get(&pdev->dev, NULL); > + > + /* Not all platforms have a clk so it is not an error if the clock >

Re: [PATCH v4 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

On Thu, Dec 12, 2013 at 06:18:29AM -0500, Matt Porter wrote: > /** > + * struct phy_attrs - represents phy attributes > + * @bus_width: Data path width implemented by PHY > + */ > +struct phy_attrs { > + u32 bus_width; Why u32? > int phy_power_off(struct phy *phy); > +st

Re: ARM: v3.13-rc1: USB regression

On Mon, Nov 25, 2013 at 06:33:02PM +0200, Aaro Koskinen wrote: > Hi, > > On Sun, Nov 24, 2013 at 10:43:59PM +, Russell King - ARM Linux wrote: > > On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote: > > > [ 33.967324] ohci ohci: Coherent DMA mask 0x

Re: ARM: v3.13-rc1: USB regression

On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote: > Hi, > > With 3.13-rc1, the USB OHCI probe fails on Amstrad E3 (ARM/OMAP1) > as follows: > > [ 33.814705] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver > [ 33.821482] ohci-omap: OHCI OMAP driver > [ 33.925153] ohci ohc

Re: [PATCH] usb: ohci-pxa27x: include linux/dma-mapping.h

On Fri, Nov 15, 2013 at 09:45:16AM +0100, Daniel Mack wrote: > Include linux/dma-mapping.h to make the new functions available that are > used since 22d9d8e83 ("DMA-API: usb: use dma_set_coherent_mask()"). > > Signed-off-by: Daniel Mack > --- > I got the following error while building for PXA pla

Re: [PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub

On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote: > @@ -107,10 +108,22 @@ static int ci_hdrc_imx_probe(struct platform_device > *pdev) > return ret; > } > > + data->clk_phy = devm_clk_get(&pdev->dev, "phy"); > + if (IS_ERR(data->clk_phy)) { > +

  1   2   3   >