Re: how to test g_webcam

2019-10-16 Thread Roger Quadros
Hi, On 15/10/2019 18:26, Gopal, Saranya wrote: Hi Quadros, I used the a different uvc-gadget application from this location [1] and it seems to work quite fine with builtin video pattern and jpg image but not with V4L2 capture source. So something is broken in uvc-gadget at [2] [1] https://

Re: how to test g_webcam

2019-10-15 Thread Roger Quadros
Hi, On 14/10/2019 17:22, Felipe Balbi wrote: Hi, Roger Quadros writes: Hmm, Link Change is disabled by default upstream, unless you're running on anything older than 2.50a. I don't remember the version you're using, though :-p 2.02a Thanks :-) irq/170-dwc

Re: how to test g_webcam

2019-10-14 Thread Roger Quadros
On 14/10/2019 15:38, Felipe Balbi wrote: Hi, Roger Quadros writes: I'm having a hard time to figure out how to get g_webcam working with the tip of http://git.ideasonboard.org/uvc-gadget.git Platform I'm using is dra7-evm with dwc3 controller. which arguments are you

Re: how to test g_webcam

2019-10-14 Thread Roger Quadros
+Bin Hi, On 11/10/2019 16:06, Felipe Balbi wrote: Hi, Roger Quadros writes: Hi, I'm having a hard time to figure out how to get g_webcam working with the tip of http://git.ideasonboard.org/uvc-gadget.git Platform I'm using is dra7-evm with dwc3 controller. which argumen

how to test g_webcam

2019-10-11 Thread Roger Quadros
Hi, I'm having a hard time to figure out how to get g_webcam working with the tip of http://git.ideasonboard.org/uvc-gadget.git Platform I'm using is dra7-evm with dwc3 controller. At first things just lock up the moment I load g_webcam. To fix the deadlock drivers/us

[PATCH] usb: dwc3: don't set gadget->is_otg flag

2019-08-26 Thread Roger Quadros
1: Dual-Role OTG device on non-HNP port [ 98.487545] usb 1-1: set a_alt_hnp_support failed: -32 [ 98.493532] usb usb1-port1: unable to enumerate USB device Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b

[PATCH v2] usb: gadget: udc: core: Fix segfault if udc_bind_to_driver() for pending driver fails

2019-08-22 Thread Roger Quadros
[ 61.154869] ---[ end trace afb22e9b637bd9a7 ]--- Segmentation fault Signed-off-by: Roger Quadros --- Changelog: v2 - Retain policy behaviour if pending gadget driver fails to bind. drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH] usb: gadget: udc: core: Fix error case while binding pending gadget drivers

2019-08-22 Thread Roger Quadros
On 21/08/2019 17:30, Alan Stern wrote: > On Wed, 21 Aug 2019, Roger Quadros wrote: > >> If binding a pending gadget driver fails we should not >> remove it from the pending driver list, otherwise it >> will cause a segmentation fault later when the gadget driver is &

[PATCH] usb: gadget: udc: core: Fix error case while binding pending gadget drivers

2019-08-21 Thread Roger Quadros
]--- Segmentation fault Signed-off-by: Roger Quadros --- drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 7cf34beb50df..c272c8014772 100644 --- a/drivers/usb/gadget/udc/core.c +++ b

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-21 Thread Roger Quadros
On 19/08/2019 17:19, Alan Stern wrote: > On Mon, 19 Aug 2019, Roger Quadros wrote: > >> On 15/08/2019 17:39, Alan Stern wrote: >>> On Thu, 15 Aug 2019, Roger Quadros wrote: >>> >>>> Felipe & Alan, >>>> >>>> On 21/07/2019 21:

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-19 Thread Roger Quadros
On 15/08/2019 17:39, Alan Stern wrote: > On Thu, 15 Aug 2019, Roger Quadros wrote: > >> Felipe & Alan, >> >> On 21/07/2019 21:32, Pawel Laszczak wrote: >>> This patch introduce new Cadence USBSS DRD driver to linux kernel. >>> >>> The C

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-19 Thread Roger Quadros
0644 drivers/usb/cdns3/trace.c >>> create mode 100644 drivers/usb/cdns3/trace.h >>> >> >> >> >>> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c >>> new file mode 100644 >>> index ..900b2ce08162 >>> --- /de

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-15 Thread Roger Quadros
Felipe & Alan, On 21/07/2019 21:32, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configu

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-15 Thread Roger Quadros
ew file mode 100644 > index ..900b2ce08162 > --- /dev/null > +++ b/drivers/usb/cdns3/core.c > @@ -0,0 +1,554 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Cadence USBSS DRD Driver. > + * > + * Copyright (C) 2018-2019 Cadence. > + * Copyright (C) 2017-2018 NXP >

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-14 Thread Roger Quadros
On 21/07/2019 21:32, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to Linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. > >

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-14 Thread Roger Quadros
On 21/07/2019 21:32, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to Linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. > >

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-13 Thread Roger Quadros
On 13/08/2019 10:30, Chunfeng Yun wrote: > On Mon, 2019-08-12 at 16:04 +0300, Roger Quadros wrote: >> >> On 12/08/2019 15:46, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: >>>>> The sysfs file we expose

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-12 Thread Roger Quadros
On 12/08/2019 15:46, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> The sysfs file we expose from the class for the role switches is >>> primarily meant for supporting proprietary protocols that require us >>> to basically override the co

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-12 Thread Roger Quadros
On 12/08/2019 13:31, Heikki Krogerus wrote: > Hi, > >> +real_role = cdsn3_real_role_switch_get(cdns->dev); >> + >> +current_role = role; >> +dev_dbg(cdns->dev, "Switching role"); >> + >> +ret = cdns3_role_start(cdns, real_role); >> +

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-12 Thread Roger Quadros
On 11/08/2019 14:59, Pawel Laszczak wrote: > Hi, > >> >> On 21/07/2019 21:32, Pawel Laszczak wrote: >>> This patch introduce new Cadence USBSS DRD driver to Linux kernel. >>> >>> The Cadence USBSS DRD Controller is a highly configurable IP Core which >>> can be instantiated as Dual-Role Device

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-12 Thread Roger Quadros
urce_start(pdev, PCI_BAR_OTG); >>> + res[RES_DRD_ID].end = pci_resource_end(pdev, PCI_BAR_OTG); >>> + res[RES_DRD_ID].name = "otg"; >>> + res[RES_DRD_ID].flags = IORESOURCE_MEM; >>> + dev_dbg(&pdev->dev,

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-09 Thread Roger Quadros
Pawel, On 08/08/2019 07:12, Pawel Laszczak wrote: > Hi Roger, > >> >> >> On 23/07/2019 07:32, Pawel Laszczak wrote: >> >>> Hi, >> >>> >> On Mon 2019-07-22 13:56:44, Pavel Machek wrote: >> > Hi! >> > >> > This patch introduce new Cadence USBSS DRD driver to linux kernel. >> >>

Re: [PATCH] usb: dwc3: remove generic PHYs forwarding for XHCI device

2019-08-09 Thread Roger Quadros
Hi, On 08/08/2019 15:47, Felipe Balbi wrote: > > Hi, > > Marek Szyprowski writes: > >> Commit 08f871a3aca2 ("usb: dwc3: host: convey the PHYs to xhci") added >> forwarding of the generic PHYs from DWC3 core to the instantiated XHCI-plat >> device. However XHCI(-plat) driver never gained suppor

Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-08-07 Thread Roger Quadros
return PTR_ERR(wrap->plat_dev); > + } > + } > + > + pci_set_drvdata(pdev, wrap); > + return err; > +} > + > +static void cdns3_pci_remove(struct pci_dev *pdev) > +{ > + struct cdns3_wrap *wrap; > + struct pci_dev *func; > + >

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-07 Thread Roger Quadros
Pawel, On 23/07/2019 07:32, Pawel Laszczak wrote: > Hi, > >> On Mon 2019-07-22 13:56:44, Pavel Machek wrote: >>> Hi! >>> >>> This patch introduce new Cadence USBSS DRD driver to linux kernel. >>> >>> The Cadence USBSS DRD Controller is a highly configurable IP Core which >>> can

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-08-07 Thread Roger Quadros
On 05/07/2019 14:44, Pawel Laszczak wrote: > >> EXTERNAL MAIL >> >> >> >> Hi, >> >> Pawel Laszczak writes: >>> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h >>> index da82606be605..d388a3a5ab7e 100644 >>> --- a/include/linux/usb/ch9.h >>> +++ b/include/linux/usb/ch9.h >>> @@ -

Re: DWC3 USB hub issue

2019-06-17 Thread Roger Quadros
On 17/06/2019 10:13, Felipe Balbi wrote: > > Hi, > > Manivannan Sadhasivam writes: >> Hello, >> >> I'm trying to upstream Designware USB3 host driver present in the Actions >> Semi S900 SoC. It can successfully detect the USB hub but when any of the >> USB device got plugged in, it fails with

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-03-07 Thread Roger Quadros
On 07/03/2019 09:06, Pawel Laszczak wrote: > Hi, > >> Hi, >> >> On 21/02/2019 09:14, Felipe Balbi wrote: >>> >>> Hi, >>> >>> (please break your emails at 80-columns) >>> >>> Pawel Laszczak writes: >> One more thing. Workaround has implemented algorithm that decide for >> which >> end

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-03-04 Thread Roger Quadros
Hi, On 21/02/2019 09:14, Felipe Balbi wrote: > > Hi, > > (please break your emails at 80-columns) > > Pawel Laszczak writes: One more thing. Workaround has implemented algorithm that decide for which endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it should

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Roger Quadros
Pawel, On 20/02/2019 13:18, Pawel Laszczak wrote: > Hi Roger. >> >> On 14/02/2019 21:45, Pawel Laszczak wrote: >>> Controller for OUT endpoints has shared on-chip buffers for all incoming >>> packets, including ep0out. It's FIFO buffer, so packets must be handle >>> by DMA in correct order. If the

Re: usb: over-current condition

2019-02-20 Thread Roger Quadros
On 20/02/2019 13:00, Subhashini Rao Beerisetty wrote: > On Tue, Feb 19, 2019 at 8:30 PM Roger Quadros wrote: >> >> Please keep linux-usb in cc. >> >> On 19/02/2019 16:50, Subhashini Rao Beerisetty wrote: >>> On Tue, Feb 19, 2019 at 8:06 PM Roger Qua

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-20 Thread Roger Quadros
Pawel, On 14/02/2019 21:45, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. >

Re: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Roger Quadros
Pawel, On 14/02/2019 21:45, Pawel Laszczak wrote: > Controller for OUT endpoints has shared on-chip buffers for all incoming > packets, including ep0out. It's FIFO buffer, so packets must be handle > by DMA in correct order. If the first packet in the buffer will not be > handled, then the followi

Re: usb: over-current condition

2019-02-19 Thread Roger Quadros
Please keep linux-usb in cc. On 19/02/2019 16:50, Subhashini Rao Beerisetty wrote: > On Tue, Feb 19, 2019 at 8:06 PM Roger Quadros wrote: >> >> Hi Subhashini, >> >> On 19/02/2019 16:30, Subhashini Rao Beerisetty wrote: >>> Hi All, >>> >>> [

Re: usb: over-current condition

2019-02-19 Thread Roger Quadros
Hi Subhashini, On 19/02/2019 16:30, Subhashini Rao Beerisetty wrote: > Hi All, > > [ Please keep me in CC as I'm not subscribed to the list] > > > I’m using an Ubuntu 16.04.4 LTS PC and when I connect an USB device to > my Ubuntu PC, I see the below mentioned messages in dmesg. > > > > [ 901

Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4

2019-02-06 Thread Roger Quadros
+Marek As Vivek's and Andrzej's Samsung IDs bounced back. On 06/02/19 11:38, Jochen Sprickerhof wrote: > * Roger Quadros [2019-02-06 10:41]: >> Hi, >> >> On 21/01/19 16:02, Jochen Sprickerhof wrote: > [..] >>> I'm not sure why this it only works

Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4

2019-02-06 Thread Roger Quadros
Hi, On 21/01/19 16:02, Jochen Sprickerhof wrote: > Note that it only works with USB_XHCI_PLATFORM=y. Also it needs a hard > reset when coming from an unpatched kernel. > > This was included in the original patch in > https://patchwork.kernel.org/patch/9992809/ but got dropped when > accepted in d

[PATCH v2 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2019-01-10 Thread Roger Quadros
ny side effects on v2.40a. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 07bd31b..a9cf4dd4 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/

[PATCH v2 0/3] usb: dwc3: Add support for AM654 USB

2019-01-10 Thread Roger Quadros
Hi Felipe, TI's AM654 USB SoC has 2 instances of the DWC3 controller. This series adds AM654 USB wrapper support to the keystone-usb driver. Changelog: v2: - Moved compatible to separate lines in DT binding. cheers, -roger Roger Quadros (3): usb: dwc3: gadget: Fix OTG events when g

[PATCH v2 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3

2019-01-10 Thread Roger Quadros
The AM654 SoC contains a DWC3 controller with TI specific wrapper. Add support for that. Unlike the Keystone 2 case, for AM654 We don't need to process any IRQs for basic USB operation. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/Kconfig | 6 +++--- drivers/usb/dwc3

[PATCH v2 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2019-01-10 Thread Roger Quadros
The AM654 SoC from TI contains a DWC3 controller. Add support for it. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/keystone-usb.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b

[PATCH v3] usb: ehci-omap: Fix deferred probe for phy handling

2018-12-14 Thread Roger Quadros
o PHY) then error out. This fixes USB Ethernet on omap5-uevm if PHY happens to probe after EHCI thus causing a -EPROBE_DEFER. Cc: Alan Stern Cc: Johan Hovold Cc: Ladislav Michl Cc: Peter Ujfalusi Cc: Tony Lindgren Reported-by: Peter Ujfalusi Signed-off-by: Roger Quadros --- drivers/usb/host

[PATCH v2] usb: ehci-omap: Fix deferred probe for phy handling

2018-12-13 Thread Roger Quadros
o PHY) then error out. This fixes USB Ethernet on omap5-uevm if PHY happens to probe after EHCI thus causing a -EPROBE_DEFER. Cc: Alan Stern Cc: Johan Hovold Cc: Ladislav Michl Cc: Peter Ujfalusi Cc: Tony Lindgren Reported-by: Peter Ujfalusi Signed-off-by: Roger Quadros --- drivers/usb/host

Re: [PATCH] USB: ehci-omap: Fix deferred probe for phy handling

2018-12-13 Thread Roger Quadros
fixing? > Cc: Alan Stern > Cc: Johan Hovold > Cc: Ladislav Michl > Cc: Peter Ujfalusi > Cc: Roger Quadros > Reported-by: Peter Ujfalusi > Signed-off-by: Tony Lindgren > --- > drivers/usb/host/ehci-omap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.

2018-12-11 Thread Roger Quadros
Pawel, On 10/12/18 14:39, Pawel Laszczak wrote: > This patch aim at documenting USB related dt-bindings for the > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak > --- > .../devicetree/bindings/usb/cdns3-usb.txt | 31 +++ > 1 file changed, 31 insertions(+) >

Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-11 Thread Roger Quadros
Pawel, On 10/12/18 14:39, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver > to linux kernel. > > The Cadence USBSS DRD Driver is a highly > configurable IP Core which can be > instantiated as Dual-Role Device (DRD), > Peripheral Only and Host Only (XHCI) > configurations

Re: [PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-10 Thread Roger Quadros
Hi Vignesh, On 06/12/18 12:32, Vignesh R wrote: > Hi Roger, > > On 05/12/18 8:49 PM, Roger Quadros wrote: >> The AM654 SoC from TI contains a DWC3 controller. Add >> support for it. >> >> Signed-off-by: Roger Quadros >> --- >> Documentation

[PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2018-12-05 Thread Roger Quadros
ny side effects on v2.40a. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 679c12e..79120c0 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/

[PATCH 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3

2018-12-05 Thread Roger Quadros
The AM654 SoC contains a DWC3 controller with TI specific wrapper. Add support for that. Unlike the Keystone 2 case, for AM654 We don't need to process any IRQs for basic USB operation. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/Kconfig | 6 +++--- drivers/usb/dwc3

Re: [PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Misspelled Felipe's ID. Will resend this series. On 05/12/18 17:14, Roger Quadros wrote: > Hi Felipe, > > TI's AM654 USB SoC has 2 instances of the DWC3 controller. > This series adds AM654 USB wrapper support to the keystone-usb driver. > > cheers, > -roger

[PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Hi Felipe, TI's AM654 USB SoC has 2 instances of the DWC3 controller. This series adds AM654 USB wrapper support to the keystone-usb driver. cheers, -roger Roger Quadros (3): usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded dt-bindings: usb: keystone-usb: Add ti,

[PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-05 Thread Roger Quadros
The AM654 SoC from TI contains a DWC3 controller. Add support for it. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b

[PATCH 0/3] usb: dwc3: Add support for AM654 USB

2018-12-05 Thread Roger Quadros
Hi Felipe, TI's AM654 USB SoC has 2 instances of the DWC3 controller. This series adds AM654 USB wrapper support to the keystone-usb driver. cheers, -roger Roger Quadros (3): usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded dt-bindings: usb: keystone-usb: Add ti,

[PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

2018-12-05 Thread Roger Quadros
The AM654 SoC from TI contains a DWC3 controller. Add support for it. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b

[PATCH 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3

2018-12-05 Thread Roger Quadros
The AM654 SoC contains a DWC3 controller with TI specific wrapper. Add support for that. Unlike the Keystone 2 case, for AM654 We don't need to process any IRQs for basic USB operation. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/Kconfig | 6 +++--- drivers/usb/dwc3

[PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2018-12-05 Thread Roger Quadros
ny side effects on v2.40a. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 679c12e..79120c0 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Roger Quadros
On 04/12/18 10:50, Peter Chen wrote: >>> + * Cadence USBSS DRD Driver. >>> + * >>> + * Copyright (C) 2018 Cadence. >>> + * >>> + * Author: Peter Chen >>> + * Pawel Laszczak >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>

Re: [RFC PATCH v2 12/15] usb:cdns3: Adds enumeration related function.

2018-11-28 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch implements a set of function related to enumeration process. > Some standard requests are handled on controller driver level and > other are delegated to gadget core driver. > All class requests are delegated to gadget core driver. > > Signed-off

Re: [RFC PATCH v2 11/15] usb:cdns3: Implements ISR functionality.

2018-11-28 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds set of generic functions used for handling interrupts > generated by controller. Interrupt related functions are divided > into three groups. The first is related to ep0 and is placed in ep0.c. > The second is responsible for non-default endp

Re: [RFC PATCH v2 10/15] usb:cdns3: Ep0 operations part of the API

2018-11-28 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch implements related to default endpoint callback functions > defined in usb_ep_ops object > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/ep0.c| 191 - > drivers/usb/cdns3/gadget.c | 8 ++ >

Re: [RFC PATCH v2 09/15] usb:cdns3: EpX operations part of the API

2018-11-28 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch implements callback functions for non-default endpoints > defined in usb_ep_ops object. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/ep0.c| 18 ++ > drivers/usb/cdns3/gadget.c | 442 - > d

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-11-28 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds implementation callback function defined in > usb_gadget_ops object. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/gadget.c | 249 - > 1 file changed, 247 insertions(+), 2 deletions(-) > >

Re: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support - initialization.

2018-11-28 Thread Roger Quadros
+Felipe. Pawel, Please copy Felipe Balbi as he maintains the USB gadget stack. On 18/11/18 12:09, Pawel Laszczak wrote: > Patch implements a set of functions responsible for initialization, > configuration, starting and stopping device mode. > This patch also adds new ep0.c that holds all functi

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-11-27 Thread Roger Quadros
Pawel, On 27/11/18 13:29, Pawel Laszczak wrote: > Hi Roger > Patch adds supports for detecting Host/Device mode. + +static int cdns3_otg_get_id(struct cdns3 *cdns) +{ + int id; + + id = readl(&cdns->otg_regs->sts) & OTGSTS_ID_VALUE; + dev_dbg(cdns->dev,

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-11-26 Thread Roger Quadros
On 26/11/18 12:09, Pawel Laszczak wrote: Pawel, On 26/11/18 09:23, Pawel Laszczak wrote: > Hi Roger, > >> On 18/11/18 12:09, Pawel Laszczak wrote: >>> Patch adds supports for detecting Host/Device mode. >>> Controller has additional OTG register that allow >>

Re: [RFC PATCH v2 06/15] usb:cdns3: Adds Host support

2018-11-26 Thread Roger Quadros
Hi, On 26/11/18 10:24, Pawel Laszczak wrote: >> EXTERNAL MAIL >> >> >> On 18/11/18 12:09, Pawel Laszczak wrote: >>> Patch adds host-export.h and host.c file and mplements functions that >>> allow to initialize, start and stop XHCI host driver. >>> >>> Signed-off-by: Pawel Laszczak >>> --- >>> dr

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-11-26 Thread Roger Quadros
On 26/11/18 10:39, Pawel Laszczak wrote: >> >> Pawel, >> >> On 26/11/18 09:23, Pawel Laszczak wrote: >>> Hi Roger, >>> On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-11-26 Thread Roger Quadros
Pawel, On 26/11/18 09:23, Pawel Laszczak wrote: > Hi Roger, > >> On 18/11/18 12:09, Pawel Laszczak wrote: >>> Patch adds supports for detecting Host/Device mode. >>> Controller has additional OTG register that allow >>> implement even whole OTG functionality. >>> At this moment patch adds support

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-11-23 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap pins and ID pin.

Re: [RFC PATCH v2 06/15] usb:cdns3: Adds Host support

2018-11-23 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds host-export.h and host.c file and mplements functions that > allow to initialize, start and stop XHCI host driver. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Kconfig | 10 ++ > drivers/usb/cdns3/Makefile | 1 + >

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-11-23 Thread Roger Quadros
On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile

Re: [RFC PATCH v2 03/15] dt-bindings: add binding for USBSS-DRD controller.

2018-11-23 Thread Roger Quadros
On 18/11/18 12:08, Pawel Laszczak wrote: > Thsi patch aim at documenting USB related dt-bindings for the s/Thsi/This > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak > --- > .../devicetree/bindings/usb/cdns3-usb.txt | 17 + > 1 file changed, 17 insertions

Re: [RFC PATCH v2 01/15] usb:cdns3: add pci to platform driver wrapper.

2018-11-23 Thread Roger Quadros
Hi Pawel, On 18/11/18 12:08, Pawel Laszczak wrote: > Patch adds PCI specific glue driver that creates and registers in-system > cdns-usb3 platform device. Thanks to that we will be able to use > the cdns-usb3 platform driver for USBSS-DEV controller > build on PCI board > > Signed-off-by: Pawel L

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-12 Thread Roger Quadros
On 12/11/18 13:03, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>>> Also can we have some consistency in usage of '-' vs '_'? >>> Right.. I agree. I've been using '-' as it is the preferred syntax as >>

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-12 Thread Roger Quadros
Thinh, On 12/11/18 07:29, Thinh Nguyen wrote: > Hi Roger, > > On 11/9/2018 3:58 AM, Roger Quadros wrote: >> Hi, >> >> On 08/11/18 04:10, Thinh Nguyen wrote: >>> Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" >>> proper

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-09 Thread Roger Quadros
Hi, On 08/11/18 04:10, Thinh Nguyen wrote: > Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" > property via "snps,usb2-lpm-disable" property. > > Signed-off-by: Thinh Nguyen > --- > drivers/usb/dwc3/core.c | 2 ++ > drivers/usb/dwc3/core.h | 2 ++ > drivers/usb/dwc3/host.c |

Re: [RFC PATCH v1 14/14] usb:cdns3: Feature for changing role

2018-11-08 Thread Roger Quadros
On 08/11/18 13:51, Pawel Laszczak wrote: >> On 03/11/18 19:51, Pawel Laszczak wrote: >>> Patch adds feature that allow to change role from user space. >>> >>> Signed-off-by: Pawel Laszczak >>> --- >>> drivers/usb/cdns3/Makefile | 2 +- >>> drivers/usb/cdns3/core.c| 2 + >>> drivers/usb/cdn

Re: [RFC PATCH v1 13/14] usb:cdns3: Adds debugging function.

2018-11-08 Thread Roger Quadros
Hi, On 03/11/18 19:51, Pawel Laszczak wrote: > Patch implements some function used for debugging driver. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile | 2 +- > drivers/usb/cdns3/debug.c | 128 + > drivers/usb/cdns3/ep0.c| 3 +

Re: [RFC PATCH v1 14/14] usb:cdns3: Feature for changing role

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds feature that allow to change role from user space. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile | 2 +- > drivers/usb/cdns3/core.c| 2 + > drivers/usb/cdns3/debugfs.c | 94 + >

Re: [RFC PATCH v1 03/14] usb:cdns3: Driver initialization code.

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Patch also adds gadget.c, host.c, gadget-export.h, host-export.

Re: [RFC PATCH v1 04/14] usb:cdns3: Added DRD support

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap pins and ID pi

Re: [RFC PATCH v1 03/14] usb:cdns3: Driver initialization code.

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Patch also adds gadget.c, host.c, gadget-export.h, host-export.

Re: [RFC PATCH v1 01/14] usb:cdns3: add pci to platform driver wrapper.

2018-11-06 Thread Roger Quadros
Hi Pawel, On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds PCI specific glue drivier that creaties and registers in s/drivier/driver s/creaties/creates s/in system/in-system > system cdns-usb3 platform device. Thanks to that we will be able to use > the cdns-usb3 platform driver for USBSS-D

Re: usb: dwc3: dwc3 errors while video streaming with uvc-gadget

2018-11-05 Thread Roger Quadros
ll -Original Message- From: Laurent Pinchart Sent: 02 November 2018 11:49 To: Roger Quadros Cc: Terence Neill ; linux-usb@vger.kernel.org; Eaves, Paul Subject: Re: usb: dwc3: dwc3 errors while video streaming with uvc-gadget Hello, On Friday, 2 November 2018 11:50:47 EET Roger Quadros w

Re: usb: dwc3: dwc3 errors while video streaming with uvc-gadget

2018-11-02 Thread Roger Quadros
Hi Terry, On 15/10/18 19:34, Terence Neill wrote: Hi Felipe, I am having some issues when attempting to stream 1280x720 uncompressed video @ 10fps over a USB 2.0 High-Speed link. The system setup is: WebCam --- USB 2.0 link ---> x86 Linux Machine running uvc-gadget USB 2.0 link ---> x

Re: [PATCH 3/3] mfd: omap-usb-host: Drop support for non-DT probe

2018-09-12 Thread Roger Quadros
On 12/09/18 11:30, Laurent Pinchart wrote: > Hi Roger, > > On Wednesday, 12 September 2018 10:57:31 EEST Roger Quadros wrote: >> On 11/09/18 18:06, Laurent Pinchart wrote: >>> Now that all platforms using OMAP USB host devices have been converted >>> to DT, dro

Re: [PATCH 2/3] ARM: OMAP2+: Remove legacy USB initialization code

2018-09-12 Thread Roger Quadros
On 11/09/18 18:06, Laurent Pinchart wrote: > Several legacy USB-related functions, structures and macros are not used > anymore after conversion to DT. Remove them. > > Signed-off-by: Laurent Pinchart Acked-by: Roger Quadros cheers, -roger > --- > arch/arm/m

Re: [PATCH 3/3] mfd: omap-usb-host: Drop support for non-DT probe

2018-09-12 Thread Roger Quadros
Hi Laurent, On 11/09/18 18:06, Laurent Pinchart wrote: > Now that all platforms using OMAP USB host devices have been converted > to DT, drop support for legacy non-DT probe from the driver. > > Signed-off-by: Laurent Pinchart > --- > drivers/mfd/omap-usb-host.c| 153 > +++-

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-06-21 Thread Roger Quadros
On 21/06/18 13:52, Lars-Peter Clausen wrote: > On 06/21/2018 10:29 AM, Roger Quadros wrote: > [...] >>>> static int ffs_aio_cancel(struct kiocb *kiocb) >>>> { >>>> struct ffs_io_data *io_data = kiocb->private; >>>> -

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-06-21 Thread Roger Quadros
+Lars-Peter Vincent, On 14/06/18 16:23, Sam Protsenko wrote: > + Roger Quadros > + Praneeth Bajjuri > > Tested-by: Sam Protsenko > > I've tested it on X15 board (DWC3 controller) on Android master, by > doing "adb root". Without this patch I see backtrace a

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-21 Thread Roger Quadros
On 21/06/18 01:55, Rafael J. Wysocki wrote: > On Thu, Jun 21, 2018 at 12:32 AM, Rafael J. Wysocki wrote: >> On Wed, Jun 20, 2018 at 5:46 PM, Johan Hovold wrote: >>> On Wed, Jun 20, 2018 at 02:54:10PM +0200, Rafael J. Wysocki wrote: On Wednesday, June 20, 2018 2:23:46 PM CEST Johan Hovold wro

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Roger Quadros
+Tero, Tony and some TI folks On 18/06/18 15:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> On 18/06/18 12:51, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Johan Hovold writes: >>>> On Mon, Jun 18, 2018 at 12:

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Roger Quadros
On 18/06/18 12:51, Felipe Balbi wrote: > > Hi, > > Johan Hovold writes: >> On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: >> >>> Johan Hovold writes: >> I suggest merging this fix for 4.18-rc, and then Roger can rework the driver so that it works also on OMAP. >>> >>> o

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-13 Thread Roger Quadros
On 13/06/18 11:05, Felipe Balbi wrote: > Roger Quadros writes: > >> Hi Johan, >> >> On 31/05/18 17:45, Johan Hovold wrote: >>> The clocks have already been explicitly disabled and put as part of >>> remove() so the runtime suspend callback must not be r

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-13 Thread Roger Quadros
Hi Johan, On 31/05/18 17:45, Johan Hovold wrote: > The clocks have already been explicitly disabled and put as part of > remove() so the runtime suspend callback must not be run when balancing > the runtime PM usage count before returning. > > Fixes: 16adc674d0d6 ("usb: dwc3: add generic OF glue

[PATCH 2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active()

2018-05-28 Thread Roger Quadros
Don't call pm_runtime_set_active() as it will prevent the device from being activated in the next pm_runtime_get_sync() call. Also call pm_runtime_get_sync() before of_platform_populate(). Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-of-simple.c | 7 +++ 1 file chang

[PATCH 1/2] usb: dwc3: of-simple: Don't fail if no clock entries

2018-05-28 Thread Roger Quadros
of_count_phandle_with_args() returns -ENOENT (-2) if there are no clock entries. Don't fail in such a case. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-of-simple.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/dr

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

2018-05-18 Thread Roger Quadros
On 18/05/18 10:47, Andrzej Hajda wrote: > On 18.05.2018 09:38, Roger Quadros wrote: >> On 18/05/18 08:39, Andrzej Hajda wrote: >>> On 17.05.2018 18:06, kbuild test robot wrote: >>>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings"

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

2018-05-18 Thread Roger Quadros
On 18/05/18 08:39, Andrzej Hajda wrote: > On 17.05.2018 18:06, kbuild test robot wrote: >> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings") >> Signed-off-by: kbuild test robot > > It should be static of course, my bad. > > Reviewed-by: Andrzej Hajda I don't think we ac

Re: [PATCH v2 2/3] usb: gadget: uvc: remove delay usb status phase

2018-04-25 Thread Roger Quadros
Hi Paul, On 24/04/18 23:59, Paul Elder wrote: > The completion of the usb status phase doesn't need to be delayed > from uvc_function_set_alt to uvc_v4l2_streamon/off. > Remove USB_GADGET_DELAYED_STATUS and usb_composite_setup_delay from > these two, respectively. > > Signed-off-by: Paul Elder >

  1   2   3   4   5   6   7   8   9   10   >