Hi
I have started playing around with a board based on the DragonBoard
820c and I cannot manage to get the USB2 working as host.
If I connect a mouse, before I start the board I can see how the
system powers up the port (vbus) and enumerates the device, just to
kill it a couple of seconds later.
Hi Rob
On Thu, May 24, 2018 at 6:49 PM Rob Herring wrote:
> On Thu, May 24, 2018 at 7:18 AM, Ricardo Ribalda Delgado
> wrote:
> > Hi Johan,
> >
> > On Thu, May 24, 2018 at 2:07 PM Johan Hovold wrote:
> >
> >> Hi Ricardo,
> >
> >> On
Hi Johan,
On Thu, May 24, 2018 at 2:07 PM Johan Hovold wrote:
> Hi Ricardo,
> On Wed, May 23, 2018 at 11:17:20AM +0200, Ricardo Ribalda Delgado wrote:
> > Hi
> >
> > I have a flash controller connected to the main computer via a usb to
> > serial. My plan is t
Hello Paul
Thanks for your info, I will not be able to test anything until next week.
Regards!
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tested-by: Ricardo Ribalda Delgado
On Tue, May 12, 2015 at 8:37 PM, Mian Yousaf Kaukab
wrote:
> ep_cfg.IN_EP_ENABLE is only valid in advance mode.
>
> Signed-off-by: Mian Yousaf Kaukab
> ---
> drivers/usb/gadget/udc/net2280.c | 4 ++--
> 1 file changed, 2 insertio
Can you try with the latest kernel from linux-next?
There are some patches from Mian Yousaf Kaukab
, that might be related to your problem
Regards
ps: Make sure your mail client works in text mode or you wont be able
to send mails to the mailing list.
On Tue, Apr 21, 2015 at 2:39 AM, Praveen Mu
Hello Carolyn
I have tried using g_mass_storage and g_network, but I cannot see why
it should not work with gadgetfs.
What is exactly the issue? It does not build? it does not behave as expected?
I am putting the linux-usb mailing list on cc
Regards!
On Sat, Jan 31, 2015 at 12:06 AM, Smith, C
Hello Tod
If you cc the linux-usb mailing list, there will be more chances to
get a proper answer :)
>From the error message it seems that the device did not have an irq,
which is needed by the driver. Take a loop to lspci -vvv to see if it
is true.
Unfortunately I have not access to that board
b0
>> [ 201.304973] [] ? kthread_create_on_node+0x180/0x180
>> [ 201.305486] ---[ end trace a7f3e86a1a37203b ]—
>> Followed by:
>> [ 263.311338] net2280 :01:00.0: The dmastat return = 5002!!
>> [ 263.409818] g_mass_storage gadget: super-speed config
Fix sparse warning
Fixes: cb442ee1592d2681 (usb: gadget: udc: net2280: Re-enable dynamic debug
messages)
Reported-by: kbuild test robot
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
gt;Thanks!
>>
>>Not at all. :-)
>>
>> [...]
>>
>> >>On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote:
>>
>> >>>restart_dma is not used before it is declaration. Therefore we can
>>
>> >>s/it is/its/.
>&
Hello
>> If I want to get closer to the maximum speed should I just forget
>> about mass storage and use something else? What?
>>
>
> You might want to look into UAS (USB Attached SCSI).
> There is "USB Gadget Target Fabric Module" in Kconfig.
> There is a gadget-cli tool to control it from usersp
Hello
As you know I am trying to improve the net2280 driver to a point where
it is usable for my company (qtec.com). We develop smart cameras based
on linux, and we want to provide also a mass storage interface to the
camera.
Right now, the maximum speed I have been able to achieve is around 80
M
Hello
Thanks for reviewing. I will fix it and resend it on the next version
of the patchset to avoid spamming the ML
I guess it is ok to add your Reviewed-by
Thanks!
On Fri, Nov 28, 2014 at 3:46 PM, Sergei Shtylyov
wrote:
> Hello.
>
> On 11/28/2014 04:50 PM, Ricardo Ribalda Delg
.
Due to the fact that I am implementing the scather gatter on the top of
this tree I would like to get this merged/reviewed before continuing.
Ricardo Ribalda Delgado (17):
net2280: Remove obsolete module param use_dma_chaining
net2280: remove full_speed module parameter
net2280: Remove
Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 08c16ee..27b94c6 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget
Parameter use_msi was used to enable msi irq on usb338x chips, it was
enabled by default.
There is no reason to prefer non-msi irq on usb338x, and it falls back
to non msi on error.
Therefore remove this option.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 6
meter, which was disabled by default.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 147 ---
1 file changed, 13 insertions(+), 134 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
use_dma parameter was designed to enable the dma on the chip. It was
enabled by default.
It comes from the time when the dma was not reliable. Now it has been
working ok in production.
This patch removes this parameter.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280
Remove dma_started field from net2280_ep structure, since it is not used
by any function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 4
drivers/usb/gadget/udc/net2280.h | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb
restart_dma is not used before it is declaration. Therefore we can
remove this definition.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index
irqs_superspeed calls ep_stall instead of set/clear_halt, due to a
workaround for SS seqnum. Create a function with the workaround and
call set/clear_halt instead.
This way we can compare the code of super/normal speed and it is easier
to follow the code.
Signed-off-by: Ricardo Ribalda Delgado
Field is_halt is never used by any function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 6 +-
drivers/usb/gadget/udc/net2280.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc
ep_stdrsp was only called by handle_stat0_irqs_superspeed and with
always the same flags.
Remove the function and replace the call by the code inside the
function, since it is very simple once the dead code is removed.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c
Do not duplicate the code for the else branch of the condition.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc
We can use the same function for both families of chips and also remove
the ep_stop_dma() function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/gadget/udc
After fix superspeed dma_done was applied we can simplify the code by
removing the duplicated dma_done and letting the function check if there
are more completed dma transactions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 5 ++---
1 file changed, 2 insertions
The function is very simple, does not declare any variable and it is
called in the irq path.
The counterpart for net228x is already declared as inline.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Function resume_dma is not used, remove it.
The reason the compiler did not catch this dead code is the inline
modifier.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b
Once the defect 7374 is patched, there is no reason the keep reading the
idx scratch register.
Cache the content of the scratch idx register on device flag.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 153 +--
drivers/usb
Some debug messages were not build due to unconditional #if 0.
These messages are very useful for debugging and the user can enable
them on demand via dynamic debug.
If they are not enabled the performance is not affected.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc
ASSERT_OUT_NAKING was only called by out_flush and was hidden behind a
ifdef.
This patch moves the inline function into out_flush and remove the
ifdef. The user can decide to print the debug message or not via dynamic
printk
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc
hello Sebastian
On Tue, Nov 25, 2014 at 6:18 PM, Sebastian Andrzej Siewior
wrote:
> On 11/25/2014 06:10 PM, Ricardo Ribalda Delgado wrote:
>> Exactly the same that I am experiencing. I am preparing a patch that
>> removes the option, does some dma cleanout and then add support for
Now that I open the pandora box
Is there any reason to have use_dma, use_msi, enable_suspend and
full_speed as parameters? I might as well remove them.
Regards!
On Tue, Nov 25, 2014 at 6:10 PM, Ricardo Ribalda Delgado
wrote:
> Hello
>
> On Tue, Nov 25, 2014 at 6:05 PM, Alan Ste
Hello
On Tue, Nov 25, 2014 at 6:05 PM, Alan Stern wrote:
> On Tue, 25 Nov 2014, Ricardo Ribalda Delgado wrote:
>
>> Hello Alan
>>
>> Could you test if the parameter dma_chaining works on your board with
>> the current kernel?
>>
>> #on the target
>>
On Tue, Nov 25, 2014 at 4:32 PM, Alan Stern wrote:
> On Tue, 25 Nov 2014, Ricardo Ribalda Delgado wrote:
>
>> Hello Felipe
>>
>> On Tue, Nov 25, 2014 at 3:54 PM, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Tue, Nov 25, 2014 at 02:44:16AM +01
Hello Felipe
On Tue, Nov 25, 2014 at 3:54 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Nov 25, 2014 at 02:44:16AM +0100, Ricardo Ribalda Delgado wrote:
>> > might be better if you can fix the code, instead. We have a "better"
>> > scatter-gather suppor
peed config #1: Linux
> File-Backed Storage
>
> Unplugging and re-plugging the USB cable does allow me to remount the volume.
>
> Paul.
> On 25 Nov 2014, at 15:24, Ricardo Ribalda Delgado
> wrote:
>
>> Could you try
>> if (likely(t & (BIT(FIFO_EMPTY) | BIT(NAK_
; epstat=16528, td_dma=ce40c050
>
> Paul.
>
> On 25 Nov 2014, at 14:08, Ricardo Ribalda Delgado
> wrote:
>
>> hmm it seems that the code is waiting for a dma to complete. Please print
>>
>> ep->dma->dmactl
>> ep->dma->dmastat
>>
= 0, req->valid = 1, le32_to_cpu(req->td->dmacount) = 2952791040
>
> Paul.
>
> On 25 Nov 2014, at 13:09, Ricardo Ribalda Delgado
> wrote:
>
>> Could you print
>>
>> count, req->valid and le32_to_cpu(req->td->dmacount) just before udelay(1)
op many times.
> Even without writing to the device I then get the lockup message while inside
> the loop (ep->dev = ep-b).
>
> Paul.
>
> On 25 Nov 2014, at 02:06, Ricardo Ribalda Delgado
> wrote:
>
>> Hello
>>
>> Could you check if the code is stal
Hello Felipe
>
> might be better if you can fix the code, instead. We have a "better"
> scatter-gather support in the framework itself.
As I understand it, the code was designed to reduce the number of irqs
when you expect to send X consecutive packages. In that scenario you
only want an irq at
Hello
Could you check if the code is stalled at this loop ?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/gadget/udc/net2280.c#n2594
Regards!
On Thu, Nov 13, 2014 at 3:37 PM, Paul Jones wrote:
> Hi,
>
> using the latest kernel from
> https://git.kernel.org/cg
Hello
I cannot make work the parameter use_dma_chaining with g_mass_storage
and a usb3380 device. The initial enumeration works, but after a
couple of frames the enumeration is restarted. If I compare usbmon
with and without the parameter I can see that the device fails to
reply to the host.
Whi
I could offer you a net3380 usb gadget device (mini pcie or pcie) but
the uPD720200 is my notebook, so I cannot afford an extra one for you
:)
On Mon, Sep 1, 2014 at 2:25 PM, Mathias Nyman
wrote:
> On 09/01/2014 02:19 PM, Ricardo Ribalda Delgado wrote:
>> Do you have a NEC/Renesas uPD7
Hello Felipe
I think that you have forgotten about this patch :). It is needed by
usb3380 in usb3.0 mode. Otherwise the device keeps reseting.
Thanks!
On Tue, Aug 26, 2014 at 6:00 PM, Ricardo Ribalda Delgado
wrote:
> Without this patch, some hosts keep restarting indefinitely the tar
Do you have a NEC/Renesas uPD720200 USB 3.0 Host?
If so, try with an usb gadget acting as a mass storage. That hits the
bug in my machine.
Regarsd!
On Mon, Sep 1, 2014 at 1:12 PM, Mathias Nyman wrote:
> On 09/01/2014 01:26 PM, Ricardo Ribalda Delgado wrote:
>> Well, it is hard to
:36 PM, Ricardo Ribalda Delgado wrote:
>> After some time of use (one hour or so) my system started to behave
>> "weird". I did check dmesg and I was receiving the following line
>> again and again:
>>
>> usb-storage: Error in queuecommand_lck: us->sfb= f
:S
On Mon, Sep 1, 2014 at 11:02 AM, Ricardo Ribalda Delgado
wrote:
> Hello
>
> The promised dmesg output. Still some "xhci_drop_endpoint called with..."
>
> Thanks!
>
> Sep 1 10:52:00 neopili kernel: [ 193.123108] usb 2-2: new SuperSpeed
> USB device number 2
i kernel: [ 224.926336] sd 6:0:0:0: [sdb] Mode
Sense: 00 00 00 00
On Fri, Aug 29, 2014 at 5:20 PM, Mathias Nyman wrote:
> On 08/28/2014 06:09 PM, Ricardo Ribalda Delgado wrote:
>> Sure, but the hw leaves my desk until next monday in 30 minutes.
>>
>> So unless you s
Sure, but the hw leaves my desk until next monday in 30 minutes.
So unless you send the patch right now you will have to wait for
results until next Monday
Thanks!
On Thu, Aug 28, 2014 at 5:20 PM, Mathias Nyman wrote:
> On 08/28/2014 03:36 PM, Ricardo Ribalda Delgado wrote:
>> Hell
5.6: usbfs: process 1521 (pool) did not claim
interface 0 before use
[ 160.471327] pool[1680]: segfault at fc0e61c0 ip
7f570f036200 sp 7f570639f0d0 error 5 in
libc-2.19.so[7f570efee000+19f000]
Thanks!
On Thu, Aug 28, 2014 at 12:50 PM, Ricardo Ribalda Delgado
wrote:
> Hello
>
Hello
On Thu, Aug 28, 2014 at 12:41 PM, Mathias Nyman wrote:
> On 08/27/2014 07:10 PM, Ricardo Ribalda Delgado wrote:
>> Perhaps we could apply both patches to current tree and backport mine
>> to older kernels?
>>
>
> The already applied patch fixes many othe
Hello Greg
>>
>> Not many drivers define the pci interface and there is no other driver
>> that has the same vendor and product id. Therefore I see no hurt in
>> adding both patches, one to make the driver broader, and another to
>> fix pci-sysfs.
>>
>> Also, the change on pci-sysfs might affect
Hello Greg
On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
wrote:
> On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
>> Defining the vendor and the product id should be enough to discriminate
>> the device.
>>
>> The reason for th
Perhaps we could apply both patches to current tree and backport mine
to older kernels?
On Wed, Aug 27, 2014 at 5:27 PM, Mathias Nyman wrote:
> On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote:
>> At least I have seen the issue on Debian 3.14 and 3.16. Is your patch
>&
Hello
Is somebody using/supporting g_webcam?
The only reference userland server is uvc-gadget from
http://git.ideasonboard.org/?p=uvc-gadget.git;a=summary ?
I have an industrial fpga camera that speaks v4l2, my plan is to
export it as an uvc camera via usb3380 as a debug interface.
Thanks!
--
At least I have seen the issue on Debian 3.14 and 3.16. Is your patch
going to be backported to linux-stable? The computer crashes very very
badly
On Wed, Aug 27, 2014 at 4:25 PM, Mathias Nyman wrote:
> On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote:
>> While testing a usb
in lowercase.
This means that some implementations modprobe will fail to load the
driver.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
Without this patch, some hosts keep restarting indefinitely the target.
Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)
Signed-off-by: Ricardo Ribalda Delgado
---
v2: Request by Felipe Balbi
Use Fixes: on commit message
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion
Without this patch, some hosts keeps restarting indefinitely the target.
Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget:
net2280: Code Cleanup
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
:0e:00.0: WARN
Cannot submit Set TR Deq Ptr
Aug 26 17:34:37 neopili kernel: [ 4767.480504] xhci_hcd :0e:00.0: WARN deq
seg = (null), deq pt = 8805516d7800
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/host/xhci-ring.c | 3 ++-
1 file changed, 2 insertions(+), 1
Hello
When I connect a usb gadget mass storage to my laptop the whole system
crashes. It seems that the bug happens when the gadget/host
initialize a reset.
I lose all control to the computer, and the only way to recover
control is rebooting it via powerbutton.
Kernel that does not work: 3.14 3
wrote:
> On Mon, 2014-08-04 at 11:20 +0200, Ricardo Ribalda Delgado wrote:
>> Suggested-by: Dan Williams
>
> Before we apply this patch though, can you grab for the following for
> me?
>
> cat /sys/class/tty/*/hsotype
>
> and lets see if the firmware actually responds
Suggested-by: Dan Williams
On Mon, Aug 4, 2014 at 11:11 AM, Ricardo Ribalda Delgado
wrote:
> After this patch:
>
> [ 32.985530] hso: drivers/net/usb/hso.c: Option Wireless
> [ 33.000452] hso 2-1.4:1.7: Not our interface
> [ 33.001849] usbcore: registered new interface driver hso
Hello Dan
>
> Are you 100% sure these don't go into the 'hso' driver? 'option' is
> used for mostly older Option devices (like 5+ years old). I tried to
> find information about this module, and the closest I could come for
> 0af0:9200 was:
>
> http://trac.gateworks.com/wiki/3g
>
> which indicat
Vendor Specific Class
bDeviceSubClass 255 Vendor Specific Subclass
bDeviceProtocol 255 Vendor Specific Protocol
bMaxPacketSize064
bNumConfigurations 1
Device Status: 0x0001
Self Powered
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/net/usb/hso.c | 1 +
1
255 Vendor Specific Subclass
bDeviceProtocol 255 Vendor Specific Protocol
bMaxPacketSize064
bNumConfigurations 1
Device Status: 0x0001
Self Powered
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/serial/option.c | 2 ++
1 file changed, 2 insertions(+)
diff
My fault. Thank you very much for reporting it. I have just posted the patch
Regards
On Fri, Jul 4, 2014 at 9:37 AM, Paul Bolle wrote:
> Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
> included in today's linux-next (ie, next-20140704).
>
> It contains this odd chunk:
>
Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function")
includes a editing mistake on one of the #ifdef.
This patch fixes it.
Reported-by: Paul Bolle
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Hello Felipe
Any comment on this patchset? Shall I resend it rebased on v3.16-rc2?
Regards
On Tue, Jun 10, 2014 at 10:19 PM, Ricardo Ribalda Delgado
wrote:
> Ping...
>
> On Tue, May 20, 2014 at 6:30 PM, Ricardo Ribalda Delgado
> wrote:
>> The USB 3380 is a PCI Expres
Ping...
On Tue, May 20, 2014 at 6:30 PM, Ricardo Ribalda Delgado
wrote:
> The USB 3380 is a PCI Express Gen 2 to USB 3.0 SuperSpeed Peripheral
> Controller. It shares a lot functionatily with the net228x family.
>
> This series of patches includes some resend of previous patches
Driver was using custom functions WARNING, ERROR, DEBUG, instead of
pr_err, pr_dgb...
New ep_* macros have been created that use standard pr_* functions.
Signed-off-by: Ricardo Ribalda Delgado
---
v2: Comment by Joe Perches and Alan Stern
-Use ep_* instead of custom DETDEV macro
drivers
Instead of using magic numbers use #defines
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 68 +++-
drivers/usb/gadget/net2280.h | 1 +
2 files changed, 36 insertions(+), 33 deletions(-)
diff --git a/drivers/usb/gadget/net2280
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index b43725a..bd851de 100644
--- a/drivers/usb/gadget/net2280.c
+++ b
Improves readability of the code
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 572 +--
drivers/usb/gadget/net2280.h | 65 ++---
2 files changed, 318 insertions(+), 319 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b
For bool variables
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 5b9368d..b43725a 100644
--- a/drivers/usb/gadget/net2280.c
Ricardo Ribalda Delgado (10):
usb: gadget: net2280: Add support for PLX USB338X
usb: gadget: net2280: Dont use magic numbers
usb: gadget: net2280: Use BIT() macro
usb: gadget: net2280: Use true/false instead of 1/0
usb: gadget: net2280: Use module_pci_driver macro
usb: gadget: net2280
Replace a long and ugly expresion with an already available function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index bd851de
- Move logical continuations to end of line
- Improve spacing
Signed-off-by: Ricardo Ribalda Delgado
---
v2: Comments by Alan Stern
-Use octal notation istead of S_I
drivers/usb/gadget/net2280.c | 155 +--
drivers/usb/gadget/net2280.h | 4 +-
2
Use of quirks improve readability and will be easier to add new devices
to this driver.
Suggested-by: Alan Stern
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 83 +++-
drivers/usb/gadget/net2280.h | 6
2 files changed
t mind implementing it, but please as
a follow-up patch, since there are 8 patches depending on this :)
Regards!
On Tue, May 20, 2014 at 4:21 PM, Alan Stern wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
>
>> Instead of using magic numbers use #defines
>>
>
Not for grep...
But if this is an issue I have no problem going back to the original.
We can spend a whole year just talking about codestyle.
On Tue, May 20, 2014 at 10:52 AM, David Laight wrote:
> From: Alan Stern
> ...
>> > -static struct usb_request *
>> > -net2280_alloc_request (struct usb
Hello
I have just realized that I havent moved the changleg information
under the tear line. I will resend the patchset with this fixed once I
have received comments about this patchset.
Sorry and thanks for your patience.
On Mon, May 19, 2014 at 11:20 PM, Ricardo Ribalda Delgado
wrote
The USB 3380 is a PCI Express Gen 2 to USB 3.0 SuperSpeed Peripheral
Controller. It shares a lot functionatily with the net228x family.
This series of patches includes some resend of previous patches.
Please check the changelog for every patch.
Ricardo Ribalda Delgado (9):
usb: gadget
For bool variables
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 5b9368d..b43725a 100644
--- a/drivers/usb/gadget/net2280.c
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index b43725a..bd851de 100644
--- a/drivers/usb/gadget/net2280.c
+++ b
Driver was using custom functions WARNING, ERROR, DEBUG, instead of
pr_err, pr_dgb...
New ep_* macros have been created that use standard pr_* functions.
v2: Comment by Joe Perches and Alan Stern
-Use ep_* instead of custom DETDEV macro
Signed-off-by: Ricardo Ribalda Delgado
---
drivers
Instead of using magic numbers use #defines
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 68 +++-
drivers/usb/gadget/net2280.h | 1 +
2 files changed, 36 insertions(+), 33 deletions(-)
diff --git a/drivers/usb/gadget/net2280
Replace a long and ugly expresion with an already available function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index bd851de
Improves readability of the code
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 572 +--
drivers/usb/gadget/net2280.h | 65 ++---
2 files changed, 318 insertions(+), 319 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b
- Move logical continuations to end of line
- Improve spacing
v2: Comments by Alan Stern
-Use octal notation istead of S_I
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 155 +--
drivers/usb/gadget/net2280.h | 4 +-
2
Good idea.
I am going to define ep_* and use them.
btw, DEBUG cannot be used if not unset, because there is a namespace collision.
Regards!
On Mon, May 19, 2014 at 10:29 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 16:17 -0400, Alan Stern wrote:
>> On Mon, 19 May 2014, Ricard
014, Ricardo Ribalda Delgado wrote:
>
>> Driver was using custom functions WARNING, ERROR, DEBUG, instead of
>> pr_err, pr_dgb...
>
> What's wrong with that, and why bother to change it?
>
>> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
>
Hello Alan
I am trying to be consistent around the file. On a previous patch I
was asked to move the operators at the end. I did so, and now I am
modifying the file to look alike.
On Mon, May 19, 2014 at 9:43 PM, Alan Stern wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wr
Hello Joe
OK, then I will use dev_vdbg. Thanks!
On Mon, May 19, 2014 at 9:42 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 21:33 +0200, Ricardo Ribalda Delgado wrote:
>> I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
>> replaced it with dev_dbg.
>>
Hello Alan
What about using octal notation in all the file and merge the patch
with the other big patch of the series? I am trying to have some
consistency in the file :)
Thanks!
On Mon, May 19, 2014 at 9:30 PM, Alan Stern wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wr
Hello Joe
I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
replaced it with dev_dbg.
But if you prefer to use dev_dbg, I will modify it to use dev_dbg
Thanks!
On Mon, May 19, 2014 at 9:16 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 21:11 +0200, Ricardo Ribalda Delg
10 patches, only
the new ones.
Ricardo Ribalda Delgado (5):
usb: gadget: net2280: Refactor queues_show
usb: gadget: net2280: Use S_I macros
usb: gadget: net2280: Pass checkpacth.pl test
usb: gadget: net2280: Code Cleanup
usb: gadget: net2280: Use pr_* function
drivers/usb/gadget
Instead of octal notation, to be consistent around the file.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index c3205ec..5b2ab68 100644
1 - 100 of 115 matches
Mail list logo
