Re: [PATCH V5] USB: Increment wakeup count on remote wakeup.

2018-04-21 Thread Ravi Chandra Sadineni
Sure. Pushing it to the older kernels will definitely help. Thanks, Ravi On Sat, Apr 21, 2018 at 1:59 AM, Greg KH wrote: > On Fri, Apr 20, 2018 at 11:08:21AM -0700, Ravi Chandra Sadineni wrote: >> On chromebooks we depend on wakeup count to identify the wakeup source. >> Bu

Re: [PATCH V3] USB: Increment wakeup count on remote wakeup.

2018-04-20 Thread Ravi Chandra Sadineni
On Fri, Apr 20, 2018 at 10:29 AM, Alan Stern wrote: > On Fri, 20 Apr 2018, Ravi Chandra Sadineni wrote: > >> On chromebooks we depend on wakeup count to identify the wakeup source. >> But currently USB devices do not increment the wakeup count when they >> trigger the

[PATCH V5] USB: Increment wakeup count on remote wakeup.

2018-04-20 Thread Ravi Chandra Sadineni
Notification to the host (USB3.0 spec section 8.5.6.4) Thus on receiving the Function Wake, increment the wakeup count. Signed-off-by: Ravi Chandra Sadineni --- V5: Added the description of changes between different versions of patches. V4: Moved the wakeup count increment logic to the existing if which is

[PATCH V4] USB: Increment wakeup count on remote wakeup.

2018-04-20 Thread Ravi Chandra Sadineni
Notification to the host (USB3.0 spec section 8.5.6.4) Thus on receiving the Function Wake, increment the wakeup count. Signed-off-by: Ravi Chandra Sadineni --- drivers/usb/core/hcd.c | 1 + drivers/usb/core/hub.c | 10 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb

Re: [PATCH V2] USB: Increment wakeup count on remote wakeup.

2018-04-20 Thread Ravi Chandra Sadineni
On Fri, Apr 20, 2018 at 7:12 AM, Alan Stern wrote: > On Thu, 19 Apr 2018, Ravi Chandra Sadineni wrote: > >> On chromebooks we depend on wakeup count to identify the wakeup source. >> But currently USB devices do not increment the wakeup count when they >> trigger the

[PATCH V3] USB: Increment wakeup count on remote wakeup.

2018-04-20 Thread Ravi Chandra Sadineni
Notification to the host (USB3.0 spec section 8.5.6.4) Thus on receiving the Function Wake, increment the wakeup count. Signed-off-by: Ravi Chandra Sadineni --- drivers/usb/core/hcd.c | 2 ++ drivers/usb/core/hub.c | 10 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb

Re: [PATCH] USB: Increment wakeup count on remote wakeup.

2018-04-19 Thread Ravi Chandra Sadineni
Hi Alan, Thanks for reviewing the change. Appreciate your time. I tried to address your comments in the V2 of the patch. On Thu, Apr 19, 2018 at 8:01 AM, Alan Stern wrote: > On Wed, 18 Apr 2018, Ravi Chandra Sadineni wrote: > >> On chromebooks we depend on wakeup count to identif

[PATCH V2] USB: Increment wakeup count on remote wakeup.

2018-04-19 Thread Ravi Chandra Sadineni
Notification to the host (USB3.0 spec section 8.5.6.4) Thus on receiving the Function Wake, increment the wakeup count. Signed-off-by: Ravi Chandra Sadineni --- drivers/usb/core/hcd.c | 2 ++ drivers/usb/core/hub.c | 10 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH] USB: Increment wakeup count on remote wakeup.

2018-04-18 Thread Ravi Chandra Sadineni
On chromebooks we depend on wakeup count to identify the wakeup source. But currently USB devices do not increment the wakeup count when they trigger the remote wake. This patch addresses the same. Resume condition is reported differently on USB 2.0 and USB 3.0 devices. On USB 2.0 devices, a wake