On Thu, 21 Feb 2019, Greg KH wrote:
> On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote:
> > On Thu, 21 Feb 2019, Greg KH wrote:
> >
> > > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote:
> > > > On Wed, 20 Feb 2019, Greg
On Thu, 21 Feb 2019, Greg KH wrote:
> On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote:
> > On Wed, 20 Feb 2019, Greg KH wrote:
> >
> > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote:
> > > > From: Jean-Philippe Menil
>
On Wed, 20 Feb 2019, Greg KH wrote:
> On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote:
> > From: Jean-Philippe Menil
> >
> > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing
> > prototype for xhci_free_virt_devices_depth_fir
Fix build warning when building drivers/usb/host/xhci-mem.o due to missing
prototype for xhci_free_virt_devices_depth_first.
This function is only used in xhci-mem.c so just make it static.
Signed-off-by: Jean-Philippe Menil
---
drivers/usb/host/xhci-mem.c | 2 +-
1 file changed, 1 insertion
On Sat, Dec 23, 2017 at 8:52 AM, Lu Baolu wrote:
> Update the xhci dbc files with the correct SPDX license identifiers.
>
> Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
> Cc: Philippe Ombredanne
> Signed-off-by: Lu Baolu
> ---
> changes
> * xhci-dbgcap.h - xHCI debug capability support
> *
> diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c
> index 8d47b6f..033cc0e 100644
> --- a/drivers/usb/host/xhci-dbgtty.c
> +++ b/drivers/usb/host/xhci-dbgtty.c
> @@ -1,3 +1,4 @@
> +// SPDX-Lic
rk properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller"
> Cc: Andreas Kemnade
> Cc: Johan Hovold
> Reported-by: Philippe Ombredanne
> Signed-off-by: Greg Kroah-Hartman
Reviewed-by: Philippe Ombredanne
--
Cordially
P
On Sun, Nov 5, 2017 at 2:51 PM, Greg Kroah-Hartman
wrote:
> On Sun, Nov 05, 2017 at 01:53:54PM +0100, Philippe Ombredanne wrote:
>> On Sat, Nov 4, 2017 at 11:40 AM, Greg Kroah-Hartman
>> wrote:
>> > On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote:
>> &g
rthand, which can be used
>> > instead of the full boiler plate text.
>> >
>> > This work is based on a script and data from Thomas Gleixner, Philippe
>> > Ombredanne, and Kate Stewart.
>> >
>> > Cc: Thomas Gleixner
>> > Cc: Kate Stewart
>
to
>> > audit the kernel tree for correct licenses. This patch adds these
>> > identifiers to all files in drivers/usb/ based on a script and data from
>> > Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
>> >
>> > Cc: Thomas Gleixner
>>
us on GPL first, ignoring BSD/MIT for now
- only take out unambiguous boilerplate that is matched exactly
- and only take it out if there a proper and corresponding
license identifier already there, or add one otherwise
[0] https://github.com/nexB/scancode-toolkit
--
Cordially
Philippe Omb
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/pegasus.c | 14 --
1 files
|set}_settings.
Philippe Reynes (11):
net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings
net: usb: smsc95xx: use new api ethtool_{get|set}_link_ksettings
net: usb: sr9800: use new api ethtool_{get|set}_link_ksettings
net: usb: cdc_ncm: use new api ethtool_{get|set}_link_ksettings
The ethtool api {get|set}_settings is deprecated.
We add the new api {get|set}_link_ksettings to this driver.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/usbnet.
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/cdc_ncm.c |4 ++--
1 files changed, 2
The function usbnet_{get|set}_settings is no longer used,
so we remove it.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/usbnet.c | 35 ---
include/linux/usb/usbnet.h |4
2 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/drivers
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/asix_devices.c | 12 ++--
1 files
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/sr9700.c |4 ++--
1 files changed, 2
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/sierra_net.c |4 ++--
1 files
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/smsc75xx.c |4 ++--
1 files changed, 2
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/mcs7830.c |4 ++--
1 files changed, 2
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/smsc95xx.c | 24 ---
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/sr9800.c |4 ++--
1 files changed, 2
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/dm9601.c |4 ++--
1 files changed, 2
Hi Chris,
On 3/13/17, Chris Roth wrote:
> I can test it tomorrow. I'll pull a clean copy of 4.10.2, or do you
> suggest a different version than that?
I think that 4.10.2 is fine, there are no change on this driver
between 4.10 and git (net-next).
Thanks a lot for the test.
> C
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/rtl815
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/r8152.c | 21 -
1 fil
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/catc.c | 31 ++
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/ax88179_178a.c | 14 --
1 fil
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/lan78xx.c | 70 +---
1 files changed, 40 insertions(+), 30 deletions(-)
diff --git a/drivers
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/ax88172a.c | 22 ++
1 files changed, 2 insertions(+), 20 deletions(-)
diff --git a
, 3.17.
I hope i was finally able do disable line-wrapping...
Signed-off-by: Philippe Prédhomme
diff -git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -362,6 +362,8 @@
#define USB_VENDOR_ID_GREENASIA0x0e8f
#define
.
Signed-off-by: Philippe Prédhomme
diff -git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -362,6 +362,8 @@
#define USB_VENDOR_ID_GREENASIA 0x0e8f
#define USB_DEVICE_ID_GREENASIA_DUAL_USB_JOYPAD 0x3013
+#define
.
Signed-off-by: Philippe Prédhomme
diff -git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -362,6 +362,8 @@
#define USB_VENDOR_ID_GREENASIA0x0e8f
#define USB_DEVICE_ID_GREENASIA_DUAL_USB_JOYPAD0x3013
+#define
get/legacy/hid.c
drivers/usb/gadget/epautoconf.c:23:26: erreur fatale: gadget_chips.h :
Aucun fichier ou dossier de ce type
This compilation line include :
/buildroot/driver/usb/gadget
but the real path is :
/buildroot/output/build/linux-3.17-rc1/driver/usb/gadget
Signed-off-by: Philippe Reyne
Hi Fabio,
On 16/08/14 18:01, Fabio Estevam wrote:
Hi Philippe,
On Sat, Aug 16, 2014 at 12:38 PM, Philippe Reynes wrote:
Hi all,
i.MX27's usb needs three clocks (usb_ipg_gate, usb_ahb_gate and usb_div)
but the current chipidea driver implementation, and devicetree, provides
only ipg an
d a second, optionnal, clock in ci_hdrc_imx.c
with 'per' name in devicetree and to add clock name 'main_clk' for mandatory
clock.
This approach it correct? Or an other approach seems better?
Thank you very much for your point of
to me.
Excellent! Will update those comments and resend later.
Thanks,
Philippe
This patch series fixes a number of issues found with coverity in
libusbg
A pull request has also be made:
https://github.com/libusbg/libusbg/pull/4
This is the second version where we use a different fix for the
rea
Avoid calling usbg_read_string with a 40 byte long buffer, which in turn is
filled in
by usbg_read_buf which uses a maximum of USBG_MAX_STR_LENGTH which is 256 bytes.
Signed-off-by: Philippe De Swert
---
src/usbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usbg.c
We check if func is NULL, so if the allocation function failed we should
not dereference or handle it anymore, so we jump straight to the end.
Signed-off-by: Philippe De Swert
---
src/usbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/usbg.c b/src/usbg.c
index 66aa435..8ad6a9e
We probably need to check if we get valid attributes passed. Otherwise we will
try to dereference a NULL-pointer as the usb_config_attr will not be valid.
Signed-off-by: Philippe De Swert
---
src/usbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usbg.c b/src/usbg.c
Readlink can return the total length of the buffer (here 4096), so we do not
want to dereference target[4096] as that would give an off by one error.
Signed-off-by: Philippe De Swert
---
src/usbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usbg.c b/src/usbg.c
index
missed first time around.
Philippe De Swert (4):
libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129
libusbg: Fix buffer overrun issue. CID#56128
libusbg: Do not try to dereference func when it is NULL. CID#56127
libusbg: Do not dereference usb config attributes when they are
it would be good to double-check.
Cheers,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 12/05/14 09:58, Krzysztof Opasiak wrote:
Avoid calling usbg_read_string with a 40 byte long buffer, which in
turn is filled in
by usbg_read_buf which uses a maximum of USBG_MAX_LENGTH which is
256 bytes.
Signed-off-by: Philippe De Swert
---
src/usbg.c | 2 +-
1 file changed, 1
ke happens with 4097 instead of 4096. Although just adding the byte
seems a bit overkill to me.
Maybe it is just better to read 4095 bytes so we have room for the '\0'.
So only do nmb = readlink(bpath, target, sizeof(target - 1)); As I guess
that the kernel uses a USBG_MAX_PATH_LE
and expose it in
some way? As in this case I cannot short-cut it by using a power_supply
class type of device. And just to be sure I would like to find a way
that would be acceptable upstream.
Cheers,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" i
Hi,
When using the USB serial gadget it regularly occurs that USB packets
arrive at the host in the wrong order. I am using kernel version 3.4
with the corresponding RT patch on an ARM Cortex-A8 platform.
The problem appears to be in file 'drivers/usb/gadget/u_serial.c'.
It seems that kernel thr
Alan Stern for suggesting the correct test in this case.
Found with coverity: CID 744367, CID 145679
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/ga
the correct one this time.
The second patch should now finally have the correct test.
Thank you Alan for your patience, I should really not make patches late at
night.
Philippe De Swert (2):
usb:gadget:dummy_hcd : Avoid infinite loop
usb:gadget:dummy_hcd : Detect port and link state
do so. We need to decrement first because the
adding at the current
index of i is the one that failed.
At the same time the code is harmonized for hcd platform adding.
Found with coverity : CID 751073
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 8 +++-
1 f
DED
check in, but it might not be needed. I can update that if needed.
Thank you.
Philippe De Swert (2):
usb:gadget:dummy_hcd : Avoid infinite loop
usb:gadget:dummy_hcd : Detect port and link state correctly to avoid
unreachable code
drivers/usb/gadget/dummy_hcd.c | 14 +-
for suggesting the correct test in this case.
Found with coverity: CID 744367, CID 145679
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
i
do so. We need to decrement first because the
adding at the current
index of i is the one that failed.
At the same time the code is harmonized for hcd platform adding.
Found with coverity : CID 751073
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 8 +++-
1 f
S_U0.
Found with coverity: CID 744367, CID 145679
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 5c506fb..22cd01c 100644
--- a/drivers
These two patches fix some minor issues in the dummy_hcd driver. Both
errors were detected with the help of coverity analysis.
Philippe De Swert (2):
usb:gadget:dummy_hcd : Avoid infinite loop
usb:gadget:dummy_hcd : Detect port and link state correctly to avoid
unreachable code
drivers
so. We decrement first because the adding at
the current
index of i is the one that failed.
Found with coverity : CID 751073
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/dummy_hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.
e hex number is a language identifier, as
specified by the USB Interface Forum:
http://www.usb.org/developers/docs/
(see the paragraph near the end about LANGID codes).
Of course! I just never looked deep enough into that.
The strings are not USB identifiers; they are USB descriptors.
Tr
The documentation for the USB gadget fs is actually in
Documentation/usb/gadget_configfs.txt.
Signed-off-by: Philippe De Swert
---
drivers/usb/gadget/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 8e93683
string as identifier. Are we rather talking about one of the USB
identifiers here?
The rest seems to be pretty clear so I'll start playing around with it.
Thanks,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to major
Hi,
On 12/08/13 21:08, Felipe Balbi wrote:
On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote:
Some bad gadget drivers do not check the return status of usb_add_config.
fix the gadget driver
As stated in my comment (see below) that is indeed what should happen.
But we
argued that the faulty gadget driver should be fixed, but imho it is better
to avoid crashing the kernel and letting the gadget developer know he/she
is making a mistake. And have the developer of said gadget driver then fix
the problem of course.
Signed-off-by: Philippe De Swert
---
drivers/usb
Hello,
On Fri, May 24, 2013 at 09:46:32AM -0400, Alan Stern wrote:
> On Fri, 24 May 2013, Philippe De Muyter wrote:
>
> > On Thu, May 23, 2013 at 08:31:18AM -0700, Greg Kroah-Hartman wrote:
> > > On Thu, May 23, 2013 at 03:07:09PM +0200, Philippe De Muyter
On Thu, May 23, 2013 at 08:31:18AM -0700, Greg Kroah-Hartman wrote:
> On Thu, May 23, 2013 at 03:07:09PM +0200, Philippe De Muyter wrote:
> > Hi all,
> >
> > I have a lot of linux computers equipped with a GlobalSat Br-353 GPS
> > receiver,
> > which is connec
some usefull debugging about the USB polling for this serial line ?
Thanks in advance
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2013/4/8 Laurent Pinchart :
> Hi Jean-Philippe,
>
> On Wednesday 06 March 2013 14:21:14 jean-philippe francois wrote:
>> Hi,
>>
>> The company I work for is doing USB cameras, for which
>> I wrote the drivers (out of tree).
>
> Just out of curiosit
2013/3/12 jean-philippe francois :
> 2013/3/12 jean-philippe francois :
>> 2013/3/12 Sarah Sharp :
>>> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote:
>>>> Hi,
>>>>
>>>> The company I work for is doing USB ca
2013/3/12 jean-philippe francois :
> 2013/3/12 Sarah Sharp :
>> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote:
>>> Hi,
>>>
>>> The company I work for is doing USB cameras, for which I wrote the
>>> drivers (out of tree).
>>
2013/3/12 Sarah Sharp :
> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote:
>> Hi,
>>
>> The company I work for is doing USB cameras, for which I wrote the
>> drivers (out of tree).
>
> Kernel driver or userspace driver?
>
Kernel driver.
asmedia ASM1042.
Please find attached the dmesg output, and the output of lsusb -v for
the device.
This is with 3.8.2 opensuse Kernel Of The Day
Regards,
Jean-Philippe François
PS : I am not subscribed to the list, can I be cc'ed in the reply ?
Bus 003 Device 002: ID 17db:9195
D
Kernel reports a section mismatch when compiling in musb drivers.
This patch fixes that.
Signed-off-by: Philippe De Swert
---
drivers/usb/musb/musb_dma.h |2 +-
drivers/usb/musb/musbhsdma.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb
: Philippe De Swert
---
drivers/usb/musb/musb_core.c | 31 ++-
drivers/usb/musb/musbhsdma.h |4
drivers/usb/musb/omap2430.c | 22 ++
drivers/usb/musb/ux500.c | 22 ++
4 files changed, 46 insertions(+), 33 deletions
Hi all,
On 26/09/2012, Philippe De Swert wrote:
> Hi,
>
>>On Tue, Sep 25, 2012 at 2:39 PM, Philippe De Swert
>>>> Then maybe it's best to just remove the ifdefs and always provide
>>>> generic_interrupt() ?
>
Hi,
>On Tue, Sep 25, 2012 at 2:39 PM, Philippe De Swert
>>> Then maybe it's best to just remove the ifdefs and always provide
>>> generic_interrupt() ?
>>>
>>> Anyone against it ?
>
>Providing generic_inter
tion?
>
> Then maybe it's best to just remove the ifdefs and always provide
> generic_interrupt() ?
>
> Anyone against it ?
Well it seems there are only two drivers that use it omap2430 and
ux500. Maybe we somehow link it to the drivers that need it? (I might
have missed other dri
x.c: musb->isr = da8xx_musb_interrupt;
drivers/usb/musb/am35x.c: musb->isr = am35x_musb_interrupt;
Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
76 matches
Mail list logo
