[PATCH] smsc95xx: use ethtool_op_get_ts_info()

2017-07-13 Thread Petr Kulhavy
ethtool_op_get_ts_info() as get_ts_info() also the SOF_TIMESTAMPING_TX_SOFTWARE is announced. Signed-off-by: Petr Kulhavy --- drivers/net/usb/smsc95xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 2dfca96..340c134 100644 --- a

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

2016-04-04 Thread Petr Kulhavy
On 15.03.2016 03:07, David Lechner wrote: On 03/14/2016 02:00 AM, Felipe Balbi wrote: Hi, why isn't this an actual clock phandle ? Driver could, then, use clk_get_rate() to figure this one out. You could just use a fixed clock here to satisfy the clock API. I've actually been working on g

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-19 Thread Petr Kulhavy
On 11.03.2016 19:24, Sergei Shtylyov wrote: On 03/11/2016 07:21 PM, Petr Kulhavy wrote: I am having 2nd thought on parsing the clock prop, Sergei's comment might be better. I will look more on this over this weekend. (DT is not in my expertise...) Regards, -Bin. I like Sergei's

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-11 Thread Petr Kulhavy
On 11.03.2016 17:06, Bin Liu wrote: Hi, On Fri, Mar 11, 2016 at 04:58:52PM +0100, Petr Kulhavy wrote: On 11.03.2016 16:51, Bin Liu wrote: Hi, On Fri, Mar 11, 2016 at 09:29:45AM +0100, Petr Kulhavy wrote: DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. It seems the dts(i

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-11 Thread Petr Kulhavy
On 11.03.2016 16:51, Bin Liu wrote: Hi, On Fri, Mar 11, 2016 at 09:29:45AM +0100, Petr Kulhavy wrote: DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. It seems the dts(i) file is not touched in this patch set, so DA8xx MUSB still does not use DT with these patches? Or did I

[PATCH 2/5 v10] usb: musb: core: added helper function for parsing DT

2016-03-11 Thread Petr Kulhavy
This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb_get_power() : added missin

[PATCH 5/5 v10] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-11 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy --- v1: v2: - using standard MUSB properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-

[PATCH 4/5 v10] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY

2016-03-11 Thread Petr Kulhavy
Only few MUSB PHY reference clock frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: v7: v8: v9: v10: include/linux

[PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-11 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- v1: v2: - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti,"

[PATCH 3/5 v10] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-03-11 Thread Petr Kulhavy
content of the config. Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: - whitespace formatting corrected v7: v8: v9: v10: drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files

Re: [PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-10 Thread Petr Kulhavy
On 09.03.2016 12:53, Sergei Shtylyov wrote: Hello. On 3/9/2016 12:25 PM, Petr Kulhavy wrote: This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy [...] diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c

Re: [PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-10 Thread Petr Kulhavy
On 09.03.2016 21:00, Bin Liu wrote: Hi, On Wed, Mar 09, 2016 at 10:25:27AM +0100, Petr Kulhavy wrote: +static inline int get_phy_refclk_cfg(struct device_node *np) +{ + u32 freq; + + if (of_property_read_u32(np, "ti,usb2-phy-refclock-hz", &freq)) +

[PATCH 4/5 v9] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY

2016-03-09 Thread Petr Kulhavy
Only few MUSB PHY reference clock frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: v7: v8: v9: include/linux

[PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-09 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy --- v1: v2: - using standard MUSB properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-

[PATCH 3/5 v9] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-03-09 Thread Petr Kulhavy
content of the config. Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: - whitespace formatting corrected v7: v8: v9: drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3

[PATCH 2/5 v9] usb: musb: core: added helper function for parsing DT

2016-03-09 Thread Petr Kulhavy
This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb_get_power() : added missing boundary check for the max

[PATCH 1/5 v9] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-09 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- v1: v2: - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti,"

Re: [PATCH 5/5 v8] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-08 Thread Petr Kulhavy
On 07.03.2016 18:56, Sergei Shtylyov wrote: On 03/07/2016 07:08 PM, Petr Kulhavy wrote: Hello On 07.03.2016 14:29, Sergei Shtylyov wrote: Hello. On 3/7/2016 2:20 PM, Petr Kulhavy wrote: @@ -544,17 +643,25 @@ static int da8xx_probe(struct platform_device *pdev) pinfo.data = pdata

Re: [PATCH 5/5 v8] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-07 Thread Petr Kulhavy
Hello On 07.03.2016 14:29, Sergei Shtylyov wrote: Hello. On 3/7/2016 2:20 PM, Petr Kulhavy wrote: @@ -544,17 +643,25 @@ static int da8xx_probe(struct platform_device *pdev) pinfo.data = pdata; pinfo.size_data = sizeof(*pdata); +ret = regulator_enable(glue->vbus_sup

[PATCH 1/5 v8] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-07 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- v1: v2: - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti,"

[PATCH 5/5 v8] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-07 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy Acked-by: Sergei Shtylyov --- v1: v2: - using standard MUSB properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoi

[PATCH 2/5 v8] usb: musb: core: added helper function for parsing DT

2016-03-07 Thread Petr Kulhavy
This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb_get_power() : added missing boundary check for the max

[PATCH 4/5 v8] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY

2016-03-07 Thread Petr Kulhavy
Only few MUSB PHY reference clock frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: v7: v8: include/linux/platform_data

[PATCH 3/5 v8] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-03-07 Thread Petr Kulhavy
content of the config. Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: - whitespace formatting corrected v7: v8: drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-29 Thread Petr Kulhavy
On 26.02.2016 15:23, Bin Liu wrote: Hi, On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: Well, so we're still at the same point - there is a fundamental mismatch in the diff

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-26 Thread Petr Kulhavy
On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: Well, so we're still at the same point - there is a fundamental mismatch in the different developers' view how the "power" parameter should be represented. There already 3 op

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-25 Thread Petr Kulhavy
On 25.02.2016 12:53, Sergei Shtylyov wrote: I then fail to understand the logic behind hard coding. And I fail to understand your plans with the other drivers. Are you trying to say that the "mentor,power" (or "power" in OMAP2430) property should be completely abandoned and the values hard

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-25 Thread Petr Kulhavy
On 24.02.2016 18:30, Sergei Shtylyov wrote: On 02/24/2016 08:10 PM, Petr Kulhavy wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-24 Thread Petr Kulhavy
On 24.02.2016 18:00, Sergei Shtylyov wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data + * + * in case the property is not found returns 0 + */ +extern u8 musb_

[PATCH 5/5 v7] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-02-24 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy Acked-by: Sergei Shtylyov --- v1: v2: - using standard MUSB properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoi

[PATCH 3/5 v7] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-02-24 Thread Petr Kulhavy
content of the config. Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov --- v5: v6: - whitespace formatting corrected v7: drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions

[PATCH 4/5 v7] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY

2016-02-24 Thread Petr Kulhavy
Only few MUSB PHY reference clock frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov --- v5: v6: v7: include/linux/platform_data/usb-davinci.h | 6 ++ 1

[PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-24 Thread Petr Kulhavy
This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_get_mode() Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb

[PATCH 1/5 v7] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-24 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- v1: v2: - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti,"

Re: [PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-24 Thread Petr Kulhavy
On 18.02.2016 09:18, Felipe Balbi wrote: Hi Felipe, I will do as soon as the patch 1/5 gets approved. It seem to be a bit stuck at the moment as Rob Herring from the DT wants the "mentor,power" to be represented as a regulator, whereas Sergei and me want to stick to the existing "mentor,power

Re: [PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-17 Thread Petr Kulhavy
On 17.02.2016 15:58, Felipe Balbi wrote: Hi, Petr Kulhavy writes: This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_mode musb_get_mode() Signed-off-by: Petr Kulhavy seems like I don't have patch 1/5. After fixing

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-17 Thread Petr Kulhavy
Hello Rob, On 16.02.2016 21:05, Rob Herring wrote: On Fri, Feb 12, 2016 at 11:24 AM, Petr Kulhavy wrote: I understand your point that the description should be generic. However the USB 2.0 specification does not define any relation between the bMaxPower provided by the device and the actual

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-16 Thread Petr Kulhavy
Hello Rob, is there any follow-up on this one? Thanks Petr On 12.02.2016 18:24, Petr Kulhavy wrote: On 12.02.2016 17:21, Rob Herring wrote: On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can

Re: [PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-15 Thread Petr Kulhavy
Hello Sergei On 12.02.2016 18:50, Sergei Shtylyov wrote: +/* gets the "dr_mode" property from DT and converts it into musb_mode + * if the property is not found returns MUSB_UNDEFINED + */ +extern enum musb_mode musb_get_mode(struct device *dev); + +#if IS_ENABLED(CONFIG_OF) +/* gets the "ment

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-12 Thread Petr Kulhavy
On 12.02.2016 17:21, Rob Herring wrote: On Thu, Feb 11, 2016 at 12:01:06PM +0100, Petr Kulhavy wrote: + - mentor,power : Specifies the maximum current in milliamperes the controller can + supply in host mode. Still a no for me. Looks like this just sets hcd->power_budget. This prope

Re: [PATCH 3/5] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-02-12 Thread Petr Kulhavy
On 12.02.2016 17:22, Sergei Shtylyov wrote: On 02/12/2016 06:01 PM, Petr Kulhavy wrote: I have just resent the 4 patches with the changes. The one you've already acknowledged I left out. Hope now everything is ok. Please always post the whole series, else the maintainers will ha

[PATCH 4/5] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros in platform_data

2016-02-12 Thread Petr Kulhavy
Only few MUSB PHY PLL frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy --- include/linux/platform_data/usb-davinci.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux

[PATCH 3/5] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-02-12 Thread Petr Kulhavy
content of the config. Signed-off-by: Petr Kulhavy --- drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index

Re: [PATCH 3/5] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-02-12 Thread Petr Kulhavy
Hello Sergei, I have just resent the 4 patches with the changes. The one you've already acknowledged I left out. Hope now everything is ok. Regards Petr -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 5/5] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-02-12 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy --- drivers/usb/musb/da8xx.c | 87 1 file changed, 87 insertions(+) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index b03d3b8

[PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-12 Thread Petr Kulhavy
This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_mode musb_get_mode() Signed-off-by: Petr Kulhavy --- drivers/usb/musb/musb_core.c | 37 + drivers/usb/musb/musb_core.h | 20 +

[PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-12 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt diff --git a

Re: [PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-11 Thread Petr Kulhavy
On 11.02.2016 18:33, Sergei Shtylyov wrote: Actually, we also have UDC specific 'min_power' field and a number of other fields (does it really work w/o specifying 'clock' BTW?). I'd suggest a larger function, assigning directly to the platform data fields... Is there a property already d

Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-11 Thread Petr Kulhavy
On 11.02.2016 14:53, Sergei Shtylyov wrote: +ti,phy20-clkmux-pll; +ti,phy20-refclock-frequency = <2400>; In principle these 2 should belong to the USB PHY subnode... Do you mean to define a PHY subnode even if there is currently no standalone PHY driver for da8xx?

[PATCH 3/5] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-02-11 Thread Petr Kulhavy
the content of the config. Signed-off-by: Petr Kulhavy --- drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index

Re: [PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-11 Thread Petr Kulhavy
On 11.02.2016 15:05, Sergei Shtylyov wrote: +int ret; +unsigned power_ma; + +/* the "mentor,power" value is in milliamperes, whereas + * the mentor configuration is in 2mA units + */ +ret = of_property_read_u32(dev->of_node, "mentor,power", &power_ma); + +return re

[PATCH 3/5] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-02-11 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy --- drivers/usb/musb/da8xx.c | 88 1 file changed, 88 insertions(+) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index b03d3b8

[PATCH 4/5] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros in platform_data

2016-02-11 Thread Petr Kulhavy
Only few MUSB PHY PLL frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy --- include/linux/platform_data/usb-davinci.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux

[PATCH 5/5] usb: musb: core: added missing const qualifier to the config pointer in platform data

2016-02-11 Thread Petr Kulhavy
s added to protect the content of the config. Signed-off-by: Petr Kulhavy --- drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musb_core.h | 2 +- include/linux/usb/musb.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/driver

[PATCH 2/5] usb: musb: core: added helper functions for parsing DT

2016-02-11 Thread Petr Kulhavy
This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_mode musb_get_mode() Signed-off-by: Petr Kulhavy --- drivers/usb/musb/musb_core.c | 36 drivers/usb/musb/musb_core.h | 13 +

[PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver

2016-02-11 Thread Petr Kulhavy
This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt

Re: [PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-10 Thread Petr Kulhavy
Hello Sergei, On 10.02.2016 15:05, Sergei Shtylyov wrote: @@ -1,6 +1,9 @@ /* * Texas Instruments DA8xx/OMAP-L1x "glue layer" * + * DT support + * Copyright (c) 2016 Petr Kulhavy, Barix AG + * Could you place this after MV's copyright? I was trying to preserve

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Petr Kulhavy
On 10.02.2016 15:12, Sergei Shtylyov wrote: of the patch based on Felipe's "next" branch and incorporating all you guys' feedback. Also the binding was submitted separately. I'll go find it, haven't seen yet. I just haven't received it. Please make sure to CC at least linux-usb next

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Petr Kulhavy
On 09.02.2016 11:50, Sergei Shtylyov wrote: Doesn't usb_get_dr_mode() work for you? I can't really say because I can't test it. Is this the replacement for of_usb_get_dr_mode() ? Seems so. The call in musb_dsps.c was just replaced. Thanks, Sergei. Yesterday I submitted the (hopeful

[PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-09 Thread Petr Kulhavy
Adds DT support for the TI DA830 and DA850 USB driver. Signed-off-by: Petr Kulhavy --- drivers/usb/musb/da8xx.c | 136 +++ drivers/usb/musb/musb_core.c | 24 drivers/usb/musb/musb_core.h | 2 + 3 files changed, 162 insertions(+) diff

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-09 Thread Petr Kulhavy
On 08.02.2016 18:55, Sergei Shtylyov wrote: On 02/08/2016 06:32 PM, Petr Kulhavy wrote: I have prepared the patch as per you comments. Unfortunately I cannot use the 4.5 kernel from Felipe's repo as the of_usb_get_dr_mode() has been replaced with of_usb_get_dr_mode_by_phy() which requi

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Petr Kulhavy
What shall we do? Regards Petr On 08.02.2016 13:25, Sergei Shtylyov wrote: On 2/8/2016 2:48 PM, Petr Kulhavy wrote: And the patch is against 3.17? You should only submit patches against the recent kernel. In this case, against the -next branch of Felipe's repo on kernel.org. Could you g

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Petr Kulhavy
Hello Arndt, On 05.02.2016 23:22, Arnd Bergmann wrote: Please make this Should be one of "ti,da850-musb" or "ti,da830-musb" We don't use wildcards in compatible strings, I'm seeing something different though: $ grep -r "compatible.*xx" Documentation/devicetree/bindings/ |wc -l 44

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Petr Kulhavy
On 08.02.2016 13:25, Sergei Shtylyov wrote: As for the mode and power, I agree -- they are part of the board-specific platform data (there's also power-on-to-power-good delay BTW which you missed). I've also noticed the potpgt it in the platform driver. However the musb doesn't seem to

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Petr Kulhavy
Hello Sergei, On 08.02.2016 12:20, Sergei Shtylyov wrote: And the patch is against 3.17? You should only submit patches against the recent kernel. In this case, against the -next branch of Felipe's repo on kernel.org. Could you give me the full branch name please. I was wondering abo

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Petr Kulhavy
hange of the da8xx USB and platform drivers. That's why I didn't go for that. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 63 drivers/usb/musb/da8xx.c | 162 + include/linux/plat

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-05 Thread Petr Kulhavy
On 5 February 2016 at 23:22, Arnd Bergmann wrote: > One more thing: > >> 3 files changed, 227 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt >> b/Documentation/devicet

[PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-05 Thread Petr Kulhavy
TI DA8xx MUSB driver equipped with DeviceTree support. Tested with AM1808 board and USB2.0 (OTG) in host mode. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 63 drivers/usb/musb/da8xx.c | 162

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-04 Thread Petr Kulhavy
Hi Arnd, thanks for your feedback, please see my comments below. On 04.02.2016 14:37, Arnd Bergmann wrote: I would suggest you do the opposite and leave the id table in there but change the first check to if (IS_ENABLED(CONFIG_OF) && np) So the compiler can discard that code when CONF

[PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-04 Thread Petr Kulhavy
TI DA8xx MUSB driver equipped with DeviceTree support. Tested with AM1808 board and USB2.0 (OTG) in host mode. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++ drivers/usb/musb/da8xx.c | 166

Re: [PATCH 2/2] Drivers: MUSB: Davinci MUSB: added DT support

2016-01-22 Thread Petr Kulhavy
are not the best bindings to take as an example. What would you recommend as a good example then? Regards Petr On 22.01.2016 00:07, Rob Herring wrote: On Thu, Jan 21, 2016 at 03:53:19PM +0100, Petr Kulhavy wrote: TI DaVinci MUSB driver equipped with DeviceTree support. Tested with AM1808 board

[PATCH 2/2] Drivers: MUSB: Davinci MUSB: added DT support

2016-01-21 Thread Petr Kulhavy
TI DaVinci MUSB driver equipped with DeviceTree support. Tested with AM1808 board and USB2.0 (OTG) in host mode. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++ drivers/usb/musb/da8xx.c | 166