Bjørn Mork [2015-11-05 12:03:36]:
> make this function return bool. And the patch should go to netdev.
Thanks, done.
> With those changes it looks good to me. But I haven't tested it, so I
> trust your testing :)
usb 2-1.2: new high-speed USB device number 3 using ci_hdrc
qcserial 2-1.2:1.0:
bmAttributes 0xa0
(Bus Powered)
Remote Wakeup
MaxPower 500mA
Signed-off-by: Petr Štetiar
---
Changes since v1:
* make quectel_ec20_detected return bool (Bjørn)
drivers/net/usb/qmi_wwan.c | 21 +
1 file changed, 21
bmAttributes 0xa0
(Bus Powered)
Remote Wakeup
MaxPower 500mA
Signed-off-by: Petr Štetiar
---
drivers/net/usb/qmi_wwan.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb
Bjørn Mork [2015-11-04 16:57:06]:
> > +#define QUECTEL_EC20_VENDORID 0x05c6
> > +#define QUECTEL_EC20_PRODUCTID 0x9215
> > +#define QUECTEL_EC20_NINTERFACES 5
> > +#define QUECTEL_EC20_QMI_IFACE_FIX 4
>
> Not directly related to the issue at hand, but I sort of hate macros
> like
Bjørn Mork [2015-11-04 13:15:10]:
> Based on that, I wonder if it wouldn't be more appropriate to simply do
> this as a device specific quirk in the qmi_wwan probe?
So rather something like this?
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 2a7c1be.
Bjørn Mork [2015-11-03 13:37:56]:
> I guess this means that we need to add an interface count quirk to the
> qmi_wwan driver as well? I assume there are devices out there with the
> same device ID, the same ff/ff/ff interface descriptors, but with
> QMI/net on interface #0.
Indeed, your guess i
Bjørn Mork [2015-11-03 13:37:56]:
> > + case 4:
> > + /* Don't claim the QMI/net interface */
> > + altsetting = -1;
> > + break;
> > + }
>
> I guess this means that we need to add an interface count quirk to the
> qmi_wwan driver as well? I assume there are de
500mA
Signed-off-by: Petr Štetiar
---
drivers/usb/serial/qcserial.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index ebcec8c..d462132 100644
--- a/drivers/usb/serial/qcserial.c
+++ b
