Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Peter Griffin
Hi, On Mon, 06 Jun 2016, Lee Jones wrote: > Phasing out generic reset line requests enables us to make some better > decisions on when and how to (de)assert said lines. If an 'exclusive' > line is requested, we know a device *requires* a reset and that it's > preferable to act upon a request rig

Re: [STLinux Kernel] [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
n requesting shared/exclusive reset lines. > > Signed-off-by: Lee Jones > --- > drivers/usb/dwc3/dwc3-st.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Peter Griffin -- To unsubscribe from this list: send the line "unsubscribe linux-usb&quo

Re: [STLinux Kernel] [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
f-by: Lee Jones > --- > drivers/usb/host/ehci-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Peter Griffin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [STLinux Kernel] [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
sting shared/exclusive reset lines. > > Signed-off-by: Lee Jones > --- > drivers/phy/phy-miphy28lp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Peter Griffin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [STLinux Kernel] [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
> Signed-off-by: Lee Jones Acked-by: Peter Griffin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: dwc3: st: Fix USB_DR_MODE_PERIPHERAL configuration.

2016-05-11 Thread Peter Griffin
mment about what setting this bit means. Signed-off-by: Peter Griffin --- drivers/usb/dwc3/dwc3-st.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c index 5c0adb9..50d6ae6 100644 --- a/drivers/usb/dwc3/dwc3-st.c

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-04-11 Thread Peter Griffin
Hi Mathias, On Fri, 25 Mar 2016, Peter Griffin wrote: > Otherwise generic-xhci and xhci-platform which have no data get wrongly > detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). > > This fixes a regression in v4.5 for STiH407 family SoC's which use the &

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-26 Thread Peter Griffin
Hi Felipe, On Fri, 25 Mar 2016, Felipe Balbi wrote: > > Hi, > > Gregory CLEMENT writes: > >> Peter Griffin writes: > >>> Otherwise generic-xhci and xhci-platform which have no data get wrongly > >>> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by

[PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Peter Griffin
org Cc: gregory.clem...@free-electrons.com Cc: yoshihiro.shimoda...@renesas.com Signed-off-by: Peter Griffin --- drivers/usb/host/xhci-plat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h index 5a2e2e3..529c3c4 1006

Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

2014-10-06 Thread Peter Griffin
On Fri, 03 Oct 2014, Paul Bolle wrote: > Signed-off-by: Paul Bolle > Fixes: 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection") Acked-by: Peter Griffin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

[PATCH v6 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-08 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v6 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-09-08 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v6 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-09-08 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 1

[PATCH v6 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-09-08 Thread Peter Griffin
e unnecessary header files Peter Griffin (5): usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver support for ST STB devices usb: host: ehci-st: Add ehci-st devicetree bindings documentation usb: host: ohci-st: Add ohci-st devicetree bindings docume

[PATCH v6 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-09-08 Thread Peter Griffin
This patch adds the ehci-st.c and ohci-st.c files for the usb 2.0 & usb1.1 host controller drivers found on stih41x and stih4xx STMicroelectronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions

[PATCH v6 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-09-08 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 1

Re: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Peter Griffin
Hi Arnd, On Fri, 05 Sep 2014, Arnd Bergmann wrote: > On Friday 05 September 2014 18:23:45 Peter Griffin wrote: > > +struct st_platform_priv { > > + struct clk *clks[USB_MAX_CLKS]; > > + struct clk *clk48; > > + struct reset_control *rst; > >

[PATCH RESEND v5 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-09-05 Thread Peter Griffin
s formating / spelling nits identified by Lee Jones - Make driver depend on OF & remove node checks in code - Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (5): usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver support for ST S

[PATCH RESEND v5 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-09-05 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH RESEND v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 1

[PATCH RESEND v5 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 1

[PATCH RESEND v5 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-09-05 Thread Peter Griffin
This patch adds the ehci-st.c and ohci-st.c files for the usb 2.0 & usb1.1 host controller drivers found on stih41x and stih4xx STMicroelectronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions

Re: [PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Peter Griffin
Hi Felipe, On Fri, 05 Sep 2014, Felipe Balbi wrote: > > > + > > > + device_for_each_child(&pdev->dev, NULL, st_dwc3_remove_child); > > > > same as before, of_platform_depopulate(). I can fix this one myself this > > time. Oh sorry, not sure what happened there, thanks for fixing it up:-) > > it

[PATCH v6 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 68 +++ 1

[PATCH v6 0/3] Add ST dwc3 glue layer driver

2014-09-05 Thread Peter Griffin
_match_ptr() Changes since v1 - Fix Kconfig mistake Peter Griffin (3): usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture Documentation/devicetree/bindings/usb/dwc3-st

[PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- drivers/usb/dwc3/Kconfig | 9

[PATCH v6 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-09-05 Thread Peter Griffin
This patch adds the new dwc3-st.c glue driver found on STMicroelectronics stih407 consumer electronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin Acked-by: Lee Jones --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

[PATCH v5 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-02 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- drivers/usb/dwc3/Kconfig | 9

[PATCH v5 0/3] Add ST dwc3 glue layer driver

2014-09-02 Thread Peter Griffin
me logging levels to dev_dbg - Various whitespace and formatting cleanup - Use SIMPLE_DEV_PM_OPS() - Add const to of_device struct - Reorder header files alphabetically - Use devm_ioremap_resource instead of devm_request_and_ioremap - Remove of_match_ptr() Changes since v1 - Fix Kconfig mist

[PATCH v5 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-09-02 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 68 +++ 1

[PATCH v5 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-09-02 Thread Peter Griffin
This patch adds the new dwc3-st.c glue driver found on STMicroelectronics stih407 consumer electronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin Acked-by: Lee Jones --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

Re: [PATCH v4 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-02 Thread Peter Griffin
Hi Felipe, Sorry for the delay in replying to this mail, I've been trying to get answers to the suspend/resume questions you had. > > +config USB_DWC3_ST > > + tristate "STMicroelectronics Platforms" > > + depends on ARCH_STI && OF > > + default USB_DWC3_HOST > > this seems wrong as USB_D

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Peter Griffin
Hi Felipe, On Thu, 21 Aug 2014, Felipe Balbi wrote: > > Currently (in the vendor tree) one of the phys lives in > > drivers/usb/phy and the other in drivers/phy. > > I believe that is because one is only a usb phy and the other is a > > multi function phy which can drive PCI-E or USB3. > > right

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Peter Griffin
Hi Felipe, Thanks for reviewing, see my comments below: - On Wed, 20 Aug 2014, Felipe Balbi wrote: > > + dwc3: dwc3@990 { > > + compatible = "snps,dwc3"; > > + reg = <0x0990 0x10>; > > + interrupts = ; > > + dr_mode

Re: [PATCH v4 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-08-21 Thread Peter Griffin
Hi Felipe, Will fix the commit log and rebase onto 3.17-rc1 for the next iteration. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-15 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v5 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-08-15 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2066f4..89aef87 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1356,6 +1356,8 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

[PATCH v5 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-08-15 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 1

[PATCH v5 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-08-15 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v5 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-08-15 Thread Peter Griffin
Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (5): usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver support for ST STB devices usb: host: ehci-st: Add ehci-st devicetree bindings documentation usb: host: ohci-st: Add o

[PATCH v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-08-15 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 1

[PATCH v4 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-08-07 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v4 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-08-07 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 1

[PATCH v4 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-08-07 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2066f4..89aef87 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1356,6 +1356,8 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

[PATCH v4 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-08-07 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 1

[PATCH v4 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-08-07 Thread Peter Griffin
s in code - Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (5): usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver support for ST STB devices usb: host: ehci-st: Add ehci-st devicetree bindings documentation usb: host: ohci-st: Add oh

[PATCH v4 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-07 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

Re: [PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > Changes since v2: > > - Based on Arnd Berghman feedback, split out into 2 devices / drivers > > - Base drivers oh ehci-platform.c & ohci-platform.c with required > > extensions > >to allow possible re-merge in the furture. > > Hi

Re: [PATCH v3 1/6] usb: host: usb-st-common: Add common code required by ohci-st and ehci-st

2014-08-07 Thread Peter Griffin
Hi Arnd, > > > (priv->rst); > > > + if (ret) > > > + goto err_assert_power; > > > + } > > > > I wouldn't make these optional, just call the functions > > unconditionally and fail the probe function if they are > > not available. Also I've also done as you suggest and made

Re: [PATCH v3 1/6] usb: host: usb-st-common: Add common code required by ohci-st and ehci-st

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > + if (priv->rst) { > > + ret = > > (priv->rst); > > + if (ret) > > + goto err_assert_power; > > + } > > I wouldn't make these optional, just call the functions > unconditionally and fail the pr

Re: [PATCH v3 2/6] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > +static int st_ehci_platform_reset(struct usb_hcd *hcd) > > +{ > > + struct platform_device *pdev = to_platform_device(hcd->self.controller); > > + struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev); > > + struct ehci_hcd

[PATCH v3 1/6] usb: host: usb-st-common: Add common code required by ohci-st and ehci-st

2014-08-06 Thread Peter Griffin
This patch abstracts out some common code required by both the ehci-st and ohci-st drivers. Signed-off-by: Peter Griffin --- drivers/usb/host/usb-st-common.c | 99 drivers/usb/host/usb-st-common.h | 34 ++ 2 files changed, 133 insertions

[PATCH v3 2/6] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-06 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v3 3/6] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-08-06 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Gr

[PATCH v3 4/6] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-08-06 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 41 +++ 1 file changed, 41 insertions(+) create mode 1

[PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's

2014-08-06 Thread Peter Griffin
n OF & remove node checks in code - Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (6): usb: host: usb-st-common: Add common code required by ohci-st and ehci-st usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver s

[PATCH v3 5/6] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-08-06 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 40 +++ 1 file changed, 40 insertions(+) create mode 1

[PATCH v3 6/6] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-08-06 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 359a64e..847572d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,7 +1325,8 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc

[PATCH v4 0/3] Add ST dwc3 glue layer driver

2014-07-30 Thread Peter Griffin
whitespace and formatting cleanup - Use SIMPLE_DEV_PM_OPS() - Add const to of_device struct - Reorder header files alphabetically - Use devm_ioremap_resource instead of devm_request_and_ioremap - Remove of_match_ptr() Changes since v1 - Fix Kconfig mistake Peter Griffin (3): usb: dwc3: add ST

[PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-07-30 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 69 +++ 1

[PATCH v4 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-30 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- drivers/usb/dwc3/Kconfig | 9

[PATCH v4 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-30 Thread Peter Griffin
Signed-off-by: Peter Griffin Acked-by: Lee Jones --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Arnd, > > > > I'm of course happy to change it if required. I see looking through that a > > lot > > of other platforms do it the way you describe with a > > > > ehci-.c and ohci-.c > > Right. We are trying to gradually move some of them over to use the > generic *hci-platform.c drivers

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > Unfortunately, this seems to be done in a rather strange way, > I suspect you'll have to start over, but I'll let Alan and Greg > weigh in. > > > + > > +struct st_hcd_dev { > > + int port_nr; > > + struct platform_device *ehci_device;

[PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
This driver adds support for the USB HCD present in STi SoC's from STMicroelectronics. It has been tested on the stih416-b2020 board. Signed-off-by: Peter Griffin --- drivers/usb/host/Kconfig | 12 ++ drivers/usb/host/Makefile | 1 + drivers/usb/host/st-hcd.c

[PATCH v2 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture

2014-07-24 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..359a64e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

[PATCH v2 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.

2014-07-24 Thread Peter Griffin
This patch documents the device tree documentation required for the ST HCD controller found in STMicroelectronics SoCs. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/st-hcd.txt | 49 1 file changed, 49 insertions(+) create mode 100644

[PATCH v2 0/3] Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
ce v1: - Correct s/OCHI/OHCI/ spelling - Improve kconfig help message - Various formating / spelling nits identified by Lee Jones - Make driver depend on OF & remove node checks in code - Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (3): usb: host: st-hcd: Ad

Re: [PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Lee, Thanks for reviewing. All your review comments have been fixed in v2. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-23 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- drivers/usb/dwc3/Kconfig | 9 ++ drivers/usb/dwc3

[PATCH v3 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-07-23 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 69 +++ 1 file changed, 69

[PATCH v3 0/3] Add ST dwc3 glue layer driver

2014-07-23 Thread Peter Griffin
SIMPLE_DEV_PM_OPS() - Add const to of_device struct - Reorder header files alphabetically - Use devm_ioremap_resource instead of devm_request_and_ioremap - Remove of_match_ptr() Peter Griffin (3): usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC usb: dwc3: dwc3-st: Add st-dwc3 devicetree

[PATCH v3 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-23 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-23 Thread Peter Griffin
Hi Felipe, Thanks for reviewing, see my comments inline: - > > > Just use {read,write}l_relaxed() directly. > > > > Ok, unabstracted in v3 > > no, no... all other glues add their own local helpers for register > access. This is good for tracing, it's very easy to add a tracepoint to > this sort

Re: [PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-22 Thread Peter Griffin
Hi Alan, > > > > Most platform drivers have already been moved. > > Okay, I grant the point. Objections withdrawn. Fix up the spelling > error and the other stuff in the Kconfig help text, and this will be > acceptable. Thanks, I intend to send a new version shortly. regards, Peter. -- T

Re: [RFC PATCH] usb: dwc3: core: allow vendor drivers to check probe status

2014-07-22 Thread Peter Griffin
Hi Felipe, Sorry for the delay in replying. I've been trying to get to the root cause of this problem so I could reply which took longer than I had hoped. The problem manifested itself as a hang on register read/write access if dwc3-st probed before the usb3 phy. Even though dwc3 core would bai

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-22 Thread Peter Griffin
Hi Jingoo, Sorry for the delay in replying. Thanks for reviewing, see my comments inline below: - > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-22 Thread Peter Griffin
Hi Lee, Thanks for reviewing, see my comments inline below: - On Mon, 07 Jul 2014, Lee Jones wrote: > On Sat, 05 Jul 2014, Peter Griffin wrote: > > > This patch adds the ST glue logic to manage the DWC3 HC > > on STiH407 SoC family. It manages the powerdown signal, >

Re: [PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-11 Thread Peter Griffin
Hi Alan, Thanks for reviewing. On Thu, 10 Jul 2014, Alan Stern wrote: > On Thu, 10 Jul 2014, Peter Griffin wrote: > > > This driver adds support for the USB HCD present in STi > > SoC's from STMicroelectronics. It has been tested on the > > stih416-b2020 board.

Re: [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-10 Thread Peter Griffin
Hi Felipe, > > Maxime, > > Once Acked by Felipe, I think this should go in via your tree to > > avoid conflicts with other ARM/STI ARCHITECTURE additions. > > there are still many unresolved comments on patches 1 and 2. Yes, sorry I've been a bit busy this week on other activities to send a V3

[PATCH 0/3] Add USB HCD support for STi SoCs

2014-07-10 Thread Peter Griffin
This driver adds support for the USB HCD controller present in STi SoC's from STMicroelectronics. It has been tested on the stih416-b2020 board. The original author is no longer with the company and therefore emails to his address bounce, thus I have not added him to CC. Peter Griffin (3):

[PATCH 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture

2014-07-10 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..359a64e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

[PATCH 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.

2014-07-10 Thread Peter Griffin
This patch documents the device tree documentation required for the ST HCD controller found in STMicroelectronics SoCs. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/st-hcd.txt | 51 1 file changed, 51 insertions(+) create mode 100644

[PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-10 Thread Peter Griffin
This driver adds support for the USB HCD present in STi SoC's from STMicroelectronics. It has been tested on the stih416-b2020 board. Signed-off-by: Peter Griffin --- drivers/usb/host/Kconfig | 17 ++ drivers/usb/host/Makefile | 1 + drivers/usb/host/st-hcd.c

[PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-04 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- drivers/usb/dwc3/Kconfig | 9 ++ drivers/usb/dwc3

[PATCH v2 0/3] Add ST dwc3 glue layer driver.

2014-07-04 Thread Peter Griffin
This series adds support for the ST glue logic to manage the DWC3 HC on STiH407 SoC family chipsets. Peter Griffin (3): usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC ARM: dts: sti: Add st-dwc3 devicetree bindings documentation MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

[PATCH v2 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-04 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 58 +++ 1 file changed, 58

[PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-04 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F

Re: [PATCH 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-04 Thread Peter Griffin
Hi Daniele, Thanks for reviewing. On Fri, 04 Jul 2014, Daniele Forsi wrote: > 2014-07-04 13:13 GMT+02:00 Peter Griffin: > > > +Required properties: > > + - compatible : must be "st,stih407-dwc3" > > + - reg : glue logic base address and USB syscfg ctr

Re: [PATCH 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-04 Thread Peter Griffin
Hi Daniele, Thankyou for reviewing. > > +config USB_DWC3_ST > > + tristate "STMicroelectronics Platforms" > > + depends on ARCH_STI && OF > > + default USB_DWC3_HOST > > + help > > + STMicroelectronics SoCs chip with one DesignWare Core USB3 IP > > + inside

[PATCH 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-04 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- drivers/usb/dwc3/Kconfig | 9 ++ drivers/usb/dwc3

[PATCH 0/3] Add ST dwc3 glue layer driver.

2014-07-04 Thread Peter Griffin
This series adds support for the ST glue logic to manage the DWC3 HC on STiH407 SoC family chipsets. Peter Griffin (3): usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC ARM: dts: sti: Add st-dwc3 devicetree bindings documentation MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

[PATCH 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-04 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 58 +++ 1 file changed, 58

[PATCH 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-04 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F