users
were actually relying on this mechanism.
Signed-off-by: Paul Kocialkowski
---
Changes sinve v3:
* Added extra patch to refactor PHY selection and only keep a single one.
Changes since v2:
* Fixed typos in commit message.
Changes since v1:
* Only consider legacy USB PHY error for fallback as sug
easier to
understand and follow.
All error pointers (except for EPROBE_DEFER) are considered as PHY
not found.
Signed-off-by: Paul Kocialkowski
---
drivers/usb/chipidea/core.c | 49 -
1 file changed, 32 insertions(+), 17 deletions(-)
diff --git a/drivers/usb
gacy) PHY remains
> > after
> > probe?
> >
>
> Yes, I just want only one valid, either ci->phy or ci->usb_phy, it makes
> sense.
Sounds good to me. I'll send out v4 with this patch and an extra one to
refactor the PHY selection path and only attempt to get a single PHY.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
that we can end up with both a generic and legacy PHY?
I thought this was expected behavior at probe, and the rest of the code
will just use the generic one in priority.
Do you want to make it so that only one (generic or legacy) PHY remains
after probe?
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
rth the effort to add it.
> > > >
> > > > When no legacy USB PHY is found by phandle, fallback to grabbing any
> > > > registered
> > > > USB2 PHY. This ensures backward compatibility if some users were
> > > > actually relying on this mecha
elper for similar lookup on legacy PHYs and
> > it's
> > probably not worth the effort to add it.
> >
> > When no legacy USB PHY is found by phandle, fallback to grabbing any
> > registered
> > USB2 PHY. This ensures backward compatibility if some users we
users
were actually relying on this mechanism.
Signed-off-by: Paul Kocialkowski
---
Changes since v2:
* Fixed typos in commit message.
Changes since v1:
* Only consider legacy USB PHY error for fallback as suggested;
* Checked against EPROBE_DEFER before entering fallback.
drivers/usb/chipidea/core.
e actually relying on this mechanism.
Signed-off-by: Paul Kocialkowski
---
Changes since v1:
* Only consider legacy USB PHY error for fallback as suggested;
* Checked against EPROBE_DEFER before entering fallback.
drivers/usb/chipidea/core.c | 9 -
1 file changed, 8 insertions(+), 1 d
> > > and never both. With your change, you can have ci->phy and
> > > ci->usb_phy both be valid if the legacy USB PHY was found using
> > > devm_usb_get_phy_by_phandle(), but not if we fell back to
> > > devm_usb_get_phy().
> >
> > Okay that makes sense, your suggestion is indeed more consistent with the
> > existing
> > behavior. I'll go with that in the next revision!
> >
>
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
ay that makes sense, your suggestion is indeed more consistent with
the existing behavior. I'll go with that in the next revision!
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Hi,
On Wed, 2019-01-16 at 11:53 +0100, Thomas Petazzoni wrote:
> Hello,
>
> Thanks for the patch!
And thanks for the review!
> On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote:
> > According to the chipidea driver bindings, the USB PHY is specified via
> >
e actually relying on this mechanism.
Signed-off-by: Paul Kocialkowski
---
drivers/usb/chipidea/core.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 7bfcbb23c2a4..11d3ee1e3fe5 100644
--- a/drivers/u
Hi,
Le mardi 01 mai 2018 à 07:25 -0500, Bin Liu a écrit :
> On Mon, Apr 30, 2018 at 11:08:42PM +0200, Paul Kocialkowski wrote:
> > Hi,
> >
> > Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit :
> > > Okay, this came down to an argument that whether we should
I have other MUSB-enabled
devices in my collection though, but I would be willing to test fixes to
this issue on the ones I have.
Cheers,
--
Paul Kocialkowski,
developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repo
Hi,
Le vendredi 20 avril 2018 à 09:25 -0500, Bin Liu a écrit :
> On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote:
> > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkow
Hi,
Le mardi 03 avril 2018 à 11:29 +0200, Maxime Ripard a écrit :
> Hi,
>
> On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote:
> > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote:
> > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wr
Hi,
On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote:
> On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote:
> > This allows dual-role ports to be reported as having gadget mode by
> > the
> > musb_has_gadget helper. This is required to enable MUSB
root HUB, regardless of whether the current mode should be gadget
or host.
This fixes USB OTG on Allwinner devices that I could test it with,
mainly A20 devices.
Signed-off-by: Paul Kocialkowski
---
drivers/usb/musb/musb_virthub.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
ID
[ 69.197987] ath: phy0: REGISTER READ FAILED: (0x7044, -110)
[ 70.231015] ath: phy0: Timeout waiting for WMI command: WMI_REG_RMW_CMDID
What could be causing these issues?
Cheers!
--
Paul Kocialkowski, developer of free digital technology at the lower levels
Website: https://www.paulk.f
19 matches
Mail list logo
