Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-09 Thread Paul Fertser
Hi, On Fri, May 09, 2014 at 09:07:00AM +, suresh.gu...@freescale.com wrote: > > Are you really sure we can't get async VBUS state change notifications > > until controller has USB_CMD_RUN_STOP bit set (and the same bit actually > > controls internal 1.5k dataline pullup)? If yes, I guess it me

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
On Thu, May 08, 2014 at 06:42:53PM +, suresh.gu...@freescale.com wrote: > > > And Host might be attach after system bootup or after driver > > > initialization. So putting this check in probe will not help much. > > > > If the host is attached after the driver was initialised, the interrupt >

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
Hi, On Thu, May 08, 2014 at 02:30:39PM +, suresh.gu...@freescale.com wrote: > As per my limited knowledge, the purpose of > OTGSC_STS_B_SESSION_VALID bit is to tell either VBUS is above the B > session valid threshold and which comes only Host is attached. Yes, that matches the datasheet I've

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-30 Thread Paul Fertser
Hello, Thank you for the review. On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote: > > If VBUS is already present during the driver initialisation, the > > s/initialisation/initialization If I

[PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-24 Thread Paul Fertser
If VBUS is already present during the driver initialisation, the corresponding IRQ never fires, so there is no way the gadget can get enumerated. This patch is real-life tested on an i.MX25 board with VBUS constantly hooked up. Signed-off-by: Paul Fertser --- drivers/usb/gadget/fsl_udc_core.c

Re: DesignWare USB OTG dwc_otg issues with high-speed hubs

2012-08-10 Thread Paul Fertser
Hi Felipe, On Fri, Aug 10, 2012 at 10:39:52PM +0300, Felipe Balbi wrote: > On Fri, Aug 10, 2012 at 10:35:20PM +0400, Paul Fertser wrote: > > I'm using an RT3052F device (DIR-620 SOHO wifi router) with current > > OpenWrt trunk and its USB port is handled by the dwc_otg drive

Re: DesignWare USB OTG dwc_otg issues with high-speed hubs

2012-08-10 Thread Paul Fertser
On Fri, Aug 10, 2012 at 10:35:20PM +0400, Paul Fertser wrote: > I've not tried forcing full-speed mode for dwc_otg by hacking the > sources directly, so no experimental data about it available yet. By using 1 (full speed) for the default value of the "speed" module param

DesignWare USB OTG dwc_otg issues with high-speed hubs

2012-08-10 Thread Paul Fertser
Hi, I'm using an RT3052F device (DIR-620 SOHO wifi router) with current OpenWrt trunk and its USB port is handled by the dwc_otg driver. The source is available from their repository: https://dev.openwrt.org/browser/trunk/target/linux/ramips/files/drivers/usb/dwc_otg The problem appears when i co