Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-08-16 Thread Patong Yang
On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote: > On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > > Greg, > > > > Please see my response inline below. > > > > Patong > > > > > But there is a bigger problem here: > >

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-08-15 Thread Patong Yang
Greg, Please see my response inline below. Patong > But there is a bigger problem here: > > > + xrusb_tty_driver = alloc_tty_driver(XRUSB_TTY_MINORS); > > + if (!xrusb_tty_driver) > > + return -ENOMEM; > > Why are you not using the usb serial core here? You need to do that, > no

[PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-07-24 Thread Patong Yang
Greg KH Signed-off-by: Patong Yang --- drivers/usb/serial/xrusb_serial.c | 2380 + drivers/usb/serial/xrusb_serial.h | 234 +++ 2 files changed, 2614 insertions(+) create mode 100644 drivers/usb/serial/xrusb_serial.c create mode 100644 drivers/usb/serial

[PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Patong Yang
c USB tree location, and some configuration data is stored. The driver checks for the port_config file when the driver is loaded for each port and loads the configuration settings if there is a port_config file for the USB tree location. Signed-off-by: Patong Yang --- drivers/