Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Nick Desaulniers
id); > - return scnprintf(buf, PAGE_SIZE, "%s\n", pr_cdid); > + return sprintf(buf, "%16ph\n", cbaf->cdid.data); > } Great simplification overall. If you wanted to push further, cbaf_wusb_c{h|d}id_show() are basically (almost) the same function no

Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Nick Desaulniers
"%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx", > +"%02hhx %02hhx %02hhx %02hhx %02hhx %02hhx %02hhx > %02hhx " > +"%02hhx %02hhx %02hhx %02hhx %02hhx %02hhx %02hhx > %02hhx", Looks like lib/vsprintf.c#format_decode() acc

Re: wrong device idProduct?

2018-08-06 Thread Nick Desaulniers
Ok, thanks for taking a look. On Mon, Aug 6, 2018 at 12:18 PM Alan Stern wrote: > > On Mon, 6 Aug 2018, Nick Desaulniers wrote: > > > On Mon, Aug 6, 2018 at 11:27 AM Alan Stern > > wrote: > > > > > > On Mon, 6 Aug 2018, Nick Desaulniers wrote: > > &

Re: wrong device idProduct?

2018-08-06 Thread Nick Desaulniers
On Mon, Aug 6, 2018 at 11:27 AM Alan Stern wrote: > > On Mon, 6 Aug 2018, Nick Desaulniers wrote: > > > On Mon, Jul 30, 2018 at 1:24 PM Alan Stern > > wrote: > > > > > > On Mon, 30 Jul 2018, Nick Desaulniers wrote: > > > > > &g

Re: wrong device idProduct?

2018-08-06 Thread Nick Desaulniers
On Mon, Jul 30, 2018 at 1:24 PM Alan Stern wrote: > > On Mon, 30 Jul 2018, Nick Desaulniers wrote: > > > Hello, > > Today my usb keyboard stopped working: > > > > [513672.838235] usbhid 3-10.1:1.0: couldn't find an input interrupt endpoint > > > >

wrong device idProduct?

2018-07-30 Thread Nick Desaulniers
oduct=0142 and the broken one: [513672.837646] usb 3-10.1: New USB device found, idVendor=24f0, idProduct= This causes the product to be misidentified. Is something wrong with the keyboard that's causing it to misreport the idProduct? -- Thanks, ~Nick Desaulniers -- To unsubscribe from