> -Original Message-
> From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com]
> Sent: 2014年10月28日 21:10
> To: Neil Zhang; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org
> Cc: ba...@ti.com; gre...@linuxfoundation.org
> Subject: Re: [PATCH] usb: gadget
Don't create new usb_gadget_string_container if the current strings are
already exist in the usb_composite_dev.
Otherwise the ids_tab will overflow soon if we bind / unbind usb
functions frequently like android does.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/composite.c |6
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: 2014年2月26日 23:19
> To: Neil Zhang
> Cc: ba...@ti.com; Peter Chen; gre...@linuxfoundation.org;
> linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Alexander Shishkin
> Subject: Re: [P
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: 2014年2月26日 2:13
> To: Peter Chen
> Cc: Neil Zhang; ba...@ti.com; gre...@linuxfoundation.org;
> linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Alexander Shishkin
> Subject: Re: [PATCH 2/6
> -Original Message-
> From: Peter Chen [mailto:peter.c...@freescale.com]
> Sent: 2014年2月25日 9:59
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 3/6] usb: gadget: mv_udc
> -Original Message-
> From: Peter Chen [mailto:peter.c...@freescale.com]
> Sent: 2014年2月25日 12:18
> To: Neil Zhang
> Cc: Matthieu CASTET; ba...@ti.com; gre...@linuxfoundation.org;
> linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re: [P
> -Original Message-
> From: Peter Chen [mailto:peter.c...@freescale.com]
> Sent: 2014年2月25日 12:19
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 5/6] USB: gadget:
> -Original Message-
> From: Peter Chen [mailto:peter.c...@freescale.com]
> Sent: 2014年2月25日 13:15
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: RE: [PATCH 2/6] usb: gadget: mv_ud
> -Original Message-
> From: Peter Chen [mailto:peter.c...@freescale.com]
> Sent: 2014年2月25日 9:19
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 2/6] usb: gadget: mv_ud
> -Original Message-
> From: Matthieu CASTET [mailto:matthieu.cas...@parrot.com]
> Sent: 2014年2月24日 18:32
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 0/6] bug fix for
This patch set is mainly for bug fix.
Neil Zhang (6):
usb: gadget: mv_udc: remove redundant pull up in udc_start
usb: gadget: mv_udc: disable HW zlt for ep0
usb: gadget: mv_udc: clear corresponding interrupt when flush fifo
usb: gadget: mv_udc: check endpoint before queue dtd
USB
Hardware zlt will try to send the zero length packet automatically
when the data transferd is multiple times of max packet, this will
cause issues on Windows.
So let's disable HW zlt by default.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |2 +-
1 file chang
Romove redundant pull up in udc_start since function udc_bind_to_driver
in udc-core.c will do it for us.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
There is a corner case that endpoint is disabled by system shutdown
between check ep->desc and hold spin lock in mv_ep_queue. In this
case ep->ep.desc will be NULL and occur kernel panic when access
it in build_dtd.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c
eqh_status (56), and release_prime_mask
(42) states. As shown in the waveform, the ep_addtd_tripwire_clr signal
is not set to clear the tripwire bit in these states.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c | 20
1 file changed, 20 insertions(+)
di
need clear the pending corresponding interrupt
as well as flush
endpoint.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index 657ac5c..d5a9bdf 100644
--
When the missing dTD issue is triggerred, queue_dtd may prime the new
request instead of the missing dTD.
We can just add the request to the queue end and jump out if there are
more than one request in the queue already.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c | 12
> -Original Message-
> From: Neil Zhang [mailto:zhan...@marvell.com]
> Sent: 2013年12月11日 14:18
> To: ba...@ti.com; gre...@linuxfoundation.org
> Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Neil Zhang
> Subject: [PATCH] usb: phy: initilize the notifier
We need to initilize the notifer before use it.
So lets initilize it when add a new phy device to reduce the code
redundance.
Signed-off-by: Neil Zhang
---
drivers/usb/phy/phy-ab8500-usb.c|2 --
drivers/usb/phy/phy-generic.c |1 -
drivers/usb/phy/phy-gpio-vbus-usb.c |2
> -Original Message-
> From: Neil Zhang [mailto:zhan...@marvell.com]
> Sent: 2013年12月11日 13:05
> To: ba...@ti.com; gre...@linuxfoundation.org
> Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Neil Zhang
> Subject: [PATCH] usb: phy: Initilize the spinlock i
We need to initilize the notifer before use it.
So lets initilize it when add a new phy device to reduce the code
redundance.
Signed-off-by: Neil Zhang
---
drivers/usb/phy/phy-ab8500-usb.c|2 --
drivers/usb/phy/phy-generic.c |1 -
drivers/usb/phy/phy-gpio-vbus-usb.c |2
We need to initilize every spinlock before use it.
So lets initilize the spinlock in notifier when add a new phy device.
Signed-off-by: Neil Zhang
---
drivers/usb/phy/phy.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
index 1b74523
; Bill
> Pemberton; Neil Zhang; Chao Xie; Michal Nazarewicz; Linus Walleij; Felipe
> Balbi
> Subject: [PATCH 4/6] usb: gadget: mv_udc_core: fix sparse warnings
>
> fix the following sparse warnings:
>
> drivers/usb/gadget/mv_udc_core.c:1850:6: warning: symbol
> 'ir
Hi Balbi,
> -Original Message-
> From: Neil Zhang
> Sent: 2012年7月25日 19:52
> To: Neil Zhang; ba...@ti.com; gre...@linuxfoundation.org
> Cc: Chao Xie; khoroshi...@ispras.ru; linux-usb@vger.kernel.org
> Subject: RE: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature
&
Hi Balbi,
> -Original Message-
> From: Neil Zhang
> Sent: 2012年7月19日 22:48
> To: Neil Zhang; ba...@ti.com; gre...@linuxfoundation.org
> Cc: Chao Xie; khoroshi...@ispras.ru; linux-usb@vger.kernel.org
> Subject: RE: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature
&
Hi Balbi,
> -Original Message-
> From: Neil Zhang [mailto:zhan...@marvell.com]
> Sent: 2012年7月10日 10:07
> To: ba...@ti.com; gre...@linuxfoundation.org
> Cc: Chao Xie; khoroshi...@ispras.ru; linux-usb@vger.kernel.org; Neil
> Zhang
> Subject: [PATCH 0/7 v2] usb: gadget
From: Yunfan Zhang
Fix system hang in udc shutdown routine which caused by accessing usb
register when clock is disabled. So enable usb clock before access
register.
Signed-off-by: Yunfan Zhang
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |2 ++
1 files changed, 2
cable attached at the boot up time,
the vbus is low, so it will call stop_activity path without clock
enabled which will cause system hang then.
Actually, we need't go this path when clock is disabled, what we need to
do is just jump out.
Signed-off-by: Neil Zhang
---
drivers/usb/g
According to ChipIdea's reference manual in section 8.5.2
"Non-streaming operational mode in device mode", we'd better enable stream
mode, especially that ISO endpoints are not supported when the SDIS bit
is set.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.
From: Chao Xie
In order to support iso, we need do the following things:
1. fix length for one dtd
2. allow req contains multiple packets for a ISO transfer
Signed-off-by: Chao Xie
Signed-off-by: Yu Xu
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c | 21
Clean unused code for mv_udc driver.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index 9e40f89..c05d340 100644
--- a/drivers/usb
build_dtd() can be called when hold a spinlock, but GFP_KERNEL may cause
dma_pool_alloc() sleep, So we need use GFP_ATOMIC instead of GFP_KERNEL.
But using GFP_ATOMIC may cause failure when allocating memory, add error
handler to handle it.
Signed-off-by: Alexey Khoroshilov
Signed-off-by: Neil
This patch set will add ISO support for mv_udc and do some bug fix.
ChangeLog:
V2:
1. Fix some syntax error in comments.
2. Use usb_endpoint_xfer_isoc instead of redundant code, thanks Sergei.
Chao Xie (1):
usb: gadget: mv_udc: add iso support
Neil Zhang (5):
usb: gadget: mv_udc: reduce the
There are several places use udelay(LOOPS_USEC) to wait the status to be
changed, but the delay interval is a bit too long, so reduce it to
enhance the performance.
Signed-off-by: Neil Zhang
---
drivers/usb/gadget/mv_udc_core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Hi Sergei,
> -Original Message-
> From: Sergei Shtylyov [mailto:sshtyl...@mvista.com]
> Sent: 2012年7月7日 1:34
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; Chao Xie;
> khoroshi...@ispras.ru; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 1/7] usb: g
Hi Sergei,
> -Original Message-
> From: Sergei Shtylyov [mailto:sshtyl...@mvista.com]
> Sent: 2012年7月7日 1:39
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; Chao Xie;
> khoroshi...@ispras.ru; linux-usb@vger.kernel.org; Chao Xie; Yu Xu
> Subject
> -Original Message-
> From: Sergei Shtylyov [mailto:sshtyl...@mvista.com]
> Sent: 2012年7月7日 1:32
> To: Neil Zhang
> Cc: ba...@ti.com; gre...@linuxfoundation.org; Chao Xie;
> khoroshi...@ispras.ru; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 2/7] usb: gadget:
37 matches
Mail list logo
