Re: function ehci_hub_control in ehci-hub.c

2016-04-04 Thread Navin P.S
On Mon, Apr 04, 2016 at 11:57:27AM -0400, Alan Stern wrote: > On Mon, 4 Apr 2016, Navin P.S wrote: > > > > You want to replace 2 statements with 8 statements that do exactly > > > the same thing? This does not seem like an improvement. > > > > > >

Re: function ehci_hub_control in ehci-hub.c

2016-04-04 Thread Navin P.S
On Mon, Apr 04, 2016 at 10:38:37AM -0400, Alan Stern wrote: > On Mon, 4 Apr 2016, Navin P.S wrote: > > > I was proposing something like the attached. > > When you have an oppurtunity to fix or be complaint let us use that so. > > > > I finally leave this he

Re: function ehci_hub_control in ehci-hub.c

2016-04-04 Thread Navin P.S
On Sun, Apr 03, 2016 at 02:25:05PM -0400, Alan Stern wrote: > On Sun, 3 Apr 2016, Navin P.S wrote: > > > On Sat, Apr 2, 2016 at 8:00 PM, Alan Stern > > wrote: > > > On Sat, 2 Apr 2016, Navin P.S wrote: > > >>regs->hostpc[(wIndex & 0xff) - 1]; &g

Re: function ehci_hub_control in ehci-hub.c

2016-04-02 Thread Navin P.S
On Sat, Apr 2, 2016 at 8:00 PM, Alan Stern wrote: > On Sat, 2 Apr 2016, Navin P.S wrote: >>regs->hostpc[(wIndex & 0xff) - 1]; > > You're asking the question backwards. wIndex is allowed to be 0 > because the USB spec says so. You can't argue with that. > &g

Re: function ehci_hub_control in ehci-hub.c

2016-04-01 Thread Navin P.S
On Fri, Apr 1, 2016 at 9:19 PM, Alan Stern wrote: > On Fri, 1 Apr 2016, Navin P.S wrote: > >> On Fri, Apr 1, 2016 at 8:00 PM, Alan Stern wrote: >> > On Fri, 1 Apr 2016, Navin P.S wrote: >> > >> >> Hi, >> >> >> >> I was looking at

Re: function ehci_hub_control in ehci-hub.c

2016-04-01 Thread Navin P.S
On Fri, Apr 1, 2016 at 8:00 PM, Alan Stern wrote: > On Fri, 1 Apr 2016, Navin P.S wrote: > >> Hi, >> >> I was looking at the bug https://bugzilla.kernel.org/show_bug.cgi?id=112171 >> which says >> >> Feb 08 22:58:56 x kernel: UBSAN: Undefined behaviou

function ehci_hub_control in ehci-hub.c

2016-04-01 Thread Navin P.S
Hi, I was looking at the bug https://bugzilla.kernel.org/show_bug.cgi?id=112171 which says Feb 08 22:58:56 x kernel: UBSAN: Undefined behaviour in drivers/usb/host/ehci-hub.c:873:47 Feb 08 22:58:56 x kernel: index -1 is out of range for type 'u32 [1]' I'm suspective the ehci-tegra function ehc