Re: [PATCH] usb: gadget: Don't allocate zero-length buffers

2019-03-29 Thread Michał Nazarewicz
Sorry for the late reply. On Thu, 21 Mar 2019 at 07:42, Andrzej Pietrasiewicz wrote: > > Hi Greg, > > W dniu 20.03.2019 o 15:25, Greg KH pisze: > > On Wed, Mar 20, 2019 at 01:56:41PM +0100, Andrzej Pietrasiewicz wrote: > >> Don't actually allocate anything if userspace enqueues a zero-length > >>

Re: [PATCH V2 2/2] usb: gadget: storage: Remove reference counting

2018-07-05 Thread Michał Nazarewicz
Acked-by: Michal Nazarewicz 2018-07-04 5:51 GMT+01:00 Jaejoong Kim : > The kref used to be needed because sharing of fsg_common among multiple USB > function instances was handled by fsg. Now this is managed by configfs, we > don't need it anymore. So let's eliminate kref from this driver. > > Si

Re: [PATCH 1/3] usb: gadget: storage: Fix reference count if fsg_alloc_inst() failed

2018-06-26 Thread Michał Nazarewicz
2018-06-22 2:23 GMT+01:00 Jaejoong Kim : > Hi Michal, > > Could you check this patch? Sorry about long delay, I haven’t settled in my new place yet (which is also why I’m using Gmail). > 2018년 6월 14일 (목) 오후 11:55, Alan Stern 님이 작성: >> >> On Thu, 14 Jun 2018, Jaejoong Kim wrote: >> >> > The refere

Re: [PATCH 3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get}

2018-06-26 Thread Michał Nazarewicz
Getting rid of kref seems sensible to me. Reference counting used to be needed because sharing of fsg_common among multiple USB function instances was handled by fsg. Now this is handled by configfs layer and I don’t think the kref is necessary any more. 2018-06-14 19:23 GMT+01:00 Jaejoong Kim : >

Re: [PATCH 2/3] usb: gadget: storage: Add error handling for no memory

2018-06-26 Thread Michał Nazarewicz
Acked-by: Michal Nazarewicz (Does Gmail still hates LKML? Guess we’ll see…) 2018-06-14 15:50 GMT+01:00 Alan Stern : > On Thu, 14 Jun 2018, Jaejoong Kim wrote: > >> fsg_common_set_num_buffers() may fail due to ENOMEM. So add >> error handling for fail case. >> >> Signed-off-by: Jaejoong Kim >> -

Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to epfiles

2018-03-31 Thread Michał Nazarewicz
2018-03-30 23:32 GMT+01:00 Jerry Zhang : > This allows 32 bit owners of ffs endpoints to > make ioctls into a 64 bit kernel. > > All of the current epfile ioctls can be handled > with the same struct definitions as regular > ioctl. > > Signed-off-by: Jerry Zhang Ack