Re: [PATCH] usb: dwc2: Fix EP TxFIFO number setting

2019-01-31 Thread Maynard Cabiente
erwise there is probability to > have same TxFIFO number for different EP's because of OR operator. > > Signed-off-by: Minas Harutyunyan I have verified that this patch fixed the issue we have regarding usb data being sent to the incorrect usb endpoint. Tested-by: Maynar

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-31 Thread Maynard Cabiente
Hi Minas, On Thu, Jan 31, 2019 at 9:34 AM Minas Harutyunyan wrote: > Hi Maynard, > > On 1/31/2019 3:36 AM, Maynard Cabiente wrote: > > Hi Minas, > > > > On Wed, Jan 30, 2019 at 9:02 AM Minas Harutyunyan > > wrote: > >> Root cause of data messing be

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-30 Thread Maynard Cabiente
Hi Minas, On Wed, Jan 30, 2019 at 9:02 AM Minas Harutyunyan wrote: > Root cause of data messing between IN EP's because all IN EP's use same > TXFIFO. TxFIFO number 7. See DIEPCTL's, bits 22-25 txfnum, from debug logs: > > EP1IN DIEPCTL = 0x11ca8200 > EP2IN DIEPCTL = 0x11ca8200 > EP5IN DIEPCTL =

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-29 Thread Maynard Cabiente
Hi Minas, On Tue, Jan 29, 2019 at 5:30 AM Minas Harutyunyan wrote: > Please send me regdump. > Below is the regdump you requested. But, I'm not sure if this is the time when it is failing or not as it is hard for me to determine (and time it) when it fails without looking at the USB trace or ker

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-25 Thread Maynard Cabiente
Hi Minas, On Fri, Jan 25, 2019 at 2:54 AM Minas Harutyunyan wrote: > Besides, mentioned by you timestamp <23.918 564 900>, where BULK IN data > messed between EP1IN and EP2IN, I found in USB trace one more invalid > traffic packets sequence. See in trace at timestamp <24.169 347 217>: on > same E

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-25 Thread Maynard Cabiente
Hi Minas, On Fri, Jan 25, 2019 at 2:54 AM Minas Harutyunyan wrote: > I not found yet where from come this bug. > > Meanwhile, could you please: > 1. Test same scenario in BDMA mode Sorry but I'm not familiar with BDMA mode. DId not find it in the Altera reference manual or inside the kernel doc

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-23 Thread Maynard Cabiente
Hi Minas, On Wednesday, January 23, 2019 3:58 AM Minas Harutyunyan wrote: > But before it, could you please add some debug print in > dwc2_hsotg_suspend() function. I suspect that host side autosuspend mass > storage device(s) this is why dwc2 driver complete request with ERROR: > -108. Based on

Re: FW: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-23 Thread Maynard Cabiente
Hi Greg, On Wednesday, January 23, 2019 2:09 AM, Greg KH wrote: > On Wed, Jan 23, 2019 at 06:52:00AM +0000, Maynard CABIENTE wrote: > > This e-mail, and any document attached hereby, may contain confidential > > and/or privileged information. If you are not the intended recipien

RE: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-22 Thread Maynard CABIENTE
Hi Minas, On Wednesday, January 23, 2019 1:42 AM, Minas Harutyunyan wrote: > > Can you provide USB trace for above fragment. > Is it ok to have a 14MB attachment on this e-mail list? My USB trace was taken using the Ellisys USB Analyzer. It requires that you download their Windows software from

usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-22 Thread Maynard CABIENTE
Hi Minas, I have one more issue on the dwc2 gadget driver that I can't figure out the root cause. Hopefully, you have an idea on this problem. Our system is using an Altera Cyclone V SoC FPGA on our board with linux kernel 4.14.44 and enabling the USB gadget for HID (keyboard and mouse) and mas

RE: usb: dwc2 continuously receiving BNA interrupts on ep0

2019-01-15 Thread Maynard CABIENTE
Hi Minas, On Tuesday, January 15, 2019 3:02 AM, Minas Harutyunyan wrote: > > Please apply follow patches which included starting from 4.16: > 1. usb: dwc2: Add safety check in setting of descriptor chain pointers commit > ID: 201ec568c57a43dbc73c7ac00e73c3c2d39559fc > 2. usb: dwc2: Add safety chec

usb: dwc2 continuously receiving BNA interrupts on ep0

2019-01-14 Thread Maynard CABIENTE
Hi Minas and John, I'm hoping that one of you can help me devise a fix to a system hang issue caused by BNA interrupts on USB Endpoint 0. Our system is using an Altera Cyclone V SoC FPGA on our board with linux kernel 4.14.44 and enabling the USB gadget for HID (keyboard and mouse) and mass st

RE: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-06 Thread Maynard CABIENTE
Hi Minas, I tried your new patch on top of the other 2 patches for a couple of days now and I do not see the issue that Marek encountered. Of course, I did not see it also on the original two patches you created. I also do not see the original FIFO map warning issue that I have with all 3 patch

RE: WARNING: CPU: 0 PID: 0 at ../drivers/usb/dwc2/gadget.c:300 dwc2_hsotg_init_fifo+0x34/0x1b4

2018-11-07 Thread Maynard CABIENTE
Hi Minas, On Wednesday, November 07, 2018 2:10 AM, Minas Harutyunyan wrote: > This warn message popup due to on disconnect not all EP's are disabled and > FIFO released in fifo_map. To solve this issue I submitted patches: > [PATCH v2] usb: dwc2: Disable all EP's on disconnect and fix to above pat

WARNING: CPU: 0 PID: 0 at ../drivers/usb/dwc2/gadget.c:300 dwc2_hsotg_init_fifo+0x34/0x1b4

2018-11-06 Thread Maynard CABIENTE
Hi John, Sorry re-sending as it was detected as spam before (due to HTML subpart). I’m not certain if you are the correct person that maintains the drivers/usb/dwc2 for Linux kernel 4.14. I noticed that 4.20 is a different person. We are using an Altera Cyclone V SoC FPGA on our board with lin