Re: 5.2.x kernel: WD 8TB USB Drives: Unaligned partial completion (resid=78, sector_sz=512)

2019-08-12 Thread Martin K. Petersen
ch > ZONED=0 Damien: What can we do to limit the messages in cases like this? Would it make sense to make the residual warning conditional on sd_is_zoned()? -- Martin K. Petersen Oracle Linux Engineering

Re: 5.2.x kernel: WD 8TB USB Drives: Unaligned partial completion (resid=78, sector_sz=512)

2019-08-07 Thread Martin K. Petersen
lated to the firmware on the > device according to [1] and [2]? Please send us the output of: # sg_vpd -p bl /dev/sdN # sg_vpd -p bdc /dev/sdN # sg_readcap -l /dev/sdN -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-19 Thread Martin K. Petersen
x27;t see it because the device setting always took precedence and voided any user setting. -- Martin K. Petersen Oracle Linux Engineering

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-15 Thread Martin K. Petersen
3 does appear to be a regular SATA drive behind a USB bridge. Have you tried to issue a DSM TRIM command via ATA passthrough? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-14 Thread Martin K. Petersen
o T470s), it _does_ show "UAS". Refer the arrow below: Do you get different sg_readcap -l output when accessing it in UAS mode? I.e. is lbpme=1? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: [PATCH 13/15] scsi: make device_type const

2017-08-25 Thread Martin K. Petersen
Bhumika, > Make these const as they are only stored in the type field of a device > structure, which is const. Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-09 Thread Martin K. Petersen
>>>>> "Oliver" == Oliver Neukum writes: Oliver> On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: >> >>>>> "Oliver" == Oliver Neukum writes: >> Oliver> Some SATA to USB bridges fail to cooperate with some driv

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-18 Thread Martin K. Petersen
aches. That causes data loss when the drive is Oliver> powered down. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-15 Thread Martin K. Petersen
u just blacklist the mode select on the device in question? Something like: if (us->fflags & US_FL_ALWAYS_SYNC) { sdev->skip_ms_page_3f = 1; sdev->skip_ms_page_8 = 1; sdev->wce_default_on = 1; } ? -- Martin K. Peters

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-10 Thread Martin K. Petersen
/* T10 PI (DIF) should be disabled */ unsigned broken_fua:1; /* Don't set FUA bit */ unsigned lun_in_cdb:1; /* Store LUN bits in CDB[1] */ I must be missing something. How is always_sync different from just setting wce_default_on? -- Martin K. Petersen

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-08 Thread Martin K. Petersen
aches. That causes data loss when the drive is Oliver> powered down. Alan? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-15 Thread Martin K. Petersen
>>>>> "Hans" == Hans de Goede writes: Hans> Oliver Neukum is taking over uas maintainership from me and Gerd Hans> Hoffmann. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [-next] BUG_ON in scsi_target_destroy()

2016-04-15 Thread Martin K. Petersen
mes> running target when it has no more scsi devices left on it. So James> the correct patch should be to make the BUG_ON see this: Commit amended. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: optimal io size / custom alignment

2015-06-20 Thread Martin K. Petersen
rive. To me they look like to be of different nature. We don't know whether a discovered device is "a simple drive". And once again: The whole point of the queue limit is to have an common abstraction for all block devices. -- Martin K. Petersen Oracle Linux Engineering --

Re: optimal io size / custom alignment

2015-06-18 Thread Martin K. Petersen
us. As do enterprise disk drives. We deal with broken devices by blacklisting them. I suggest you try to find a way we can reliably identify your UAS devices. If there is a common pattern, we can entertain adding a workaround. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: optimal io size / custom alignment

2015-06-16 Thread Martin K. Petersen
uraging. Tom> I just feel like the kernel shouldn't bind values from totally Tom> different source (raid stripe vs vpd limit) to the same variable. RAID devices communicate the stripe width through the Block Limits VPD. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Martin K. Petersen
t; levels, this ought to work. Looks good, Alan. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Martin K. Petersen
t; SCSI-over-USB transports, only the Bulk-Only transport gives the Alan> LUN separately from the CDB. I don't know if there are any Alan> multi-LUN USB devices that don't use the Bulk-Only transport, but Alan> if there are then they won't work if the LUN isn't stor

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-30 Thread Martin K. Petersen
nn. Alan> Martin, please submit your patch for inclusion in the stable Alan> kernels as soon as possible. James? [PATCH] SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_pa

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-29 Thread Martin K. Petersen
>>>>> "Alan" == Alan Stern writes: Alan> In the case of these bug reports, the scsi_report_opcode() call Alan> returns -EINVAL. Oh, right. Because I actually do an explicit SCSI version check in scsi_report_opcode(). That's OK, then... -- Martin K. Petersen

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-29 Thread Martin K. Petersen
read_write_same() function. But how about we do the following instead? -- Martin K. Petersen Oracle Linux Engineering SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_page() call