Hi,
On Thu, Jan 22, 2015 at 11:43:30AM +0100, Maxime Ripard wrote:
> Hi Yegor,
>
> On Thu, Jan 22, 2015 at 08:37:45AM +0100, Yegor Yefremov wrote:
> > On 21.01.2015 19:53, Bin Liu wrote:
> > > Hi,
> > >
> > > On Wed, Jan 21, 2015 at 10:06 AM, Maxime Ripard
> > > wrote:
> > >> Hi Felipe,
> > >>
Hi,
On Wed, Jan 14, 2015 at 11:08:12AM -0600, Felipe Balbi wrote:
> On Wed, Jan 14, 2015 at 05:12:55PM +0100, 'Markus Pargmann' wrote:
> > Hi,
> >
> > On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote:
> > > From: Markus Pargmann
> > >
Hi,
On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote:
> From: Markus Pargmann
> > The first arugment has to be a pointer to the memory. buf is a char
> > array and already a pointer itself. The current code passes a pointer to
> > a char array to copy_from_user()
The first arugment has to be a pointer to the memory. buf is a char
array and already a pointer itself. The current code passes a pointer to
a char array to copy_from_user() which is not correct.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_debugfs.c | 2 +-
1 file changed, 1
Hi Sebastian,
This thread was about the of_node assignment for the child device
musb-hdrc. Mainline commit:
4fc4b274f9b3 (usb: musb: dsps: do not bind to "musb-hdrc")
On Mon, Nov 25, 2013 at 05:48:54PM +0100, Sebastian Andrzej Siewior wrote:
>
> Is this fixing a bug? Commit 4fc4b2 ("usb:
fsl,usbphy is no optional property. This patch moves it to the list of
required properties.
Signed-off-by: Markus Pargmann
---
Documentation/devicetree/bindings/usb/ci-hdrc-imx.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc
() returned -ENODEV.
Signed-off-by: Markus Pargmann
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 2e58f8dfd311..65444b02bd68 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
Hi,
On Tue, Jul 08, 2014 at 08:28:59PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 07/08/2014 02:14 PM, Markus Pargmann wrote:
>
> >fsl,usbphy is no optional property. This patch moves it to the list of
> >required properties.
>
> >Signed-off-by: Markus Pa
() returned -ENODEV.
Signed-off-by: Markus Pargmann
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 2e58f8dfd311..65444b02bd68 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
fsl,usbphy is no optional property. This patch moves it to the list of
required properties.
Signed-off-by: Markus Pargmann
---
Documentation/devicetree/bindings/usb/ci-hdrc-imx.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc
Hi,
On Fri, Jan 17, 2014 at 10:22:34AM +0100, Markus Pargmann wrote:
> Hi,
>
> The two remaining patches from the previous series "usb: musb bugfixes". In v4
> I used the device name for the debugfs root dir and added a commit message to
> the second patch.
Felipe, cou
debugfs files to show the contents of important dsps registers.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 54
1 file changed, 54 insertions(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index
Replace kzalloc by devm_kzalloc and remove the kfree() calls.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index d0a97d6..6cae0c8 100644
--- a
Hi,
The two remaining patches from the previous series "usb: musb bugfixes". In v4
I used the device name for the debugfs root dir and added a commit message to
the second patch.
Regards,
Markus
Markus Pargmann (2):
usb: musb: dsps, debugfs files
usb: musb: dsps, use de
Hi,
On Mon, Nov 25, 2013 at 05:48:54PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/25/2013 05:14 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote:
> >> It is not safe to assign the of_node to a device with
On Mon, Nov 25, 2013 at 09:58:04AM -0600, Felipe Balbi wrote:
> On Mon, Nov 18, 2013 at 04:54:38PM +0100, Markus Pargmann wrote:
> > Signed-off-by: Markus Pargmann
>
> no commit log == no commit. Sorry, but I'll be very pedantic about it.
Okay I will add a commit messag
Hi,
On Mon, Nov 25, 2013 at 09:57:39AM -0600, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 18, 2013 at 04:54:37PM +0100, Markus Pargmann wrote:
> > @@ -350,6 +373,30 @@ out:
> > return ret;
> > }
> >
> > +static int dsps_musb_dbg_init(st
Hi,
I rebased this series onto Felipe's next branch. There are no other changes.
The series contains two bugfixes and some debugfs file operations for dsps
similar to the musb core regdump debugfs file.
Regards,
Markus Pargmann
Changes in v3:
- Using debugfs_reg32 for regdump debug
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 06debf8..058d611 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
If there is no gadget driver musb should stay in B_IDLE state.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 3 ---
drivers/usb/musb/musb_gadget.c | 14 --
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers
debugfs files to show the contents of important dsps registers.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 55
1 file changed, 55 insertions(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index
It is not safe to assign the of_node to a device without driver. The
device is matched against a list of drivers and the of_node could lead
to a DT match with the parent driver.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 12 +++-
drivers/usb/musb/musb_dsps.c | 1
Hi Felipe,
On Wed, Oct 16, 2013 at 02:51:08PM +0200, Markus Pargmann wrote:
> Hi,
>
> the series contains two bugfixes and some debugfs file operations for dsps
> similar to the musb core regdump debugfs file.
Do you have some time to look at these patches?
Thanks,
Mar
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 0680f0e..aae017c 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
It is not safe to assign the of_node to a device without driver. The
device is matched against a list of drivers and the of_node could lead
to a DT match with the parent driver.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 12 +++-
drivers/usb/musb/musb_dsps.c | 1
debugfs files to show the contents of important dsps registers.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 55
1 file changed, 55 insertions(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index
Hi,
the series contains two bugfixes and some debugfs file operations for dsps
similar to the musb core regdump debugfs file.
Regards,
Markus Pargmann
Changes in v3:
- Using debugfs_reg32 for regdump debug file
- Added a patch to replace kzalloc with devm_kzalloc
- otg->gadget_driver N
If there is no gadget driver musb should stay in B_IDLE state.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 3 ---
drivers/usb/musb/musb_gadget.c | 14 --
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers
On Mon, Oct 14, 2013 at 03:43:35PM -0500, Bin Liu wrote:
> On Mon, Oct 14, 2013 at 10:22 AM, Markus Pargmann wrote:
> > Hi,
> >
> > On Mon, Oct 14, 2013 at 08:54:09AM -0500, Bin Liu wrote:
> >> On Mon, Oct 14, 2013 at 8:35 AM, Markus Pargmann
> >> wr
Hi,
On Mon, Oct 14, 2013 at 08:54:09AM -0500, Bin Liu wrote:
> On Mon, Oct 14, 2013 at 8:35 AM, Markus Pargmann wrote:
> > The USB Controller does not support ID pin change interrupts. So we have
> > to use a polling function to detect changes of A/B device state
> > (
debugfs files to show the contents of important dsps registers.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 87
1 file changed, 87 insertions(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index
When the device is connected to a host without a gadget driver,
otg->gadget is NULL.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 18e8
It is not safe to assign the of_node to a device without driver. The
device is matched against a list of drivers and the of_node could lead
to a DT match with the parent driver.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 12 +++-
drivers/usb/musb/musb_dsps.c | 1
Hi,
the series contains two bugfixes and some debugfs file operations for dsps
similar to the musb core regdump debugfs file.
v2 removes the dev_info() in patch 3 in dsps_musb_init.
Regards,
Markus Pargmann
Markus Pargmann (3):
usb: musb: Handle nullpointer
usb: musb: Bugfix
otg_timer poll
function again.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 84
1 file changed, 78 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index b24b697..0245e8d 100644
When the device is connected to a host without a gadget driver,
otg->gadget is NULL.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 18e8
debugfs files to show the contents of important dsps registers.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_dsps.c | 89
1 file changed, 89 insertions(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index
It is not safe to assign the of_node to a device without driver. The
device is matched against a list of drivers and the of_node could lead
to a DT match with the parent driver.
Signed-off-by: Markus Pargmann
---
drivers/usb/musb/musb_core.c | 12 +++-
drivers/usb/musb/musb_dsps.c | 1
Hi,
the series contains two bugfixes and some debugfs file operations for dsps
similar to the musb core regdump debugfs file.
Regards,
Markus Pargmann
Markus Pargmann (3):
usb: musb: Handle nullpointer
usb: musb: Bugfix of_node assignment
usb: musb: dsps, debugfs files
39 matches
Mail list logo
