-off-by: Maksim Salau
---
`lsusb -v` of the device:
Bus 001 Device 003: ID 09d8:0320
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass2 Communications
bDeviceSubClass 0
bDeviceProtocol 0
Hi Stuart,
> This introduces the `uart_mode` sysfs attribute as seen in the `io_ti`
> USB serial driver, allowing this USB serial interface to be switched
> between RS-232, 2-wire RS-485 and 4-wire RS-485.
Recently I've discovered a blog post by Greg Kroah-Hartman on sysfs files [1].
I believe th
get_version_reply is not freed if function returns with success.
Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")
Reported-by: Heikki Krogerus
Signed-off-by: Maksim Salau
---
v2:
Changed tags to match guidelines.
drivers/usb/misc/legousbtower.c | 1 +
1 file
get_version_reply is not freed if function returns with success.
Memory leak was introduced by commit 942a48730faf149ccbf3e12ac718aee120bb3529
Signed-off-by: Heikki Krogerus
Signed-off-by: Maksim Salau
---
drivers/usb/misc/legousbtower.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface
> > *interface, const struct usb_device
>
> Don't you need to free get_version_reply here?
>
> > return retval;
> >
> > error:
> > + kfree(get_version_reply);
> > tower_delete(dev);
> > return retval;
> > }
> >* removed Tested-by: Alfredo Rafael Vicente Boix ;
>
> I added this back, as it matters, and your change from the previous
> version was trivial.
>
> >* removed Cc: sta...@vger.kernel.org
> > since this patch doesn't apply against v4.10.12
>
> I added this back as well
Allocate buffers on HEAP instead of STACK for local structures
that are to be received using usb_control_msg().
Signed-off-by: Maksim Salau
---
Changes in v3:
* rebased against usb-next;
* removed Tested-by: Alfredo Rafael Vicente Boix ;
* removed Cc: sta...@vger.kernel.org
On Tue, 25 Apr 2017 20:04:24 +0200
Greg Kroah-Hartman wrote:
> On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote:
> > Allocate buffers on HEAP instead of STACK for local structures
> > that are to be received using usb_control_msg().
> >
> > Signed-off-by:
> + } else if (object_is_on_stack(urb->transfer_buffer)) {
> + WARN_ONCE(1, "transfer buffer is on stack\n");
> + ret = -EAGAIN;
> } else {
Hi,
Has anyone considered a fail-safe mode? I.e.: if a buff
Some local constants don't change from call to call and are good
candidates to become static. This will prevent copying of these
constants to stack during runtime.
Signed-off-by: Maksim Salau
---
drivers/usb/serial/upd78f0730.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Allocate buffers on HEAP instead of STACK for local structures
that are to be received using usb_control_msg().
Signed-off-by: Maksim Salau
Tested-by: Alfredo Rafael Vicente Boix
Cc: sta...@vger.kernel.org
---
Changes in v2:
* made checkpatch happy with the format string passed to dev_info
Allocate buffers on HEAP instead of STACK for local structures
that are to be received using usb_control_msg().
Signed-off-by: Maksim Salau
---
I took the liberty to fix the module if Greg don't mind.
It is to be applied on vanilla v4.10.12 (without Greg's patch).
Changes compared
> Sort the device ids by vendor id.
>
> Signed-off-by: Johan Hovold
Thanks for taking care of that. I didn't bothered about order
before your comment about ftd_sio driver.
Maksim.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
The adaptor on Analog Devices EVAL-ADXL362Z development board is used
to flash and debug firmware of on-board Renesas RL78/G13 MCU.
Also added support of the 153600 baud rate, since the stock firmware
uses it.
Signed-off-by: Maksim Salau
---
Changes in v2:
* mentioned additional baudrate in the
The adaptor on Analog Devices EVAL-ADXL362Z development board is used
to flash and debug firmware of on-board Renesas RL78/G13 MCU.
Signed-off-by: Maksim Salau
---
I have no access to such board to test the change, but the VID/PID pair
is found in same Windows driver package.
The stock firmware
> Now applied. Nice work with this one!
Thanks!
Regards,
Maksim.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rsion is supported.
Signed-off-by: Maksim Salau
---
Changes in v6:
Changed commit message prefix to 'USB: serial:'
Removed '__func__ - ' prefix from all WARN and ERR messages
Removed the attach callback (duplicates functionality of generic driver)
Refine
Hi Johan,
> You made some further changes than what I suggested but forgot to
> document those. Often better to explicitly list the changes made rather
> than refer to review comments this way.
Sorry for that, I'll try to describe changes more verbosely.
> > + if (res < 0)
> > + retu
rsion is supported.
Signed-off-by: Maksim Salau
---
Changes in v5:
Fixed a typo in assignment of opcode of the SET_DTR_RTS request
Changes in v4:
Addressed comments from Johan
drivers/usb/serial/Kconfig | 9 +
drivers/usb/serial/Makefile | 1 +
drivers/usb/serial/upd78f0730.c
rsion is supported.
Signed-off-by: Maksim Salau
---
drivers/usb/serial/Kconfig | 9 +
drivers/usb/serial/Makefile | 1 +
drivers/usb/serial/upd78f0730.c | 458
3 files changed, 468 insertions(+)
create mode 100644 drivers/usb/serial/upd78f0
Hi Johan,
> And keep the current modem-control-signal polarity. What are the levels
> of these signals when coming out of reset (i.e. after having connected
> the device, but not opened it yet)?
Thanks.
RTS is low (0V) after plugging the device in.
Regards,
Maksim.
--
To unsubscribe from this li
Hi Johan,
> I think it's right to keep them as in the current version of the patch
> (i.e. active high) which is accordance with the datasheet, but if
> possible you should verify the levels when using hardware flow control
> to be certain that the polarity is not inverted when enabling hardware
>
Hi Johan,
Thanks for feedback.
> > * Dropped inversion of DTR and RTS signals
>
> Did you figure out whether this was needed or not, for example by
> comparing to the hardware flow control levels?
The current version matches the Windows driver.
I don't have any other adapters at the moment, bu
rsion is supported.
Signed-off-by: Maksim Salau
---
PATCH v2 can be found here:
http://thread.gmane.org/gmane.linux.usb.general/137999
Changes from v2:
* Addressed all comments
* Dropped inversion of DTR and RTS signals
* Removed support of software flow control and
added hardware flow control
Hi Johan,
On Sun, 24 Apr 2016 15:36:35 +0200
Johan Hovold wrote:
> On Mon, Feb 29, 2016 at 04:11:20PM +0300, Maksim Salau wrote:
> > The adaptor can be found on development boards for 78k, RL78 and V850
> > microcontrollers produced by Renesas Electronics Corporation.
> &g
rsion is supported.
Signed-off-by: Maksim Salau
---
drivers/usb/serial/Kconfig | 9 +
drivers/usb/serial/Makefile | 1 +
drivers/usb/serial/upd78f0730.c | 543
3 files changed, 553 insertions(+)
create mode 100644 drivers/usb/serial/upd78f0
rsion is supported.
Signed-off-by: Maksim Salau
---
drivers/usb/serial/Kconfig | 9 +
drivers/usb/serial/Makefile | 1 +
drivers/usb/serial/upd78f0730.c | 537
3 files changed, 547 insertions(+)
create mode 100644 drivers/usb/serial/upd78f0
27 matches
Mail list logo
