Re: [RFTv3 PATCH] xhci: rework cycle bit checking for new dequeue pointers

2014-07-30 Thread Maciej Puzio
This works fine, as I have already found by mistakenly leaving find_trb_seg in the code. I also tested kernel 3.16-rc7 with the Asmedia controller; works fine with and without the patch. Thanks Maciej On Wed, Jul 30, 2014 at 11:05 AM, Mathias Nyman wrote: > I think you can leave the find_trb_seg

Re: [RFTv3 PATCH] xhci: rework cycle bit checking for new dequeue pointers

2014-07-30 Thread Maciej Puzio
Apologies, my positive report was somewhat premature. I had to apply the patch manually to 3.2.61, and I missed the deletion of find_trb_seg function. After applying the full patch, xhci-ring.c does not compile, due to call to find_trb_seg in xhci_cmd_to_noop: drivers/usb/host/xhci-ring.c: In func

Re: [RFTv3 PATCH] xhci: rework cycle bit checking for new dequeue pointers

2014-07-29 Thread Maciej Puzio
I tested the patch with kernel 3.2.61 and Asmedia ASM1042A controller (the problematic combination), and the patch fixes the regression. On Tue, Jul 29, 2014 at 11:35 AM, Mathias Nyman wrote: > When we manually need to move the TR dequeue pointer we need to set the > correct cycle bit as well. Pr

Re: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-17 Thread Maciej Puzio
Tested-by: Maciej Puzio On Tue, Jul 8, 2014 at 2:01 PM, Julius Werner wrote: > Commit 1f81b6d22 "usb: xhci: Prefer endpoint context dequeue pointer > over stopped_trb" changed the logic in xhci_find_new_dequeue_state() to > only use the Endpoint Context's TR Dequeue Poi

Re: Possible bug in xhci-ring.c

2014-07-17 Thread Maciej Puzio
, with and without a patch, and same can be said about patched 3.2.61. I am sending "Tested-by" reply to LKML. Thank you very much for your help, I really appreciate it. Maciej Puzio PS. Julius, apology for duplicated email; clicked "reply" instead of "reply to all".

Re: Possible bug in xhci-ring.c

2014-07-15 Thread Maciej Puzio
" tag? > The patch is up here, I think you should've been CCed on it Indeed I was, the mail got misplaced among other linux-usb messages. Sorry about the confusion. Thanks a lot Maciej Puzio -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: Possible bug in xhci-ring.c

2014-07-14 Thread Maciej Puzio
Julius, I am back from vacation and ready to do further tests, or to test your patch if it is available. Apologies for the delay, I have been away from the hardware for a week. Thanks Maciej Puzio -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: Possible bug in xhci-ring.c

2014-07-03 Thread Maciej Puzio
the debug output, this appears to be happening in the new version as well, at least in this particular case. I will be on vacation for the rest of this week and the next one. I will try to answer emails, but unfortunately testing will have to wait until July 14th, when I am back. Thanks a lot Macie

Possible bug in xhci-ring.c

2014-07-01 Thread Maciej Puzio
ented by 16, becomes equal to state->new_deq_ptr, and second part of the expression becomes false. I do not fully understand why the above behavior shows so many differences depending on kernel version and hardware. Help will be greatly appreciated. Thank you! Maciej Puzio Links: [1] https://bug