Hi
> @@ -110,6 +115,7 @@ struct rcar_gen3_chan {
> bool extcon_host;
> bool is_otg_channel;
> bool uses_otg_pins;
> + bool uses_usb_x1;
> };
It seems we can start to think about bit-field around here ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
t; + return 0;
> +}
phy_put() will do nothing if priv->phy was NULL.
We can remove if() here ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
From: Kuninori Morimoto
This patch updates license to use SPDX-License-Identifier
instead of verbose license text.
Signed-off-by: Kuninori Morimoto
---
- 2weeks passed. resend this patch again
include/linux/platform_data/ehci-sh.h | 16 ++--
1 file changed, 2 insertions(+), 14
return;
(snip)
> + /* disable clks if exist */
> + if (priv->num_clks)
> + clk_bulk_disable_unprepare(priv->num_clks, priv->clks);
I think clk_bulk_xxx() will do nothing if priv->num_clks was 0.
priv->num_clks check is not neede, I think.
Best regards
---
Kuninori Morimoto
From: Kuninori Morimoto
This patch updates license to use SPDX-License-Identifier
instead of verbose license text.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- add changlog
include/linux/platform_data/ehci-sh.h | 16 ++--
1 file changed, 2 insertions(+), 14 deleti
Hi Greg
> > From: Kuninori Morimoto
> >
> > Signed-off-by: Kuninori Morimoto
> > ---
> > include/linux/platform_data/ehci-sh.h | 14 +-
> > 1 file changed, 1 insertion(+), 13 deletions(-)
>
> I can not take patches without any chang
From: Kuninori Morimoto
Signed-off-by: Kuninori Morimoto
---
include/linux/platform_data/ehci-sh.h | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/include/linux/platform_data/ehci-sh.h
b/include/linux/platform_data/ehci-sh.h
index 5c15a73..d8397df 100644
From: Kuninori Morimoto
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/renesas_usbhs
From: Kuninori Morimoto
We already have renesas_usbhs_get_info() macro.
Let's use it.
Signed-off-by: Kuninori Morimoto
---
Shimoda-san
can you please check this patch ?
drivers/usb/renesas_usbhs/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
ommon.c | 9 +
> 2 files changed, 24 insertions(+), 5 deletions(-)
For all patches
Acked-by: Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon
Thank you for your patch
> Add fallback compatibility strings for R-Car Gen2 and Gen3.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Also add SoC names.
>
> Signed-off-by: Simon Horman
> ---
(snip)
> Required pro
Hi Simon
> > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
> > > with what I documented elsewhere in the patch)
> >
> > "renesas,rcar-usbhs" is better,
> > but I guess you want to have "renesas,rcar-gen2-usbhs" ?
> >
> > My understanding is these
> >
> > * renesas,usbhs-r8
Hi Simon
> (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
> with what I documented elsewhere in the patch)
"renesas,rcar-usbhs" is better,
but I guess you want to have "renesas,rcar-gen2-usbhs" ?
My understanding is these
* renesas,usbhs-r8a77xx# SoC specific
* renes
Hi Simon
> > > Add fallback compatibility string.
> > > This is in keeping with the fallback scheme being adopted wherever
> > > appropriate for drivers for Renesas SoCs.
> > >
> > > Signed-off-by: Simon Horman
> > > ---
> > (snip)
> > > + {
> > > + .compatible = "renesas,usbhs",
> > >
Hi Simon
> Add fallback compatibility string.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Signed-off-by: Simon Horman
> ---
(snip)
> + {
> + .compatible = "renesas,usbhs",
> + .data = (void *)US
Hi Shimoda-san
> This patch adds a compatible string to support for R-Car H3.
>
> Since the HS-USB controller of R-Car H3 is almost the same specification
> with R-Car Gen2 (these have 16 pipes and usb-dmac), this patch
> sets the "type" of renesas_usbhs_driver_param to USBHS_TYPE_RCAR_GEN2.
>
From: Kuninori Morimoto
Current usbhs_for_each_dfifo macro will read out-of-array's
memory after last loop operation.
It was not good C language operation, and the binary which was
compiled by (at least) gcc 4.8.1 is broken.
This patch is based on
925403f425a4a9c503f2fc295652647b1eb10d82
From: Kuninori Morimoto
Current usbhs_for_each_dfifo macro will read out-of-array's
memory after last loop operation.
It was not good C language operation, and the kernel which was
compiled by (at least) gcc 4.8.1 will be broken.
This patch is based on
925403f425a4a9c503f2fc295652647b1eb
Hi shimoda-san
> This patch series is based on Felipe's usb.git / testing/next branch.
> (commit id = 05cf6e00b8ff2b80c8b2d1e69f07cdd6c830efe0)
>
> Yoshihiro Shimoda (2):
> usb: renesas_usbhs: add usbhsf_dma_init_pdev() function
> usb: renesas_usbhs: add support for requesting DT DMA
>
> .
> #define USBHSG_STATUS_SELF_POWERED (1 << 3)
> +
> + unsignedsoftconnect:1;
> };
We can re-use USBHSG_STATUS_xxx instead of new variable ?
renesas_usb driver has usbhsg_status_xxx() macro.
Best regards
---
Kuninori Morimoto
--
To unsubscribe f
uep_to_pipe(uep);
>
> + if (!uep || !uep->pipe)
> + return -EINVAL;
> +
> usbhsg_pipe_disable(uep);
> usbhs_pipe_free(pipe);
If uep can be NULL,
we need care about usbhsg_uep_to_pipe(uep) too.
and, "uep->pipe" is same as "pipe" ?
+)
> create mode 100644 Documentation/devicetree/bindings/usb/renesas_usbhs.txt
For all patches
Acked-by: Kuninori Morimoto
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;enable-gpio", 0, NULL);
> + if (gpio > 0)
> + dparam->enable_gpio = gpio;
(snip)
> +static const struct of_device_id usbhs_of_match[] = {
> + { .compatible = "renesas,usbhs-r8a7790"},
> + { .compatible = "renesas,usbhs-r8a7791"},
> + { },
drivers/usb/renesas_usbhs/rcar2.h
For all patches
Acked-by: Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; re-connecting
>
> drivers/usb/renesas_usbhs/mod_gadget.c |2 ++
> drivers/usb/renesas_usbhs/pipe.c | 11 +++
> drivers/usb/renesas_usbhs/pipe.h |1 +
> 3 files changed, 14 insertions(+)
For all patches
Acked-by: Kuninori Morimoto
--
To unsubs
be() using memcpy() for getting info->xxx)
I guess struct usbhs_priv is good place,
and you can use usbhs_pdev_to_priv() for this purpose ?
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to major
ping ?
> From: Kuninori Morimoto
>
> Current usbhs gadget driver didn't complete STATUS stage after receiving.
> It wasn't problem for us before, because some USB class doesn't use
> DATA OUT stage in control transfer.
> But, it is required on some device.
>
Hi Sergei
> > + /*
> > +* Transmission end
> > +*/
> > + if (*is_done) {
> > + if (usbhs_pipe_is_dcp(pipe))
>
> Why not collapse these into single *if*? That would decrease the
> indentation level...
This is same style with TX case
--
To unsubscribe from this list: s
From: Kuninori Morimoto
Current usbhs gadget driver didn't complete STATUS stage after receiving.
It wasn't problem for us before, because some USB class doesn't use
DATA OUT stage in control transfer.
But, it is required on some device.
Signed-off-by: Yoshihiro Shimoda
Signed-o
Hi Felipe
> > + chan = dma_request_slave_channel_compat(mask,
> > + shdma_chan_filter, (void *)id, dev, name);
>
> this adds a build warning:
>
> drivers/usb/renesas_usbhs/fifo.c:1012:24: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cas
From: Kuninori Morimoto
Remove original filter from usbhsf_dma_init(),
and use SH-DMA suitable filter.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/fifo.c | 76 +++---
drivers/usb/renesas_usbhs/fifo.h |3 --
2 files changed, 39
From: Kuninori Morimoto
DMAEngine uses IRQ if dma_request_channel() was called,
and it is using devm_request_irq() today,
OTOH, dma_request_channel() will be called when each
USB connection happened on this driver.
This means same IRQ will be requested many times
whenever each USB connected,
and
Hi Felipe again
# my previous email didn't include USB-ML
These patches cleanup DMAEngine port on renesas_usbhs.
#1 is bugfix patch
#2 is new feature patch
Kuninori Morimoto (2):
usb: renesas_usbhs: fifo: request DMAEngine once
usb: renesas_usbhs: remove original filter
eate mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
> create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
For all patches
Acked-by: Kuninori Morimoto
# I think we can implement usb_phy_xxx() method
# in renesas_usbhs driver someday.
Best regards
---
Kuninori M
callbacks. Thus, looks like the phy driver can't really
> auto-suspend and doesn't really support runtime PM.
>
> I think that handling clocks in the init/shutdown is a bit cleaner.
> It gives us more control over the phy power, where pm_runtime_xxx will
> do nothing if
7;ll still need it later to properly configure the channel.
> Besides, is saves us some bits leaving all the unused callbacks and
> device structures out if we do not register the device when the driver
> is disabled.
Ahh, I see.
Sorry for my noise
Best regards
---
Kuninori Mo
Hi Valentine
> This adds USBHS PHY and registers USBHS device if the driver is enabled.
>
> Signed-off-by: Valentine Barshak
> ---
(snip)
> +/* USBHS */
> +#if IS_ENABLED(CONFIG_USB_RENESAS_USBHS_UDC)
> +static const struct resource usbhs_resources[] __initconst = {
> + DEFINE_RES_MEM(0xe65
Hi Valentine
Thank you for your patch
> +/* Setup USB channels */
> +static void __rcar_gen2_usb_phy_setup(struct rcar_gen2_usb_phy_priv *priv)
> +{
> + u32 val;
> +
> + clk_prepare_enable(priv->clk);
> +
> + /* Set USB channels in the USBHS UGCTRL2 register */
> + val = ioread32
Hi Valentine
> @@ -296,6 +298,8 @@ static struct clk_lookup lookups[] = {
> CLKDEV_DEV_ID("ee22.mmcif", &mstp_clks[MSTP305]),
> CLKDEV_DEV_ID("sh_mmcif.1", &mstp_clks[MSTP305]),
> CLKDEV_DEV_ID("sh_cmt.0", &mstp_clks[MSTP124]),
> + CLKDEV_DEV_ID("renesas_usbhs", &mstp_cl
d-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_gadget.c |6 +++---
drivers/usb/renesas_usbhs/mod_host.c |6 +++---
drivers/usb/renesas_usbhs/pipe.h |6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_gadget
: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_gadget.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c
b/drivers/usb/renesas_usbhs/mod_gadget.c
index ed4949f..805940c 100644
--- a/drivers/usb/renesas_usbhs/mod_gadget.c
+++ b/drivers/usb
rry.
This mention (= phy and ohci/ehci registration in one function) was my fault.
Your style is correct I think.
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I just copied your approach from the R8A7779 code.
Ahh, yes, indeed
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ly if Soc/platform
calls r8a7778_init_late().
but, usb phy isn't registered without r8a7778_add_usb_phy_device().
The ohci/ehci resource will be used vainly if platform doesn't have USB
ohci/ehci and phy should be registered in same time/function.
Best regards
---
Kun
> used or not
> > >>> on BOCK-W board? PHY initialization seems to work with either
> > >>> settings...
> > >> I can ask it to HW team if you want me.
> >
> > Yes, ask them please.
>
> Now, I'm asking it to HW team
> Plea
W board? PHY initialization seems to work with either
> >>> settings...
> >> I can ask it to HW team if you want me.
>
> Yes, ask them please.
Now, I'm asking it to HW team
Please wait
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
sed or not
> on BOCK-W board? PHY initialization seems to work with either settings...
I can ask it to HW team if you want me.
But our local BSP is using "No ferrite bead" settings...
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe l
rcar-phy: remove EHCI internal buffer setup
> [5/9] ARM: shmobile: R8A7779: remove USB PHY 2nd memory resource
> [6/9] rcar-phy: correct base address
> [7/9] rcar-phy: add platform data
> [8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device
> [9/9] rcar-phy: handle platf
> so
> maybe the patchset can be merged thru Simon's tree with Felipe's and Alan
> Stern's ACKs.
I guess you already got request about patch style from Simon.
When you send v2 patch, could you please add "this patch is tested on bard"
on each patch's co
: Kuninori Morimoto
---
>> Felipe
Does this solve "error" issue ?
# I guess common.c still has "warning" though...
arch/arm/mach-shmobile/board-armadillo800eva.c |8 ++--
arch/arm/mach-shmobile/board-kzm9g.c |8 ++--
arch/arm/mach-shmobile/boar
Hi Felipe
> > On Wed, Mar 27, 2013 at 06:21:19PM -0700, Kuninori Morimoto wrote:
> > > > linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible
> > > > types in conditional expression (different base types)
> > > > linux/driver
which branch or commit are you using ?
- which compiler are you using ?
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
REN | MEMEN;
> >> >> + AHB_WRITE(hci, data, OHCI_CMND_STS);
> >> >> + AHB_WRITE(hci, data, EHCI_CMND_STS);
> >> >> +
> >> >> + /* enable pci interrupt */
> >> >> + data = __raw_readl(hci->base + PCI_INT_ENABLE);
> >> >> + data |= USBH_PMEEN | USBH_INTBEN | USBH_INTAEN;
> >> >> + AHB_WRITE(hci, data, PCI_INT_ENABLE);
(snip)
> > ohci-rmobile.c -> ohci->sh.c
> > ohci-common.c -> ohci-r8a7740.c
> >
>
> Thanks for your comment.
> OK, I will rename and update patches.
Could you please teach me current status of this patch ?
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
on(dev);
if (err < 0)
return err;
}
...
hcd->regs = devm_ioremap_resource(&dev->dev, res_mem);
if (IS_ERR(hcd->regs)) {
err = PTR_ERR(hcd->regs);
goto err_put_hcd;
}
# init() here ?
if (pdata->init)
err = pdata->init(dev, hcd->regs);
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
his driver even...
I'm not sure what is the best solution.
But current rcar_usb_phy is expecting above (strange) mapping,
and initialize method is came from datasheet
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ite32(0x, (reg0 + USBPCTRL0));
>
> Why change this register at all at shutdown?
Sorry, I didn't mention about these settings value on this patch.
This driver is using the fixed value for particular applications at this point,
because of prototype driver at that point.
This me
| 4 +
drivers/usb/host/Makefile |1 +
drivers/usb/host/ehci-hcd.c |5 +
drivers/usb/host/ehci-rmobile.c | 384 +
drivers/usb/host/ohci-hcd.c | 21 +-
drivers/usb/host/ohci-rmobile.c | 377
drivers/usb/host/rmobile-common.c | 145 ++
drivers/usb/host/rmobile-common.h | 53 +
include/linux/usb/rmobile.h | 254
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ci, data, OHCI_CMND_STS);
> + AHB_WRITE(hci, data, EHCI_CMND_STS);
> +
> + /* enable pci interrupt */
> + data = __raw_readl(hci->base + PCI_INT_ENABLE);
> + data |= USBH_PMEEN | USBH_INTBEN | USBH_INTAEN;
> + AHB_WRITE(hci, data, PCI_INT_ENABLE);
Are these
on't be freed.
OK, I see
Sorry for my noise
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
free_endpoints(dwc);
>
> @@ -2514,13 +2530,7 @@ err0:
>
> void dwc3_gadget_exit(struct dwc3 *dwc)
> {
> - int irq;
> -
> usb_del_gadget_udc(&dwc->gadget);
> - irq = platform_get_irq(to_platform_device(dwc->dev), 0);
> -
> - dwc3_writel(dwc->regs, DWC3_DEVTEN, 0x00);
> - free_irq(irq, dwc);
>
> dwc3_gadget_free_endpoints(dwc);
>
> --
> 1.8.1.rc1.5.g7e0651a
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Current usbhsg_ep_disable() didn't care
uep->pipe and pipe->mod_private variable which is used on usbhsg_ep_enable().
It breaks renesas_usbhs gadget when resume.
This patch fixes it.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_gadget.c | 11 ---
1 f
Current driver always initialized uep->pipe to NULL on usbhsg_try_start().
But it breaks relationship with
usb_ep_ops :: enable/disable functions when suspend/resume.
This patch solved this issue by initializing uep->pipe on probe()
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas
Hi felipe, Greg
Cc Simon
These are renesas_usbhs gadget suspned/resume fixup patches.
Without these patches, renesas_usbhs gadget resume will break.
Kuninori Morimoto (2):
usb: renesas_usbhs: gadget: remove usbhsg_uep_init()
usb: renesas_usbhs: gadget: usbhsg_ep_disable() care pipe
Hi Felipe
> > usbhsh_ureq_free() free ureq which includes ubshs_pkt.
> > But current driver used usbhs_pkt after freed ureq.
> > This patch fixup this bug.
> > Special thanks to Chen
> >
> > Reported-by: Chen Gang
> > Signed-off-by: Kuninori Morimot
usbhsh_ureq_free() free ureq which includes ubshs_pkt.
But current driver used usbhs_pkt after freed ureq.
This patch fixup this bug.
Special thanks to Chen
Reported-by: Chen Gang
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_host.c |3 ++-
1 file changed, 2 insertions
gt; I prefer the relative member to provide relative patch.
> if can not find relative member, I should try (although it seems not a
> good idea)
Thank you for your review, and nice catch !
I think this is bug, and I didn't notice it.
Best regards
---
Kuninori Morimoto
--
To
ge address mapping.
Thus, it is difficult to calculate transfer counter setting address.
This patch use fixed table for it.
Signed-off-by: Kuninori Morimoto
---
>> Felipe
This patch is based on felipe/gadget branch.
But you will get conflict when you merged with feli
created strange driver behavior.
But it can re-use this attached pipe if multi urb was queued.
This patch implements it.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_host.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a
ge address mapping.
Thus, it is difficult to calculate transfer counter setting address.
This patch use fixed table for it.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/fifo.c |4 ++
drivers/usb/renesas_usbhs/pipe.c | 101 ++
d
Because usbhsh_hub_status_data() will be called many times,
there are too many obstructive/useless debug informations if driver has #define
DEBUG.
Thus, other important dev_dbg() information will hide.
This patch removed obstructive/useless dev_dbg().
Signed-off-by: Kuninori Morimoto
Hi Felipe, GregKH
These pathces fixup renesas_usbhs host side strange behavior for v3.8 kernel.
based on felipe/master branch
Kuninori Morimoto (3):
usb: renesas_usbhs: remove debug information from usbhsh_hub_status_data()
usb: renesas_usbhs: use transfer counter if IN direction
f function\
'iowrite32' [-Werror=implicit-function-declaration]
drivers/usb/phy/rcar-phy.c:83:4: error: implicit declaration of function\
'ioread32' [-Werror=implicit-function-declaration]
Signed-off-by: Kuninori Morimoto
---
>> Felipe
Sorry for late
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v5 -> v6
- used if (priv->counter++ == 0)
- used if (priv-&g
This patch enabled dma mapping, and used dma transfer handler
on mod_host
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_host.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_host.c
b/drivers/usb
mod.h has irq_bempsts/irq_brdysts to keep each irq status,
but it was difficult to find where they were used
on renesas_usbhs driver by using "grep irq_" command,
since it used irq_##status macro.
This patch fixup them
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_us
This patch uses devm_request_irq() instead of request_irq(),
and removed free_irq() from driver
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/phy/Kconfig| 12 +++
drivers/usb/phy/Makefile
Hi felipe
These are resend patches for renesas usb drivers.
Kuninori Morimoto (4):
usb: phy: add R-Car USB phy driver
usb: renesas_usbhs: use devm_request_irq()
usb: renesas_usbhs: fixup unreadable macro
usb: renesas_usbhs: add DMAEngine support on mod_host
drivers/usb
Hi Felipe
> > This patch enabled dma mapping, and used dma transfer handler
> > on mod_host
> >
> > Signed-off-by: Kuninori Morimoto
> > ---
> > Felipe
> >
> > I sent some patches before, and I guess it will go to v3.8 branch.
>
renesas_usbhs driver can switch DMA/PIO transfer by using handler,
and each handler have push/pop direction.
But unfortunately, current dma push handler didn't a path
which calls usbhs_pipe_enable(). Thus, dma transfer never happened.
this patch fixes it.
Signed-off-by: Kuninori Mor
If renesas_usbhs or DMAEngine interrupt didn't happen by a certain cause,
urb->ep will be NULL by usb time out.
Then, host mode will access to it and crash kernel.
This patch fixes it.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_host.c |5 +
1 file ch
__usbhs_for_each_pipe() is the macro which moves around each pipe,
but it has a bug which didn't care about 1st pipe's position.
Because of this bug, it moves around
pipe0, pipe2, pipe3 ... even though it requested pipe1, pipe2, pipe3...
This patch modifies it.
Signed-off-by: Kuninor
This patch adds usbhs_sys_function_pullup() to control
D+ line for USB function, and enabled pullup support on mod_gadget.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- add explain on log
drivers/usb/renesas_usbhs/common.c |5 +
drivers/usb/renesas_usbhs/common.h |
Hi Felipe
> On Thu, Oct 11, 2012 at 09:49:38PM -0700, Kuninori Morimoto wrote:
> > When interrupt happened, renesas_usbhs driver gets irq status
> > by usbhs_status_get_each_irq(), and cleared all status by using 0.
> > But, this method is incorrect,
> > since extra in
Hi Felipe
Thank you for checking patch
> On Wed, Oct 10, 2012 at 07:18:45PM -0700, Kuninori Morimoto wrote:
> > renesas_usbhs can't handle scatter/gather type DMA.
> > Thus, return -EINVAL is better than WARNING() on mod_gadget
> >
> > Signed-off-by: Kuninor
mod.h has irq_bempsts/irq_brdysts to keep each irq status,
but it was difficult to find where they were used
on renesas_usbhs driver by using "grep irq_" command,
since it used irq_##status macro.
This patch fixup them
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_us
When interrupt happened, renesas_usbhs driver gets irq status
by usbhs_status_get_each_irq(), and cleared all status by using 0.
But, this method is incorrect,
since extra interrupt might occur between them.
This patch cleared corresponding bits only
Signed-off-by: Kuninori Morimoto
---
drivers
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/common.c |5 +
drivers/usb/renesas_usbhs/common.h |1 +
drivers/usb/renesas_usbhs/mod_gadget.c | 11 +++
3 files changed, 17 insertions(+)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb
1st pos of __usbhs_for_each_pipe() was wrong.
Each pipe were pipe0, pipe2, pipe3 ...
This patch modifies it.
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/pipe.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_usbhs/pipe.h b/drivers
renesas_usbhs can't handle scatter/gather type DMA.
Thus, return -EINVAL is better than WARNING() on mod_gadget
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod_gadget.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_
This patch enabled dma mapping, and used dma transfer handler
on mod_host
Signed-off-by: Kuninori Morimoto
---
Felipe
I sent some patches before, and I guess it will go to v3.8 branch.
please let me know if you want me to resend these.
drivers/usb/renesas_usbhs/mod_host.c | 17
This patch uses devm_request_irq() instead of request_irq(),
and removed free_irq() from driver
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/mod.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v4 -> v5
- removed LITTLE/BIG define
- use if (val == (ACT |
Dear Simon
> On Mon, Sep 10, 2012 at 07:06:48PM -0700, Kuninori Morimoto wrote:
> > This patch adds Renesas R-Car USB phy driver.
> > It supports R8A7779 chip at this point.
> >
> > R-Car has some USB controllers, but has only one phy-initializer.
> >
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v3 -> v4
- rcar_usb_phy_shutdown() became static
- used p
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- used devm_request_and_ioremap()
drivers/usb/renesas_usbhs/common.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb/renesas_usbhs/common.c
index 681d
000 ===
EHCI
--
0x0094 PHY
0x009C PHY
--
EHCI
0x0400 ==
...
0x0800 --
PHY
0x0900 --
This driver couldn't probe if it used "request_mem_regio
Signed-off-by: Kuninori Morimoto
---
drivers/usb/renesas_usbhs/common.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb/renesas_usbhs/common.c
index 681da06..d56e1f6 100644
--- a/drivers/usb/renesas_usbhs
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v2 -> v3
- remove /* spin lock */ /* spin unlocked */
- fixup mu
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- enable usb_phy_xxx()
- used subsys_initcall()
drivers/
1 - 100 of 128 matches
Mail list logo
