Re: usb/hid: slab-out-of-bounds read in usbhid_parse

Hi Andrey 2017-09-19 21:38 GMT+09:00 Andrey Konovalov : > On Tue, Sep 19, 2017 at 1:47 PM, Kim Jaejoong wrote: >> Hi, Andrey Konovalov >> >> Thanks for the report. >> >> 2017-09-19 2:33 GMT+09:00 Andrey Konovalov : >>> Hi! >>> >>>

Re: usb/hid: slab-out-of-bounds read in usbhid_parse

Hi, Andrey Konovalov Thanks for the report. 2017-09-19 2:33 GMT+09:00 Andrey Konovalov : > Hi! > > I've got the following crash while fuzzing the kernel with syzkaller. > > On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). > > It seems that there's no proper check on the hdesc->bNumDes

Re: [PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

2017-03-02 23:13 GMT+09:00 Benjamin Tissoires : > On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: >> The hid-core announces kernel message which driver is loaded if there is >> a hiddev, but hiddev's minor number is always zero even though it's not >> zero. >> >> So, we need to store the minor n

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-02 23:10 GMT+09:00 Benjamin Tissoires : > On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: >> We need to store the minor number each drivers. In case of hidraw, it's >> minor number stores in struct hidraw. But hiddev's minor is located in >> struct hid_device. >> >> So reallocates for hi

Re: [PATCH v2] HID: hiddev: allocate minor number hiddev's USB interface is bound to

Hi Benjamin Thanks for the review my patch :) 2017-03-01 2:05 GMT+09:00 Benjamin Tissoires : > On Feb 15 2017 or thereabouts, Jaejoong Kim wrote: >> When HID device connected to the PC, HID device driver announces which >> driver is loaded with a kernel info message. In this case, hiddev's minor

Re: [PATCH v2] HID: hiddev: allocate minor number hiddev's USB interface is bound to

Hi Jiri, Benjamin Could you please review my hiddev patch? Thanks, jaejoong 2017-02-15 18:55 GMT+09:00 Jaejoong Kim : > When HID device connected to the PC, HID device driver announces which > driver is loaded with a kernel info message. In this case, hiddev's minor > number is always '0' even t

Re: [PATCH v2] usb: core: update comments for send message functions

Keep sending several times same patch file is totally my fault. I am really sorry about that. (today I said lots of 'sorry'..) My default gmail's view options is conversation view. And this conversation view option makes me misunderstand my resend path is reply the previous mail with subject [PATC

Re: [PATCH v2] usb: core: update comments for send message functions

I just want to send v2 patch with new mail thread with subject [PATCH v2] not reply I don't understand why v2 patch mail is followed previous mail thread. --no-chain-reply-to : fail ( this is wrong option for in this case) --subject-prefix "PATCH v2" : fail.. why? This is what I did for send patc

Re: [PATCH] usb: core: update comments for send message functions

really really sorry for noisy mail. Please ignore this mail. I will resend patch with right subject.. Jaejoong 2017-01-18 10:46 GMT+09:00 Jaejoong Kim : > The commonly use of bottom halves are tasklet and workqueue. The big > difference between tasklet and workqueue is that the tasklet runs in >

Re: [PATCH] usb: core: update comments for send message functions

Hi Alan 2017-01-18 0:57 GMT+09:00 Alan Stern : > On Tue, 17 Jan 2017, Jaejoong Kim wrote: > >> The commonly use of a bottom half are tasklet and workqueue. The big >> difference between tasklet and workqueue is that the tasklet runs in >> an interrupt context and the workqueue runs in a process co

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

Hi Oliver and Greg 2016-12-12 19:45 GMT+09:00 Oliver Neukum : > On Thu, 2016-12-08 at 16:16 +0100, Greg KH wrote: >> On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote: >> > > Do you have a driver that was based on this skeleton that needed this >> > > flag to be added to work properly?