Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-25 Thread Jonathan Liu
Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb() in ohci controller case. The finish_urb ca

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-24 Thread Jonathan Liu
Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > Hi, > > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb() in ohci controller case. The f

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-24 Thread Jonathan Liu
Hi, On 8 February 2018 at 14:55, Jeffy Chen wrote: > From: AMAN DEEP > > There is a race condition between finish_unlinks->finish_urb() function > and usb_kill_urb() in ohci controller case. The finish_urb calls > spin_unlock(&ohci->lock) before usb_hcd_giveback_urb() function call, > then if du

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-16 Thread Jonathan Liu
On 16 October 2017 at 23:49, Bin Liu wrote: > On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: >> On 10 October 2017 at 14:22, Bin Liu wrote: >> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> >> This fixes a kernel oops wh

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-15 Thread Jonathan Liu
On 10 October 2017 at 14:22, Bin Liu wrote: > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the device is >> detached. Calling usb_p

[PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
el.org # v4.3+ Signed-off-by: Jonathan Liu --- Changes for v2: - Use devm_usb_put_phy instead of usb_put_phy drivers/usb/musb/sunxi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index c9a09b5bb6e5..dc353e24d53c 100644 --- a/drivers/us

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
Hi, On 10 October 2017 at 13:14, Bin Liu wrote: > On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote: >> Hi, >> >> On 10 October 2017 at 01:23, Bin Liu wrote: >> > Hi, >> > >> > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrot

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
Hi, On 10 October 2017 at 01:23, Bin Liu wrote: > Hi, > > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the device is

[PATCH] usb: musb: Check for host-mode using is_host_active() on reset interrupt

2017-09-27 Thread Jonathan Liu
the driver logic and does not rely on register contents. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Jonathan Liu --- drivers/usb/musb/musb_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 02969205

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-09-26 Thread Jonathan Liu
Hi, On 26 September 2017 at 21:39, Jonathan Liu wrote: > This fixes a kernel oops when unloading the driver due to usb_put_phy > being called after usb_phy_generic_unregister when the device is > detached. Calling usb_phy_generic_unregister causes x->dev->driver to > be NULL

[PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-09-26 Thread Jonathan Liu
icitly managing the lifetime of usb_phy, devm_usb_get_phy is changed to usb_get_phy and we call usb_put_phy in the probe error path. Cc: sta...@vger.kernel.org # v4.3+ Signed-off-by: Jonathan Liu --- drivers/usb/musb/sunxi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

Re: [linux-sunxi] [PATCH v5 2/7] phy-sun4i-usb: Add extcon support for the otg phy (phy0)

2015-07-31 Thread Jonathan Liu
Hi Hans, On 13/06/2015 10:37 PM, Hans de Goede wrote: The sunxi musb glue needs to know if a host or normal usb cable is plugged in, add extcon support so that the musb glue can monitor the host status. Signed-off-by: Hans de Goede --- Changes in v5: -Split out of the "Add id and vbus detectio