On Tue, Jul 23, 2019 at 1:27 PM John Stultz wrote:
>
> From: Anurag Kumar Vulisha
>
> The present code in dwc3_gadget_ep_reclaim_completed_trb() will check
> for IOC/LST bit in the event->status and returns if IOC/LST bit is
> set. This logic doesn't work if mu
Joglekar
Reviewed-by: Thinh Nguyen
Signed-off-by: Anurag Kumar Vulisha
[jstultz: forward ported to mainline, added note to commit log]
Signed-off-by: John Stultz
---
Just wanted to send this out so we're all looking at the same thing.
Not sure if its correct, but it seems to solve the adb s
On Thu, Jul 18, 2019 at 6:12 PM Thinh Nguyen wrote:
> fei.y...@intel.com wrote:
> > From: Fei Yang
> >
> > If scatter-gather operation is allowed, a large USB request is split into
> > multiple TRBs. These TRBs are chained up by setting DWC3_TRB_CTRL_CHN bit
> > except the last one which has DWC3
On Fri, Jun 28, 2019 at 3:58 PM Sasha Levin wrote:
>
> On Fri, Jun 28, 2019 at 06:24:04PM +, John Stultz wrote:
> >With recent changes in AOSP, adb is using asynchronous io, which
> >causes the following crash usually on a reboot:
> >
> >[ 184.278302] BUG: sche
Balbi
(cherry picked from commit d5443bbf5fc8f8389cce146b1fc2987cdd229d12)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 2 ++
drivers/usb/dwc3/gadget.c | 1 +
drivers/usb/dwc3/gadget.h | 15 +++
3 files changed, 18 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b
# 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 3 ---
drivers/usb/dwc3/gadget.c | 40 +--
2 files changed, 1 insertion(+), 42 deletions(-)
diff
@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit d4f1afe5e896c18ae01099a85dab5e1a198bd2a8)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers
: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 65ba1038b111..eaa78e6c972c 100644
--- a/drivers/usb/dwc3/gadget.c
")
Cc: Fei Yang
Cc: Sam Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Jack Pham
Signed-off-by: Felipe Balbi
(cherry picked from commit bd6742249b9ca918565e4e3abaa06665e587f4b5)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/ga
usb: dwc3: gadget: extract dwc3_gadget_ep_skip_trbs()
usb: dwc3: gadget: introduce cancelled_list
usb: dwc3: gadget: move requests to cancelled_list
usb: dwc3: gadget: remove wait_end_transfer
Jack Pham (1):
usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup
John Stultz (1):
Rever
Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit 7746a8dfb3f9c91b3a0b63a1d5c2664410e6498d)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 61 +++
1 file
rry picked from commit 09fe1f8d7e2f461275b1cdd832f2cfa5e9be346d)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 3 +++
drivers/usb/dwc3/gadget.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4872cba8699b..0de78cb29
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit c3acd59014148470dc58519870fbc779785b4bf7)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 28
1 file changed, 4 insertions(+), 24
should be treated equally.
Cc: Fei Yang
Cc: Sam Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit 1a22ec643580626f439c8583edafdcc73798f2fb)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h
On Fri, Jun 28, 2019 at 3:10 AM Gopal, Saranya wrote:
>
> > With recent changes in AOSP, adb is using asynchronous io, which
> > causes the following crash usually on a reboot:
> >
> > [ 184.278302] BUG: scheduling while atomic: ksoftirqd/0/9/0x0104
> > [ 184.284617] Modules linked in: wl18x
On Thu, Jun 27, 2019 at 10:54 PM Jack Pham wrote:
> On Thu, Jun 27, 2019 at 08:52:39PM +0000, John Stultz wrote:
> > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> > index 879f652c5580..843586f20572 100644
> > --- a/drivers/usb/dwc3/gadget.c
>
-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 879f652c5580..843586f20572 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -177,8 +177,6 @@ static void
# 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 3 ---
drivers/usb/dwc3/gadget.c | 40 +--
2 files changed, 1 insertion(+), 42 deletions(-)
diff
rry picked from commit 09fe1f8d7e2f461275b1cdd832f2cfa5e9be346d)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 3 +++
drivers/usb/dwc3/gadget.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4872cba8699b..0de78cb29
should be treated equally.
Cc: Fei Yang
Cc: Sam Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit 1a22ec643580626f439c8583edafdcc73798f2fb)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit c3acd59014148470dc58519870fbc779785b4bf7)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 28
1 file changed, 4 insertions(+), 24
@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit d4f1afe5e896c18ae01099a85dab5e1a198bd2a8)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers
")
Cc: Fei Yang
Cc: Sam Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Jack Pham
Signed-off-by: Felipe Balbi
(cherry picked from commit bd6742249b9ca918565e4e3abaa06665e587f4b5)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/ga
Protsenko
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.19.y
Signed-off-by: Felipe Balbi
(cherry picked from commit 7746a8dfb3f9c91b3a0b63a1d5c2664410e6498d)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/gadget.c | 61 +++
1 file
wait_end_transfer
Jack Pham (1):
usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup
John Stultz (1):
Revert "usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup"
drivers/usb/dwc3/core.h | 15 ++--
drivers/usb/dwc3/gadget.c | 158 +
Balbi
(cherry picked from commit d5443bbf5fc8f8389cce146b1fc2987cdd229d12)
Signed-off-by: John Stultz
---
drivers/usb/dwc3/core.h | 2 ++
drivers/usb/dwc3/gadget.c | 1 +
drivers/usb/dwc3/gadget.h | 15 +++
3 files changed, 18 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b
On Mon, May 13, 2019 at 7:08 AM Andrzej Pietrasiewicz
wrote:
> W dniu 09.05.2019 o 23:23, John Stultz pisze:
> > So yes, the kzalloc/memset patch is a clear improvement, as it avoids
> > the bootup crash on dwc2, and seems like it should go in.
> >
> > However, the
Hey Andrzej,
I just wanted to let you know, trying to boot linus/master on the
hikey board today, I've been seeing lots of errors on boot (which
sometimes crash the board, and sometimes doesn't). See the example
below.
I've bisected the issue down to 10209abe87f5 ("usb: dwc2: gadget: Add
scatter
On Sat, Mar 2, 2019 at 4:05 AM Yu Chen wrote:
> +static int hisi_hikey_usb_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct device_node *root = dev->of_node;
Minor nit: root is unused and generates build warnings.
thanks
-john
er
Cc: Andrzej Pietrasiewicz
Cc: Greg Kroah-Hartman
Cc: Linux USB List
Suggested-by: Alan Stern
Signed-off-by: John Stultz
---
drivers/usb/gadget/function/f_fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_fs.c
b/drivers/usb/gadget/function/f_fs.c
index 1e5
On Sat, Feb 2, 2019 at 9:00 AM Alan Stern wrote:
>
> On Fri, 1 Feb 2019, John Stultz wrote:
>
> > Hey all,
> > Since the 5.0 merge window opened, I've been tripping on frequent
> > dwc3 crashes on reboot and suspend, which I've added an example to the
>
On Fri, Feb 1, 2019 at 4:46 PM Thinh Nguyen wrote:
> John Stultz wrote:
> > On Fri, Feb 1, 2019 at 4:18 PM John Stultz wrote:
> > Bisecting the changes down, it seems like its due to commit
> > fec9095bdef4e ("usb: dwc3: gadget: remove wait_end_transfer").
> &g
On Fri, Feb 1, 2019 at 4:18 PM John Stultz wrote:
>
> Hey all,
> Since the 5.0 merge window opened, I've been tripping on frequent
> dwc3 crashes on reboot and suspend, which I've added an example to the
> bottom of this mail.
>
> I've dug in a little bit and
On Fri, Feb 1, 2019 at 4:31 PM Thinh Nguyen wrote:
>
> Hi John,
>
> John Stultz wrote:
> > Hey all,
> > Since the 5.0 merge window opened, I've been tripping on frequent
> > dwc3 crashes on reboot and suspend, which I've added an example to the
> &
Hey all,
Since the 5.0 merge window opened, I've been tripping on frequent
dwc3 crashes on reboot and suspend, which I've added an example to the
bottom of this mail.
I've dug in a little bit and sort of have a sense of whats going on.
In ffs_epfile_io():
https://git.kernel.org/pub/scm/linux/ke
On Thu, Sep 27, 2018 at 5:33 AM, Artur Petrosyan
wrote:
> We would like to buy the HiKey board to perform testes.
> We found this HiKey LeMaker to have USB 2.0 ports
> https://www.ebay.com/itm/HiKey-LeMaker-version-2GB-Kirin-620-SoC-8-core-ARM-Cortex-A53-CPU-ARM-Mali-450/263958047308?hash=item3d75
On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
wrote:
> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey
> regression caused by power_down feature"
> https://marc.info/?l=linux-usb&m=152669095513248&w=2
>
> the power_down is disabled setting "p->power_down = false;" in
> "dwc2_s
On Sun, Sep 23, 2018 at 10:57 PM, Artur Petrosyan
wrote:
> Hi John,
>
> On 9/21/2018 05:05, John Stultz wrote:
>> On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan
>> wrote:
>>> On 5/23/2018 01:57, John Stultz wrote:
>>>> Its done automatically,
On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan
wrote:
> On 5/23/2018 01:57, John Stultz wrote:
>> Its done automatically, when the OTG cable is detected it the host
>> ports are disabled and when the OTG port is empty the host ports are
>> enabled.
>>
>> Let
for the reset to complete and the mouse
to be detected before re-plugging in the OTG port.
> On 5/21/2018 11:41 PM, John Stultz wrote:
>> On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan
>> wrote:
>>> Hi John,
>>>
>>> On 5/19/2018 4:49 AM, John Stultz
gets thing working again.
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Artur Petrosyan
Cc: Grigor Tovmasyan
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
v2: Use DWC2_POWER_DOWN_PARAM_NONE as suggested by Minas
---
drivers/usb/dwc2/params.c | 1 +
1 file changed, 1
On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan
wrote:
> Hi John,
>
> On 5/19/2018 4:49 AM, John Stultz wrote:
>> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")
>> caused the HiKey board to not correctly handle switching between
gets thing working again.
Cc: John Youn
Cc: Vardan Mikayelyan
Cc: Artur Petrosyan
Cc: Grigor Tovmasyan
Cc: Felipe Balbi
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/params.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/params.c b/driver
On Mon, Oct 23, 2017 at 1:41 PM, John Stultz wrote:
> On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan
> wrote:
>> Could you please verify on your setup follow patches:
>> 1. Vardan's patch.
>> 2. Patch for TOUTCAL&USBTRDTIM programming (new version see belo
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Tested by: Minas Harutyunyan
Reported-by: Amit Pundir
Signed-off-by: John Stultz
---
drivers/usb/dwc2/gadget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
John Stultz (3):
usb: dwc2: Improve gadget state disconnection handling
usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode
usb: dwc2: Fix UDC state tr
rtman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
v2: Remove the extra dwc2_hsotg_core_init_disconnected() call
I had added, as suggested by Minas.
---
drivers/usb/dwc2/hcd.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/
c: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Tested by: Minas Harutyunyan
Reported-by: YongQin Liu
Signed-off-by: John Stultz
---
drivers/usb/dwc2/gadget.c | 5 +
1 file changed, 5
On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan
wrote:
> Could you please verify on your setup follow patches:
> 1. Vardan's patch.
> 2. Patch for TOUTCAL&USBTRDTIM programming (new version see below).
> 4. Your patch 2/3 to avoid "Mode Mismatch" interrupts.
> 5. Your patch 3/3 to set udc state
On Wed, Oct 18, 2017 at 11:46 PM, Minas Harutyunyan
wrote:
> Could you please apply this patch. Please not apply your patch series
> "[PATCH 0/3] dwc2 fixes for edge cases on hikey" to check only below patch.
> If you confirm that this patch fix your issue with "Transaction Error"
> and " ChHltd s
On Tue, Oct 17, 2017 at 1:41 AM, Minas Harutyunyan
wrote:
> On 10/17/2017 1:34 AM, John Stultz wrote:
>> On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan
>> wrote:
>>> On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt.
>>> According previously s
On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan
wrote:
> On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt.
> According previously sent by you register dump (GHWCFG2 = 0x23affc70)
> your core OTG_MODE=0.
> Bellow fragment from programming guide on Device disconnect:
>
> "7.3Devic
On Thu, Oct 12, 2017 at 12:59 AM, Minas Harutyunyan
wrote:
>
> 1. Vardan's patch fixing issue when dwc2 switched from host to device
> mode. It's allow to make functional device after reconnecting without
> tracking UDC state.
While I'm sure Vardan's patch is useful, I worry that its resolving a
On Tue, Oct 3, 2017 at 2:58 AM, Minas Harutyunyan
wrote:
>
> Could you please apply patch from Vardan Mikayelyan "usb: dwc2: Fix
> dwc2_hsotg_core_init_disconnected()" submitted at 02/25/2017
> (https://marc.info/?l=linux-usb&m=148801589931039&w=2) instead of your
> "usb: dwc2: Improve gadget stat
port to the UDC layer when
the gadget device is disconnected.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: Amit Pundir
Sign
put on what the right approach
should be.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: YongQin Liu
Signed-off-by: John St
Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
John Stultz (3):
usb: dwc2: Improve gadget state disconnection handling
usb
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/hcd.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index c263114..df54428 100644
--
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/hcd.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index c263114..df54428 100644
--
Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
John Stultz (3):
usb: dwc2: Improve gadget state disconnection handling
usb
put on what the right approach
should be.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: YongQin Liu
Signed-off-by: John St
port to the UDC layer when
the gadget device is disconnected.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: Amit Pundir
Sign
On Thu, Aug 17, 2017 at 12:03 PM, John Stultz wrote:
> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
> disconnect the gadget state"), I was trying to fix up the
> fact that we somehow weren't disconnecting the gadget state,
> so that when the OTG port was
put on what the right approach
should be.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: YongQin Liu
Signed-off-by: John St
port to the UDC layer when
the gadget device is disconnected.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: Amit Pundir
Sign
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/hcd.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 740c7e8..9fd84a9 100644
--
On Fri, Aug 11, 2017 at 5:31 PM, John Stultz wrote:
> On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote:
>>> If after Cong's fix, the issue still happens, could you help try the
>>> patch attached and collect all logs when you try the reproduce the
>>> issue?
On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote:
>> If after Cong's fix, the issue still happens, could you help try the
>> patch attached and collect all logs when you try the reproduce the
>> issue? It would be great to have logs for both success case and the
>> failure case.
>>
>> Thanks so muc
On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote:
> Hi John,
>
> Is it possible to try the attached patch?
Thanks so much for the quick turn around!
So I dropped all the reverts you suggested, and applied this one
against 4.13-rc4, but I'm still seeing the problematic behavior.
> I am not sure i
out for input on what the right approach
should be.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: YongQin Liu
Cc: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Reported-by: YongQin Liu
Signed-off-by: Joh
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote:
> On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote:
>>> (Cc'ing Wei whose commit was blamed)
>>>
>>> On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote:
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote:
>
> Does your USB adapter get an IPv6 address?
Yes, it does.
> If you see the problem starts to happen on commit
> 9514528d92d4cbe086499322370155ed69f5d06c, could you try reverting all
> the following commits:
> (from new to old)
> 1eb04e7c9e63 net
On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote:
> (Cc'ing Wei whose commit was blamed)
>
> On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote:
>> On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote:
>>> So, with recent testing with my HiKey board, I've been noti
, because even fifo entries for one EP exceeds the
>total entries 1920. That's why we see the following fat warning from
>function dwc2_hsotg_init_fifo(). The new g-tx-fifo-size settings
>help to remove the warning as well.
Nice! This has been bothering me for awhile, and your
On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote:
> So, with recent testing with my HiKey board, I've been noticing some
> quirky behavior with my USB eth adapter.
>
> Basically, pluging the usb eth adapter in and then removing it, when
> plugging it back in I often find t
So, with recent testing with my HiKey board, I've been noticing some
quirky behavior with my USB eth adapter.
Basically, pluging the usb eth adapter in and then removing it, when
plugging it back in I often find that its not detected, and the system
slowly spits out the following message over and
: John Youn
Cc: Minas Harutyunyan
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/hcd.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/d
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
drivers/usb/dwc2/gadget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index c4066cd..e6f2cd8 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3202,6
On Tue, Apr 4, 2017 at 12:38 AM, Felipe Balbi
wrote:
>
> Hi,
>
> Minas Harutyunyan writes:
>>> We've noticed that when using usb ethernet adapters on HiKey, we
>>> occasionally see errors like:
>>>
>>> dwc2 f72c.usb: dwc2_hc_chhltd_intr_dma: Channel 0 - ChHltd set,
>>> b
On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan
wrote:
> On 4/3/2017 9:23 AM, John Youn wrote:
>> On 03/31/2017 04:04 PM, John Stultz wrote:
>>> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote:
>>>> Hey John,
>>>> We've noticed tha
rtman
Cc: linux-usb@vger.kernel.org
Acked-by: John Youn
Signed-off-by: John Stultz
---
v2: Minor typo fix suggested by Sergei Shtylyov
---
drivers/usb/dwc2/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index a73722e..91ed5b6 100644
--- a/drivers/
rtman
Cc: linux-usb@vger.kernel.org
Acked-by: John Youn
Signed-off-by: John Stultz
---
drivers/usb/dwc2/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index a73722e..91ed5b6 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -3264
path so the state is properly cleared.
With it, the gadget interface initializes properly on every
plug in.
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: Rob Herring
Cc: John Youn
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.
On Mon, Jan 16, 2017 at 12:57 PM, John Youn wrote:
>
>
>> On Jan 16, 2017, at 12:37 PM, John Stultz wrote:
>>
>> On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi
>> wrote:
>>>
>>> Hi,
>>>
>>> John Stultz writes:
>&
On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi
wrote:
>
> Hi,
>
> John Stultz writes:
>> Basically when plugging in various cables in different orders, I'm
>> occasionally seeing the following BUG splat:
>>
>> [ 86.215403] BUG: scheduling
On Mon, Jan 16, 2017 at 2:29 AM, Felipe Balbi
wrote:
>
> Hi,
>
> John Stultz writes:
>> I just wanted to re-send my current queue of patches for dwc2
>> controller on the HiKey board, as my last patchset ended up
>> colliding with a number of changes that landed
On Thu, Jan 12, 2017 at 12:05 AM, Felipe Balbi
wrote:
>
> Hi,
>
> John Youn writes:
>> On 1/11/2017 4:22 PM, John Stultz wrote:
>>> Just wanted to resend my patches for dwc2 controller on the
>>> HiKey board for consideration for the 4.11 merge window.
>
Cc: Wei Xu
Cc: Guodong Xu
Cc: Amit Pundir
Cc: Rob Herring
Cc: John Youn
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Vardan Mikayelyan
Cc: Kishon Vijay Abraham I
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz
---
v3:
* Rebased to synopsys-usb/nex
licon Hi6220
John Stultz (2):
usb: dwc2: Avoid sleeping while holding hsotg->lock
usb: dwc2: Workaround case where GOTGCTL state is wrong
drivers/usb/dwc2/core.c | 6 ++--
drivers/usb/dwc2/core.h | 9 +-
drivers/usb/dwc2/gadget.c | 2 +-
drivers/usb/dwc2/hcd.c
Youn
Reviewed-by: Vardan Mikayelyan
Signed-off-by: John Stultz
---
v2: Rework goto logic suggested by Vardan, and add a comment
v3:
* Rebased to synopsys-usb/next branch
---
drivers/usb/dwc2/hcd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb
vger.kernel.org
Signed-off-by: Chen Yu
[jstultz: Reworked to simplify the patch, and made
commit log to be more specific about the issue]
Signed-off-by: John Stultz
---
v2:
* Fix build issue reported by kbuildbot
* Rework to avoid using new dts entry suggested by RobH
* Further tweaks from Chen Yu to
u
Cc: Amit Pundir
Cc: Rob Herring
Cc: John Youn
Cc: Douglas Anderson
Cc: Chen Yu
Cc: Vardan Mikayelyan
Cc: Kishon Vijay Abraham I
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: Chen Yu
Signed-off-by: John Stultz
---
v3:
* Rebased to synopsys-usb/next b
On Wed, Jan 11, 2017 at 2:58 PM, John Youn wrote:
> On 1/11/2017 2:39 PM, John Stultz wrote:
>> On Wed, Jan 11, 2017 at 2:08 PM, John Youn wrote:
>>> On 1/3/2017 11:52 AM, John Stultz wrote:
>>>> Hope everyone had a happy new years!
>>>>
>>>>
On Wed, Jan 11, 2017 at 2:08 PM, John Youn wrote:
> On 1/3/2017 11:52 AM, John Stultz wrote:
>> Hope everyone had a happy new years!
>>
>> I just wanted to send out my current queue of patches for dwc2
>> controller on the HiKey board for consideration for the 4.11
On Mon, Jan 9, 2017 at 1:10 PM, John Youn wrote:
> From: Vardan Mikayelyan
>
> Remove DMA memory free from EP disable flow by replacing
> dma_alloc_coherent with dmam_alloc_coherent.
>
> Cc: John Stultz
> Signed-off-by: Vardan Mikayelyan
> Signed-off-by: John Youn
Thi
On Thu, Jan 5, 2017 at 6:01 PM, John Youn wrote:
> From: Vardan Mikayelyan
>
> Remove DMA memory free from EP disable flow by replacing
> dma_alloc_coherent with dmam_alloc_coherent.
>
> Cc: John Stultz
> Signed-off-by: Vardan Mikayelyan
> Signed-off-by: John Youn
&g
it against Linus' HEAD and my
tree is stale?
Anyway, after re-applying it to my tree:
Tested-by: John Stultz
thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 5, 2017 at 6:50 PM, Leo Yan wrote:
> When use configfs to configure USB port as as ethernet gadget, the
> kernel has panic with below backtrace; it clearly indicates the
> coherent memory allocation is happened in the interrupt context,
> but the function __get_vm_area_node() is possib
On Tue, Jan 3, 2017 at 4:31 PM, John Youn wrote:
> On 1/3/2017 12:05 PM, John Stultz wrote:
>> On Tue, Jan 3, 2017 at 11:52 AM, John Stultz wrote:
>>> Hope everyone had a happy new years!
>>>
>>> I just wanted to send out my current queue of patches for dwc2
&
On Tue, Jan 3, 2017 at 11:52 AM, John Stultz wrote:
> Hope everyone had a happy new years!
>
> I just wanted to send out my current queue of patches for dwc2
> controller on the HiKey board for consideration for the 4.11
> merge window.
>
> This does exclude my patchset[1]
1 - 100 of 185 matches
Mail list logo
