On 18. 02. 19, 15:00, David Chen wrote:
> From: David Chen
>
> RTL8153-BD is used in Dell DA300 type-C dongle.
> It should be added to the whitelist of devices to activate MAC address
> pass through.
>
> Per confirming with Realtek all devices containing RTL8153-BD should
> activate MAC pass thr
On 22. 01. 19, 16:23, Greg KH wrote:
> On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
>> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
>> are no more hidden accesses to local variables (vc_data and
>> sisusb_usb_data).
>>
>> s
There are two macros defined:
1) ifdef CONFIG_COMPAT => define SISUSB_NEW_CONFIG_COMPAT
2) ifdef CONFIG_USB_SISUSBVGA_CON => define INCL_SISUSB_CON
Remove the latter and make use only of the former. This removes one
layer of obfuscation.
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sis
aligned to be readable too.
Use sisusb_haddr on 4 more places in sisusbcon_blank and
sisusbcon_scroll. It was open coded there with [x, y] being [0, 0].
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 78 -
1 file changed, 39 insertions(+), 39 deletions
Remove macros which are only wrappers around standard operations. When
we expand them into code, we see that sisusbcon_memsetw can simply use
memset16 and sisusbcon_putcs can just call memcpy. So make the code
compact.
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 48
After the previous patch we see, that whole files are ifdeffed depending
on CONFIG options. So do not build the files at all if the CONFIG is not
enabled. (I.e. move the check from .c to Makefile.)
Signed-off-by: Jiri Slaby
---
drivers/usb/misc/sisusbvga/Makefile | 3 ++-
drivers/usb/misc
On 09/05/2018, 03:08 AM, Jaejoong Kim wrote:
> > @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct
> tty_port *port,
> > extern void tty_port_close_end(struct tty_port *port, struct
> tty_struct *tty);
> > extern void tty_port_close(struct tty_port *port,
> >
On 03/30/2018, 03:17 PM, Jiri Slaby wrote:
> Hi,
>
> I have seen r8152 from my docking station to kill my box several times
> in the last few days. The notebook is new, so I don't know if this is a
> regression.
Forgot to add, I am seeing this in dmesg:
[ 13.353239] r815
Hi,
I have seen r8152 from my docking station to kill my box several times
in the last few days. The notebook is new, so I don't know if this is a
regression.
I have the NIC connected all the time. And when I return to the notebook
after a while, the networking is dead. Looking at the stack trace
rning bool which was
intended to do in d705ff3818 but omitted.
Signed-off-by: Jiri Slaby
Fixes: d705ff3818 (tty: vt, cleanup and document con_scroll)
Cc: Thomas Winischhofer
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 2 +-
1 file changed, 1
rning bool which was
intended to do in d705ff3818 but omitted.
Signed-off-by: Jiri Slaby
Fixes: d705ff3818 (tty: vt, cleanup and document con_scroll)
Cc: Thomas Winischhofer
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Cc: co...@systeme.lip6.fr
---
drivers/usb/misc/sisusbvga/sisusb_con.c
m the "!lines" then-branch
immediatelly. This allows flushing the else-branch 1 level to the
left, obviously.
Few more new lines and comments were added too.
And do not forget to export the helper function given sisusb can be
built as module.
Signed-off-by: Jiri Slaby
Cc: Thomas Winisch
up to the con_scroll
hook which actually accepted all those as signed int.
Next, the 'dir' parameter can have only two values and we define
constants for that: SM_UP and SM_DOWN. Switch them to enum and do
proper type checking on 'dir' too.
Finally, document the behaviour of the h
Cc: proper lists.
ep->desc.bInterval seems to be 0 here.
On 08/21/2016, 12:42 PM, Vittorio Zecca wrote:
> I am not sure this is the right place so please bear with me...
> From Vittorio Zecca
>
> After compiling kernel 4.7.2 with ubsan I got the following messages
> at boot time:
>
> (devio.c:1
bytes_written parameter of sisusb_copy_memory and sisusb_read_memory
is an out parameter, but its value is never used. So remove it and
pass a dummy variable down to sisusb_read_mem_bulk.
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
Cc: linux-usb@vger.kernel.org
---
drivers/usb/misc
* allow NULL consw->con_scrolldelta (some consoles define an empty
hook)
* => remove empty hooks now
* return value of consw->con_scrolldelta is never checked => make the
function void
* document consw->con_scrolldelta a bit
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
* allow NULL consw->con_set_palette (some consoles define an empty
hook)
* => remove empty hooks now
* return value of consw->con_set_palette is never checked => make the
function void
* document consw->con_set_palette a bit
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
It is never called since commit 81732c3b2fede (tty vt: Fix line
garbage in virtual console on command line edition) in 3.7. So remove
all the callbacks.
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
Cc: linux-usb@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard
Cc: Tomi Valkeinen
Cc
Namely convert:
* IS_FG -> con_is_fg
* DO_UPDATE -> con_should_update
* CON_IS_VISIBLE -> con_is_visible
DO_UPDATE was a weird name for a yes/no answer, so the new name is
con_should_update.
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
Cc: Jean-Christophe Plagniol-Villard
Cc:
GFP_NOWARN. So do so.
The size could be also clipped by something like:
if (size >= (1 << (MAX_ORDER + PAGE_SHIFT - 1)))
return -ENOMEM;
But I think the overall limit of 16M (by usbfs_increase_memory_usage)
is enough, so that we only silence the warning here.
Signed
after
the lock.
Signed-off-by: Jiri Slaby
Cc: Pete Zaitcev
Cc: Greg Kroah-Hartman
Fixes: 7f477358e2 ("usblp: Implement the ENOSPC convention")
---
drivers/usb/class/usblp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/class/usblp.c b/drivers/usb/cla
On 03/17/2015, 03:20 PM, Alan Stern wrote:
> On Mon, 2 Mar 2015, Alan Stern wrote:
>
>> On Fri, 27 Feb 2015, Christian Böhme wrote:
>>
>>> Alan Stern writes:
>>>
> Specifically, HID_QUIRK_IGNORE_MOUSE existed in 2.6.27
> and was dealt with in drivers/hid/usbhid/hid-core.c:730,
> there
On 01/30/2015, 10:54 PM, Tim Chen wrote:
> On Sat, 2015-01-31 at 00:03 +0300, Sergei Shtylyov wrote:
>> On 01/30/2015 10:54 PM, Tim Chen wrote:
>
>>>
>>> return NULL;
>>> }
>>> + /* round up to full page size */
>>> + size = (((size-1) >> PAGE_SHIFT) + 1) * PAGE_SIZE;
>>
>>
On 09/07/2014, 10:27 PM, Vincent Stehlé wrote:
> Commit 6a04d05acfb51355 ("USB: OHCI: fix bugs in debug routines") has removed
> the unused `verbose' argument of the debug function ohci_dump(); adapt
> ohci-spear accordingly.
>
> This fixes the following compilation error:
>
> drivers/usb/host/
On 07/07/2014 05:42 PM, grantksupp...@operamail.com wrote:
> Hi,
>
>>> Can this USB3 fix be added to Kernel's stable branch so our distro(s)
>>> can/will pick it up for packaging ?
>>
>> What "this USB3 fix"? Do you have the git commit id of the patch in
>> Linus's tree? And what kernel version(
On 06/25/2013 01:42 AM, Greg Kroah-Hartman wrote:
> On Wed, Jun 19, 2013 at 08:50:08AM +0200, Jiri Slaby wrote:
>> On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote:
>>>> So currently I have what is attached... Comments?
>>>
>>> Looks good to me, want me to
On 06/19/2013 09:10 AM, Tomi Valkeinen wrote:
> On 17/06/13 23:05, Jiri Slaby wrote:
>
>> The last point I inclined to the Greg's argument to remove the
>> EXPERT dependency.
>>
>> So currently I have what is attached... Comments?
>
> The patch looks
On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote:
>> So currently I have what is attached... Comments?
>
> Looks good to me, want me to queue it up through my char/misc driver
> tree for 3.11?
If there are no objections... Whoever picks that up, I would be happy 8-).
--
js
suse labs
--
To unsub
On 06/18/2013 10:51 AM, Felipe Balbi wrote:
> right, but my argument is that I rather not have either. Depend on
> PCI if you us PCI, depend on EXTCON if you use extcon, but no
> driver should have an ARCH dependency. Specially since it lets
> people include mach/* and asm/* headers because "it doe
On 06/18/2013 10:18 AM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jun 18, 2013 at 06:51:32AM +0200, Michal Marek wrote:
>> Dne 17.6.2013 22:05, Jiri Slaby napsal(a):
>>> On 05/23/2013 05:09 AM, Jeff Mahoney wrote:
>>>> On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote:
On 05/23/2013 05:09 AM, Jeff Mahoney wrote:
> On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote:
>> On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri Slaby wrote:
>>> Some drivers can be built on more platforms than they run on. This
>>> causes users and distributors packagi
On 05/16/2013 11:36 AM, Alexander Shishkin wrote:
> The benefit from compiling it on non-arm (or non-imx) architectures for
> me is compilation testing. We don't have a whole lot of architectures
> with CONFIG_OF so it's nice to give it a stretch.
Yes, the newly added COMPILE_TEST config option wi
On 05/08/2013 11:07 AM, Alexander Shishkin wrote:
> Jiri Slaby writes:
>
>> From: Jeff Mahoney
>>
>> The chipidea driver currently has needless ifneq rules in the makefile
>> for things that should be config options.
>
> Please elaborate on the "shoul
tty_port_tty_get might return a tty which is NULL. But it is
dereferenced unconditionally in edge_send. Stop dereferencing that by
sending usb_serial_port pointer around.
Signed-off-by: Jiri Slaby
Cc: Johan Hovold
Cc: linux-usb@vger.kernel.org
---
drivers/usb/serial/io_ti.c | 9 -
1
On 03/05/2013 11:32 PM, Peter Hurley wrote:
>> So I'm thinking about
>> something like this:
>>
>> if (port->tty)
>>set_bit(TTY_IO_ERROR, &port->tty->flags);
>> tty = port->tty; <=== take a snapshot
>> spin_unlock_irqrestore(&port->lock, flags);
>> tty_port_shutdown(port, tty); <=== use the sn
On 03/05/2013 11:02 PM, Peter Hurley wrote:
> On Tue, 2013-03-05 at 22:56 +0100, Jiri Slaby wrote:
>> On 03/05/2013 06:06 PM, Peter Hurley wrote:
>>>>> @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port)
>>>> spin_lock_irqsave(&port->
On 03/05/2013 06:06 PM, Peter Hurley wrote:
>>> @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port)
>> spin_lock_irqsave(&port->lock, flags);
>> port->count = 0;
>> port->flags &= ~ASYNC_NORMAL_ACTIVE;
>> - if (port->tty) {
>> + if (port->tty)
>>
On 02/28/2013 09:57 PM, Peter Hurley wrote:
> Hi Jiri,
>
> Just wanted to make sure you saw this series.
Hi, thanks for letting me know. Johan, care to CC Alan Cox and me (or at
least LKML) when you're changing the TTY core next time?
I have a couple of questions for 2/4:
> Move HUPCL handling
On 02/11/2013 07:40 AM, Yinghai Lu wrote:
> Can you try attached debug patch?
FWIW this fixes it for me. No more 'derived' or 'nobody' in dmesg.
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
M
On 11/13/2012 09:45 AM, Takashi Iwai wrote:
> At Tue, 13 Nov 2012 09:30:10 +0100,
> Jiri Slaby wrote:
>>
>> On 11/13/2012 09:28 AM, Takashi Iwai wrote:
>>> At Tue, 13 Nov 2012 09:26:17 +0100,
>>> Jiri Slaby wrote:
>>>>
>>>> Hello,
>>
On 11/13/2012 09:28 AM, Takashi Iwai wrote:
> At Tue, 13 Nov 2012 09:26:17 +0100,
> Jiri Slaby wrote:
>>
>> Hello,
>>
>> I've just plugged+unplugged+plugged my USB audio card and the audio
>> subsystem got stuck:
>
> Which kernel? If it's older
Hello,
I've just plugged+unplugged+plugged my USB audio card and the audio
subsystem got stuck:
INFO: task khubd:440 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
khubd D 8801cbc92400 0 440 2 0x
8
On 09/19/2012 04:36 AM, Kevin Daughtridge wrote:
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -775,12 +775,14 @@ int hid_open_report(struct hid_device *d
> return -ENODEV;
> size = device->dev_rsize;
>
> +start = kmemdup(start, size, GFP_KERNEL);
> +if
Hi,
I have this in dmesg:
DMAR:[DMA Write] Request device [00:02.0] fault addr ee1512000
DMAR:[fault reason 05] PTE Write access is not set
PCI-DMA: Intel(R) Virtualization Technology for Directed I/O
DMAR:[DMA Read] Request device [00:1d.7] fault addr 7d5f
DMAR:[fault reason 06] PTE Read acc
44 matches
Mail list logo
