Re: [PATCH v3 1/3] dt-bindings: usb: Add support for msm8998

2019-01-30 Thread Jeffrey Hugo
On 1/30/2019 8:42 AM, Rob Herring wrote: On Mon, Jan 21, 2019 at 02:32:46PM -0700, Jeffrey Hugo wrote: msm8998 USB has a dwc3 controller just like the existing sdm845 support. Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- Documentation/devicetree/bindings/usb/qcom,dwc3.txt

[PATCH v3 3/3] arm64: dts: qcom: msm8998: Add USB-related nodes

2019-01-21 Thread Jeffrey Hugo
Add nodes for USB and related PHYs. Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 22 arch/arm64/boot/dts/qcom/msm8998.dtsi | 92 +++ 2 files changed, 114 insertions(+) diff --git a/arch/arm64

[PATCH v3 2/3] usb: dwc3: qcom: Add support for MSM8998

2019-01-21 Thread Jeffrey Hugo
Add a MSM8998 specific DT compatible so that we can properly bind to the device and enable the USB controller. Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- drivers/usb/dwc3/dwc3-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers

[PATCH v3 1/3] dt-bindings: usb: Add support for msm8998

2019-01-21 Thread Jeffrey Hugo
msm8998 USB has a dwc3 controller just like the existing sdm845 support. Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b

[PATCH v3 0/6] MSM8998 basic USB support

2019-01-21 Thread Jeffrey Hugo
anges -Split out bindings changes -Fixed dual lane support in QMP to reflect Doug's updates -Dropped the clock fixes which were accepted Jeffrey Hugo (6): clk: qcom: Add missing freq for usb30_master_clk on 8998 clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998 phy: qcom-qusb2:

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-17 Thread Jeffrey Hugo
On 1/17/2019 3:52 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 8:58 PM, Jeffrey Hugo wrote: On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: On 15/01/19 11:41 PM, Bjorn Andersson wrote: On Mon 14 Jan 08:36 PST 2019, Jeffrey

Re: [PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-16 Thread Jeffrey Hugo
On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote: Hi, On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote: On 15/01/19 11:41 PM, Bjorn Andersson wrote: On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support

[PATCH v2 6/6] arm64: dts: qcom: msm8998: Add USB-related nodes

2019-01-14 Thread Jeffrey Hugo
Add nodes for USB and related PHYs. Signed-off-by: Jeffrey Hugo --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 22 arch/arm64/boot/dts/qcom/msm8998.dtsi | 92 +++ 2 files changed, 114 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi

[PATCH v2 5/6] usb: dwc3: qcom: Add support for MSM8998

2019-01-14 Thread Jeffrey Hugo
Add a MSM8998 specific DT compatible so that we can properly bind to the device and enable the USB controller. Signed-off-by: Jeffrey Hugo --- drivers/usb/dwc3/dwc3-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index

[PATCH v2 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998

2019-01-14 Thread Jeffrey Hugo
MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845 support. Signed-off-by: Jeffrey Hugo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 140 drivers/phy/qualcomm/phy-qcom-qmp.h | 4 ++ 2 files changed, 144 insertions(+) diff --git a

[PATCH v2 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-14 Thread Jeffrey Hugo
MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support. Signed-off-by: Jeffrey Hugo --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers

[PATCH v2 2/6] dt-bindings: usb: Add support for msm8998

2019-01-14 Thread Jeffrey Hugo
msm8998 USB has a dwc3 controller just like the existing sdm845 support Signed-off-by: Jeffrey Hugo --- Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b/Documentation/devicetree

[PATCH v2 1/6] dt-bindings: phy-qcom: Add support for msm8998 usb

2019-01-14 Thread Jeffrey Hugo
USB on msm8998 utilizes the QUSB2 and QMP phys, similar to sdm845. Signed-off-by: Jeffrey Hugo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 + Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 1 + 2 files changed, 6 insertions(+) diff --git a/Documentation

[PATCH v2 0/6] MSM8998 basic USB support

2019-01-14 Thread Jeffrey Hugo
Display Port (DP) support which apparently is different from sdm845 and needs additional investigation. v2: -Fixed typo in QUSB2 bindings changes -Split out bindings changes -Fixed dual lane support in QMP to reflect Doug's updates -Dropped the clock fixes which were accepted Jeffrey Hugo (6):

Re: [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998

2019-01-11 Thread Jeffrey Hugo
On 1/11/2019 12:45 PM, Rob Herring wrote: On Fri, Jan 04, 2019 at 09:50:47AM -0700, Jeffrey Hugo wrote: MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845 support, however MSM8998 does not have display port (DP) support. Signed-off-by: Jeffrey Hugo --- .../devicetree

Re: [PATCH v1 2/6] clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998

2019-01-09 Thread Jeffrey Hugo
On 1/9/2019 11:59 AM, Stephen Boyd wrote: Quoting Jeffrey Hugo (2019-01-04 08:50:15) The gcc_usb3_phy_pipe_clk is generated by the phy, but is also used by the phy during init. The clock needs to be enabled during the init sequence, but may not be fully active until after the init sequence is

Re: [PATCH v1 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-07 Thread Jeffrey Hugo
On 1/7/2019 11:18 AM, Jack Pham wrote: Hi Jeff, Spotted a typo below: On Fri, Jan 04, 2019 at 09:50:29AM -0700, Jeffrey Hugo wrote: MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support. Signed-off-by: Jeffrey Hugo --- .../devicetree/bindings/phy/qcom-qusb2

[PATCH v1 6/6] arm64: dts: qcom: msm8998: Add USB-related nodes

2019-01-04 Thread Jeffrey Hugo
Add nodes for USB and related PHYs. Signed-off-by: Jeffrey Hugo --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 22 arch/arm64/boot/dts/qcom/msm8998.dtsi | 90 +++ 2 files changed, 112 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi

[PATCH v1 5/6] usb: dwc3: qcom: Add support for MSM8998

2019-01-04 Thread Jeffrey Hugo
Add a MSM8998 specific DT compatible so that we can properly bind to the device and enable the USB controller. Signed-off-by: Jeffrey Hugo --- Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 1 + drivers/usb/dwc3/dwc3-qcom.c| 1 + 2 files changed, 2 insertions

[PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998

2019-01-04 Thread Jeffrey Hugo
MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845 support, however MSM8998 does not have display port (DP) support. Signed-off-by: Jeffrey Hugo --- .../devicetree/bindings/phy/qcom-qmp-phy.txt | 5 + drivers/phy/qualcomm/phy-qcom-qmp.c| 142

[PATCH v1 3/6] phy: qcom-qusb2: Add QUSB2 PHY support for msm8998

2019-01-04 Thread Jeffrey Hugo
MSM8998 contains one QUSB2 PHY which is very similar to the existing sdm845 support. Signed-off-by: Jeffrey Hugo --- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 1 + drivers/phy/qualcomm/phy-qcom-qusb2.c | 41 ++ 2 files changed, 42 insertions(+) diff

[PATCH v1 2/6] clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998

2019-01-04 Thread Jeffrey Hugo
result, skip the checks to avoid the troubling situation. Signed-off-by: Jeffrey Hugo --- drivers/clk/qcom/gcc-msm8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index 42de947..1a1806a 100644 --- a/drivers

[PATCH v1 1/6] clk: qcom: Add missing freq for usb30_master_clk on 8998

2019-01-04 Thread Jeffrey Hugo
The usb30_master_clk supports a 60Mhz frequency, but that is missing from the table of supported frequencies. Add it. Fixes: b5f5f525c547 (clk: qcom: Add MSM8998 Global Clock Control (GCC) driver) Signed-off-by: Jeffrey Hugo --- drivers/clk/qcom/gcc-msm8998.c | 1 + 1 file changed, 1 insertion

[PATCH v1 0/6] MSM8998 basic USB support

2019-01-04 Thread Jeffrey Hugo
This series provides basic USB support for MSM8998. Currently missing is wiring up the Type-C detection logic so that the controller can correctly switch between host and peripheral modes. Work to implement that is ongoing, and expected to appear soon in followup patches. Jeffrey Hugo (6