Re: [PATCH v4] usb: handle warm-reset port requests on hub resume

2019-02-01 Thread Jan-Marek Glogowski
This is actually v4. With this patch applied, dmesg on device plug looks like this and has no more suspend-resume-cycle: [ 454.845205] xhci_hcd:handle_port_status: xhci_hcd :00:14.0: Port Status Change Event for port 19 [ 454.845215] xhci_hcd:handle_port_status: xhci_hcd :00:14.0: res

[PATCH] usb: handle warm-reset port requests on hub resume

2019-02-01 Thread Jan-Marek Glogowski
x27;t yet available. If a warm-reset request is detected, this sets the hubs event_bits, which will prevent any auto-suspend and allows the hubs workqueue to warm-reset the port later in port_event. Signed-off-by: Jan-Marek Glogowski --- The original thread is "USB-C storage device not detec

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-31 Thread Jan-Marek Glogowski
Am 31. Januar 2019 17:53:13 MEZ schrieb Alan Stern : >This thread has been hard to follow. I'll try to answer some of your >concerns below... > >On Thu, 31 Jan 2019, Jan-Marek Glogowski wrote: > >> Am 31.01.19 um 15:56 schrieb Mathias Nyman: >> > On 31.01.20

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-31 Thread Jan-Marek Glogowski
Am 31.01.19 um 15:56 schrieb Mathias Nyman: > On 31.01.2019 12:42, Jan-Marek Glogowski wrote: >> Am 30.01.19 um 17:56 schrieb Jan-Marek Glogowski: >>> Am 30.01.19 um 15:58 schrieb Mathias Nyman: >>>> On 30.01.2019 14:38, Jan-Marek Glogowski wrote: >>>

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-31 Thread Jan-Marek Glogowski
Am 30.01.19 um 17:56 schrieb Jan-Marek Glogowski: > Am 30.01.19 um 15:58 schrieb Mathias Nyman: >> On 30.01.2019 14:38, Jan-Marek Glogowski wrote: >> >> The hub->event bits are set when roothub polling timer function gets data >> from >> hub_status_data(),

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-30 Thread Jan-Marek Glogowski
Am 30.01.19 um 15:58 schrieb Mathias Nyman: > On 30.01.2019 14:38, Jan-Marek Glogowski wrote: >> On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE >> link state bit is set. Greping all the kernel for this bit shows >> that the port status requests a warm-reset this

[PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-30 Thread Jan-Marek Glogowski
would otherwise warm-reset ports. The device works ok without this patch, if there is already any other device connected to the hub. Signed-off-by: Jan-Marek Glogowski --- The original thread is "USB-C storage device not detected on USB 3.1 Gen 2 host when plugged in after boot". A

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-25 Thread Jan-Marek Glogowski
Am 25.01.19 um 16:14 schrieb Mathias Nyman: > On 18.01.2019 13:28, Jan-Marek Glogowski wrote: >> Just adding some CC of commit signers from get_maintainer.pl >> >> Am 16.01.19 um 18:07 schrieb Jan-Marek Glogowski: >>> On plug-in of my USB-C device, its USB_SS_PORT_LS_

Re: [PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-18 Thread Jan-Marek Glogowski
Just adding some CC of commit signers from get_maintainer.pl Am 16.01.19 um 18:07 schrieb Jan-Marek Glogowski: > On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE > link state bit is set. Greping all the kernel for this bit shows > that the port status requests a warm-reset

[PATCH v3] usb: warm-reset ports on hub resume, if requested

2019-01-16 Thread Jan-Marek Glogowski
would otherwise warm-reset ports. The device works ok without this patch, if there is already any other device connected to the hub. Signed-off-by: Jan-Marek Glogowski --- v1: This always warm-resets the ports in hub_activate, independent of the "enum hub_activation_type". Just had a s

[PATCH v2] usb: warm-reset ports on hub resume, if requested

2019-01-16 Thread Jan-Marek Glogowski
would otherwise warm-reset ports. The device works ok without this patch, if there is already any other device connected to the hub. Signed-off-by: Jan-Marek Glogowski --- drivers/usb/core/hub.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb

[PATCH] usb: warm-reset ports on hub resume, if requested

2019-01-16 Thread Jan-Marek Glogowski
would otherwise warm-reset ports. The device works ok without this patch, if there is already any other device connected to the hub. Signed-off-by: Jan-Marek Glogowski --- drivers/usb/core/hub.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/usb

Re: USB-C storage device not detected on USB 3.1 Gen 2 host when plugged in after boot

2019-01-15 Thread Jan-Marek Glogowski
Hi, just wanted to know if the logs are usable and if you now need some additional information. Now I should also build usbcore as a module, so I don't have to reboot all the time. And I'll try to look into the code to understand the port status value. AFAIK the log suggest that for whatever r

Re: USB-C storage device not detected on USB 3.1 Gen 2 host when plugged in after boot

2019-01-14 Thread Jan-Marek Glogowski
Am 14.01.19 um 11:48 schrieb Oliver Neukum: > On Fr, 2019-01-11 at 19:49 +0100, Jan-Marek Glogowski wrote: >> >> Yup, but the device is just detected if its plugged in on boot / module load. >> I now have recompiled 5.0-rc1 with xhci as a module. > > First of all

Re: USB-C storage device not detected on USB 3.1 Gen 2 host when plugged in after boot

2019-01-11 Thread Jan-Marek Glogowski
Am 11.01.19 um 19:20 schrieb Oliver Neukum: > On Fr, 2019-01-11 at 15:39 +0100, Jan-Marek Glogowski wrote: >> I've got new hardware (Acer s4640g), which has some USB 3.1 gen 2 usb-c >> ports. >> >> /: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p,

USB-C storage device not detected on USB 3.1 Gen 2 host when plugged in after boot

2019-01-11 Thread Jan-Marek Glogowski
Hi, I've got new hardware (Acer s4640g), which has some USB 3.1 gen 2 usb-c ports. /: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p, 1M |__ Port 3: Dev 2, If 0, Class=Mass Storage, Driver=usb-storage, 5000M I have installed our current Ubuntu 18.04 based release with the incl