Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Jörn Engel
On Wed, 21 August 2013 13:00:15 -0700, Brian Norris wrote: > > Yes, that's a good point. Quoting Documentation/stable_kernel_rules.txt: > > "It must be obviously correct and tested." > > Seeing as it was not tested, I am dropping the patch entirely (it is > not stable material, and there is no p

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-07 Thread Jörn Engel
On Wed, 7 August 2013 08:50:53 +0300, Jussi Kivilinna wrote: > On 06.08.2013 19:49, Jörn Engel wrote: > > On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: > >> > >> Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers > >> need

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jörn Engel
On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: > > Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need > to > be DMA-able, which stack is not. > > Patch is only compile tested. I have tested the driver back when I wrote it. Not sure why it worked then, ma