Re: musb gadget @ full speed

2014-04-22 Thread ian coolidge
t set endpoint_descriptor::wMaxPacketSize for the full-speed case. Why is this? Thanks, Ian On Tue, Apr 22, 2014 at 10:08 AM, Felipe Balbi wrote: > On Tue, Apr 22, 2014 at 09:38:11AM -0700, ian coolidge wrote: >> Hi, (resend for text/plain to list) >> >> musb gadget @ full speed

MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Ian Coolidge
Hi, We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded product. For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral mode. We use the Ethernet gadget configured for cdc_eem to use Ethernet emulation over USB for this link, and the robustness of the link i

[PATCH v2 2/2] net: usb: cdc_eem: Fix rx skb allocation for 802.1Q VLANs

2012-11-07 Thread Ian Coolidge
cdc_eem frames might need to contain 802.1Q VLAN Ethernet frames. URB/skb sizing from usbnet will default to the hard_mtu, so account for the VLAN header by expanding that via hard_header_len Signed-off-by: Ian Coolidge --- drivers/net/usb/cdc_eem.c |3 ++- 1 files changed, 2 insertions

[PATCH v2 1/2] usb: gadget: g_ether: fix frame size check for 802.1Q

2012-11-07 Thread Ian Coolidge
Checking skb->len against ETH_FRAME_LEN assumes a 1514 ethernet frame size. With an 802.1Q VLAN header, ethernet frame length can now be 1518. Validate frame length against that. Signed-off-by: Ian Coolidge --- drivers/usb/gadget/u_ether.c |3 ++- 1 files changed, 2 insertions(+)

[PATCH v2 0/2] Fix CDC_EEM with 802.1Q VLAN and 1500 MTU

2012-11-07 Thread Ian Coolidge
cdc_eem USB host driver and gadget driver both are broken in 1500 MTU case while using 802.1Q VLANs. In both cases, this is due to the assumption of standard Ethernet frame length. v2: rebase against Dave Miller's 'net/master' tree Ian Coolidge (2): usb: gadget: g_ether: fix f

[PATCH 2/2] net: usb: cdc_eem: Fix rx skb allocation for 802.1Q VLANs

2012-11-06 Thread Ian Coolidge
cdc_eem frames might need to contain 802.1Q VLAN Ethernet frames. Provide this information as an override to usbnet->rx_urb_size Signed-off-by: Ian Coolidge --- drivers/net/usb/cdc_eem.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/cdc_eem.

[PATCH 1/2] usb: gadget: g_ether: fix frame size check

2012-11-06 Thread Ian Coolidge
Checking skb->len against ETH_FRAME_LEN assumes a 1514 ethernet frame size. With an 802.1Q VLAN header, ethernet frame length can now be 1518. Validate frame length against that. Signed-off-by: Ian Coolidge --- drivers/usb/gadget/u_ether.c |3 ++- 1 files changed, 2 insertions(+)

[PATCH 0/2] Fix CDC_EEM with 802.1Q VLAN and 1500 MTU

2012-11-06 Thread Ian Coolidge
cdc_eem USB host driver and gadget driver both are broken in 1500 MTU case when using 802.1Q VLANs. In both cases, this is due to incomplete assumptions of Ethernet frame size. Ian Coolidge (2): usb: gadget: g_ether: fix frame size check net: usb: cdc_eem: Fix rx skb allocation for 802.1Q