Re: Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Hans Verkuil
On 08/02/17 11:39, Johan Hovold wrote: > On Wed, Aug 02, 2017 at 09:03:43AM +0200, Hans Verkuil wrote: >> When testing with my Raspberry Pi 3 and the 4.13-rcX mainline kernel >> I discovered that there was no ethernet. After bisecting I got to commit >> 2bf69867 ('USB: of

Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Hans Verkuil
When testing with my Raspberry Pi 3 and the 4.13-rcX mainline kernel I discovered that there was no ethernet. After bisecting I got to commit 2bf69867 ('USB: of: fix root-hub device-tree node handling'). With that commit lsusb outputs: rpi3: ~ # lsusb Bus 001 Device 001: ID 1d6b:0002 Linux Founda

Re: [PATCH v2 15/27] [media] solo6x10: Convert to the new PCM ops

2017-06-01 Thread Hans Verkuil
is needed. Signed-off-by: Takashi Iwai Acked-by: Hans Verkuil Thanks, Hans --- drivers/media/pci/solo6x10/solo6x10-g723.c | 32 ++ 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pc

Re: [PATCH 08/12] Add USB quirk for HVR-950q to avoid intermittent device resets

2017-05-22 Thread Hans Verkuil
t during tuning which would put the chip into an > unknown state. > > Signed-off-by: Devin Heitmueller I've accepted the other patches in this patch series for the media subsystem, but this patch should go through the USB subsystem. Cc-ed linux-usb. Acked-by: Hans Verkuil Regards,

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-03-29 Thread Hans Verkuil
on Odroid U3 after tftpboot"). It's rather late, but I finally had a chance to test this and it works. So: Tested-by: Hans Verkuil This was with u-boot version v2016.09.01 and kernel 4.11.0-rc1. Regards, Hans > > > Best regards, > Krzysztof > > >

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Hans Verkuil
Try again, this time with Krzysztof's new email address... On 13/12/16 13:20, Hans Verkuil wrote: Hi Krzysztof, This still seems to be broken with the latest 4.9 kernel, right? Has there been any progress on this? Do you have an updated patch series for me to use? Regards, Hans

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Hans Verkuil
Hi Krzysztof, This still seems to be broken with the latest 4.9 kernel, right? Has there been any progress on this? Do you have an updated patch series for me to use? Regards, Hans On 05/05/16 14:34, Krzysztof Kozlowski wrote: Hi, This is a different, second try to fix usb3503+lan o

Re: [PATCH 1/3] properly report a single frame rate of 60 FPS

2016-05-13 Thread Hans Verkuil
On 05/13/2016 08:41 PM, Florian Echtler wrote: > The device hardware is always running at 60 FPS, so report this both via > PARM_IOCTL and ENUM_FRAMEINTERVALS. Florian, can you post these three patches to linux-media as well? These are all V4L2 related so they should be reviewed there. By postin

Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting

2016-05-02 Thread Hans Verkuil
On 05/01/16 18:42, Krzysztof Kozlowski wrote: > On Sun, May 01, 2016 at 06:01:08PM +0200, Hans Verkuil wrote: >>> Sorry, I meant the hanging issue I got in 4.6, not the ethernet issue. >>> I get the same problem with linux-next. Can you mail me the .config you are >&g

Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting

2016-05-01 Thread Hans Verkuil
On 05/01/2016 04:09 PM, Hans Verkuil wrote: > On 05/01/2016 03:17 PM, Krzysztof Kozlowski wrote: >> On Sat, Apr 30, 2016 at 11:43:44AM +0200, Hans Verkuil wrote: >>> Hi Krzysztof, >>> >>> On 04/29/2016 12:59 PM, Krzysztof Kozlowski wrote: >>>> Hi, &

Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting

2016-05-01 Thread Hans Verkuil
On 05/01/2016 03:17 PM, Krzysztof Kozlowski wrote: > On Sat, Apr 30, 2016 at 11:43:44AM +0200, Hans Verkuil wrote: >> Hi Krzysztof, >> >> On 04/29/2016 12:59 PM, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Patches are independent, please pick up as

Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting

2016-04-30 Thread Hans Verkuil
Hi Krzysztof, On 04/29/2016 12:59 PM, Krzysztof Kozlowski wrote: > Hi, > > Patches are independent, please pick up as you wish. > > However all of them are needed to solve the issue, so I am sending > everything together for easier testng. > > > Problem > === > When Odroid U3 (usb3503 + sm

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-19 Thread Hans Verkuil
On 08/19/2014 05:01 PM, Laurent Pinchart wrote: > Hi Michael, > > Thank you for the patch. > > (CC'ing Hans Verkuil and the linux-media mailing list) > > On Friday 08 August 2014 17:38:58 Michael Grzeschik wrote: >> This patch adds ENUM_FMT as possible ioctl

Re: [PATCH 2/2] usb: gadget: f_uvc: Move to video_ioctl2

2014-08-18 Thread Hans Verkuil
On 08/18/2014 05:06 PM, Laurent Pinchart wrote: > Simplify ioctl handling by using video_ioctl2. Are you able to test this on actual hardware? And if so, can you run v4l2-compliance? Regards, Hans > > Signed-off-by: Laurent Pinchart > --- > drivers/usb/gadget/function/f_uvc.c|

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Hans Verkuil
On 08/12/2014 06:21 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote: >> On 08/12/2014 05:07 PM, Hans de Goede wrote: >>> On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: >>>> On 2014-08-04 11:17, Laurent Pinchar

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Hans Verkuil
On 08/12/2014 05:07 PM, Hans de Goede wrote: > Hi Udo, > > On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: >> On 2014-08-04 11:17, Laurent Pinchart wrote: >>> (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list) > > Thanks for the bug report. I've been looking into this,

Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, Ltd Digital Camera EX-20 DSC

2014-05-30 Thread Hans Verkuil
On 05/29/2014 08:23 PM, Richie Gress wrote: > >> Date: Wed, 28 May 2014 10:56:51 +0200 >> From: hverk...@xs4all.nl >> To: searchfgold67...@live.com; linux-usb@vger.kernel.org; >> linux-me...@vger.kernel.org >> Subject: Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran >> Microelect

Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, Ltd Digital Camera EX-20 DSC

2014-05-28 Thread Hans Verkuil
On 05/27/14 19:55, Richie Gress wrote: > > >> Date: Tue, 27 May 2014 09:03:33 +0200 >> From: hverk...@xs4all.nl >> To: searchfgold67...@live.com; linux-usb@vger.kernel.org; >> linux-me...@vger.kernel.org >> Subject: Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran >> Microelectro

Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, Ltd Digital Camera EX-20 DSC

2014-05-27 Thread Hans Verkuil
On 05/27/2014 03:34 AM, Richie wrote: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1322380 > > [1.] One line summary of the problem: > > 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, > Ltd Digital Camera EX-20 DSC > > [2.] Full description of the proble

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Hans Verkuil
On 05/23/2014 06:59 PM, Chaitanya Hazarey wrote: > Hey Dan, > > Sorry my bad, will resubmit the patch in a proper manner with the > required corrections. > Don't bother. This patch: http://comments.gmane.org/gmane.linux.drivers.driver-project.devel/48570 has just been merged and that has the sa

Re: [PATCH v2 2/3] usb: gadget: uvc: Set the V4L2 buffer field to V4L2_FIELD_NONE

2014-03-28 Thread Hans Verkuil
On 03/28/2014 05:02 PM, Laurent Pinchart wrote: > The UVC gadget driver doesn't support interlaced video but left the > buffer field uninitialized. Set it to V4L2_FIELD_NONE. > > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Regards, Hans > --- &

Re: [PATCH v2 1/3] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

2014-03-28 Thread Hans Verkuil
On 03/28/2014 05:02 PM, Laurent Pinchart wrote: > The wall time clock isn't useful for applications as it can jump around > due to time adjustement. Switch to the monotonic clock. > > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Regards, Hans > --- &

Re: [PATCH 2/2] usb: gadget: uvc: Set the vb2 queue timestamp flags

2014-03-28 Thread Hans Verkuil
g Wu > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/usb/gadget/uvc_queue.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/gadget/uvc_queue.c b/drivers/usb/gadget/uvc_queue.c > index d4561ba..4

Re: [PATCH 1/2] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

2014-03-28 Thread Hans Verkuil
Hi Laurent, I have a few comments: On 03/23/2014 04:32 PM, Laurent Pinchart wrote: > The wall time clock isn't useful for applications as it can jump around > due to time adjustement. Switch to the monotonic clock. > > Signed-off-by: Laurent Pinchart > --- > drivers/usb/gadget/uvc_queue.c | 12

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:44 PM, Russell King wrote: > Replace the following sequence: > > dma_set_mask(dev, mask); > dma_set_coherent_mask(dev, mask); > > with a call to the new helper dma_set_mask_and_coherent(). > > Signed-off-by: Russell King Acked-by

Re: [PATCH v1 43/49] media: usb: em28xx: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
On Sat 17 August 2013 18:25:08 Ming Lei wrote: > Complete() will be run with interrupt enabled, so add local_irq_save() > before acquiring the lock without irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans

Re: [PATCH v1 41/49] media: usb: tm6000: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
On Sat 17 August 2013 18:25:06 Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans Verkuil Regards, Hans >

Re: [PATCH v1 42/49] media: dvb-core: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
..@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans Verkuil Note: Mauro needs to Ack this as well. It looks good to me, but I don't maintain dvb code. Regards, Hans > --- > drivers/media/dvb-core/dvb_demux.c | 17 +++-- > 1 file changed, 11 ins

Re: [PATCH v1 39/49] media: usb: sn9x102: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
On Sat 17 August 2013 18:25:04 Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans Verkuil Regards, Hans >

Re: [PATCH v1 40/49] media: usb: tlg2300: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
On Sat 17 August 2013 18:25:05 Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans Verkuil Regards, Hans >

Re: [PATCH v1 38/49] media: usb: em28xx: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
off-by: Ming Lei Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/usb/em28xx/em28xx-core.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-core.c > b/drivers/media/usb/em28xx/em28xx-core

Re: [PATCH v1 37/49] media: usb: cx231xx: prepare for enabling irq in complete()

2013-08-22 Thread Hans Verkuil
On Sat 17 August 2013 18:25:02 Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei Acked-by: Hans Verkuil R

Re: [PATCH 35/50] media: usb: cx231xx: spin_lock in complete() cleanup

2013-07-26 Thread Hans Verkuil
On 07/11/2013 11:05 AM, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei > --- > drivers/media/usb/cx2

Re: [PATCH] console/font: Refactor font support code selection logic

2013-05-15 Thread Hans Verkuil
built-in.o: In function `solo_osd_print': > drivers/staging/media/solo6x10/solo6x10-enc.c:144: undefined reference to > `.find_font' > > Signed-off-by: Geert Uytterhoeven That looks much more sane. Thanks! Acked-by: Hans Verkuil > --- > drivers/media/platform/