Re: [PATCH v3 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings

2019-01-21 Thread Gregory CLEMENT
scellaneous" as we do for all the other IP. Gregory > > Reviewed-by: Rob Herring > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH v2 05/10] phy: add A3700 UTMI PHY driver

2019-01-18 Thread Gregory CLEMENT
efault, bein 25MHz now. bein? > + * See "PLL Settings for Typical REFCLK" table. [...] > + > + /* Wait for squetch calibration */ squetch? Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH v2 03/10] usb: ehci-orion: avoid double PHY initialization

2019-01-18 Thread Gregory CLEMENT
usb_put_hcd(hcd); > @@ -327,11 +312,6 @@ static int ehci_orion_drv_remove(struct platform_device > *pdev) > > usb_remove_hcd(hcd); > > - if (!IS_ERR(priv->phy)) { > - phy_power_off(priv->phy); > - phy_exit(priv->phy); > - } > - > if (!IS_ERR(priv->clk)) > clk_disable_unprepare(priv->clk); > > -- > 2.19.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH v2 02/10] usb: host: xhci: mvebu: add reset on resume quirk

2019-01-18 Thread Gregory CLEMENT
= { > .firmware_name = XHCI_RCAR_FIRMWARE_NAME_V1, > .init_quirk = xhci_rcar_init_quirk, > @@ -123,6 +127,9 @@ static const struct of_device_id usb_xhci_of_match[] = { > }, { > .compatible = "marvell,armada-380-xhci", > .data = &xhci_plat_marvell_armada, > + }, { > + .compatible = "marvell,armada3700-xhci", > + .data = &xhci_plat_marvell_armada3700, Reviewed-by: Gregory CLEMENT Thanks, Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH 0/2] Allow xhci-plat using a second clock

2018-04-19 Thread Gregory CLEMENT
Hi Mathias, On jeu., avril 19 2018, Mathias Nyman wrote: > On 18.04.2018 17:20, Gregory CLEMENT wrote: >> Hi Mathias, >> On mer., févr. 14 2018, Gregory CLEMENT >> wrote: >> >>> Hello, >>> >>> The purpose of this series is to allow x

[PATCH v2 2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock

2018-04-19 Thread Gregory CLEMENT
would have this kind of constraint. The binding documentation is updating accordingly. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 - drivers/usb/host/xhci-plat.c | 25 ++ drivers/usb/host/xhci.h

[PATCH v2 0/2] Allow xhci-plat using a second clock

2018-04-19 Thread Gregory CLEMENT
rc1 Gregory CLEMENT (2): usb: host: xhci-plat: Remove useless test before clk_disable_unprepare usb: host: xhci-plat: Fix clock resource by adding a register clock Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 +++- drivers/usb/host/xhci-plat.c |

[PATCH v2 1/2] usb: host: xhci-plat: Remove useless test before clk_disable_unprepare

2018-04-19 Thread Gregory CLEMENT
clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/xhci-plat.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host

Re: [PATCH 0/2] Allow xhci-plat using a second clock

2018-04-18 Thread Gregory CLEMENT
Hi Mathias, On mer., févr. 14 2018, Gregory CLEMENT wrote: > Hello, > > The purpose of this series is to allow xhci-plat using a second > clock. It is needed on the Armada 7K/8K but could be used by other > SoCs. > > The first patch is just a fix found while I was work

Re: [PATCH 2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock

2018-03-14 Thread Gregory CLEMENT
Hi Rob, (resent because of malformed cc list) On mer., févr. 28 2018, Mathias Nyman wrote: > On 14.02.2018 18:16, Gregory CLEMENT wrote: >> On Armada 7K/8K we need to explicitly enable the register clock. This >> clock is optional because not all the SoCs using this IP

Re: [PATCH 2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock

2018-02-28 Thread Gregory CLEMENT
Hi Manu, On mer., févr. 28 2018, Manu Gautam wrote: > Hi, > > > On 2/14/2018 9:46 PM, Gregory CLEMENT wrote: >> On Armada 7K/8K we need to explicitly enable the register clock. This >> clock is optional because not all the SoCs using this IP need it but at >>

Re: [PATCH 0/2] Allow xhci-plat using a second clock

2018-02-28 Thread Gregory CLEMENT
Hi Mathias, On mer., févr. 14 2018, Gregory CLEMENT wrote: > Hello, > > The purpose of this series is to allow xhci-plat using a second > clock. It is needed on the Armada 7K/8K but could be used by other > SoCs. Do you have some comments on this series and especially on t

[PATCH 2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock

2018-02-14 Thread Gregory CLEMENT
would have this kind of constraint. The binding documentation is updating accordingly. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 +++- drivers/usb/host/xhci-plat.c | 33 ++ drivers/usb/host/xhci.h

[PATCH 1/2] usb: host: xhci-plat: Remove useless test before clk_disable_unprepare

2018-02-14 Thread Gregory CLEMENT
clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/xhci-plat.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host

[PATCH 0/2] Allow xhci-plat using a second clock

2018-02-14 Thread Gregory CLEMENT
Hello, The purpose of this series is to allow xhci-plat using a second clock. It is needed on the Armada 7K/8K but could be used by other SoCs. The first patch is just a fix found while I was working on this feature. Thanks, Gregory Gregory CLEMENT (2): usb: host: xhci-plat: Remove useless

Re: [PATCH v4 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-10 Thread Gregory CLEMENT
Hi Alan, On jeu., mars 09 2017, Alan Stern wrote: > On Thu, 9 Mar 2017, Gregory CLEMENT wrote: > >> From: Hua Jing >> >> - Add a new compatible string for the Armada 3700 SoCs >> >> - add sbuscfg support for orion usb controller driver. For the SoCs >

[PATCH v4 0/3] Add EHCI support for Armada 37xx

2017-03-09 Thread Gregory CLEMENT
- Improve the commit log of the patch 2, suggested by Andrew Lunn - Fix Kconfig logic, suggested by Andrew Lunn Gregory CLEMENT (2): usb: host: Allow to build ehci orion with mvebu SoCs ARM64: dts: marvell: armada-37xx: Add USB2 node Hua Jing (1): usb: orion-echi: Add support for the Ar

[PATCH v4 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-09 Thread Gregory CLEMENT
path in ehci_orion_drv_reset() - fix checkpatch warning] Signed-off-by: Hua Jing Signed-off-by: Gregory CLEMENT Reviewed-by: Andrew Lunn --- .../devicetree/bindings/usb/ehci-orion.txt | 4 ++- drivers/usb/host/ehci-orion.c

[PATCH v4 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node

2017-03-09 Thread Gregory CLEMENT
Armada 37xx SoC embedded an EHCI controller. This patch adds the device tree node enabling its support. Reviewed-by: Andrew Lunn Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 6 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 2 files

[PATCH v4 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

2017-03-09 Thread Gregory CLEMENT
The mvebu ARM64 SoCs no longer select PLAT_ORION. However Armada 37xx use the Orion EHCI controller. This patch allows the Orion EHCI driver to be built when ARCH_MVEBU is selected. Reviewed-by: Andrew Lunn Signed-off-by: Gregory CLEMENT --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1

[PATCH v3 0/3] Add EHCI support for Armada 37xx

2017-03-09 Thread Gregory CLEMENT
ted by Andrew Lunn - Fix Kconfig logic, suggested by Andrew Lunn Gregory CLEMENT (2): usb: host: Allow to build ehci orion with mvebu SoCs ARM64: dts: marvell: armada-37xx: Add USB2 node Hua Jing (1): usb: orion-echi: Add support for the Armada 3700 .../devicetree/bindings/usb/ehci-ori

[PATCH v3 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node

2017-03-09 Thread Gregory CLEMENT
Armada 37xx SoC embedded an EHCI controller. This patch adds the device tree node enabling its support. Reviewed-by: Andrew Lunn Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 6 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 2 files

[PATCH v3 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-09 Thread Gregory CLEMENT
patch warning] Signed-off-by: Hua Jing Signed-off-by: Gregory CLEMENT Reviewed-by: Andrew Lunn --- .../devicetree/bindings/usb/ehci-orion.txt | 4 ++- drivers/usb/host/ehci-orion.c | 39 ++ 2 files changed, 42 insertions(+), 1 deletion(-) diff

[PATCH v3 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

2017-03-09 Thread Gregory CLEMENT
The mvebu ARM64 SoCs no longer select PLAT_ORION. However Armada 37xx use the Orion EHCI controller. This patch allows the Orion EHCI driver to be built when ARCH_MVEBU is selected. Reviewed-by: Andrew Lunn Signed-off-by: Gregory CLEMENT --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v3 0/3] Add EHCI support for Armada 37xx

2017-03-09 Thread Gregory CLEMENT
Hi, On jeu., mars 09 2017, Gregory CLEMENT wrote: > Hi, > > The EHCI controller in the Armada 37xx SoCs is the one used on many > other mvebu SoCs such as the orion5x, the kirkwood, or the > armada. However, for Armada 37xx an extra initialization step is > needed: this is

Re: [PATCH v2 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-09 Thread Gregory CLEMENT
etval;" as suggested below. Thanks, Gregory >> + >> +/* >> + * For SoC without hlock, need to program sbuscfg value to guarantee >> + * AHB master's burst would not overrun or underrun FIFO. >> + * >> + * sbuscfg reg has to be set after

[PATCH v2 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

2017-03-09 Thread Gregory CLEMENT
The mvebu ARM64 SoCs no longer select PLAT_ORION. However Armada 37xx use the Orion EHCI controller. This patch allows the Orion EHCI driver to be built when ARCH_MVEBU is selected. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-09 Thread Gregory CLEMENT
patch warning] Signed-off-by: Hua Jing Signed-off-by: Gregory CLEMENT --- .../devicetree/bindings/usb/ehci-orion.txt | 4 ++- drivers/usb/host/ehci-orion.c | 39 ++ 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/Documentation/devic

[PATCH v2 0/3] Add EHCI support for Armada 37xx

2017-03-09 Thread Gregory CLEMENT
the patch 2, suggested by Andrew Lunn - Fix Kconfig logic, suggested by Andrew Lunn Gregory CLEMENT (2): usb: host: Allow to build ehci orion with mvebu SoCs ARM64: dts: marvell: armada-37xx: Add USB2 node Hua Jing (1): usb: orion-echi: Add support for the Armada 3700 .../devicetree/bindings/

[PATCH v2 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node

2017-03-09 Thread Gregory CLEMENT
Armada 37xx SoC embedded an EHCI controller. This patch adds the device tree node enabling its support. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 6 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 2 files changed, 13 insertions

Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

2017-03-08 Thread Gregory CLEMENT
Hi Andrew, On mer., mars 08 2017, Andrew Lunn wrote: > On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote: >> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the >> Armada 37xx use the EHCI orion controller. This patch allow to build >

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
t here. ... but I didn't think to this trick. > >> + >> +#define USB_SBUSCFG_DEF_VAL ((USB_SBUSCFG_BAWR_ALIGN_128B << >> USB_SBUSCFG_BAWR) \ >> + | (USB_SBUSCFG_BARD_ALIGN_128B << USB_SBUSCFG_BARD) \ >> + | (USB_SBUSCFG_AHBBRST_INCR16 <&

[PATCH 0/3] Add EHCI support for Armada 37xx

2017-03-08 Thread Gregory CLEMENT
ARM64 Armada SoCs. The last one enables the EHCI in the device tree. Thanks, Gregory Gregory CLEMENT (2): usb: host: Allow to build ehci orion with mvebu SoCs ARM64: dts: marvell: armada-37xx: Add USB2 node jinghua (1): usb: orion-echi: Add support for the Armada 3700 .../devicetree

[PATCH 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node

2017-03-08 Thread Gregory CLEMENT
Armada 37xx SoC embedded an EHCI controller. This patch adds the device tree node enabling its support. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 6 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 2 files changed, 13 insertions

[PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

2017-03-08 Thread Gregory CLEMENT
The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the Armada 37xx use the EHCI orion controller. This patch allow to build the driver when ARCH_MVEBU is selected. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
patch warning] Signed-off-by: jinghua Signed-off-by: Gregory CLEMENT --- .../devicetree/bindings/usb/ehci-orion.txt | 4 ++- drivers/usb/host/ehci-orion.c | 39 ++ 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/Documentation/devic

Re: [PATCH v2 0/6] usb: xhci: plat: get rid of xhci_plat_type_is()

2016-04-07 Thread Gregory CLEMENT
r and easier to read. I tested the series on a Armada 388 GP board (using mvebu init_quirk()) and I didn't see any regression. Feel free to add my Tested-by: Gregory CLEMENT Gregory > > Felipe Balbi (6): > usb: host: xhci: rcar: retire use of xhci_plat_type_is() > usb: xh

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Gregory CLEMENT
MARVELL_ARMADA = 1, >> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2, >> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3, > > aren't these platforms using device tree ? Why aren't these just > different compatible strings ? According to 4efb2f69411456d35051e9047c15157c9a5ba217 "usb:

Re: [PATCH 04/21] usb: add HAS_IOMEM dependency to USB_XHCI_MVEBU

2016-02-11 Thread Gregory CLEMENT
or: implicit declaration of function > ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(base); > ^ > It seems strange to add this because HAS_IOMEM is implied by ARCH_MVEBU. But maybe the point of COMPILE_TEST is to make this dependencies more visible. So why not. Acked-by: Gre

[PATCH] usb: host: xhci-plat: fix NULL pointer in probe for device tree case

2016-01-22 Thread Gregory CLEMENT
ng it, avoiding a kernel crash. Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv") Cc: sta...@vger.kernel.org Signed-off-by: Gregory CLEMENT --- drivers/usb/host/xhci-plat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-p

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-12-08 Thread Gregory CLEMENT
Hi Felipe, On lun., déc. 07 2015, Felipe Balbi wrote: > Hi, > > Gregory CLEMENT writes: >> Hi Felipe, >> >> I am going back on this subject (again :) ) >> >> On mar., oct. 20 2015, Gregory CLEMENT >> wrote: >> >>> Hi F

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-12-07 Thread Gregory CLEMENT
Hi Felipe, I am going back on this subject (again :) ) On mar., oct. 20 2015, Gregory CLEMENT wrote: > Hi Felipe, > > On lun., oct. 05 2015, Felipe Balbi wrote: > > >>> So after many tests on different devices, 200ms is enough for most of >>> them, bu

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-10-20 Thread Gregory CLEMENT
as I got an interrupt when I connected it). Note that I applied this patch instead of the "usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case", is what you had in mind ? Gregory > > [1] http://www.ti.com/lit/ug/spruh73l/spruh73l.pdf > > -- > balbi --

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-08-31 Thread Gregory CLEMENT
Hi Felipe, On ven., août 21 2015, Gregory CLEMENT wrote: >> According to the OTG specification after a timeout of >> OTG_TIME_A_WAIT_VRISE (the maximum value is 100ms) the driver must >> move from the state a_wait_vrise to the state a_wait_bcon. However, >> the dsps

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-08-21 Thread Gregory CLEMENT
Hi all, On 20/08/2015 18:12, Gregory CLEMENT wrote: > According to the OTG specification after a timeout of > OTG_TIME_A_WAIT_VRISE (the maximum value is 100ms) the driver must > move from the state a_wait_vrise to the state a_wait_bcon. However, > the dsps version of musb does not

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-21 Thread Gregory CLEMENT
On 20/08/2015 18:46, Felipe Balbi wrote: > On Thu, Aug 20, 2015 at 06:35:17PM +0200, Gregory CLEMENT wrote: >> Hi Felipe, >> >> On 18/08/2015 16:13, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue, Aug 18, 2015 at 02:36:13PM +0200, Gregory CLEMENT wr

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-20 Thread Gregory CLEMENT
Hi Felipe, On 18/08/2015 16:13, Felipe Balbi wrote: > Hi, > > On Tue, Aug 18, 2015 at 02:36:13PM +0200, Gregory CLEMENT wrote: >> Hi again Felipe, >> >> I sent this email again without the capture because it prevented to be >> delivered >> to the mailing l

[PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-08-20 Thread Gregory CLEMENT
exit this state was to insert a OTG adapter with an USB device connected. Until this, the usb device mode was not available. It was tested on a AM35x based board. CC: Signed-off-by: Gregory CLEMENT --- drivers/usb/musb/musb_dsps.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-18 Thread Gregory CLEMENT
Hi again Felipe, I sent this email again without the capture because it prevented to be delivered to the mailing lists. On 04/08/2015 21:32, Felipe Balbi wrote: > On Tue, Aug 04, 2015 at 04:23:02PM +0200, Gregory CLEMENT wrote: >> Hi again, >> On 04/08/2015 15:08, Gregory CLEMEN

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-04 Thread Gregory CLEMENT
Hi again, On 04/08/2015 15:08, Gregory CLEMENT wrote: > Hi Bin, > > On 02/07/2015 19:05, Bin Liu wrote: >> Hi, >> >> On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT >> wrote: >>> Hi Felipe, >>> >>> On 27/05/2015 11:42, Alexandre Bello

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-04 Thread Gregory CLEMENT
Hi Bin, On 02/07/2015 19:05, Bin Liu wrote: > Hi, > > On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT > wrote: >> Hi Felipe, >> >> On 27/05/2015 11:42, Alexandre Belloni wrote: >>> Hi, >>> >>> On 26/05/2015 at 09:51:18 -0500, Felipe Ba

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, On 02/07/2015 16:01, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 03:52:32PM +0200, Gregory CLEMENT wrote: >> Hi Felipe, >> >> On 02/07/2015 15:14, Felipe Balbi wrote: >>> On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: >>>>

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, On 02/07/2015 15:14, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: >> >> >> On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: >>>> On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: >>>&

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, thanks for you prompt feedback. On 02/07/2015 13:45, Felipe Balbi wrote: > Hi, > > On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: >> Hello, >> >> When I use configs to configure the mass storage function for the >> gadget, and

Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
number using fsg_common_set_nluns. There is no problem at all under Linux so maybe it is jut the way how the gadget is exposed through USB. I tested it on the kernel 3.17 and 4.1 using the musb of the SoC AM335x. Thanks for your feedback. Gregory -- Gregory Clement, Free Electrons Kernel, driver

Re: MUSB dual-role on AM335x behaving weirdly

2015-07-02 Thread Gregory CLEMENT
U1 is actually not fitted. > > We didn't measure VBUS discharging but we observe the OTG pin sensing > stops when plugging an OTG cable without any device. Do you have any news about this topic? Is there something else that we can do to help solving this issue? Thanks, Gregory

Re: [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip

2015-04-15 Thread Gregory CLEMENT
nux.kernel/1879035 > > Signed-off-by: Roger Quadros FWIW: Reviewed-by: Gregory CLEMENT > --- > kernel/irq/dummychip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c > index 988dc58..2feb6fe 100644 > --- a/kernel/i

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-04-15 Thread Gregory CLEMENT
Hi Roger, On 15/04/2015 10:07, Roger Quadros wrote: > Hi Gregory, > > On 14/04/15 17:02, Gregory CLEMENT wrote: >> Hi Roger, >> >> On 14/04/2015 12:13, Roger Quadros wrote: >>> Hi Thomas, >>> >>> On 30/03/15 16:15, Roger Quadros wrote: >

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-04-14 Thread Gregory CLEMENT
sk = noop, >> +.irq_set_wake = noop_int_ret, >> }; >> EXPORT_SYMBOL_GPL(dummy_irq_chip); >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info

Re: [PATCH v2 3/3] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-03-18 Thread Gregory CLEMENT
_vbus: xhci0-vbus { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&xhci0_vbus_pins>; > + regulator-name = "xhci0-vbus"; > + regulator-min-microvolt = <

Re: [PATCH v2 3/3] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-03-02 Thread Gregory CLEMENT
0_vbus>; > + }; > + > + reg_xhci0_vbus: xhci0-vbus { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&xhci0_vbus_pins>; > + regulator-name = "xhci0-vb

[PATCH] xhci: Fix the lack of support for the Handle Port Configure Error

2015-02-06 Thread Gregory CLEMENT
orted from 3.10 and added more explanations(from Shimmer) in the commit log] Signed-off-by: Guang Shen Signed-off-by: Shimmer Huang Signed-off-by: Nadav Haklai Reviewed-by: Yehuda Yitschak Signed-off-by: Gregory CLEMENT Cc: --- Hi, usually I tried to add a kernel version for the stable tea

Re: [PATCH usb v3 22/29] host: xhci-plat: remove duplicate check on resource

2014-11-03 Thread Gregory CLEMENT
Hi Varka, On 31/10/2014 02:14, Varka Bhadram wrote: > From: Varka Bhadram > > Sanity check on resource happening with devm_ioremap_resource(). Reviewed-by: Gregory CLEMENT Thanks, Gregory > > Signed-off-by: Varka Bhadram > Acked-by: Alan Stern > --- > driv

Re: [PATCH usb v3 17/29] host: ehci-orion: remove duplicate check on resource

2014-11-03 Thread Gregory CLEMENT
Hi Varka, On 31/10/2014 02:14, Varka Bhadram wrote: > From: Varka Bhadram > > Sanity check on resource happening with devm_ioremap_resource(). Reviewed-by: Gregory CLEMENT Thanks, Gregory > > Signed-off-by: Varka Bhadram > Acked-by: Alan Stern > --- > drive

Re: [PATCH v6 00/17] USB support for Armada 38x and Armada 375

2014-05-27 Thread Gregory CLEMENT
On 28/05/2014 00:41, Greg Kroah-Hartman wrote: > On Wed, May 21, 2014 at 03:50:47PM +0200, Gregory CLEMENT wrote: >> Hi Greg, >> >> On 15/05/2014 12:17, Gregory CLEMENT wrote: >>> Hello, >>> >>> This patch set adds the USB support for the Armada 38x

Re: [PATCH 1/5] phy: add support for USB cluster on the Armada 375 SoC

2014-05-23 Thread Gregory CLEMENT
On 23/05/2014 11:20, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> The Armada 375 SoC comes with an USB2 host and device controller and >> an USB3 controller. The USB cluster control register allows to manage >>

Re: [PATCH 4/5] usb: host: xhci-plat: add optional PHY support

2014-05-23 Thread Gregory CLEMENT
On 23/05/2014 11:28, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> This commit extends the xhci-plat so that it can optionally be passed >> a reference to a PHY through the Device Tree. It will be useful for >> the Ar

Re: [PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding

2014-05-23 Thread Gregory CLEMENT
et/lists/devicetree/msg17011.html into your tree. >>> >>> I can resend that one missing patch if you want. >> >> yes please. But it's already too late to go in the next merge window. > > Gregory, could you pick it up and append your 375 binding to i

Re: [PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding

2014-05-23 Thread Gregory CLEMENT
Hi Kishon, On 23/05/2014 11:24, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> Armada 375 comes with an USB2 host and device controller and an USB3 >> controller. The USB cluster control register allows to manage common &g

Re: [PATCH v6 10/17] ARM: mvebu: add USB3 support for Armada 38x

2014-05-21 Thread Gregory CLEMENT
On 19/05/2014 13:09, Paul Bolle wrote: > On Fri, 2014-05-16 at 15:07 -0400, Jason Cooper wrote: >> On Thu, May 15, 2014 at 12:17:35PM +0200, Gregory CLEMENT wrote: >>> This patch adds the selection of the config symbol needed to build the >>> USB3 support for Armada

Re: [PATCH v6 00/17] USB support for Armada 38x and Armada 375

2014-05-21 Thread Gregory CLEMENT
Hi Greg, On 15/05/2014 12:17, Gregory CLEMENT wrote: > Hello, > > This patch set adds the USB support for the Armada 38x and Armada 375 > SOCs. These SoCs use an xHCI but still need specific initialization, > mainly to setup the MBus memory windows. They also have another USB &

[PATCH 0/5] Add support for USB cluster(PHY muxer) on the Armada 375 SoC

2014-05-16 Thread Gregory CLEMENT
o fix his dts. During the debug I also noticed that xhci don't handle the PHY so I also add the support for an optional phy. This patch is for Mathias Nyman. Thanks, Gregory Gregory CLEMENT (5): phy: add support for USB cluster on the Armada 375 SoC Documentation: dt-bindings: document

[PATCH 3/5] ARM: mvebu: add Device Tree description of USB cluster controller on Armada 375

2014-05-16 Thread Gregory CLEMENT
On Armada 375, the USB cluster allows to control the cluster composed of the USB2 and USB3 host controllers. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-375.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts

[PATCH 1/5] phy: add support for USB cluster on the Armada 375 SoC

2014-05-16 Thread Gregory CLEMENT
: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- drivers/phy/Kconfig | 6 + drivers/phy/Makefile | 1 + drivers/phy/phy-armada375-usb2.c | 140 +++ include/dt-bindings/phy/armada-375-usb

[PATCH 5/5] ARM: mvebu: add PHY support to the dts for the USB controllers on Armada 375

2014-05-16 Thread Gregory CLEMENT
Now that the USB cluster node has been added, use it as a PHY provider for the USB controller linked to it: the first EHCI and the xHCI. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-375.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/armada-375

[PATCH 4/5] usb: host: xhci-plat: add optional PHY support

2014-05-16 Thread Gregory CLEMENT
member in xhci_hcd. While only used for now in xhci-plat, here again, it might be used by other drivers in the future. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/xhci-plat.c | 29 - drivers/usb/host/xhci.h | 2 ++ 2 files changed, 30 insertions(+),

[PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding

2014-05-16 Thread Gregory CLEMENT
Armada 375 comes with an USB2 host and device controller and an USB3 controller. The USB cluster control register allows to manage common features of both USB controllers. This commit adds the Device Tree binding documentation for this piece of hardware. Signed-off-by: Gregory CLEMENT

Re: [PATCH v6 17/17] ARM: mvebu: add Device Tree description of the EHCI controller on Armada 375

2014-05-15 Thread Gregory CLEMENT
On 15/05/2014 15:34, Jason Cooper wrote: > On Thu, May 15, 2014 at 05:26:36PM +0400, Sergei Shtylyov wrote: >> Hello. >> >> On 05/15/2014 02:17 PM, Gregory CLEMENT wrote: >> >>> The Marvell Armada 375 SoCs contains one EHCI controller. This commit >> >

[PATCH v6 00/17] USB support for Armada 38x and Armada 375

2014-05-15 Thread Gregory CLEMENT
1.html the details of why it doesn't work). Instead, add a 'struct clk*' field in xhci_hcd to support the clock in xhci-plat, exactly like xhci_hcd has msix_count and msix_entries for xhci-pci. - Misc minor code style improvements. Gregory CLEMENT (14

[PATCH v6 01/17] usb: ehci-orion: use platform_get_irq() for DT probing

2014-05-15 Thread Gregory CLEMENT
From: Thomas Petazzoni Commit 77dae54ab385033e488d8b07045bc7f8d931740f ('ARM: Kirkwood: ehci-orion: Add device tree binding') added the Device Tree binding for the ehci-orion driver. To achieve that with the irq, it used the irq_of_parse_and_map() function when probed in DT-mode, and platform_get

[PATCH v6 07/17] usb: host: xhci-plat: add clock support

2014-05-15 Thread Gregory CLEMENT
ow in xhci-plat, it might be used by other drivers in the future. Moreover, the xhci_hcd structure already holds other members such as msix_count and msix_entries, which are MSI-X specific, and therefore only used by xhci-pci. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Acked-

[PATCH v6 06/17] usb: host: xhci-plat: sort the headers in alphabetic order

2014-05-15 Thread Gregory CLEMENT
Sorting the headers in alphabetic order will help to reduce the conflict when adding new headers later. Signed-off-by: Gregory CLEMENT Acked-by: Felipe Balbi --- drivers/usb/host/xhci-plat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c

[PATCH v6 05/17] Documentation: dt-bindings: update ehci-orion binding documentation

2014-05-15 Thread Gregory CLEMENT
From: Thomas Petazzoni This commit updates the Device Tree binding documentation of ehci-orion to take into account the fact that we can now optionally pass a clock and a PHY reference. Signed-off-by: Thomas Petazzoni Acked-by: Alan Stern --- Documentation/devicetree/bindings/usb/ehci-orion.t

[PATCH v6 03/17] usb: ehci-orion: fix clock reference leaking

2014-05-15 Thread Gregory CLEMENT
] Fixes: 8c869edaee07c623066266827371235fb9c12e01 ('ARM: Orion: EHCI: Add support for enabling clocks') Cc: # v3.8+ Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Acked-by: Alan Stern --- drivers/usb/host/ehci-orion.c | 45 ---

[PATCH v6 14/17] ARM: mvebu: add Device Tree description of xHCI controllers on Armada 38x

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 38x SoCs contains two xHCI controllers. This commit adds the Device Tree description of those interfaces at the SoC level, and also enables the two USB3 ports on the Armada 385 DB platform and one USB3 port on the Armada 385 RD platform. Signed-off-by: Gregory CLEMENT Signed

[PATCH v6 12/17] ARM: configs: enable XHCI mvebu support in mvebu_v7_defconfig

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 38x platform needs the xhci_mvebu driver enabled for the xHCI USB hosts, so this commit enables the corresponding Kconfig option in mvebu_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/configs/mvebu_v7_defconfig | 1 + 1 file

[PATCH v6 08/17] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers

2014-05-15 Thread Gregory CLEMENT
Armada 375 and Armada 38x XHCI controllers, and therefore enable the relevant quirk. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Acked-by: Mathias Nyman --- drivers/usb/host/Kconfig | 8 + drivers/usb/host/Makefile | 3 ++ drivers/usb/host/xhci-mvebu.c | 72

[PATCH v6 10/17] ARM: mvebu: add USB3 support for Armada 38x

2014-05-15 Thread Gregory CLEMENT
This patch adds the selection of the config symbol needed to build the USB3 support for Armada 38x into mvebu_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/mach-mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mvebu

[PATCH v6 09/17] Documentation: dt-bindings: update xhci-platform DT binding

2014-05-15 Thread Gregory CLEMENT
al 'clocks' property is now supported. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Acked-by: Mathias Nyman --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetre

[PATCH v6 11/17] ARM: mvebu: add USB3 support for Armada 375

2014-05-15 Thread Gregory CLEMENT
This patch add the selection of the config symbol to build the USB3 support for Armada 375. Signed-off-by: Gregory CLEMENT --- arch/arm/mach-mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 7960f218702b

[PATCH v6 17/17] ARM: mvebu: add Device Tree description of the EHCI controller on Armada 375

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 375 SoCs contains one EHCI controller. This commit adds the Device Tree description of this interfaces at the SoC level, and also enables the USB2 port on the Armada 375 DB platform. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/boot/dts/armada

[PATCH v6 13/17] ARM: configs: enable XHCI mvebu support in multi_v7_defconfig

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 38x platform needs the xhci_mvebu driver enabled for the xHCI USB hosts, so this commit enables the corresponding Kconfig option in multi_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Cc: a...@kernel.org Cc: Kevin Hilman Cc: Olof Johansson Cc

[PATCH v6 16/17] ARM: mvebu: add Device Tree description of the xHCI controller on Armada 375

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 375 SoCs contain a xHCI controller. This commit adds the Device Tree description of this interfaces at the SoC level, and also enables the USB3 port on the Armada 375 DB platform. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/boot/dts/armada-375

[PATCH v6 15/17] ARM: mvebu: add Device Tree description of the EHCI controller on Armada 38x

2014-05-15 Thread Gregory CLEMENT
The Marvell Armada 38x SoCs contains one EHCI controller. This commit adds the Device Tree description of this interface at the SoC level, and also enables the USB2 port on the Armada 385 DB platform. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-385-db.dts | 4 arch/arm/boot

[PATCH v6 04/17] usb: ehci-orion: add optional PHY support

2014-05-15 Thread Gregory CLEMENT
properly. Also call phy_power_off() when needed, and rename goto labels.] Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Acked-by: Alan Stern --- drivers/usb/host/ehci-orion.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/usb/host/ehci

[PATCH v6 02/17] usb: ehci-orion: rename error goto labels in ehci_orion_drv_probe()

2014-05-15 Thread Gregory CLEMENT
From: Thomas Petazzoni In preparation to the introduction of additional initialization steps in ehci_orion_drv_probe(), we rename the error goto labels from err1, err2 and err3 names to some more meaningful names. Signed-off-by: Thomas Petazzoni Acked-by: Alan Stern --- drivers/usb/host/ehci-

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-15 Thread Gregory CLEMENT
Hi Kishon, On 15/05/2014 11:01, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 15 May 2014 12:31 PM, Gregory CLEMENT wrote: >> Hi Kishon, >> >> On 14/05/2014 17:35, Gregory CLEMENT wrote: >>> On 14/05/2014 16:27, Kishon Vijay Abraham I wrote: >>>

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-15 Thread Gregory CLEMENT
Hi Kishon, On 14/05/2014 17:35, Gregory CLEMENT wrote: > On 14/05/2014 16:27, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 13 May 2014 03:11 PM, Gregory CLEMENT wrote: >>> On 13/05/2014 10:06, Gregory CLEMENT wrote: >>>> On 13/05/2014 07:

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-14 Thread Gregory CLEMENT
On 14/05/2014 16:27, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 13 May 2014 03:11 PM, Gregory CLEMENT wrote: >> On 13/05/2014 10:06, Gregory CLEMENT wrote: >>> On 13/05/2014 07:53, Kishon Vijay Abraham I wrote: >>>> Hi, >>>> >>>

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-14 Thread Gregory CLEMENT
Hi Kishon, Given the answers I provided to your concerns. I don't see any modification to do to this driver. Do you agree? If not which change is mandatory from your point of view? Thanks, Gregory On 13/05/2014 11:41, Gregory CLEMENT wrote: > On 13/05/2014 10:06, Gregory CLEME

  1   2   >