Re: [GIT PULL] USB-serial fixes for 5.4-rc4

2019-10-18 Thread Greg Kroah-Hartman
On Fri, Oct 18, 2019 at 05:39:53PM +0200, Johan Hovold wrote: > The following changes since commit 4f5cafb5cb8471e54afdc9054d973535614f7675: > > Linux 5.4-rc3 (2019-10-13 16:37:36 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [PATCH 5/5] USB: yurex: fix NULL-derefs on disconnect

2019-10-10 Thread Greg Kroah-Hartman
On Thu, Oct 10, 2019 at 01:05:32PM +0200, Johan Hovold wrote: > On Wed, Oct 09, 2019 at 05:38:48PM +0200, Johan Hovold wrote: > > The driver was using its struct usb_interface pointer as an inverted > > disconnected flag, but was setting it to NULL without making sure all > > code paths that used i

Re: [GIT PULL] USB-serial fixes for 5.4-rc2

2019-10-04 Thread Greg Kroah-Hartman
On Fri, Oct 04, 2019 at 03:52:19PM +0200, Johan Hovold wrote: > The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: > > Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [PATCH] USB: serial: keyspan: fix NULL-derefs on open() and write()

2019-10-04 Thread Greg Kroah-Hartman
span_open+0x10f/0x160 [keyspan] >serial_port_activate+0x5b/0x80 [usbserial] >tty_port_open+0x7b/0xd0 >? check_tty_count+0x43/0xa0 >tty_open+0xf1/0x490 > > Fixes: fdcba53e2d58 ("fix for bugzilla #7544 (keyspan USB-to-serial > converter)") > Cc: stable# 2.6.21 > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman

Re: [PATCH] USB: rio500: Remove Rio 500 kernel driver

2019-10-03 Thread Greg Kroah-Hartman
On Thu, Oct 03, 2019 at 03:18:16PM +0200, Bastien Nocera wrote: > On Mon, 2019-09-23 at 18:18 +0200, Bastien Nocera wrote: > > The Rio500 kernel driver has not been used by Rio500 owners since 2001 > > not long after the rio500 project added support for a user-space USB stack > > through the very f

Re: Reminder: 52 active syzbot reports in usb subsystem

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 10:32:49AM -0700, Eric Biggers wrote: > On Thu, Sep 19, 2019 at 08:40:58AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 18, 2019 at 10:23:42PM -0700, Eric Biggers wrote: > > > [This email was generated by a script. Let me know if you have any

Re: Reminder: 52 active syzbot reports in usb subsystem

2019-09-18 Thread Greg Kroah-Hartman
On Wed, Sep 18, 2019 at 10:23:42PM -0700, Eric Biggers wrote: > [This email was generated by a script. Let me know if you have any > suggestions > to make it better, or if you want it re-generated with the latest status.] > > Of the syzbot reports that have (re-)occurred in the last 7 days, I've

[PATCH 5.2 28/37] usb: chipidea: imx: fix EPROBE_DEFER support during driver probe

2019-09-13 Thread Greg Kroah-Hartman
causing imbalanced clk_*() and pm_*() API calls as part of the error code path. Fixes: 7c8e8909417e ("usb: chipidea: imx: add HSIC support") Signed-off-by: André Draszik Cc: stable CC: Peter Chen CC: Greg Kroah-Hartman CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Ke

Re: [GIT PULL] USB-serial updates for 5.4-rc1

2019-09-04 Thread Greg Kroah-Hartman
On Wed, Sep 04, 2019 at 05:03:56PM +0200, Johan Hovold wrote: > The following changes since commit d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1: > > Linux 5.3-rc5 (2019-08-18 14:31:08 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [GIT PULL] USB changes for v5.4 merge window

2019-09-02 Thread Greg Kroah-Hartman
On Fri, Aug 30, 2019 at 12:14:28PM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for the next merge window. The biggest chunk is > the addition of Cadence USB3 DRD Driver which, finally, compiles on x86, > ARM and ARM64 without any issues. I haven't gotten any failure reports

Re: next take at setting up a dma mask by default for platform devices v2

2019-08-22 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2019 at 08:24:29AM +0200, Christoph Hellwig wrote: > Hi all, > > this is another attempt to make sure the dma_mask pointer is always > initialized for platform devices. Not doing so lead to lots of > boilerplate code, and makes platform devices different from all our > major busse

Re: USB: gadget: f_midi: fixing a possible double-free in f_midi

2019-08-20 Thread Greg Kroah-Hartman
On Tue, Aug 20, 2019 at 10:45:13AM -0700, Mark Salyzyn wrote: > From: "Yavuz, Tuba" > > cherry pick from commit 7fafcfdf6377b18b2a726ea554d6e593ba44349f > ("USB: gadget: f_midi: fixing a possible double-free in f_midi") > Removing 'return err;' from conflict. > > It looks like there is a possibi

Re: [GIT PULL] USB-serial fixes for 5.3-rc5

2019-08-17 Thread Greg Kroah-Hartman
On Sat, Aug 17, 2019 at 10:22:07AM +0200, Johan Hovold wrote: > The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: > > Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: Policy to keep USB ports powered in low-power states

2019-08-16 Thread Greg Kroah-Hartman
on my answers below as you see fit? Also, sorry if I make some beginner > > mistakes here, I'm just getting familiar with the USB subsystem, and thanks > > for > > your patience. > > > > On Wed, Aug 14, 2019 at 3:20 PM Greg Kroah-Hartman > > wrote: &g

Re: [PATCH 0/3] usb: typec: fusb302: Small changes

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 07:26:42PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 15:24, Heikki Krogerus wrote: > > Hi, > > > > This series removes the deprecated fusb302 specific properties, and > > stops using struct tcpc_config in the driver. > > > > thanks, > > > > Heikki Krogerus (3): >

Re: next take at setting up a dma mask by default for platform devices

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 03:25:31PM +0200, Christoph Hellwig wrote: > On Thu, Aug 15, 2019 at 03:23:18PM +0200, Greg Kroah-Hartman wrote: > > I've taken the first 2 patches for 5.3-final. Given that patch 3 needs > > to be fixed, I'll wait for a respin of these before cons

Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 03:38:12PM +0200, Christoph Hellwig wrote: > On Thu, Aug 15, 2019 at 03:03:25PM +0200, Greg Kroah-Hartman wrote: > > > --- a/include/linux/platform_device.h > > > +++ b/include/linux/platform_device.h > > > @@ -24,6 +24,7 @@ struct

Re: next take at setting up a dma mask by default for platform devices

2019-08-15 Thread Greg Kroah-Hartman
On Sun, Aug 11, 2019 at 10:05:14AM +0200, Christoph Hellwig wrote: > Hi all, > > this is another attempt to make sure the dma_mask pointer is always > initialized for platform devices. Not doing so lead to lots of > boilerplate code, and makes platform devices different from all our > major busse

Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device

2019-08-15 Thread Greg Kroah-Hartman
On Sun, Aug 11, 2019 at 10:05:20AM +0200, Christoph Hellwig wrote: > We still treat devices without a DMA mask as defaulting to 32-bits for > both mask, but a few releases ago we've started warning about such > cases, as they require special cases to work around this sloppyness. > Add a dma_mask fi

[PATCH v2] USB: phy: fsl-usb: convert platform driver to use dev_groups

2019-08-15 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- v2: fix build errors caught by 0-day d

Re: [PATCH 0/3] usb: typec: fusb302: Small changes

2019-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 15:24, Heikki Krogerus wrote: > > Hi, > > > > This series removes the deprecated fusb302 specific properties, and > > stops using struct tcpc_config in the driver. > > Series looks good to me: > > Reviewed-by:

Re: [PATCH] usb: typec: fusb302: Call fusb302_debugfs_init earlier

2019-08-15 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2019 at 01:52:16PM +0300, Heikki Krogerus wrote: > Hi Hans, > > On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote: > > tcpm_register_port() will call some of the fusb302 code's callbacks > > wich in turn will call fusb302_log(). So we need to call > > fusb302_debugfs_in

Re: [PATCH v2 01/13] usb: ohci-nxp: enable compile-testing

2019-08-15 Thread Greg Kroah-Hartman
++--- > 2 files changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Greg Kroah-Hartman

Re: [PATCH] usb: host: ohci-pxa27x: Fix and & vs | typo

2019-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2019 at 05:04:14PM +0300, Dan Carpenter wrote: > I was looking at this code again today and I'm still convinced this > patch is correct. Should I resend? Please resend, it's not in my queue anywhere :(

Re: Policy to keep USB ports powered in low-power states

2019-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2019 at 02:12:07PM -0600, Nick Crews wrote: > Thanks for the fast response! > > On Tue, Aug 13, 2019 at 12:02 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Aug 12, 2019 at 06:08:43PM -0600, Nick Crews wrote: > > > Hi Greg! > > > >

Re: Policy to keep USB ports powered in low-power states

2019-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 06:08:43PM -0600, Nick Crews wrote: > Hi Greg! Hi! First off, please fix your email client to not send html so that vger does not reject your messages :) > I am working on a Chrome OS device that supports a policy called "USB Power > Share," which allows users to turn the

Re: [GIT PULL] USB fixes for v5.3-rc

2019-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 01:00:15PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's a pull request for some fixes that I collected from linux-usb > mailing list. > > Let me know if you want anything to be changed. > > Cheers > > The following changes since commit d45331b00ddb179e291766617259

Re: [PATCH v2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-10 Thread Greg Kroah-Hartman
On Sat, Aug 10, 2019 at 08:40:15AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Aug 9, 2019 at 11:37 PM Simon Horman > wrote: > > For consistency with the naming of (most) other documentation files for DT > > bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral > > doc

Re: [balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?

2019-08-09 Thread Greg Kroah-Hartman
On Fri, Aug 09, 2019 at 08:27:52AM +0300, Felipe Balbi wrote: > > Hi, > > kbuild test robot writes: > > > tree: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git > > testing/next > > head: d06a2c3f683a591efce9d02b2b60ef346df5ae02 > > commit: 2a714ea6d90d9d1b510ba4

Re: [PATCH 10/22] usb: omap: avoid mach/*.h headers

2019-08-09 Thread Greg Kroah-Hartman
| 3 ++- > drivers/usb/phy/phy-isp1301-omap.c | 4 ++-- > 6 files changed, 11 insertions(+), 9 deletions(-) Acked-by: Greg Kroah-Hartman

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

2019-08-08 Thread Greg Kroah-Hartman
On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote: > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > > Joe rightly points out that we should be using the "Obsolete"

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

2019-08-08 Thread Greg Kroah-Hartman
On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > Joe rightly points out that we should be using the "Obsolete" status for > these two subsystems. Even with that change, I don't see get_maintainers.pl tell me I shouldn't be sending a patch in for

[PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

2019-08-08 Thread Greg Kroah-Hartman
Joe rightly points out that we should be using the "Obsolete" status for these two subsystems. Also I got the path name wrong for the wusbcore tree. Reported-by: Joe Perches Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete") Signed-off-by: Greg

Re: [PATCH] USB: phy: fsl-usb: convert platform driver to use dev_groups

2019-08-07 Thread Greg Kroah-Hartman
te to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/USB-phy-fsl-usb-convert-platform-driver-to-use-dev_groups/20190807-021855 > base: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/usb.git > usb-test

[PATCH 09/12] USB: lvstest: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/lvstest.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c index e5c03c6d16e9..407fe7570f3b 100644 --- a/drivers/usb/misc/lvstest.c +++ b/drivers/usb

[PATCH 08/12] USB: cytherm: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/cytherm.c | 64 +++--- 1 file changed, 19 insertions(+), 45 deletions(-) diff --git a/drivers/usb/misc/cytherm.c b/drivers/usb/misc/cytherm.c index 8b15ab5e1450..3e3802aaefa3 100644 --- a/drivers/usb/misc

[PATCH 06/12] USB: usbtmc: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
: Guido Kiener Cc: Steve Bayless Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/usbtmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 4942122b2346..7ff831f2fd21 100644 --- a/drivers/usb

[PATCH 07/12] USB: cypress_cy7c63: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/cypress_cy7c63.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c index 9d780b77314b..14faec51d7a5 100644 --- a/drivers/usb

[PATCH 03/12] USB: atm: cxacru: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/atm/cxacru.c | 58 +++- 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index e57a2be8754a..5d41f85a7445 100644 --- a/drivers/usb/atm/cxacru.c

[PATCH 04/12] USB: ueagle-atm: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
: Matthieu CASTET Cc: Stanislaw Gruszka Signed-off-by: Greg Kroah-Hartman --- drivers/usb/atm/ueagle-atm.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 8faa51b1a520..8b0ea8c70d73 100644

[PATCH 05/12] USB: usblp: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/usblp.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c index 407a7a6198a2..7fea4999d352 100644 --- a/drivers/usb/class/usblp.c +++ b

[PATCH 02/12] USB: add support for dev_groups to struct usb_device_driver

2019-08-06 Thread Greg Kroah-Hartman
will make things easier for those drivers. usbip is one example, hubs might be another one. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/driver.c | 1 + include/linux/usb.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core

[PATCH 11/12] USB: usbsevseg: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/usbsevseg.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/usb/misc/usbsevseg.c b/drivers/usb/misc/usbsevseg.c index 1923d5b6d9c9..551074f5b7ad 100644 --- a/drivers/usb/misc/usbsevseg.c +++ b

[PATCH 12/12] USB: usbip: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
: Valentina Manea Cc: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/stub_dev.c | 50 ++-- 1 file changed, 8 insertions(+), 42 deletions(-) diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c index 7931e6cecc70

[PATCH 10/12] USB: trancevibrator: convert to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
: Ding Xiang Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/trancevibrator.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c index ac357ce2d1a6..a3dfc77578ea 100644 --- a/drivers/usb

[PATCH 00/12] USB: dev_groups support for usb drivers

2019-08-06 Thread Greg Kroah-Hartman
usb_device_driver (needed for the usbip driver), and then converts a number of individual USB drivers over to use this api. Greg Kroah-Hartman (12): USB: add support for dev_groups to struct usb_driver USB: add support for dev_groups to struct usb_device_driver USB: atm: cxacru: convert to use

[PATCH 01/12] USB: add support for dev_groups to struct usb_driver

2019-08-06 Thread Greg Kroah-Hartman
Now that the driver core supports dev_groups for individual drivers, expose that pointer to struct usb_driver to make it easier for USB drivers to also use it. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/driver.c | 1 + include/linux/usb.h | 3 +++ 2 files changed, 4 insertions

Re: [PATCH] usb: setup authorized_default using usb_bus_notify

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 01:00:50PM +0200, Thiébaud Weksteen wrote: > Currently, the authorized_default and interface_authorized_default > attributes for HCD are set up after the uevent has been sent to userland. > This creates a race condition where userland may fail to access this > file when proc

Re: [PATCH] USB: Move wusbcore and UWB to staging as it is obsolete

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 03:29:40AM -0700, Joe Perches wrote: > On Tue, 2019-08-06 at 12:15 +0200, Greg Kroah-Hartman wrote: > > The UWB and wusbcore code is long obsolete, so let us just move the code > > out of the real part of the kernel and into the drivers/staging/ > > l

[PATCH] USB: Move wusbcore and UWB to staging as it is obsolete

2019-08-06 Thread Greg Kroah-Hartman
The UWB and wusbcore code is long obsolete, so let us just move the code out of the real part of the kernel and into the drivers/staging/ location with plans to remove it entirely in a few releases. Signed-off-by: Greg Kroah-Hartman --- MAINTAINERS | 15

Re: [PATCH] USB: usbip: convert platform driver to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2019 at 02:22:18PM -0600, shuah wrote: > On 8/5/19 1:36 PM, Greg Kroah-Hartman wrote: > > Platform drivers now have the option to have the platform core create > > and remove any needed sysfs attribute files. So take advantage of that > > and do not registe

[PATCH] USB: phy: fsl-usb: convert platform driver to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/phy/phy-fsl-usb.c | 12 +

[PATCH] USB: phy: twl6030: convert platform driver to use dev_groups

2019-08-06 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/phy/phy-twl6030-

[PATCH] USB: musb: convert platform driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Bin Liu Signed-off-by: Greg Kroah-Hartman --- drivers/usb/musb/musb_c

[PATCH] USB: chipidea: convert platform driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/chipidea/core.c | 13 ++

[PATCH] USB: usbip: convert platform driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Valentina Manea Cc: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/us

[PATCH] USB: phy: tahvo: convert platform driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/phy/phy-ta

[PATCH] USB: phy: mv-usb: convert platform driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" any sysfs files. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/

[PATCH] USB: typec: ucsi_ccg: convert i2c driver to use dev_groups

2019-08-05 Thread Greg Kroah-Hartman
Gupta Cc: Wolfram Sang Cc: Wei Yongjun Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/ucsi/ucsi_ccg.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index f7a79a23ebed..e283a42e4

Re: Race condition when accessing authorized_default for a root hub

2019-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2019 at 12:29:27PM +0200, Thiébaud Weksteen wrote: > Hi, > > I believe there is a race condition for userland in hcd.c where the > kernel sends a uevent before the underlying sysfs is fully populated: > > (drivers/usb/core/hcd.c) > /* starting here, usbcore will pay atte

Re: [RFC PATCH] usb: typec: tcpm: Ignore unsupported/unknown alternate mode requests

2019-08-02 Thread Greg Kroah-Hartman
On Wed, Jul 24, 2019 at 09:30:37PM -0700, Guenter Roeck wrote: > TCPM may receive PD messages associated with unknown or unsupported > alternate modes. If that happens, calls to typec_match_altmode() > will return NULL. The tcpm code does not currently take this into > account. This results in cras

Re: [RFC PATCH] usb: typec: tcpm: Ignore unsupported/unknown alternate mode requests

2019-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 12:55:55PM +0300, Heikki Krogerus wrote: > On Tue, Jul 30, 2019 at 06:28:52AM -0700, Guenter Roeck wrote: > > On 7/30/19 5:07 AM, Heikki Krogerus wrote: > > > On Mon, Jul 29, 2019 at 10:31:04AM -0700, Guenter Roeck wrote: > > > > On Mon, Jul 29, 2019 at 05:04:57PM +0300, Hei

Re: [PATCH 09/14] serial: lpc32xx: allow compile testing

2019-07-31 Thread Greg Kroah-Hartman
d, 38 insertions(+), 31 deletions(-) Acked-by: Greg Kroah-Hartman

Re: [PATCH 04/14] serial: lpc32xx_hs: allow compile-testing

2019-07-31 Thread Greg Kroah-Hartman
: Arnd Bergmann > --- > drivers/tty/serial/Kconfig | 3 ++- > drivers/tty/serial/lpc32xx_hs.c | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) Acked-by: Greg Kroah-Hartman

Re: [PATCH 02/14] usb: udc: lpc32xx: allow compile-testing

2019-07-31 Thread Greg Kroah-Hartman
: Arnd Bergmann > --- > drivers/usb/gadget/udc/Kconfig | 3 ++- > drivers/usb/gadget/udc/lpc32xx_udc.c | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) Acked-by: Greg Kroah-Hartman

Re: [PATCH 01/14] usb: ohci-nxp: enable compile-testing

2019-07-31 Thread Greg Kroah-Hartman
++--- > 2 files changed, 20 insertions(+), 8 deletions(-) Acked-by: Greg Kroah-Hartman

Re: [PATCH v2 2/2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file

2019-07-25 Thread Greg Kroah-Hartman
On Thu, Jul 11, 2019 at 10:03:03AM +0200, Simon Horman wrote: > On Wed, Jul 03, 2019 at 02:28:51PM +0200, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Wed, Jul 3, 2019 at 10:35 AM Simon Horman > > wrote: > > > For consistency with the naming of (most) other documentation files for DT > > >

[PATCH 5.1 308/371] signal/usb: Replace kill_pid_info_as_cred with kill_pid_usb_asyncio

2019-07-24 Thread Greg Kroah-Hartman
uot;); return 1; } memset(&ds, 0, sizeof(ds)); ds.signr = SIGUSR2; ds.context = &ds; rc = ioctl(fd, USBDEVFS_DISCSIGNAL, &ds); if (rc == -1) { perror("Error in DISCSIGNAL ioctl"); ret

[PATCH 5.2 340/413] signal/usb: Replace kill_pid_info_as_cred with kill_pid_usb_asyncio

2019-07-24 Thread Greg Kroah-Hartman
uot;); return 1; } memset(&ds, 0, sizeof(ds)); ds.signr = SIGUSR2; ds.context = &ds; rc = ioctl(fd, USBDEVFS_DISCSIGNAL, &ds); if (rc == -1) { perror("Error in DISCSIGNAL ioctl"); ret

Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-07-03 Thread Greg Kroah-Hartman
On Fri, Jun 28, 2019 at 12:10:41PM +0200, Nikolaus Voss wrote: > On Fri, 28 Jun 2019, Heikki Krogerus wrote: > > On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: > > > Portinfo bit field is 3 bits wide, not 2 bits. This led to > > > a wrong driver configuration for some tps6598x confi

Re: [GIT PULL part2] USB: changes for v5.3 merge window

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 02:41:36PM +0300, Felipe Balbi wrote: > > Hi Greg, > > Hopefully there's still time to merge these other patches. > > They came a little late but should be safe to merge. I've tested what I > could with platforms I had. > > The biggest thing here is the new Cadence USB D

Re: [GIT PULL] USB-serial updates for 5.3-rc1

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 08:34:51AM +0200, Johan Hovold wrote: > The following changes since commit 9e0babf2c06c73cda2c0cd37a1653d823adb40ec: > > Linux 5.2-rc5 (2019-06-16 08:49:45 -1000) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-07-02 Thread Greg Kroah-Hartman
On Tue, Jul 02, 2019 at 02:46:42PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > > > This doesn't make much sense though. e387ef5c47dd should apply this > > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > > Logitech webca

[PATCH 4.19 30/72] usb: dwc3: gadget: remove wait_end_transfer

2019-07-02 Thread Greg Kroah-Hartman
commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1 upstream Now that we have a list of cancelled requests, we can skip over TRBs when END_TRANSFER command completes. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.19.y Signed-off-by: Fe

[PATCH 4.19 31/72] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup

2019-07-02 Thread Greg Kroah-Hartman
commit bd6742249b9ca918565e4e3abaa06665e587f4b5 upstream OUT endpoint requests may somtimes have this flag set when preparing to be submitted to HW indicating that there is an additional TRB chained to the request for alignment purposes. If that request is removed before the controller can execute

Re: [GIT PULL] USB: changes for v5.3 merge window

2019-07-01 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 10:55:47AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v5.3 merge window. Relevant patches have been > tested on platforms I have available. > > Let me know if you want anything to be changed > > cheers > > The following changes since commit a

Re: [usb:usb-testing 46/46] drivers/usb//misc/adutux.c:375:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}'

2019-06-20 Thread Greg Kroah-Hartman
On Thu, Jun 20, 2019 at 08:01:30AM -0700, dmg wrote: > > kbuild test robot writes: > > [...] > > > > All warnings (new ones prefixed by >>): > > > >In file included from include/linux/printk.h:332:0, > > from include/linux/kernel.h:15, > > from drivers

Re: [GIT PULL] USB: fixes for v5.2-rc5

2019-06-20 Thread Greg Kroah-Hartman
On Thu, Jun 20, 2019 at 12:13:01PM +0300, Felipe Balbi wrote: > > Hi Greg, > > Just one pending fix this time. > > Let me know if you need anything to be changed > > cheers > > > The following changes since commit 9e0babf2c06c73cda2c0cd37a1653d823adb40ec: > > Linux 5.2-rc5 (2019-06-16 08:4

Re: [GIT PULL] USB-serial fixes for 5.2-rc5

2019-06-10 Thread Greg Kroah-Hartman
On Mon, Jun 10, 2019 at 03:48:29PM +0200, Johan Hovold wrote: > The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: > > Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [GIT PULL] USB: fixes for v5.2-rc4

2019-06-08 Thread Greg Kroah-Hartman
On Fri, Jun 07, 2019 at 09:33:29AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my first set of fixes for this -rc cycle. Looks like most of what > I have in my inbox these days are new features. Very little fixes. I > guess folks are writing perfect code now :-p > > Let me know if you wan

Re: [PATCH usbutils] usb-devices.1: don't mention bash

2019-06-06 Thread Greg Kroah-Hartman
On Tue, May 28, 2019 at 02:37:04PM +0300, Baruch Siach wrote: > Since commit 508d1acf42e ("usb-devices: use /bin/sh hashbang") > usb-devices does not require bash. > > Signed-off-by: Baruch Siach > --- > usb-devices.1.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/u

Re: [PATCH v2] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2019 at 01:44:26PM +0200, Marc Gonzalez wrote: > On 05/06/2019 11:28, Greg Kroah-Hartman wrote: > > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initializ

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-06-05 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 11:14:37AM +0200, Oliver Neukum wrote: > Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta: > > On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote: > > > Are you sure only the C270 is affected? > > > > > > Regards > > > Oliver > > > > Hello

Re: Extending USB_CONNECTINFO ioctl

2019-06-04 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 09:14:51AM -0700, Dmitry Torokhov wrote: > Hi Alan, > > On Tue, Jun 04, 2019 at 10:17:25AM -0400, Alan Stern wrote: > > On Mon, 3 Jun 2019, Dmitry Torokhov wrote: > > > > > Hi Alan, Greg, > > > > > > When running software in a jailed environment where sysfs or udev is not

Re: [PATCH v4] usb: create usb_debug_root for gadget only

2019-06-04 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 04:59:14PM +0800, Chunfeng Yun wrote: > On Tue, 2019-06-04 at 09:37 +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 04, 2019 at 03:34:07PM +0800, Chunfeng Yun wrote: > > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, > >

Re: Extending USB_CONNECTINFO ioctl

2019-06-03 Thread Greg Kroah-Hartman
On Mon, Jun 03, 2019 at 05:24:10PM -0700, Dmitry Torokhov wrote: > Hi Alan, Greg, > > When running software in a jailed environment where sysfs or udev is not > readily available and one can only have an FD to usbdevfs device passed > into the jail, there is a desire to allow libusb working. Alan

[PATCH 2/2] USB: atm: ueagle-atm.c: remove redundant license text

2019-05-24 Thread Greg Kroah-Hartman
incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Thomas Gleixner Cc: Matthieu CASTET Cc: Stanislaw Gruszka Cc: Damien Bergamini Cc: Duncan Sands Signed-off-by: Greg Kroah-Hartman --- drivers/usb/atm/ue

[PATCH 1/2] USB: atm: ueagle-atm.c: fix SPDX tag to be BSD2

2019-05-24 Thread Greg Kroah-Hartman
n that the text in the header says "or later" and all of the other USB atm drivers are licensed in that way, I am going to leave the string as-is for that mark. Reported-by: Thomas Gleixner Cc: Matthieu CASTET Cc: Stanislaw Gruszka Cc: Damien Bergamini Cc: Duncan Sands Signed-off-by

Re: [usb:usb-linus] BUILD REGRESSION c1a145a3ed9a40f3b6145feb97789e8eb49c5566

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 01:58:01AM +0800, kbuild test robot wrote: > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-linus > branch HEAD: c1a145a3ed9a40f3b6145feb97789e8eb49c5566 xhci: Use %zu for > printing size_t type > > Regressions in current branch: > >

Re: [usb:usb-linus 12/16] drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}'

2019-05-22 Thread Greg Kroah-Hartman
On Wed, May 22, 2019 at 08:54:56PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-linus > head: f7fac17ca925faa03fc5eb854c081a24075f8bad > commit: 597c56e372dab2c7f79b8d700aad3a5deebf9d1b [12/16] xhci: update bounce > buffer with c

Re: [usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 09:49:36AM -0400, Alan Stern wrote: > On Tue, 21 May 2019, Greg Kroah-Hartman wrote: > > > On Tue, May 21, 2019 at 04:48:47PM +0800, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >

Re: [usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 04:48:47PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-linus > head: 53c7b63f797c96a30c21dd3b781fafaae096a12b > commit: 31e0456de5be379b10fea0fa94a681057114a96e [3/10] media: usb: siano: > Fix general pro

Re: TODO advice for octeon-usb?

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 02:05:32AM +0300, Aaro Koskinen wrote: > Hi, > > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was

Re: [PATCH 1/5] USB: serial: fix unthrottle races

2019-05-13 Thread Greg Kroah-Hartman
On Mon, May 13, 2019 at 01:46:01PM +0200, Johan Hovold wrote: > On Mon, May 13, 2019 at 12:56:06PM +0200, Greg Kroah-Hartman wrote: > > On Mon, May 13, 2019 at 12:43:39PM +0200, Johan Hovold wrote: > > > On Thu, Apr 25, 2019 at 06:05:36PM +0200, Johan Hovold wrote: > > &

Re: [PATCH 1/5] USB: serial: fix unthrottle races

2019-05-13 Thread Greg Kroah-Hartman
On Mon, May 13, 2019 at 12:43:39PM +0200, Johan Hovold wrote: > On Thu, Apr 25, 2019 at 06:05:36PM +0200, Johan Hovold wrote: > > Fix two long-standing bugs which could potentially lead to memory > > corruption or leave the port throttled until it is reopened (on weakly > > ordered systems), respec

Re: [GIT PULL] USB changes for v5.2 merge window

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 12:15:18PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for the next merge window. A bit later than > usuall this time around, due to internal high-priority tasks. Sorry > about that. > > Let me know if you need anything to be changed. > > cheers >

Re: [GIT PULL] USB-serial updates for 5.2-rc1

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 05:36:50PM +0200, Johan Hovold wrote: > The following changes since commit 79a3aaa7b82e3106be97842dedfd8429248896e6: > > Linux 5.1-rc3 (2019-03-31 14:39:29 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

[PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-02 Thread Greg Kroah-Hartman
nindenting one level of the logic, and properly label /* Fall through */ to make gcc happy. Reported-by: Gustavo A. R. Silva Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c index 4ca31c0e4174..48a439298a68 100644 --- a/drivers/usb/

Re: USB fuzzing with syzbot

2019-04-25 Thread Greg Kroah-Hartman
On Thu, Apr 25, 2019 at 02:44:11PM +0200, Andrey Konovalov wrote: > On Wed, Apr 24, 2019 at 6:05 PM Andrey Konovalov > wrote: > > > > On Fri, Apr 19, 2019 at 10:35 AM Greg Kroah-Hartman > > wrote: > > > > > > > 2. Is there an easy way to figure ou

Re: [PATCH v4 0/7] usb: typec: ucsi: Remaining changes for v5.2

2019-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 23, 2019 at 05:21:44PM +0300, Heikki Krogerus wrote: > Hi Greg, > > Ajay noticed that I was not considering earlier releases of the UCSI > specification with a specific UCSI command, GET_CURRENT_CAM, in v3. > The definition for the command was changed in UCSI specification v1.1. > The

  1   2   3   4   5   6   7   8   9   10   >