Hi Robert,
On Mon, Oct 26, 2015 at 10:23 PM, Robert Baldyga
wrote:
> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>> This patch fixes a memory leak that occurs when an endpoint fails to enqueue
>> the request. If that happens the complete function will never be called, thus
>> never freeing t
Hi Robert,
On Mon, Oct 26, 2015 at 10:30 PM, Robert Baldyga
wrote:
> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>> This avoids duplication of USB requests for OUT endpoint and
>> re-enabling endpoints.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c |
Hi Robert,
On Mon, Oct 26, 2015 at 10:13 PM, Robert Baldyga
wrote:
> Hi Felipe,
>
> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>> This makes sure f_midi doesn't try to enqueue data when the IN endpoint is
>> disabled, ie, USB cable is disconnected.
>>
>> Signed-off-by: Felipe F. Tonello
>>
Hi Clemens
On Mon, Oct 12, 2015 at 11:16 AM, Clemens Ladisch wrote:
> Felipe Tonello wrote:
>> On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote:
>>> Felipe Tonello wrote:
>>>> } else if (ep == midi->in_ep) {
>>>> -
Hi Balbi,
On Sun, Oct 11, 2015 at 8:08 PM, Clemens Ladisch wrote:
> Felipe Balbi wrote:
>> Clemens Ladisch writes:
>>> Felipe Tonello wrote:
>>>> req->actual == req->length means that there is no data left to enqueue,
>>>
>>> This condi
Hi Clemens
On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote:
> Felipe Tonello wrote:
>> req->actual == req->length means that there is no data left to enqueue,
>
> This condition is not checked in the patch.
>
>> so free the request.
>>
On Tue, Sep 29, 2015 at 1:01 PM, Felipe F. Tonello
wrote:
> Here is the third version of this patch set. It includes memory leakage bug
> fix, improvements and code cleanups.
>
> Felipe F. Tonello (4):
> usb: gadget: f_midi: free usb request when done
> usb: gadget: f_midi: free request when
On Fri, Sep 25, 2015 at 10:02 AM, Peter Chen wrote:
> On Fri, Sep 25, 2015 at 09:27:49AM +0100, Felipe Tonello wrote:
>> On Thu, Sep 24, 2015 at 2:20 AM, Peter Chen wrote:
>> > On Wed, Sep 23, 2015 at 12:40:46PM +0100, Felipe Tonello wrote:
>> >> Hi Peter,
>>
On Thu, Sep 24, 2015 at 9:51 PM, Alan Stern wrote:
> On Thu, 24 Sep 2015, Jiri Kosina wrote:
>
>> On Wed, 23 Sep 2015, Alan Stern wrote:
>>
>> > Your mistake was thinking that the driver for your keyboard is usbkbd.
>> > It isn't. It's usbhid, as you can see in the "lsusb -t" output above.
>>
>>
Hi Peter,
On Thu, Sep 24, 2015 at 2:38 AM, Peter Chen wrote:
> On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote:
>> req->actual == req->length means that there is no data left to enqueue,
>> so free the request.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>>
>> Changes in v2:
On Thu, Sep 24, 2015 at 2:20 AM, Peter Chen wrote:
> On Wed, Sep 23, 2015 at 12:40:46PM +0100, Felipe Tonello wrote:
>> Hi Peter,
>>
>> On Wed, Sep 23, 2015 at 8:09 AM, Peter Chen wrote:
>> > On Tue, Sep 22, 2015 at 07:59:10PM +0100, Felipe F. Tonello wrote:
>
Hi Peter,
On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen wrote:
> On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote:
>> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile
>> properly.
>>
>
> Would you post the warning or error messages?
>
> I just tried at v4.3-rc1 (
Hi Alan,
On Wed, Sep 23, 2015 at 3:30 PM, Alan Stern wrote:
> On Wed, 23 Sep 2015, Felipe Tonello wrote:
>
>> Hi Peter,
>>
>> On Wed, Sep 23, 2015 at 4:10 AM, Peter Chen wrote:
>> > On Tue, Sep 22, 2015 at 07:59:09PM +0100, Felipe F. Tonello wrote:
>> &
On Wed, Sep 23, 2015 at 12:39 PM, Felipe Tonello wrote:
> Hi Peter,
>
> On Wed, Sep 23, 2015 at 4:09 AM, Peter Chen wrote:
>> On Tue, Sep 22, 2015 at 07:51:34PM +0100, Felipe Tonello wrote:
>>> Hi all,
>>>
>>> On Tue, Sep 22, 2015 at 10:13 AM,
Hi Peter,
On Wed, Sep 23, 2015 at 4:10 AM, Peter Chen wrote:
> On Tue, Sep 22, 2015 at 07:59:09PM +0100, Felipe F. Tonello wrote:
>> req->actual == req->length means that there is no data left to enqueue,
>> so free the request.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadge
Hi Peter,
On Wed, Sep 23, 2015 at 8:09 AM, Peter Chen wrote:
> On Tue, Sep 22, 2015 at 07:59:10PM +0100, Felipe F. Tonello wrote:
>> This fix a memory leak that will occur in this case.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c | 4 +++-
>> 1 file cha
Hi Peter,
On Wed, Sep 23, 2015 at 4:09 AM, Peter Chen wrote:
> On Tue, Sep 22, 2015 at 07:51:34PM +0100, Felipe Tonello wrote:
>> Hi all,
>>
>> On Tue, Sep 22, 2015 at 10:13 AM, Felipe Tonello
>> wrote:
>> > Hi Peter,
>> >
>> > On Tue, Sep
Hi all,
On Tue, Sep 22, 2015 at 10:13 AM, Felipe Tonello wrote:
> Hi Peter,
>
> On Tue, Sep 22, 2015 at 8:03 AM, Peter Chen wrote:
>> On Tue, Sep 22, 2015 at 09:07:23AM +0100, Felipe Tonello wrote:
>>> On Tue, Sep 22, 2015 at 12:41 AM, Peter Chen
>>> wrote:
&g
Hi Peter,
On Tue, Sep 22, 2015 at 8:03 AM, Peter Chen wrote:
> On Tue, Sep 22, 2015 at 09:07:23AM +0100, Felipe Tonello wrote:
>> On Tue, Sep 22, 2015 at 12:41 AM, Peter Chen
>> wrote:
>> > On Mon, Sep 21, 2015 at 03:25:28PM +0100, Felipe Tonello wrote:
>> >
On Tue, Sep 22, 2015 at 12:41 AM, Peter Chen wrote:
> On Mon, Sep 21, 2015 at 03:25:28PM +0100, Felipe Tonello wrote:
>> Hi all,
>>
>> I actually found the problem but can't really understand. The ci_irq()
>> handler (from core.c) is not been called after a ep
Hi all,
I actually found the problem but can't really understand. The ci_irq()
handler (from core.c) is not been called after a ep_queue() from
f_midi_transmit().
Is there any reason for that?
I used mass_storage gadget, made file transfers and others, and the
interrupt handler was been called a
gt; Changes for v2:
> - Update code style.
>
> Changes for v3:
> - Use ip_ep instead of out_ep. Fixed typo in commit message.
I forgot to add v3 to the patch subject, so it queued here instead. Do
you want me to re-send as v3?
Felipe Tonello
--
To unsubscribe from this list: send
Hi Peter,
On Mon, Sep 21, 2015 at 8:49 AM, Peter Chen wrote:
> On Mon, Sep 21, 2015 at 09:16:05AM +0100, Felipe Tonello wrote:
>> Hi Chen,
>>
>> On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen wrote:
>> > On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.co
Hi Peter,
On Mon, Sep 21, 2015 at 7:29 AM, Peter Chen wrote:
> On Fri, Sep 18, 2015 at 06:12:40PM +0100, e...@felipetonello.com wrote:
>> From: "Felipe F. Tonello"
>>
>> _ep_queue() didn't check for errors when using add_td_to_list()
>> which can fail if dma_pool_alloc fails, thus causing a kern
Hi Chen,
On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen wrote:
> On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote:
>> From: "Felipe F. Tonello"
>>
>> f_midi is not checking weather the is an error on usb_ep_queue
>
> %s/weather/whether
> %s/the/there
I fixed it on v3. Did you
On Fri, Sep 18, 2015 at 6:30 PM, wrote:
> From: "Felipe F. Tonello"
>
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello
> ---
>
> Changes for v2:
> - Update code style.
>
> drive
Hi Felipe,
On Fri, Sep 18, 2015 at 6:17 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Sep 18, 2015 at 06:12:40PM +0100, e...@felipetonello.com wrote:
>> From: "Felipe F. Tonello"
>>
>> _ep_queue() didn't check for errors when using add_td_to_list()
>> which can fail if dma_pool_alloc fails, thus cau
Balbi,
On Fri, Sep 18, 2015 at 5:02 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Sep 18, 2015 at 04:53:09PM +0100, Felipe Tonello wrote:
>> Hi Balbi,
>>
>> On Fri, Sep 18, 2015 at 3:25 PM, Felipe Balbi wrote:
>> > On Fri, Sep 18, 2015 at 11:03:26AM +0100, Fe
Hi Balbi,
On Fri, Sep 18, 2015 at 3:25 PM, Felipe Balbi wrote:
> On Fri, Sep 18, 2015 at 11:03:26AM +0100, Felipe Tonello wrote:
>> After some debugging, here is where I am:
>>
>> The crash trace is like this:
>>
>> (f_midi.c)
>> -> ALSA calls f_midi_in_
After some debugging, here is where I am:
The crash trace is like this:
(f_midi.c)
-> ALSA calls f_midi_in_trigger()
->tasklet_hi_schedule(&midi->tasklet)
-> f_midi_transmit(midi, NULL) the NULL here causes the f_midi to
request a usb_request allocation, also it sets req->complete (which is
Hi Peter,
On Fri, Sep 18, 2015 at 6:39 AM, Peter Chen wrote:
> On Wed, Sep 16, 2015 at 02:48:50PM +0530, maitysancha...@gmail.com wrote:
>> On 15-09-16 15:54:21, Peter Chen wrote:
>> > On Wed, Sep 16, 2015 at 02:18:49PM +0530, maitysancha...@gmail.com wrote:
>> > > Hello Peter,
>> > >
>> > > >
>>
Hi Estevam,
On Tue, Sep 15, 2015 at 5:09 AM, Fabio Estevam wrote:
> On Thu, Sep 10, 2015 at 6:47 AM, Felipe Tonello
> wrote:
>> Hi,
>>
>> I have the following setup:
>>
>> DSP (read sensors and read/send MIDI) <- UART -> SOC (imx6) <- USB
>>
Hi,
I have the following setup:
DSP (read sensors and read/send MIDI) <- UART -> SOC (imx6) <- USB
MIDI GADGET -> HOST
When the throughput from the DSP is high, thus causing the throughput
on the USB to be high as well, I get a Kernel Panic saying to increase
the coherent_pool. I've used some cr
33 matches
Mail list logo
