Hi Karmo,
On 02/01/17 15:57, Greg KH wrote:
> On Mon, Jan 02, 2017 at 03:38:40PM +0200, Karmo Rosental wrote:
>> I have tried kernels 4.8.0 and 4.9.0 from Ubuntu repositories.
>> Probably I don't have latest BIOS.
>
> Try updating it and see if that resolves this issue.
>
It is very unlikely to
Hi Takashi
On 18/10/16 13:07, Takashi Iwai wrote:
> On Wed, 12 Oct 2016 18:15:04 +0200,
> Bastien Nocera wrote:
>>
>> On Wed, 2016-10-12 at 18:06 +0200, Clemens Ladisch wrote:
>>> Bastien Nocera wrote:
On Wed, 2016-10-12 at 14:43 +0200, Clemens Ladisch wrote:
> Bastien Nocera wrote:
>
Hi Bastien,
On 12/10/16 12:58, Bastien Nocera wrote:
> On Wed, 2016-10-12 at 19:36 +0900, Takashi Sakamoto wrote:
>> On Oct 12 2016 14:10, Bastien Nocera wrote:
>>> My questions are:
>>> - does the USB audio driver support jack sensing?
>>> - is this something standard that's just not implemented
Hi Bastien,
On 12/10/16 07:10, Bastien Nocera wrote:
> Hey,
>
> I recently bought some cheap USB soundcards for a computer that doesn't
> have any audio output other than through the HDMI output, and the
> screen I'm attaching doesn't have an audio output.
>
> So I'm looking to plug in 2 of thos
On 29/08/16 08:55, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> Felipe Ferreri Tonello writes:
>>>>> "Felipe F. Tonello" writes:
>>>>>> The default_length parameter of alloc_ep_req was not really necessar
Hi Balbi,
On 23/08/16 12:03, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> John Youn writes:
>>>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>>>> Use gadget's framework allocation function instead of directly cal
Hi Balbi,
On 23/08/16 12:01, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> "Felipe F. Tonello" writes:
>>>> The default_length parameter of alloc_ep_req was not really necessary
>>>> and gadget drivers would almost
Hi,
On 22/08/16 08:45, Felipe Balbi wrote:
>
> Hi,
>
> John Youn writes:
>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>> Use gadget's framework allocation function instead of directly calling
>>> usb_ep_alloc_request().
>>>
>>> Signed-off-by: Felipe F. Tonello
>>> ---
>>> drivers/usb/gad
Hi Blabi,
On 18/08/16 08:12, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> The default_length parameter of alloc_ep_req was not really necessary
>> and gadget drivers would almost always create an inline function to pass
>> the same value to len and default_len.
>>
>> So this p
Hi Balbi,
On 10/08/16 12:24, Felipe Balbi wrote:
>
> Hi,
>
> Baolin Wang writes:
>> On 26 July 2016 at 07:15, Felipe F. Tonello wrote:
>>> USB spec specifies wMaxPacketSize to be little endian (as other properties),
>>> so when using this variable in the driver we should convert to the current
Hi Balbi,
On 10/08/16 12:25, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> 512 is the value used by wMaxPacketSize, as specified by the USB Spec. This
>
> this is only true for HS :-) FS and SS use different sizes. Do you want
> to use 1024 (SS maxp) by default instead? Then a
Hi,
On 05-08-2016 20:15, kbuild test robot wrote:
> Hi Felipe,
>
> [auto build test ERROR on balbi-usb/next]
> [also build test ERROR on v4.7 next-20160805]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0
Hi Michal,
On 27/07/16 20:59, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> Using usb_ep_align() makes sure that the buffer size for OUT endpoints is
>> always aligned with wMaxPacketSize (512 usually). This makes sure
>> that no buffer has the wrong size, which can c
Hi Michal,
On 27/07/16 21:02, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> This parameter was not really necessary and gadget drivers would almost
>> always
>
> I personally like when commit messages can be read without subject, so
> perhaps:
>
> The default
Hi Michal,
On 27/07/16 20:37, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> USB spec specifies wMaxPacketSize to be little endian (as other properties),
>> so when using this variable in the driver we should convert to the current
>> CPU endianness if necessary.
>>
>>
Forgot to mention, but changes from v1 is a typo alloc_ep_req().
On 26/07/16 20:18, Felipe F. Tonello wrote:
> This parameter was not really necessary and gadget drivers would almost always
> create an inline function to pass the same value to len and default_len.
>
> So this patch also removes d
Hi Baolin,
Sorry for not replying for previous emails because for some reason these
emails were archived. :(
On 12/07/16 10:01, Baolin Wang wrote:
> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size
> attribute, which means it need to align the request buffer's size to a
Hi Michal,
On 04/04/16 13:11, Michal Nazarewicz wrote:
> On Sat, Apr 02 2016, Dan Carpenter wrote:
>> We added some new locking here, but missed an error path where we need
>> to unlock.
>>
>> Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit
>> function')
>> Signed-off-by: Da
Hi Balbi,
On 04/04/16 11:46, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>> On 30/03/16 13:33, Michal Nazarewicz wrote:
>>>>> On Wed, Mar 30 2016, Felipe Balbi wrote:
>>>>>> a USB packet, right. that's corre
Hi Dan,
On 02/04/16 05:51, Dan Carpenter wrote:
> We added some new locking here, but missed an error path where we need
> to unlock.
>
> Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit
> function')
> Signed-off-by: Dan Carpenter
Acked-by: Felipe F. Tonello
>
> diff --
Hi Balbi,
On 01/04/16 11:22, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> Hi Balbi and Mina,
>>
>> On 30/03/16 13:33, Michal Nazarewicz wrote:
>>> On Wed, Mar 30 2016, Felipe Balbi wrote:
>>>> a USB packet, right. that&#x
Hi Balbi and Mina,
On 30/03/16 13:33, Michal Nazarewicz wrote:
> On Wed, Mar 30 2016, Felipe Balbi wrote:
>> a USB packet, right. that's correct. But a struct usb_request can
>> point to whatever size buffer it wants and UDC is required to split
>> that into wMaxPacketSize transfers.
>
> D’oh. O
Hi Michal,
On 11/03/16 23:07, Michal Nazarewicz wrote:
> On Wed, Mar 09 2016, Felipe F. Tonello wrote:
>> buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed
>> devices.
>>
>> That caused the OUT endpoint to freeze if the host send any data packet of
>> length greater than 2
Hi Steve,
On 09/03/16 22:43, Steve Calfee wrote:
> On Wed, Mar 9, 2016 at 11:39 AM, Felipe F. Tonello
> wrote:
>> buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed
>> devices.
>>
>> That caused the OUT endpoint to freeze if the host send any data packet of
>> length grea
Hi,
On 09/03/16 17:12, Greg KH wrote:
> On Wed, Mar 09, 2016 at 05:47:00PM +0100, Peter Maciejko wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=114111
>>
>> Bug ID: 114111
>> Summary: Reboot after shutdown, when USB 3.0 controller is enabled
>
> Please send us the full details so we don't
Hi,
On 09/03/16 16:17, Felipe F. Tonello wrote:
> Since f_midi_transmit is called by both ALSA and USB sub-systems, it can
> potentially cause a race condition between both calls because f_midi_transmit
> is not reentrant nor thread-safe. This is due to an implementation detail that
> the transmit
Hi Balbi,
On 09/03/16 10:33, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On 09/03/16 07:20, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> "Felipe F. Tonello" wri
Hi Balbi,
On 09/03/16 07:04, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> [ text/plain ]
>> This refactor results in a cleaner state machine code and promotes
>> consistency, readability, and maintanability of this driver.
>>
>> Signed-off-by: Felipe F. Tonello
>
> while wor
Hi Balbi,
On 09/03/16 07:20, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> [ text/plain ]
>> Since f_midi_transmit is called by both ALSA and USB sub-systems, it can
>> potentially cause a race condition between both calls because f_midi_transmit
>> is not reentrant nor thread-
Hi Balbi,
On 08/03/16 14:01, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>>>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>>>>>>> can
>>>>>>>> potentially cause
Hi,
On 08/03/16 14:20, Felipe Balbi wrote:
>
> Hi,
>
> Krzysztof Opasiak writes:
>> [ text/plain ]
>>
>>
>> On 03/08/2016 02:54 PM, Felipe Ferreri Tonello wrote:
>> (...)
>>
>>>>
>>>>> sort of preset library of config
Hi Balbi,
On 08/03/16 07:43, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>>>> @@ -63,6 +63,14 @@ static unsigned int out_ports = 1;
>>>>>>>> module_param(out_ports, uint, S_IRUGO);
>&g
Hi Balbi,
On 08/03/16 07:37, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>>>>> can
>>>>>> potentially cause a race conditi
Hi Balbi, how are you?
On 07/03/16 10:59, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>> "Felipe F. Tonello" writes:
>>>>>> [ text/plain ]
>>>>>> This gadget uses a bmAttributes and MaxPower that re
Hi Balbi,
On 07/03/16 07:34, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>>
Hi Balbi,
On 07/03/16 07:35, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Michal,
>>
>> On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz
>> wrote:
>>>>> On Wed, Ma
Hi Balbi,
On 07/03/16 07:32, Felipe Balbi wrote:
>
> Hi,
>
> (please break your lines at 80-characters, have a look at
> Documentation/email-clients.txt if needed)
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On Mar
Hi Balbi,
On 07/03/16 07:36, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On March 4, 2016 7:13:05 AM GMT+00:00, Felipe Balbi wrote:
>>> "Felipe F. Tonello" writes:
>>>&g
t;>> *
>>>> - * Licensed under the GPL-2 or later.
>>>> + * Licensed under the GPLv2.
>
>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
> wrote:
>>> Any particular reason to do that?
>
>On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote:
>>
mtronics Pty Ltd.
>> >>> * Ben Williamson
>> >>> *
>> >>> - * Licensed under the GPL-2 or later.
>> >>> + * Licensed under the GPLv2.
>>
>> > On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
> wrote:
>> >
Hi Michal,
On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
wrote:
>On Wed, Mar 02 2016, Felipe F. Tonello wrote:
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c | 77
>+++-
>> 1 file changed, 40 insertions(+), 37 dele
Hi Balbi,
On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>can
>> potentially cause a race condition between both calls. This is bad
>because the
>> way f_mi
Hi Balbi,
On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> This gadget uses a bmAttributes and MaxPower that requires the USB
>bus to be
>> powered from the host, which is not correct because this
>configuration is device
>> s
Hi Balbi,
On March 4, 2016 7:11:30 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Patches are pretty much self-described.
>>
>> Patch 1 is revised from comments.
>
>you really need to describe what you changed. This also should have v2
>on subject l
Hi Balbi,
On March 4, 2016 7:13:05 AM GMT+00:00, Felipe Balbi wrote:
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Signed-off-by: Felipe F. Tonello
>
>no commit log == no commit
Got it.
>
>> ---
>> drivers/usb/gadget/function/f_midi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> d
Hi Clemens,
On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch
wrote:
>Felipe Ferreri Tonello wrote:
>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>> But in what way was the old state machine not "proper"?
>>
>> Because it didn't reflect al
Hi Clemens,
On 03/03/16 11:38, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 02/03/16 21:09, Clemens Ladisch wrote:
>>> Felipe F. Tonello wrote:
>>>> This refactor results in a cleaner state machine code
>>>
>>> It increases the numbe
Hi Clemens,
On 02/03/16 21:09, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This refactor results in a cleaner state machine code
>
> It increases the number of states, and now juggles two state variables.
> I cannot agree to it being cleaner.
Yes, it increases the number of states. That
Hi Michal,
On 26/01/16 14:53, Michal Nazarewicz wrote:
> Resending my previous two sets for f_fs and f_midi. This time rebased
> on top of Felipe’s next branch.
>
> Dan Carpenter (1):
> usb: gadget: f_midi: missing unlock on error path
>
> Du, Changbin (1):
> usb: f_fs: avoid race condition
Hi Dan,
On 05/01/16 12:44, Dan Carpenter wrote:
> On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote:
>>
>>
>> On Tue, 5 Jan 2016, kbuild test robot wrote:
>>
>>> Hi Dan,
>>>
>>> [auto build test WARNING on balbi-usb/next]
>>> [also build test WARNING on v4.4-rc8 next-20160105]
>>> [if y
Hi Clemens,
On 22/12/15 17:10, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This refactor includes the following:
>> * Cleaner state machine code;
>
> It does not correctly handle system real time messages inserted between
> the status and data bytes of other messages.
True, thanks for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Balbi,
On 22/12/15 17:49, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> This refactor includes the following: * Cleaner state machine
>> code; * Reset state if MIDI message parsed is non-conformant; *
>> Fixed bug when a confo
Hi Dan,
On 21/12/15 13:20, Dan Carpenter wrote:
> We added a new error path to this function and we forgot to drop the
> lock.
>
> Fixes: e1e3d7ec5da3 ('usb: gadget: f_midi: pre-allocate IN requests')
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/usb/gadget/function/f_midi.c
> b/driv
Hi Robert,
On 11/12/15 11:24, Robert Baldyga wrote:
> It seems that gitotious repository is no longer accessible, so we replace
> it with address to active repository.
>
> Signed-off-by: Robert Baldyga
> ---
> Documentation/usb/gadget-testing.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
Hi Balbi,
On 16/12/15 16:03, Felipe Balbi wrote:
>
> Hi
>
> Felipe Ferreri Tonello writes:
>> Hi all,
>>
>> On 01/12/15 18:30, Felipe F. Tonello wrote:
>>> Fixed all comments suggested by the linux-usb list.
>>>
>>> changes in v
Hi all,
On 01/12/15 18:30, Felipe F. Tonello wrote:
> Fixed all comments suggested by the linux-usb list.
>
> changes in v6:
> - Removed patches already applied in Balbi's tree
> - Cleanups on pre-allocation usb requrests patch
> - Fixed indentention on patch 1
> - Added patch which fails set
On 01/12/15 18:31, Felipe F. Tonello wrote:
> This patch introduces pre-allocation of IN endpoint USB requests. This
> improves on latency (requires no usb request allocation on transmit) and avoid
> several potential probles on allocating too many usb requests (which involves
> DMA pool allocation
Hi Clemens
On 27/11/15 09:05, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 13/11/15 08:55, Clemens Ladisch wrote:
>>> Felipe F. Tonello wrote:
>>>> +static void f_midi_transmit(struct f_midi *midi)
>>>> +{
>>>> +...
>
Hi Clemens
On 13/11/15 08:55, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This patch introduces pre-allocation of IN endpoint USB requests. This
>> improves on latency (requires no usb request allocation on transmit) and
>> avoid
>> several potential probles on allocating too many usb re
Hi Robert,
On 13/11/15 12:38, Robert Baldyga wrote:
> Hi Felipe,
>
> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>> This patch introduces pre-allocation of IN endpoint USB requests. This
>> improves on latency (requires no usb request allocation on transmit) and
>> avoid
>> several potentia
Hi Robert,
On 16/11/15 11:43, Robert Baldyga wrote:
> On 11/16/2015 12:08 PM, Felipe Ferreri Tonello wrote:
>> Hi Robert,
>>
>> On 13/11/15 08:31, Robert Baldyga wrote:
>>> Hi Felipe,
>>>
>>> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>>
Hi Clemens,
On 13/11/15 08:11, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 10/11/15 18:43, Sergei Shtylyov wrote:
>>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>> struct usb_ep
Hi Robert,
On 13/11/15 08:31, Robert Baldyga wrote:
> Hi Felipe,
>
> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>> This patch fixes a memory leak that occurs when an endpoint fails to enqueue
>> the request. If that happens the complete function will never be called, thus
>> never freeing t
Hi Sergei,
On 10/11/15 18:43, Sergei Shtylyov wrote:
> Hello.
>
> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>
>> This avoids duplication of USB requests for OUT endpoint and
>> re-enabling endpoints.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c
Hi Robert,
On 03/11/15 12:53, Robert Baldyga wrote:
> USB requests in Loopback function are allocated in loopback_get_alt()
> function, so we prefer to free them rather in loopback_disable() than
> in loopback_complete() when request is completed with error. It provides
> better symetry in resourc
Hi Balbi,
On 26/10/15 16:55, Felipe F. Tonello wrote:
> Patch 7 has changes on how to transmit IN USB requests. It implements a FIFO
> of pre-allocated usb requests and uses then as needed, instead of allocating
> then on demand. This is my initial implementation and is open for
> suggestions and
Hi Robert,
On 27/10/15 09:47, Robert Baldyga wrote:
> On 10/27/2015 10:18 AM, Felipe Ferreri Tonello wrote:
>> Hi Robert,
>>
>> On 27/10/15 06:53, Robert Baldyga wrote:
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>>>> This function is shar
Hi Peter,
Have you seen this patch? I saw that you didn't apply it to your tree,
so I wonder if it is good or do I have to change anything.
This patch is a bug fix for a memory leak, so it is quite important.
--
Felipe
On 18/09/15 18:30, e...@felipetonello.com wrote:
> From: "Felipe F. Tonello
Hi Robert,
On 27/10/15 06:41, Robert Baldyga wrote:
> On 10/26/2015 11:49 PM, Felipe Tonello wrote:
>> Hi Robert,
>>
>> On Mon, Oct 26, 2015 at 10:13 PM, Robert Baldyga
>> wrote:
>>> Hi Felipe,
>>>
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
This makes sure f_midi doesn't try to enq
Hi Robert,
On 27/10/15 06:47, Robert Baldyga wrote:
> On 10/26/2015 11:53 PM, Felipe Tonello wrote:
>> Hi Robert,
>>
>> On Mon, Oct 26, 2015 at 10:30 PM, Robert Baldyga
>> wrote:
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
This avoids duplication of USB requests for OUT endpoint and
Hi Robert,
On 27/10/15 06:53, Robert Baldyga wrote:
> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>> This function is shared between gadget functions, so this avoid unnecessary
>> duplicated code and potentially avoid memory leaks.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/us
71 matches
Mail list logo
