Re: [PATCH 6/7] usb: gadget: f_uac2: disable IN/OUT ep if unused

Hi Felipe, On Tue, Aug 07, 2018 at 08:48:53PM +0200, Eugeniu Rosca wrote: > Hello Felipe, > > On Fri, Jul 27, 2018 at 08:57:29PM +0200, Eugeniu Rosca wrote: > > Hi Felipe, > > > > On Thu, Jul 26, 2018 at 01:51:35PM +0300, Felipe Balbi wrote: > > > Eugeni

Re: [PATCH 6/7] usb: gadget: f_uac2: disable IN/OUT ep if unused

Hello Felipe, On Fri, Jul 27, 2018 at 08:57:29PM +0200, Eugeniu Rosca wrote: > Hi Felipe, > > On Thu, Jul 26, 2018 at 01:51:35PM +0300, Felipe Balbi wrote: > > Eugeniu Rosca writes: > > > > > From: Andreas Pape > > > > > > Via p_chmask/c_chmas

Re: [PATCH 6/7] usb: gadget: f_uac2: disable IN/OUT ep if unused

Hi Felipe, On Thu, Jul 26, 2018 at 01:51:35PM +0300, Felipe Balbi wrote: > Eugeniu Rosca writes: > > > From: Andreas Pape > > > > Via p_chmask/c_chmask the user can define whether uac2 shall support > > playback and/or capture. This has only effect on the creat

[PATCH 5/7] usb: gadget: u_audio: remove cached period bytes value

zero in u_audio_iso_complete() function, if there is a race with uac_pcm_hw_free(), which sets prm->period_size to 0. Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver") Signed-off-by: Vladimir Zapolskiy Signed-off-by: Eugeniu Rosca --- drivers/usb/gadget/function/u

[PATCH 4/7] usb: gadget: u_audio: remove caching of stream buffer parameters

Audio Class 2.0 Driver") Signed-off-by: Vladimir Zapolskiy Signed-off-by: Eugeniu Rosca --- drivers/usb/gadget/function/u_audio.c | 30 --- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadge

[PATCH 6/7] usb: gadget: f_uac2: disable IN/OUT ep if unused

Signed-off-by: Eugeniu Rosca --- drivers/usb/gadget/function/f_uac2.c | 216 +-- 1 file changed, 172 insertions(+), 44 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c index 6954db22c2f3..87fa6f14efcf 100644 --- a

[PATCH 7/7] usb: gadget: u_audio: protect stream runtime fields with stream spinlock

q+0xb4/0x12c [] cpuidle_enter_state+0x818/0x844 [] cpuidle_enter+0x18/0x20 [] call_cpuidle+0x98/0x9c [] do_idle+0x214/0x264 [] cpu_startup_entry+0x20/0x24 [] rest_init+0x30c/0x320 [] start_kernel+0x570/0x5b0 ---<-snip->--- Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver"

[PATCH 3/7] usb: gadget: u_audio: update hw_ptr in iso_complete after data copied

hw_ptr after the data has been copied to avoid this. Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver") Signed-off-by: Joshua Frkuska Signed-off-by: Eugeniu Rosca --- drivers/usb/gadget/function/u_audio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 2/7] usb: gadget: u_audio: fix pcm/card naming in g_audio_setup()

cpy/' rework: * v2.6.31 commit 8372d4980fbc ("ALSA: ctxfi - Fix PCM device naming") * v4.14 commit 003d3e70dbeb ("ALSA: ad1848: fix format string overflow warning") * v4.14 commit 6d8b04de87e1 ("ALSA: cs423x: fix format string overflow warning") Fixes: eb9fecb9e69b

[PATCH 0/7] Fix issues in UAC2 gadget driver

al Customer products. Thank you in advance for any feedback/review comments. Best regards, Eugeniu. Contributors (auto-generated by git) Andreas Pape (1): usb: gadget: f_uac2: disable IN/OUT ep if unused Eugeniu Rosca (2): usb: gadget: f_uac2: fix error handling in afunc_bind (again) usb: gadg

[PATCH 1/7] usb: gadget: f_uac2: fix error handling in afunc_bind (again)

failed to start g_audio: -19 modprobe: ERROR: could not insert 'g_audio': No such device rcar-gen3:/home/root# modprobe -r g_audio rcar-gen3:/home/root# Fixes: f1d3861d63a5 ("usb: gadget: f_uac2: fix error handling at afunc_bind") Signed-off-by: Eugeniu Rosca --- drivers/us